Completed
Pull Request — 1.x (#627)
by
unknown
08:55
created

Db::createService()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 10
Code Lines 6

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 10
rs 9.4285
cc 1
eloc 6
nc 1
nop 1
1
<?php
2
3
namespace ZfcUser\Factory\Authentication\Adapter;
4
5
use Zend\ServiceManager\FactoryInterface;
6
use Zend\ServiceManager\ServiceLocatorInterface;
7
use ZfcUser\Authentication\Adapter\Db as DbAdapter;
8
9
class Db implements FactoryInterface
10
{
11
    /**
12
     * Create service
13
     *
14
     * @param ServiceLocatorInterface $serviceLocator
15
     * @return mixed
16
     */
17
    public function createService(ServiceLocatorInterface $serviceLocator)
18
    {
19
        $mapper = $serviceLocator->get('zfcuser_user_mapper');
20
        $options = $serviceLocator->get('zfcuser_module_options');
21
22
        return new DbAdapter(
23
            $mapper,
0 ignored issues
show
Documentation introduced by
$mapper is of type object|array, but the function expects a object<ZfcUser\Mapper\User>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
24
            $options
0 ignored issues
show
Documentation introduced by
$options is of type object|array, but the function expects a object<ZfcUser\Options\A...cationOptionsInterface>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
25
        );
26
    }
27
}
28