User::createService() - Code Metrics - Inspection of "Merge pull request #578 from claytondaley/form-upg..." - ZF-Commons/ZfcUser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 6e286e...c7aa89 )

by Daniel

created 2015-12-12 14:15 UTC

User::createService() A

↳ Parent: User

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	11
rs	9.4286
cc	1
eloc	9
nc	1
nop	1

<?php
/**
 * Created by PhpStorm.
 * User: Clayton Daley
 * Date: 5/6/2015
 * Time: 6:43 PM
 */

namespace ZfcUser\Factory\Mapper;

use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use ZfcUser\Mapper;

class User implements FactoryInterface
{

    /**
     * Create service
     *
     * @param ServiceLocatorInterface $serviceLocator
     * @return mixed
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $options = $serviceLocator->get('zfcuser_module_options');
        $mapper = new Mapper\User();
        $mapper->setDbAdapter($serviceLocator->get('zfcuser_zend_db_adapter'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $entityClass = $options->getUserEntityClass();
        $mapper->setEntityPrototype(new $entityClass);
        $mapper->setHydrator(new Mapper\UserHydrator());
        $mapper->setTableName($options->getTableName());
        return $mapper;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Clayton Daley
5			* Date: 5/6/2015
6			* Time: 6:43 PM
7			*/
8
9			namespace ZfcUser\Factory\Mapper;
10
11			use Zend\ServiceManager\FactoryInterface;
12			use Zend\ServiceManager\ServiceLocatorInterface;
13			use ZfcUser\Mapper;
14
15			class User implements FactoryInterface
16			{
17
18			/**
19			* Create service
20			*
21			* @param ServiceLocatorInterface $serviceLocator
22			* @return mixed
23			*/
24			public function createService(ServiceLocatorInterface $serviceLocator)
25			{
26			$options = $serviceLocator->get('zfcuser_module_options');
27			$mapper = new Mapper\User();
28			$mapper->setDbAdapter($serviceLocator->get('zfcuser_zend_db_adapter'));
			0 ignored issues – show Documentation introduced 2015-12-12 15:00 UTC by Report Bug Copy Issue Report `$serviceLocator->get('zfcuser_zend_db_adapter')` is of type `object\|array`, but the function expects a `object<Zend\Db\Adapter\Adapter>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			$entityClass = $options->getUserEntityClass();
30			$mapper->setEntityPrototype(new $entityClass);
31			$mapper->setHydrator(new Mapper\UserHydrator());
32			$mapper->setTableName($options->getTableName());
33			return $mapper;
34			}
35			}
36

ZF-Commons / ZfcUser

Push — 1.x ( 6e286e...c7aa89 )

User::createService() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like