UserMapperFactory::createService() - Code Metrics - ZF-Commons/ZfcUser - Measure and Improve Code Quality continuously with Scrutinizer

UserMapperFactory::createService() B
last analyzed 2016-09-27 16:19 UTC

↳ Parent: UserMapperFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
rs	8.9713
cc	1
eloc	12
nc	1
nop	1

<?php
namespace ZfcUser\Factory;

use Zend\Db;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Zend\Stdlib\Hydrator;
use ZfcUser\Mapper;
use ZfcUser\Options;

class UserMapperFactory implements FactoryInterface
{
    /**
     * {@inheritDoc}
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        /* @var $options Options\ModuleOptions */
        $options = $serviceLocator->get('zfcuser_module_options');

        /* @var $dbAdapter Db\Adapter\Adapter */
        $dbAdapter = $serviceLocator->get('zfcuser_zend_db_adapter');

        $mapper = new Mapper\User();
        $mapper->setDbAdapter($dbAdapter);

        $entityClass = $options->getUserEntityClass();

        /* @var $hydrator Hydrator\HydratorInterface */
        $hydrator = $serviceLocator->get('zfcuser_user_hydrator');

        $mapper
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setEntityPrototype(new $entityClass)
            ->setHydrator($hydrator)
            ->setTableName($options->getTableName())
        ;

        return $mapper;
    }
}


1			<?php
2			namespace ZfcUser\Factory;
3
4			use Zend\Db;
5			use Zend\ServiceManager\FactoryInterface;
6			use Zend\ServiceManager\ServiceLocatorInterface;
7			use Zend\Stdlib\Hydrator;
8			use ZfcUser\Mapper;
9			use ZfcUser\Options;
10
11			class UserMapperFactory implements FactoryInterface
12			{
13			/**
14			* {@inheritDoc}
15			*/
16			public function createService(ServiceLocatorInterface $serviceLocator)
17			{
18			/* @var $options Options\ModuleOptions */
19			$options = $serviceLocator->get('zfcuser_module_options');
20
21			/* @var $dbAdapter Db\Adapter\Adapter */
22			$dbAdapter = $serviceLocator->get('zfcuser_zend_db_adapter');
23
24			$mapper = new Mapper\User();
25			$mapper->setDbAdapter($dbAdapter);
26
27			$entityClass = $options->getUserEntityClass();
28
29			/* @var $hydrator Hydrator\HydratorInterface */
30			$hydrator = $serviceLocator->get('zfcuser_user_hydrator');
31
32			$mapper
			0 ignored issues – show Bug introduced 2016-03-07 14:45 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `ZfcBase\Mapper\AbstractDbMapper` as the method `setTableName()` does only exist in the following sub-classes of `ZfcBase\Mapper\AbstractDbMapper`: `ZfcUser\Mapper\User`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
33			->setEntityPrototype(new $entityClass)
34			->setHydrator($hydrator)
35			->setTableName($options->getTableName())
36			;
37
38			return $mapper;
39			}
40			}
41

ZF-Commons / ZfcUser

UserMapperFactory::createService() B last analyzed 2016-09-27 16:19 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

UserMapperFactory::createService() B
last analyzed 2016-09-27 16:19 UTC