Issues in class.Weather.php (master) - Issues in master - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (843)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

require/class.Weather.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This class is part of FlightAirmap. It's used to get weather data and create clouds
 *
 * Copyright (c) Ycarus (Yannick Chabanois) <[email protected]>
 * Licensed under AGPL license.
 * For more information see: https://www.flightairmap.com/
*/
require_once(dirname(__FILE__).'/class.Common.php');
class Weather {
	public function buildcloudlayer($metar) {
		//print_r($metar);
		$result = array();
		foreach($metar['cloud'] as $key => $data) {
			$alt_m = $metar['cloud'][$key]['level'];
			$alt_ft = $alt_m*3.28084;
			$pressure = $metar['QNH'];
			$cumulus_base = 122.0 * ($metar['temperature'] - $metar['dew']);
			$stratus_base = 100.0 * (100.0 * $metar['rh'])*0.3048;
			$coverage_norm = 0.0;
			if ($metar['cloud'][$key]['type'] == 'Few') {
				$coverage_norm = 2.0/8.0;
			} elseif ($metar['cloud'][$key]['type'] == 'Scattered') {
				$coverage_norm = 4.0/8.0;
			} elseif ($metar['cloud'][$key]['type'] == 'Broken') {
				$coverage_norm = 6.0/8.0;
			} elseif ($metar['cloud'][$key]['type'] == 'Overcast/Full cloud coverage') {
				$coverage_norm = 8.0/8.0;
			}
			$layer_type = 'nn';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			if ($metar['cloud'][$key]['significant'] == 'cirrus') {
				$layer_type = 'ci';
			} elseif ($alt_ft > 16500) {
				$layer_type = 'ci';
			} elseif ($alt_ft > 6500) {
				$layer_type = 'ac';
				if ($pressure < 1005.0 && $coverage_norm >= 0.5) {
					$layer_type = 'ns';
				}
			} else {
				if ($cumulus_base * 0.80 < $alt_m && $cumulus_base * 1.20 > $alt_m) {
					$layer_type = 'cu';
				} elseif ($stratus_base * 0.80 < $alt_m && $stratus_base * 1.40 > $alt_m) {
					$layer_type = 'st';
				} else {
					if ($alt_ft < 2000) {
						$layer_type = 'st';
					} elseif ($alt_ft < 4500) {
						$layer_type = 'cu';
					} else {
						$layer_type = 'sc';
					}
				}
			}
			//echo 'coverage norm : '.$coverage_norm.' - layer_type: '.$layer_type."\n";
			$result[] = array('cov' => $coverage_norm, 'type' => $layer_type,'alt' => $alt_m,'rh' => $metar['rh']);
		}
		if (count($result) < 2 && $metar['rh'] > 60) {
			$result[] = array('cov' => 0.75, 'type' => 'ci','alt' => 4000,'rh' => $metar['rh']);
		}
		return $result;
	}
	
	public function openweathermap($latitude,$longitude) {
		global $globalOpenWeatherMapKey;
		if ($globalOpenWeatherMapKey == '') return array();
		$Common = new Common();
		$url = 'http://api.openweathermap.org/data/2.5/weather?lat='.$latitude.'&lon='.$longitude.'&units=metric&appid='.$globalOpenWeatherMapKey;
		//echo $url."\n";
		$weatherdata = json_decode($Common->getData($url),true);
		if (!isset($weatherdata['main']['temp']) || !isset($weatherdata['weather'][0]['id'])) return array('clouds' => array(),'rain' => array());
		$dew = $weatherdata['main']['temp'] - ((100-$weatherdata['main']['humidity'])/5);
		$cumulus_base = 122.0 * ($weatherdata['main']['temp'] - $dew);
		$stratus_base = 100.0 * (100.0 * $weatherdata['main']['humidity'])*0.3048;
		$coverage_norm = 0.0;
		if ($weatherdata['weather'][0]['id'] == 801) {
			// few clouds
			$coverage_norm = 2.0/8.0;
		} elseif ($weatherdata['weather'][0]['id'] == 802) {
			//scattered cloud
			$coverage_norm = 4.0/8.0;
		} elseif ($weatherdata['weather'][0]['id'] == 803) {
			// broken clouds
			$coverage_norm = 6.0/8.0;
		} elseif ($weatherdata['weather'][0]['id'] == 804) {
			// overcast clouds
			$coverage_norm = 8.0/8.0;
		}
		$alt_m = 1000;
		if ($cumulus_base * 0.80 < $alt_m && $cumulus_base * 1.20 > $alt_m) {
			$layer_type = 'cu';
		} elseif ($stratus_base * 0.80 < $alt_m && $stratus_base * 1.40 > $alt_m) {
			$layer_type = 'st';
		} else {
			$layer_type = 'st';
		}
		$result = array();
		$result[] = array('cov' => $coverage_norm, 'type' => $layer_type,'alt' => $alt_m,'rh' => $weatherdata['main']['humidity']);
		if ($weatherdata['main']['humidity'] > 60) {
			$result[] = array('cov' => 0.75, 'type' => 'ci','alt' => 4000,'rh' => $weatherdata['main']['humidity']);
		}
		return array('clouds' => $result,'rain' => array('tmp' => $weatherdata['main']['temp'],'rh' => $weatherdata['main']['humidity']));
	}
	
	public function nomad_wind($hour = '') {
		global $globalWindsPath;
		if ($hour == '') $hour = date('G');
		if (isset($globalWindsPath) && $globalWindsPath != '') {
			$grib2json = $globalWindsPath['grib2json'];
			$windpathsrc = $globalWindsPath['source'];
			$windpathdest = $globalWindsPath['destination'];
		} else {
			$grib2json = dirname(__FILE__).'/libs/grib2json/bin/grib2json';
			$windpathsrc = dirname(__FILE__).'/../data/winds.gb2';
			$windpathdest = dirname(__FILE__).'/../data/winds.json';
		}
		
		// http://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_0p50.pl?file=gfs.t05z.pgrb2full.0p50.f000&lev_10_m_above_ground=on&lev_surface=on&var_TMP=on&var_UGRD=on&var_VGRD=on&leftlon=0&rightlon=360&toplat=90&bottomlat=-90&dir=/gfs.2017111717
		$resolution = '0.5';
		$baseurl = 'http://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_'.($resolution === '1' ? '1p00':'0p50').'.pl';
		$get = array('file' => 'gfs.t'.sprintf('%02d',(6*floor($hour/6))).($resolution === '1' ? 'z.pgrb2.1p00.f000' : 'z.pgrb2full.0p50.f000'),
			'lev_10_m_above_ground' => 'on',
			'lev_surface' => 'on',
			'var_TMP' => 'on',
			'var_UGRD' => 'on',
			'var_VGRD' => 'on',
			'leftlon' => 0,
			'rightlon' => 360,
			'toplat' => 90,
			'bottomlat' => -90,
			'dir' => '/gfs.'.date('Ymd').sprintf('%02d',(6*floor($hour/6)))
		);
		$url = $baseurl.'?'.http_build_query($get);
		//echo $url;
		$Common = new Common();
		$Common->download($url,$windpathsrc);
		// Check if the downloaded file is in GRIB format
		$file = fopen($windpathsrc,"r");
		$firc = fgetc($file);
		fclose($file);
		if ($firc == 'G') {
			system($grib2json.' --data --output '.$windpathdest.' --names --compact '.$windpathsrc);
		} else {
			// if not try previous run
			if ($hour == date('G')) $this->nomad_wind(date('G')-6);
		}
	}

	public function oscar_wave() {
		global $globalWavesPath, $globalPODACCuser,$globalPODACCpass;
		if ($globalPODACCuser == '' && $globalPODACCpass == '') return;
		if (isset($globalWavesPath) && $globalWavesPath != '') {
			$grib2json = $globalWavesPath['grib2json'];
			$wavepathsrc = $globalWavesPath['source'];
			$wavepathdest = $globalWavesPath['destination'];
		} else {
			$grib2json = dirname(__FILE__).'/libs/grib2json/bin/grib2json';
			$wavepathsrc = dirname(__FILE__).'/../data/waves.nc';
			$wavepathdest = dirname(__FILE__).'/../data/waves.json';
		}
		
		$url = 'https://podaac.jpl.nasa.gov/ws/search/granule/?datasetId=PODAAC-OSCAR-03D01&itemsPerPage=1&sortBy=timeDesc&format=atom&pretty=false';
		$Common = new Common();
		$auth = base64_encode("$globalPODACCuser:$globalPODACCpass");
		$oscarlst = $Common->getData($url);
		$oscarlst_xml = json_decode(json_encode(simplexml_load_string($oscarlst)),true);
		foreach ($oscarlst_xml['entry']['link'] as $oscarlnk) {
			if ($oscarlnk['@attributes']['type'] == 'application/x-netcdf') {
				$Common->download($oscarlnk['@attributes']['href'],$wavepathsrc.'.gz','',array("Authorization: BASIC $auth"));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				break;
			}
		}
		$Common->gunzip($wavepathsrc.'.gz');
		system($grib2json.' --data --output '.$wavepathdest.' --names --compact '.$wavepathsrc);
	}
}
/*
require_once('class.METAR.php');
$METAR = new METAR();
*/
/*
$themetar = $METAR->getMETAR('LFLL');
print_r($themetar);
$result = $METAR->parse($themetar[0]['metar']);
*/
/*
$result = $METAR->parse('LFLL 081330Z 01006KT 340V050 9999 FEW020 BKN080 07/01 Q1018 NOSIG');
print_r($result);
$Weather = new Weather();
//print_r($Weather->buildcloudlayer($result));
//print_r($Weather->buildcloud('46.3870','5.2941','2000','0.25'));
print_r($Weather->generateRandomPoint('46.3870','5.2941','2000'));
*/
/*
$Weather = new Weather();
$Weather->nomad_wind();
*/
/*
$Weather = new Weather();
$Weather->oscar_wave();
*/
/*
$Weather = new Weather();
print_r($Weather->openweathermap(0.0,-10.0));
*/
?>

1			<?php
2			/**
3			* This class is part of FlightAirmap. It's used to get weather data and create clouds
4			*
5			* Copyright (c) Ycarus (Yannick Chabanois) <[email protected]>
6			* Licensed under AGPL license.
7			* For more information see: https://www.flightairmap.com/
8			*/
9			require_once(dirname(__FILE__).'/class.Common.php');
10			class Weather {
11			public function buildcloudlayer($metar) {
12			//print_r($metar);
13			$result = array();
14			foreach($metar['cloud'] as $key => $data) {
15			$alt_m = $metar['cloud'][$key]['level'];
16			$alt_ft = $alt_m*3.28084;
17			$pressure = $metar['QNH'];
18			$cumulus_base = 122.0 * ($metar['temperature'] - $metar['dew']);
19			$stratus_base = 100.0 * (100.0 * $metar['rh'])*0.3048;
20			$coverage_norm = 0.0;
21			if ($metar['cloud'][$key]['type'] == 'Few') {
22			$coverage_norm = 2.0/8.0;
23			} elseif ($metar['cloud'][$key]['type'] == 'Scattered') {
24			$coverage_norm = 4.0/8.0;
25			} elseif ($metar['cloud'][$key]['type'] == 'Broken') {
26			$coverage_norm = 6.0/8.0;
27			} elseif ($metar['cloud'][$key]['type'] == 'Overcast/Full cloud coverage') {
28			$coverage_norm = 8.0/8.0;
29			}
30			$layer_type = 'nn';
			0 ignored issues – show Unused Code introduced 2017-11-14 15:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$layer_type` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31			if ($metar['cloud'][$key]['significant'] == 'cirrus') {
32			$layer_type = 'ci';
33			} elseif ($alt_ft > 16500) {
34			$layer_type = 'ci';
35			} elseif ($alt_ft > 6500) {
36			$layer_type = 'ac';
37			if ($pressure < 1005.0 && $coverage_norm >= 0.5) {
38			$layer_type = 'ns';
39			}
40			} else {
41			if ($cumulus_base * 0.80 < $alt_m && $cumulus_base * 1.20 > $alt_m) {
42			$layer_type = 'cu';
43			} elseif ($stratus_base * 0.80 < $alt_m && $stratus_base * 1.40 > $alt_m) {
44			$layer_type = 'st';
45			} else {
46			if ($alt_ft < 2000) {
47			$layer_type = 'st';
48			} elseif ($alt_ft < 4500) {
49			$layer_type = 'cu';
50			} else {
51			$layer_type = 'sc';
52			}
53			}
54			}
55			//echo 'coverage norm : '.$coverage_norm.' - layer_type: '.$layer_type."\n";
56			$result[] = array('cov' => $coverage_norm, 'type' => $layer_type,'alt' => $alt_m,'rh' => $metar['rh']);
57			}
58			if (count($result) < 2 && $metar['rh'] > 60) {
59			$result[] = array('cov' => 0.75, 'type' => 'ci','alt' => 4000,'rh' => $metar['rh']);
60			}
61			return $result;
62			}
63
64			public function openweathermap($latitude,$longitude) {
65			global $globalOpenWeatherMapKey;
66			if ($globalOpenWeatherMapKey == '') return array();
67			$Common = new Common();
68			$url = 'http://api.openweathermap.org/data/2.5/weather?lat='.$latitude.'&lon='.$longitude.'&units=metric&appid='.$globalOpenWeatherMapKey;
69			//echo $url."\n";
70			$weatherdata = json_decode($Common->getData($url),true);
71			if (!isset($weatherdata['main']['temp']) \|\| !isset($weatherdata['weather'][0]['id'])) return array('clouds' => array(),'rain' => array());
72			$dew = $weatherdata['main']['temp'] - ((100-$weatherdata['main']['humidity'])/5);
73			$cumulus_base = 122.0 * ($weatherdata['main']['temp'] - $dew);
74			$stratus_base = 100.0 * (100.0 * $weatherdata['main']['humidity'])*0.3048;
75			$coverage_norm = 0.0;
76			if ($weatherdata['weather'][0]['id'] == 801) {
77			// few clouds
78			$coverage_norm = 2.0/8.0;
79			} elseif ($weatherdata['weather'][0]['id'] == 802) {
80			//scattered cloud
81			$coverage_norm = 4.0/8.0;
82			} elseif ($weatherdata['weather'][0]['id'] == 803) {
83			// broken clouds
84			$coverage_norm = 6.0/8.0;
85			} elseif ($weatherdata['weather'][0]['id'] == 804) {
86			// overcast clouds
87			$coverage_norm = 8.0/8.0;
88			}
89			$alt_m = 1000;
90			if ($cumulus_base * 0.80 < $alt_m && $cumulus_base * 1.20 > $alt_m) {
91			$layer_type = 'cu';
92			} elseif ($stratus_base * 0.80 < $alt_m && $stratus_base * 1.40 > $alt_m) {
93			$layer_type = 'st';
94			} else {
95			$layer_type = 'st';
96			}
97			$result = array();
98			$result[] = array('cov' => $coverage_norm, 'type' => $layer_type,'alt' => $alt_m,'rh' => $weatherdata['main']['humidity']);
99			if ($weatherdata['main']['humidity'] > 60) {
100			$result[] = array('cov' => 0.75, 'type' => 'ci','alt' => 4000,'rh' => $weatherdata['main']['humidity']);
101			}
102			return array('clouds' => $result,'rain' => array('tmp' => $weatherdata['main']['temp'],'rh' => $weatherdata['main']['humidity']));
103			}
104
105			public function nomad_wind($hour = '') {
106			global $globalWindsPath;
107			if ($hour == '') $hour = date('G');
108			if (isset($globalWindsPath) && $globalWindsPath != '') {
109			$grib2json = $globalWindsPath['grib2json'];
110			$windpathsrc = $globalWindsPath['source'];
111			$windpathdest = $globalWindsPath['destination'];
112			} else {
113			$grib2json = dirname(__FILE__).'/libs/grib2json/bin/grib2json';
114			$windpathsrc = dirname(__FILE__).'/../data/winds.gb2';
115			$windpathdest = dirname(__FILE__).'/../data/winds.json';
116			}
117
118			// http://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_0p50.pl?file=gfs.t05z.pgrb2full.0p50.f000&lev_10_m_above_ground=on&lev_surface=on&var_TMP=on&var_UGRD=on&var_VGRD=on&leftlon=0&rightlon=360&toplat=90&bottomlat=-90&dir=/gfs.2017111717
119			$resolution = '0.5';
120			$baseurl = 'http://nomads.ncep.noaa.gov/cgi-bin/filter_gfs_'.($resolution === '1' ? '1p00':'0p50').'.pl';
121			$get = array('file' => 'gfs.t'.sprintf('%02d',(6*floor($hour/6))).($resolution === '1' ? 'z.pgrb2.1p00.f000' : 'z.pgrb2full.0p50.f000'),
122			'lev_10_m_above_ground' => 'on',
123			'lev_surface' => 'on',
124			'var_TMP' => 'on',
125			'var_UGRD' => 'on',
126			'var_VGRD' => 'on',
127			'leftlon' => 0,
128			'rightlon' => 360,
129			'toplat' => 90,
130			'bottomlat' => -90,
131			'dir' => '/gfs.'.date('Ymd').sprintf('%02d',(6*floor($hour/6)))
132			);
133			$url = $baseurl.'?'.http_build_query($get);
134			//echo $url;
135			$Common = new Common();
136			$Common->download($url,$windpathsrc);
137			// Check if the downloaded file is in GRIB format
138			$file = fopen($windpathsrc,"r");
139			$firc = fgetc($file);
140			fclose($file);
141			if ($firc == 'G') {
142			system($grib2json.' --data --output '.$windpathdest.' --names --compact '.$windpathsrc);
143			} else {
144			// if not try previous run
145			if ($hour == date('G')) $this->nomad_wind(date('G')-6);
146			}
147			}
148
149			public function oscar_wave() {
150			global $globalWavesPath, $globalPODACCuser,$globalPODACCpass;
151			if ($globalPODACCuser == '' && $globalPODACCpass == '') return;
152			if (isset($globalWavesPath) && $globalWavesPath != '') {
153			$grib2json = $globalWavesPath['grib2json'];
154			$wavepathsrc = $globalWavesPath['source'];
155			$wavepathdest = $globalWavesPath['destination'];
156			} else {
157			$grib2json = dirname(__FILE__).'/libs/grib2json/bin/grib2json';
158			$wavepathsrc = dirname(__FILE__).'/../data/waves.nc';
159			$wavepathdest = dirname(__FILE__).'/../data/waves.json';
160			}
161
162			$url = 'https://podaac.jpl.nasa.gov/ws/search/granule/?datasetId=PODAAC-OSCAR-03D01&itemsPerPage=1&sortBy=timeDesc&format=atom&pretty=false';
163			$Common = new Common();
164			$auth = base64_encode("$globalPODACCuser:$globalPODACCpass");
165			$oscarlst = $Common->getData($url);
166			$oscarlst_xml = json_decode(json_encode(simplexml_load_string($oscarlst)),true);
167			foreach ($oscarlst_xml['entry']['link'] as $oscarlnk) {
168			if ($oscarlnk['@attributes']['type'] == 'application/x-netcdf') {
169			$Common->download($oscarlnk['@attributes']['href'],$wavepathsrc.'.gz','',array("Authorization: BASIC $auth"));
			0 ignored issues – show Documentation introduced 2019-10-31 08:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array("Authorization: BASIC {$auth}")` is of type `array<integer,?>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
170			break;
171			}
172			}
173			$Common->gunzip($wavepathsrc.'.gz');
174			system($grib2json.' --data --output '.$wavepathdest.' --names --compact '.$wavepathsrc);
175			}
176			}
177			/*
178			require_once('class.METAR.php');
179			$METAR = new METAR();
180			*/
181			/*
182			$themetar = $METAR->getMETAR('LFLL');
183			print_r($themetar);
184			$result = $METAR->parse($themetar[0]['metar']);
185			*/
186			/*
187			$result = $METAR->parse('LFLL 081330Z 01006KT 340V050 9999 FEW020 BKN080 07/01 Q1018 NOSIG');
188			print_r($result);
189			$Weather = new Weather();
190			//print_r($Weather->buildcloudlayer($result));
191			//print_r($Weather->buildcloud('46.3870','5.2941','2000','0.25'));
192			print_r($Weather->generateRandomPoint('46.3870','5.2941','2000'));
193			*/
194			/*
195			$Weather = new Weather();
196			$Weather->nomad_wind();
197			*/
198			/*
199			$Weather = new Weather();
200			$Weather->oscar_wave();
201			*/
202			/*
203			$Weather = new Weather();
204			print_r($Weather->openweathermap(0.0,-10.0));
205			*/
206			?>

Ysurac / FlightAirMap

Issues (843)

Security Analysis not enabled

require/class.Weather.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like