Issues in location-data.php - All Issues - Inspection of "Fix #410" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aee2fd...22b09a )

by Yannick

created 2018-07-19 18:31 UTC

location-data.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
require_once('require/class.Connection.php');
require_once('require/class.Language.php');
require_once('require/class.Source.php');
$Source = new Source();

if (isset($_GET['sourceid'])) {
	$sourceid = filter_input(INPUT_GET,'sourceid',FILTER_SANITIZE_NUMBER_INT);
	$source_data = $Source->getLocationInfoById($sourceid);
	if (isset($source_data[0])) {
 ?>
<div class="alldetails">
<button type="button" class="close">&times;</button>
<?php
$spotter_item = $source_data[0];

date_default_timezone_set('UTC');

print '<div class="top">';
if ($spotter_item['name'] != '') print '<div class="right"><div class="callsign-details"><div class="callsign">'.$spotter_item['name'].'</div>';
elseif ($spotter_item['location_id'] != 0) print '<div class="right"><div class="callsign-details"><div class="callsign">'.$spotter_item['location_id'].'</div>';
elseif ($spotter_item['type'] == 'lightning') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Lightning").'</div>';
elseif ($spotter_item['type'] == 'wx') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Weather Station").'</div>';
elseif ($spotter_item['type'] == 'fires') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Fire").'</div>';
else print '<div class="right"><div class="callsign-details"><div class="callsign"></div>';
print '</div>';

print '</div></div>';
print '<div class="details"><div class="mobile airports"><div class="airport">';
print '</div></div>';

if ($spotter_item['type'] != 'fires' && $spotter_item['type'] != 'lightning') {
	print '<div>';
	print '<span>'._("Altitude").'</span>';
	print $spotter_item['altitude'];
	print '</div>';
}

print '<div><span>'._("Last Seen").'</span>';
print $spotter_item['last_seen'].' UTC';
print '</div>';

if ($spotter_item['city'] != '') print '<div><span>'._("City").'</span>'.$spotter_item['city'].'</div>';
if ($spotter_item['country'] !='') print '<div><span>'._("Country").'</span>'.$spotter_item['country'].'</div>';
print '<div><span>'._("Coordinates").'</span>'.round($spotter_item['latitude'],4).', '.round($spotter_item['longitude'],4).'</div>';
/*
if ($spotter_item['atc_range'] > 0) {
    print '<div><span>'._("Range").'</span>';
    print $spotter_item['atc_range'];
    print '</div>';
}
*/
if ($spotter_item['type'] == 'wx') {
	$weather = json_decode($spotter_item['description'],true);
	//print_r($weather);
	if (isset($weather['temp'])) print '<div><span>'._("Temperature").'</span>'.$weather['temp'].'°C</div>';
	if (isset($weather['pressure'])) print '<div><span>'._("Pressure").'</span>'.$weather['pressure'].'hPa</div>';
	if (isset($weather['wind_gust'])) print '<div><span>'._("Wind Gust").'</span>'.$weather['wind_gust'].' km/h</div>';
	if (isset($weather['humidity'])) print '<div><span>'._("Humidity").'</span>'.$weather['humidity'].'%</div>';
	if (isset($weather['rain'])) print '<div><span>'._("Rain").'</span>'.$weather['rain'].' mm</div>';
	if (isset($weather['precipitation'])) print '<div><span>'._("Precipitation 24H").'</span>'.$weather['precipitation'].' mm</div>';
	if (isset($weather['precipitation24h'])) print '<div><span>'._("Precipitation Today").'</span>'.$weather['precipitation24h'].' mm</div>';
	$spotter_item['description'] = $weather['comment'];
} elseif ($spotter_item['type'] == 'fires') {

	//print_r(json_decode($spotter_item['description'],true));
}
print '</div>';
if ($spotter_item['type'] != 'wx' && $spotter_item['type'] != 'fires') {
	if ($spotter_item['description'] != '') {
		print '<div class="notamtext"><span>'._("Info").'</span>';
		print $spotter_item['description'];
		print '</div>';
	}
}


print '</div>';
}
print '</div>';
}
?>

1			<?php
2			require_once('require/class.Connection.php');
3			require_once('require/class.Language.php');
4			require_once('require/class.Source.php');
5			$Source = new Source();
6
7			if (isset($_GET['sourceid'])) {
8			$sourceid = filter_input(INPUT_GET,'sourceid',FILTER_SANITIZE_NUMBER_INT);
9			$source_data = $Source->getLocationInfoById($sourceid);
10			if (isset($source_data[0])) {
11			?>
12			<div class="alldetails">
13			<button type="button" class="close">×</button>
14			<?php
15			$spotter_item = $source_data[0];
16
17			date_default_timezone_set('UTC');
18
19			print '<div class="top">';
20			if ($spotter_item['name'] != '') print '<div class="right"><div class="callsign-details"><div class="callsign">'.$spotter_item['name'].'</div>';
21			elseif ($spotter_item['location_id'] != 0) print '<div class="right"><div class="callsign-details"><div class="callsign">'.$spotter_item['location_id'].'</div>';
22			elseif ($spotter_item['type'] == 'lightning') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Lightning").'</div>';
23			elseif ($spotter_item['type'] == 'wx') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Weather Station").'</div>';
24			elseif ($spotter_item['type'] == 'fires') print '<div class="right"><div class="callsign-details"><div class="callsign">'._("Fire").'</div>';
25			else print '<div class="right"><div class="callsign-details"><div class="callsign"></div>';
26			print '</div>';
27
28			print '</div></div>';
29			print '<div class="details"><div class="mobile airports"><div class="airport">';
30			print '</div></div>';
31
32			if ($spotter_item['type'] != 'fires' && $spotter_item['type'] != 'lightning') {
33			print '<div>';
34			print '<span>'._("Altitude").'</span>';
35			print $spotter_item['altitude'];
36			print '</div>';
37			}
38
39			print '<div><span>'._("Last Seen").'</span>';
40			print $spotter_item['last_seen'].' UTC';
41			print '</div>';
42
43			if ($spotter_item['city'] != '') print '<div><span>'._("City").'</span>'.$spotter_item['city'].'</div>';
44			if ($spotter_item['country'] !='') print '<div><span>'._("Country").'</span>'.$spotter_item['country'].'</div>';
45			print '<div><span>'._("Coordinates").'</span>'.round($spotter_item['latitude'],4).', '.round($spotter_item['longitude'],4).'</div>';
46			/*
47			if ($spotter_item['atc_range'] > 0) {
48			print '<div><span>'._("Range").'</span>';
49			print $spotter_item['atc_range'];
50			print '</div>';
51			}
52			*/
53			if ($spotter_item['type'] == 'wx') {
54			$weather = json_decode($spotter_item['description'],true);
55			//print_r($weather);
56			if (isset($weather['temp'])) print '<div><span>'._("Temperature").'</span>'.$weather['temp'].'°C</div>';
57			if (isset($weather['pressure'])) print '<div><span>'._("Pressure").'</span>'.$weather['pressure'].'hPa</div>';
58			if (isset($weather['wind_gust'])) print '<div><span>'._("Wind Gust").'</span>'.$weather['wind_gust'].' km/h</div>';
59			if (isset($weather['humidity'])) print '<div><span>'._("Humidity").'</span>'.$weather['humidity'].'%</div>';
60			if (isset($weather['rain'])) print '<div><span>'._("Rain").'</span>'.$weather['rain'].' mm</div>';
61			if (isset($weather['precipitation'])) print '<div><span>'._("Precipitation 24H").'</span>'.$weather['precipitation'].' mm</div>';
62			if (isset($weather['precipitation24h'])) print '<div><span>'._("Precipitation Today").'</span>'.$weather['precipitation24h'].' mm</div>';
63			$spotter_item['description'] = $weather['comment'];
64			} elseif ($spotter_item['type'] == 'fires') {
			0 ignored issues – show Unused Code introduced 2017-07-21 12:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `elseif` statement is empty, and could be removed. This check looks for the bodies of `elseif` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `elseif` bodies can be removed. If you have an empty elseif but statements in the `else` branch, consider inverting the condition. Loading history...
65			//print_r(json_decode($spotter_item['description'],true));
66			}
67			print '</div>';
68			if ($spotter_item['type'] != 'wx' && $spotter_item['type'] != 'fires') {
69			if ($spotter_item['description'] != '') {
70			print '<div class="notamtext"><span>'._("Info").'</span>';
71			print $spotter_item['description'];
72			print '</div>';
73			}
74			}
75
76
77			print '</div>';
78			}
79			print '</div>';
80			}
81			?>

Ysurac / FlightAirMap

Push — master ( aee2fd...22b09a )

location-data.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like