Completed
Push — master ( bd3ead...d11f0e )
by Yannick
10:09
created
install/class.update_schema.php 1 patch
Braces   +368 added lines, -136 removed lines patch added patch discarded remove patch
@@ -258,7 +258,9 @@  discard block
 block discarded – undo
258 258
     		// Update table countries
259 259
     		if ($Connection->tableExists('airspace')) {
260 260
     		    $error .= update_db::update_countries();
261
-		    if ($error != '') return $error;
261
+		    if ($error != '') {
262
+		    	return $error;
263
+		    }
262 264
 		}
263 265
 		// Update schema_version to 7
264 266
 		$query = "UPDATE `config` SET `value` = '7' WHERE `name` = 'schema_version'";
@@ -314,7 +316,9 @@  discard block
 block discarded – undo
314 316
     		$error = '';
315 317
     		// Update table aircraft
316 318
 		$error .= create_db::import_file('../db/source_location.sql');
317
-		if ($error != '') return $error;
319
+		if ($error != '') {
320
+			return $error;
321
+		}
318 322
 		// Update schema_version to 6
319 323
 		$query = "UPDATE `config` SET `value` = '8' WHERE `name` = 'schema_version'";
320 324
         	try {
@@ -331,7 +335,9 @@  discard block
 block discarded – undo
331 335
     		$error = '';
332 336
     		// Update table aircraft
333 337
 		$error .= create_db::import_file('../db/notam.sql');
334
-		if ($error != '') return $error;
338
+		if ($error != '') {
339
+			return $error;
340
+		}
335 341
 		$query = "DELETE FROM config WHERE name = 'last_update_db';
336 342
                         INSERT INTO config (name,value) VALUES ('last_update_db',NOW());
337 343
                         DELETE FROM config WHERE name = 'last_update_notam_db';
@@ -365,7 +371,9 @@  discard block
 block discarded – undo
365 371
 		$error = '';
366 372
     		// Update table atc
367 373
 		$error .= create_db::import_file('../db/atc.sql');
368
-		if ($error != '') return $error;
374
+		if ($error != '') {
375
+			return $error;
376
+		}
369 377
 		
370 378
 		$query = "UPDATE `config` SET `value` = '10' WHERE `name` = 'schema_version'";
371 379
         	try {
@@ -389,13 +397,21 @@  discard block
 block discarded – undo
389 397
 		$error = '';
390 398
     		// Add tables
391 399
 		$error .= create_db::import_file('../db/aircraft_owner.sql');
392
-		if ($error != '') return $error;
400
+		if ($error != '') {
401
+			return $error;
402
+		}
393 403
 		$error .= create_db::import_file('../db/metar.sql');
394
-		if ($error != '') return $error;
404
+		if ($error != '') {
405
+			return $error;
406
+		}
395 407
 		$error .= create_db::import_file('../db/taf.sql');
396
-		if ($error != '') return $error;
408
+		if ($error != '') {
409
+			return $error;
410
+		}
397 411
 		$error .= create_db::import_file('../db/airport.sql');
398
-		if ($error != '') return $error;
412
+		if ($error != '') {
413
+			return $error;
414
+		}
399 415
 		
400 416
 		$query = "UPDATE `config` SET `value` = '11' WHERE `name` = 'schema_version'";
401 417
         	try {
@@ -469,19 +485,33 @@  discard block
 block discarded – undo
469 485
 		$error = '';
470 486
     		// Add tables
471 487
 		$error .= create_db::import_file('../db/stats.sql');
472
-		if ($error != '') return $error;
488
+		if ($error != '') {
489
+			return $error;
490
+		}
473 491
 		$error .= create_db::import_file('../db/stats_aircraft.sql');
474
-		if ($error != '') return $error;
492
+		if ($error != '') {
493
+			return $error;
494
+		}
475 495
 		$error .= create_db::import_file('../db/stats_airline.sql');
476
-		if ($error != '') return $error;
496
+		if ($error != '') {
497
+			return $error;
498
+		}
477 499
 		$error .= create_db::import_file('../db/stats_airport.sql');
478
-		if ($error != '') return $error;
500
+		if ($error != '') {
501
+			return $error;
502
+		}
479 503
 		$error .= create_db::import_file('../db/stats_owner.sql');
480
-		if ($error != '') return $error;
504
+		if ($error != '') {
505
+			return $error;
506
+		}
481 507
 		$error .= create_db::import_file('../db/stats_pilot.sql');
482
-		if ($error != '') return $error;
508
+		if ($error != '') {
509
+			return $error;
510
+		}
483 511
 		$error .= create_db::import_file('../db/spotter_archive_output.sql');
484
-		if ($error != '') return $error;
512
+		if ($error != '') {
513
+			return $error;
514
+		}
485 515
 		
486 516
 		$query = "UPDATE `config` SET `value` = '13' WHERE `name` = 'schema_version'";
487 517
         	try {
@@ -521,7 +551,9 @@  discard block
 block discarded – undo
521 551
     		// Add tables
522 552
     		if (!$Connection->tableExists('stats_flight')) {
523 553
 			$error .= create_db::import_file('../db/stats_flight.sql');
524
-			if ($error != '') return $error;
554
+			if ($error != '') {
555
+				return $error;
556
+			}
525 557
 		}
526 558
 		$query = "UPDATE `config` SET `value` = '15' WHERE `name` = 'schema_version'";
527 559
         	try {
@@ -545,7 +577,9 @@  discard block
 block discarded – undo
545 577
     		} catch(PDOException $e) {
546 578
 		    return "error (update stats) : ".$e->getMessage()."\n";
547 579
     		}
548
-		if ($error != '') return $error;
580
+		if ($error != '') {
581
+			return $error;
582
+		}
549 583
 		$query = "UPDATE `config` SET `value` = '16' WHERE `name` = 'schema_version'";
550 584
         	try {
551 585
             	    $sth = $Connection->db->prepare($query);
@@ -566,7 +600,9 @@  discard block
 block discarded – undo
566 600
     		if (!$Connection->tableExists('stats_callsign')) {
567 601
 			$error .= create_db::import_file('../db/stats_callsign.sql');
568 602
 		}
569
-		if ($error != '') return $error;
603
+		if ($error != '') {
604
+			return $error;
605
+		}
570 606
 		$query = "UPDATE `config` SET `value` = '17' WHERE `name` = 'schema_version'";
571 607
         	try {
572 608
             	    $sth = $Connection->db->prepare($query);
@@ -584,7 +620,9 @@  discard block
 block discarded – undo
584 620
     		if (!$Connection->tableExists('stats_country')) {
585 621
 			$error .= create_db::import_file('../db/stats_country.sql');
586 622
 		}
587
-		if ($error != '') return $error;
623
+		if ($error != '') {
624
+			return $error;
625
+		}
588 626
 		$query = "UPDATE `config` SET `value` = '18' WHERE `name` = 'schema_version'";
589 627
         	try {
590 628
             	    $sth = $Connection->db->prepare($query);
@@ -607,7 +645,9 @@  discard block
 block discarded – undo
607 645
 			    return "error (update stats) : ".$e->getMessage()."\n";
608 646
     			}
609 647
     		}
610
-		if ($error != '') return $error;
648
+		if ($error != '') {
649
+			return $error;
650
+		}
611 651
 		$query = "UPDATE `config` SET `value` = '19' WHERE `name` = 'schema_version'";
612 652
         	try {
613 653
             	    $sth = $Connection->db->prepare($query);
@@ -623,7 +663,9 @@  discard block
 block discarded – undo
623 663
 		$error = '';
624 664
     		// Update airport table
625 665
 		$error .= create_db::import_file('../db/airport.sql');
626
-		if ($error != '') return 'Import airport.sql : '.$error;
666
+		if ($error != '') {
667
+			return 'Import airport.sql : '.$error;
668
+		}
627 669
 		// Remove primary key on Spotter_Archive
628 670
 		$query = "alter table spotter_archive drop spotter_archive_id";
629 671
         	try {
@@ -699,7 +741,9 @@  discard block
 block discarded – undo
699 741
 				return "error (add source_name column) : ".$e->getMessage()."\n";
700 742
     			}
701 743
     		}
702
-		if ($error != '') return $error;
744
+		if ($error != '') {
745
+			return $error;
746
+		}
703 747
 		$query = "UPDATE `config` SET `value` = '20' WHERE `name` = 'schema_version'";
704 748
         	try {
705 749
             	    $sth = $Connection->db->prepare($query);
@@ -717,7 +761,9 @@  discard block
 block discarded – undo
717 761
     		// Update airline table
718 762
     		if (!$globalIVAO && !$globalVATSIM && !$globalphpVMS) {
719 763
 			$error .= create_db::import_file('../db/airlines.sql');
720
-			if ($error != '') return 'Import airlines.sql : '.$error;
764
+			if ($error != '') {
765
+				return 'Import airlines.sql : '.$error;
766
+			}
721 767
 		}
722 768
 		if (!$Connection->checkColumnName('aircraft_modes','type_flight')) {
723 769
 			// Add column over_country
@@ -729,7 +775,9 @@  discard block
 block discarded – undo
729 775
 				return "error (add over_country) : ".$e->getMessage()."\n";
730 776
     			}
731 777
     		}
732
-		if ($error != '') return $error;
778
+		if ($error != '') {
779
+			return $error;
780
+		}
733 781
 		/*
734 782
     		if (!$globalIVAO && !$globalVATSIM && !$globalphpVMS) {
735 783
 			// Force update ModeS (this will put type_flight data
@@ -759,7 +807,9 @@  discard block
 block discarded – undo
759 807
 			} catch(PDOException $e) {
760 808
 				return "error (rename type to stats_type on stats*) : ".$e->getMessage()."\n";
761 809
 			}
762
-			if ($error != '') return $error;
810
+			if ($error != '') {
811
+				return $error;
812
+			}
763 813
 		}
764 814
 		$query = "UPDATE `config` SET `value` = '22' WHERE `name` = 'schema_version'";
765 815
         	try {
@@ -782,7 +832,9 @@  discard block
 block discarded – undo
782 832
 			} else {
783 833
 				$error .= create_db::import_file('../db/pgsql/stats_source.sql');
784 834
 			}
785
-			if ($error != '') return $error;
835
+			if ($error != '') {
836
+				return $error;
837
+			}
786 838
 		}
787 839
 		$query = "UPDATE config SET value = '23' WHERE name = 'schema_version'";
788 840
         	try {
@@ -804,12 +856,16 @@  discard block
 block discarded – undo
804 856
 		if ($globalDBdriver == 'mysql') {
805 857
 			if (!$Connection->tableExists('tle')) {
806 858
 				$error .= create_db::import_file('../db/tle.sql');
807
-				if ($error != '') return $error;
859
+				if ($error != '') {
860
+					return $error;
861
+				}
808 862
 			}
809 863
 		} else {
810 864
 			if (!$Connection->tableExists('tle')) {
811 865
 				$error .= create_db::import_file('../db/pgsql/tle.sql');
812
-				if ($error != '') return $error;
866
+				if ($error != '') {
867
+					return $error;
868
+				}
813 869
 			}
814 870
 			$query = "create index flightaware_id_idx ON spotter_archive USING btree(flightaware_id)";
815 871
 			try {
@@ -849,7 +905,9 @@  discard block
 block discarded – undo
849 905
 		} else {
850 906
 			$error .= create_db::import_file('../db/pgsql/airlines.sql');
851 907
 		}
852
-		if ($error != '') return 'Import airlines.sql : '.$error;
908
+		if ($error != '') {
909
+			return 'Import airlines.sql : '.$error;
910
+		}
853 911
 		if (!$Connection->checkColumnName('airlines','forsource')) {
854 912
 			// Add forsource to airlines
855 913
 			$query = "ALTER TABLE airlines ADD forsource VARCHAR(255) NULL DEFAULT NULL";
@@ -1332,20 +1390,28 @@  discard block
 block discarded – undo
1332 1390
 		}
1333 1391
 		if ($globalDBdriver == 'mysql') {
1334 1392
 			$error .= create_db::import_file('../db/airlines.sql');
1335
-			if ($error != '') return $error;
1393
+			if ($error != '') {
1394
+				return $error;
1395
+			}
1336 1396
 		} else {
1337 1397
 			$error .= create_db::import_file('../db/pgsql/airlines.sql');
1338
-			if ($error != '') return $error;
1398
+			if ($error != '') {
1399
+				return $error;
1400
+			}
1339 1401
 		}
1340 1402
 		if ((isset($globalVATSIM) && $globalVATSIM) || (isset($globalIVAO) && $globalIVAO)) {
1341 1403
 			include_once(dirname(__FILE__).'/class.update_db.php');
1342 1404
 			if (isset($globalVATSIM) && $globalVATSIM) {
1343 1405
 				$error .= update_db::update_vatsim();
1344
-				if ($error != '') return $error;
1406
+				if ($error != '') {
1407
+					return $error;
1408
+				}
1345 1409
 			}
1346 1410
 			if (isset($globalIVAO) && $globalIVAO && file_exists('tmp/ivae_feb2013.zip')) {
1347 1411
 				$error .= update_db::update_IVAO();
1348
-				if ($error != '') return $error;
1412
+				if ($error != '') {
1413
+					return $error;
1414
+				}
1349 1415
 			}
1350 1416
 		}
1351 1417
 
@@ -1608,41 +1674,65 @@  discard block
 block discarded – undo
1608 1674
 		if ($globalDBdriver == 'mysql') {
1609 1675
 			if (!$Connection->tableExists('tracker_output')) {
1610 1676
 				$error .= create_db::import_file('../db/tracker_output.sql');
1611
-				if ($error != '') return $error;
1677
+				if ($error != '') {
1678
+					return $error;
1679
+				}
1612 1680
 			}
1613 1681
 			if (!$Connection->tableExists('tracker_live')) {
1614 1682
 				$error .= create_db::import_file('../db/tracker_live.sql');
1615
-				if ($error != '') return $error;
1683
+				if ($error != '') {
1684
+					return $error;
1685
+				}
1616 1686
 			}
1617 1687
 			if (!$Connection->tableExists('marine_output')) {
1618 1688
 				$error .= create_db::import_file('../db/marine_output.sql');
1619
-				if ($error != '') return $error;
1689
+				if ($error != '') {
1690
+					return $error;
1691
+				}
1620 1692
 			}
1621 1693
 			if (!$Connection->tableExists('marine_live')) {
1622 1694
 				$error .= create_db::import_file('../db/marine_live.sql');
1623
-				if ($error != '') return $error;
1695
+				if ($error != '') {
1696
+					return $error;
1697
+				}
1624 1698
 			}
1625 1699
 			if (!$Connection->tableExists('marine_identity')) {
1626 1700
 				$error .= create_db::import_file('../db/marine_identity.sql');
1627
-				if ($error != '') return $error;
1701
+				if ($error != '') {
1702
+					return $error;
1703
+				}
1628 1704
 			}
1629 1705
 			if (!$Connection->tableExists('marine_mid')) {
1630 1706
 				$error .= create_db::import_file('../db/marine_mid.sql');
1631
-				if ($error != '') return $error;
1707
+				if ($error != '') {
1708
+					return $error;
1709
+				}
1632 1710
 			}
1633 1711
 		} else {
1634 1712
 			$error .= create_db::import_file('../db/pgsql/tracker_output.sql');
1635
-			if ($error != '') return $error;
1713
+			if ($error != '') {
1714
+				return $error;
1715
+			}
1636 1716
 			$error .= create_db::import_file('../db/pgsql/tracker_live.sql');
1637
-			if ($error != '') return $error;
1717
+			if ($error != '') {
1718
+				return $error;
1719
+			}
1638 1720
 			$error .= create_db::import_file('../db/pgsql/marine_output.sql');
1639
-			if ($error != '') return $error;
1721
+			if ($error != '') {
1722
+				return $error;
1723
+			}
1640 1724
 			$error .= create_db::import_file('../db/pgsql/marine_live.sql');
1641
-			if ($error != '') return $error;
1725
+			if ($error != '') {
1726
+				return $error;
1727
+			}
1642 1728
 			$error .= create_db::import_file('../db/pgsql/marine_identity.sql');
1643
-			if ($error != '') return $error;
1729
+			if ($error != '') {
1730
+				return $error;
1731
+			}
1644 1732
 			$error .= create_db::import_file('../db/pgsql/marine_mid.sql');
1645
-			if ($error != '') return $error;
1733
+			if ($error != '') {
1734
+				return $error;
1735
+			}
1646 1736
 		}
1647 1737
 		$query = "UPDATE config SET value = '37' WHERE name = 'schema_version'";
1648 1738
 		try {
@@ -1661,35 +1751,55 @@  discard block
 block discarded – undo
1661 1751
 		if ($globalDBdriver == 'mysql') {
1662 1752
 			if (!$Connection->tableExists('marine_image')) {
1663 1753
 				$error .= create_db::import_file('../db/marine_image.sql');
1664
-				if ($error != '') return $error;
1754
+				if ($error != '') {
1755
+					return $error;
1756
+				}
1665 1757
 			}
1666 1758
 			if (!$Connection->tableExists('marine_archive')) {
1667 1759
 				$error .= create_db::import_file('../db/marine_archive.sql');
1668
-				if ($error != '') return $error;
1760
+				if ($error != '') {
1761
+					return $error;
1762
+				}
1669 1763
 			}
1670 1764
 			if (!$Connection->tableExists('marine_archive_output')) {
1671 1765
 				$error .= create_db::import_file('../db/marine_archive_output.sql');
1672
-				if ($error != '') return $error;
1766
+				if ($error != '') {
1767
+					return $error;
1768
+				}
1673 1769
 			}
1674 1770
 			if (!$Connection->tableExists('tracker_archive')) {
1675 1771
 				$error .= create_db::import_file('../db/tracker_archive.sql');
1676
-				if ($error != '') return $error;
1772
+				if ($error != '') {
1773
+					return $error;
1774
+				}
1677 1775
 			}
1678 1776
 			if (!$Connection->tableExists('marine_archive_output')) {
1679 1777
 				$error .= create_db::import_file('../db/tracker_archive_output.sql');
1680
-				if ($error != '') return $error;
1778
+				if ($error != '') {
1779
+					return $error;
1780
+				}
1681 1781
 			}
1682 1782
 		} else {
1683 1783
 			$error .= create_db::import_file('../db/pgsql/marine_image.sql');
1684
-			if ($error != '') return $error;
1784
+			if ($error != '') {
1785
+				return $error;
1786
+			}
1685 1787
 			$error .= create_db::import_file('../db/pgsql/marine_archive.sql');
1686
-			if ($error != '') return $error;
1788
+			if ($error != '') {
1789
+				return $error;
1790
+			}
1687 1791
 			$error .= create_db::import_file('../db/pgsql/marine_archive_output.sql');
1688
-			if ($error != '') return $error;
1792
+			if ($error != '') {
1793
+				return $error;
1794
+			}
1689 1795
 			$error .= create_db::import_file('../db/pgsql/tracker_archive.sql');
1690
-			if ($error != '') return $error;
1796
+			if ($error != '') {
1797
+				return $error;
1798
+			}
1691 1799
 			$error .= create_db::import_file('../db/pgsql/tracker_archive_output.sql');
1692
-			if ($error != '') return $error;
1800
+			if ($error != '') {
1801
+				return $error;
1802
+			}
1693 1803
 		}
1694 1804
 		if ($globalDBdriver == 'mysql') {
1695 1805
 			$query = "SELECT ENGINE FROM information_schema.TABLES where TABLE_SCHEMA = '".$globalDBname."' AND TABLE_NAME = 'spotter_archive'";
@@ -1944,8 +2054,11 @@  discard block
 block discarded – undo
1944 2054
     	    if ($Connection->tableExists('aircraft')) {
1945 2055
     		if (!$Connection->tableExists('config')) {
1946 2056
     		    $version = '1';
1947
-    		    if ($update) return self::update_from_1();
1948
-    		    else return $version;
2057
+    		    if ($update) {
2058
+    		    	return self::update_from_1();
2059
+    		    } else {
2060
+    		    	return $version;
2061
+    		    }
1949 2062
 		} else {
1950 2063
     		    $Connection = new Connection();
1951 2064
 		    $query = "SELECT value FROM config WHERE name = 'schema_version' LIMIT 1";
@@ -1959,162 +2072,281 @@  discard block
 block discarded – undo
1959 2072
     		    if ($update) {
1960 2073
     			if ($result['value'] == '2') {
1961 2074
     			    $error = self::update_from_2();
1962
-    			    if ($error != '') return $error;
1963
-    			    else return self::check_version(true);
2075
+    			    if ($error != '') {
2076
+    			    	return $error;
2077
+    			    } else {
2078
+    			    	return self::check_version(true);
2079
+    			    }
1964 2080
     			} elseif ($result['value'] == '3') {
1965 2081
     			    $error = self::update_from_3();
1966
-    			    if ($error != '') return $error;
1967
-    			    else return self::check_version(true);
2082
+    			    if ($error != '') {
2083
+    			    	return $error;
2084
+    			    } else {
2085
+    			    	return self::check_version(true);
2086
+    			    }
1968 2087
     			} elseif ($result['value'] == '4') {
1969 2088
     			    $error = self::update_from_4();
1970
-    			    if ($error != '') return $error;
1971
-    			    else return self::check_version(true);
2089
+    			    if ($error != '') {
2090
+    			    	return $error;
2091
+    			    } else {
2092
+    			    	return self::check_version(true);
2093
+    			    }
1972 2094
     			} elseif ($result['value'] == '5') {
1973 2095
     			    $error = self::update_from_5();
1974
-    			    if ($error != '') return $error;
1975
-    			    else return self::check_version(true);
2096
+    			    if ($error != '') {
2097
+    			    	return $error;
2098
+    			    } else {
2099
+    			    	return self::check_version(true);
2100
+    			    }
1976 2101
     			} elseif ($result['value'] == '6') {
1977 2102
     			    $error = self::update_from_6();
1978
-    			    if ($error != '') return $error;
1979
-    			    else return self::check_version(true);
2103
+    			    if ($error != '') {
2104
+    			    	return $error;
2105
+    			    } else {
2106
+    			    	return self::check_version(true);
2107
+    			    }
1980 2108
     			} elseif ($result['value'] == '7') {
1981 2109
     			    $error = self::update_from_7();
1982
-    			    if ($error != '') return $error;
1983
-    			    else return self::check_version(true);
2110
+    			    if ($error != '') {
2111
+    			    	return $error;
2112
+    			    } else {
2113
+    			    	return self::check_version(true);
2114
+    			    }
1984 2115
     			} elseif ($result['value'] == '8') {
1985 2116
     			    $error = self::update_from_8();
1986
-    			    if ($error != '') return $error;
1987
-    			    else return self::check_version(true);
2117
+    			    if ($error != '') {
2118
+    			    	return $error;
2119
+    			    } else {
2120
+    			    	return self::check_version(true);
2121
+    			    }
1988 2122
     			} elseif ($result['value'] == '9') {
1989 2123
     			    $error = self::update_from_9();
1990
-    			    if ($error != '') return $error;
1991
-    			    else return self::check_version(true);
2124
+    			    if ($error != '') {
2125
+    			    	return $error;
2126
+    			    } else {
2127
+    			    	return self::check_version(true);
2128
+    			    }
1992 2129
     			} elseif ($result['value'] == '10') {
1993 2130
     			    $error = self::update_from_10();
1994
-    			    if ($error != '') return $error;
1995
-    			    else return self::check_version(true);
2131
+    			    if ($error != '') {
2132
+    			    	return $error;
2133
+    			    } else {
2134
+    			    	return self::check_version(true);
2135
+    			    }
1996 2136
     			} elseif ($result['value'] == '11') {
1997 2137
     			    $error = self::update_from_11();
1998
-    			    if ($error != '') return $error;
1999
-    			    else return self::check_version(true);
2138
+    			    if ($error != '') {
2139
+    			    	return $error;
2140
+    			    } else {
2141
+    			    	return self::check_version(true);
2142
+    			    }
2000 2143
     			} elseif ($result['value'] == '12') {
2001 2144
     			    $error = self::update_from_12();
2002
-    			    if ($error != '') return $error;
2003
-    			    else return self::check_version(true);
2145
+    			    if ($error != '') {
2146
+    			    	return $error;
2147
+    			    } else {
2148
+    			    	return self::check_version(true);
2149
+    			    }
2004 2150
     			} elseif ($result['value'] == '13') {
2005 2151
     			    $error = self::update_from_13();
2006
-    			    if ($error != '') return $error;
2007
-    			    else return self::check_version(true);
2152
+    			    if ($error != '') {
2153
+    			    	return $error;
2154
+    			    } else {
2155
+    			    	return self::check_version(true);
2156
+    			    }
2008 2157
     			} elseif ($result['value'] == '14') {
2009 2158
     			    $error = self::update_from_14();
2010
-    			    if ($error != '') return $error;
2011
-    			    else return self::check_version(true);
2159
+    			    if ($error != '') {
2160
+    			    	return $error;
2161
+    			    } else {
2162
+    			    	return self::check_version(true);
2163
+    			    }
2012 2164
     			} elseif ($result['value'] == '15') {
2013 2165
     			    $error = self::update_from_15();
2014
-    			    if ($error != '') return $error;
2015
-    			    else return self::check_version(true);
2166
+    			    if ($error != '') {
2167
+    			    	return $error;
2168
+    			    } else {
2169
+    			    	return self::check_version(true);
2170
+    			    }
2016 2171
     			} elseif ($result['value'] == '16') {
2017 2172
     			    $error = self::update_from_16();
2018
-    			    if ($error != '') return $error;
2019
-    			    else return self::check_version(true);
2173
+    			    if ($error != '') {
2174
+    			    	return $error;
2175
+    			    } else {
2176
+    			    	return self::check_version(true);
2177
+    			    }
2020 2178
     			} elseif ($result['value'] == '17') {
2021 2179
     			    $error = self::update_from_17();
2022
-    			    if ($error != '') return $error;
2023
-    			    else return self::check_version(true);
2180
+    			    if ($error != '') {
2181
+    			    	return $error;
2182
+    			    } else {
2183
+    			    	return self::check_version(true);
2184
+    			    }
2024 2185
     			} elseif ($result['value'] == '18') {
2025 2186
     			    $error = self::update_from_18();
2026
-    			    if ($error != '') return $error;
2027
-    			    else return self::check_version(true);
2187
+    			    if ($error != '') {
2188
+    			    	return $error;
2189
+    			    } else {
2190
+    			    	return self::check_version(true);
2191
+    			    }
2028 2192
     			} elseif ($result['value'] == '19') {
2029 2193
     			    $error = self::update_from_19();
2030
-    			    if ($error != '') return $error;
2031
-    			    else return self::check_version(true);
2194
+    			    if ($error != '') {
2195
+    			    	return $error;
2196
+    			    } else {
2197
+    			    	return self::check_version(true);
2198
+    			    }
2032 2199
     			} elseif ($result['value'] == '20') {
2033 2200
     			    $error = self::update_from_20();
2034
-    			    if ($error != '') return $error;
2035
-    			    else return self::check_version(true);
2201
+    			    if ($error != '') {
2202
+    			    	return $error;
2203
+    			    } else {
2204
+    			    	return self::check_version(true);
2205
+    			    }
2036 2206
     			} elseif ($result['value'] == '21') {
2037 2207
     			    $error = self::update_from_21();
2038
-    			    if ($error != '') return $error;
2039
-    			    else return self::check_version(true);
2208
+    			    if ($error != '') {
2209
+    			    	return $error;
2210
+    			    } else {
2211
+    			    	return self::check_version(true);
2212
+    			    }
2040 2213
     			} elseif ($result['value'] == '22') {
2041 2214
     			    $error = self::update_from_22();
2042
-    			    if ($error != '') return $error;
2043
-    			    else return self::check_version(true);
2215
+    			    if ($error != '') {
2216
+    			    	return $error;
2217
+    			    } else {
2218
+    			    	return self::check_version(true);
2219
+    			    }
2044 2220
     			} elseif ($result['value'] == '23') {
2045 2221
     			    $error = self::update_from_23();
2046
-    			    if ($error != '') return $error;
2047
-    			    else return self::check_version(true);
2222
+    			    if ($error != '') {
2223
+    			    	return $error;
2224
+    			    } else {
2225
+    			    	return self::check_version(true);
2226
+    			    }
2048 2227
     			} elseif ($result['value'] == '24') {
2049 2228
     			    $error = self::update_from_24();
2050
-    			    if ($error != '') return $error;
2051
-    			    else return self::check_version(true);
2229
+    			    if ($error != '') {
2230
+    			    	return $error;
2231
+    			    } else {
2232
+    			    	return self::check_version(true);
2233
+    			    }
2052 2234
     			} elseif ($result['value'] == '25') {
2053 2235
     			    $error = self::update_from_25();
2054
-    			    if ($error != '') return $error;
2055
-    			    else return self::check_version(true);
2236
+    			    if ($error != '') {
2237
+    			    	return $error;
2238
+    			    } else {
2239
+    			    	return self::check_version(true);
2240
+    			    }
2056 2241
     			} elseif ($result['value'] == '26') {
2057 2242
     			    $error = self::update_from_26();
2058
-    			    if ($error != '') return $error;
2059
-    			    else return self::check_version(true);
2243
+    			    if ($error != '') {
2244
+    			    	return $error;
2245
+    			    } else {
2246
+    			    	return self::check_version(true);
2247
+    			    }
2060 2248
     			} elseif ($result['value'] == '27') {
2061 2249
     			    $error = self::update_from_27();
2062
-    			    if ($error != '') return $error;
2063
-    			    else return self::check_version(true);
2250
+    			    if ($error != '') {
2251
+    			    	return $error;
2252
+    			    } else {
2253
+    			    	return self::check_version(true);
2254
+    			    }
2064 2255
     			} elseif ($result['value'] == '28') {
2065 2256
     			    $error = self::update_from_28();
2066
-    			    if ($error != '') return $error;
2067
-    			    else return self::check_version(true);
2257
+    			    if ($error != '') {
2258
+    			    	return $error;
2259
+    			    } else {
2260
+    			    	return self::check_version(true);
2261
+    			    }
2068 2262
     			} elseif ($result['value'] == '29') {
2069 2263
     			    $error = self::update_from_29();
2070
-    			    if ($error != '') return $error;
2071
-    			    else return self::check_version(true);
2264
+    			    if ($error != '') {
2265
+    			    	return $error;
2266
+    			    } else {
2267
+    			    	return self::check_version(true);
2268
+    			    }
2072 2269
     			} elseif ($result['value'] == '30') {
2073 2270
     			    $error = self::update_from_30();
2074
-    			    if ($error != '') return $error;
2075
-    			    else return self::check_version(true);
2271
+    			    if ($error != '') {
2272
+    			    	return $error;
2273
+    			    } else {
2274
+    			    	return self::check_version(true);
2275
+    			    }
2076 2276
     			} elseif ($result['value'] == '31') {
2077 2277
     			    $error = self::update_from_31();
2078
-    			    if ($error != '') return $error;
2079
-    			    else return self::check_version(true);
2278
+    			    if ($error != '') {
2279
+    			    	return $error;
2280
+    			    } else {
2281
+    			    	return self::check_version(true);
2282
+    			    }
2080 2283
     			} elseif ($result['value'] == '32') {
2081 2284
     			    $error = self::update_from_32();
2082
-    			    if ($error != '') return $error;
2083
-    			    else return self::check_version(true);
2285
+    			    if ($error != '') {
2286
+    			    	return $error;
2287
+    			    } else {
2288
+    			    	return self::check_version(true);
2289
+    			    }
2084 2290
     			} elseif ($result['value'] == '33') {
2085 2291
     			    $error = self::update_from_33();
2086
-    			    if ($error != '') return $error;
2087
-    			    else return self::check_version(true);
2292
+    			    if ($error != '') {
2293
+    			    	return $error;
2294
+    			    } else {
2295
+    			    	return self::check_version(true);
2296
+    			    }
2088 2297
     			} elseif ($result['value'] == '34') {
2089 2298
     			    $error = self::update_from_34();
2090
-    			    if ($error != '') return $error;
2091
-    			    else return self::check_version(true);
2299
+    			    if ($error != '') {
2300
+    			    	return $error;
2301
+    			    } else {
2302
+    			    	return self::check_version(true);
2303
+    			    }
2092 2304
     			} elseif ($result['value'] == '35') {
2093 2305
     			    $error = self::update_from_35();
2094
-    			    if ($error != '') return $error;
2095
-    			    else return self::check_version(true);
2306
+    			    if ($error != '') {
2307
+    			    	return $error;
2308
+    			    } else {
2309
+    			    	return self::check_version(true);
2310
+    			    }
2096 2311
     			} elseif ($result['value'] == '36') {
2097 2312
     			    $error = self::update_from_36();
2098
-    			    if ($error != '') return $error;
2099
-    			    else return self::check_version(true);
2313
+    			    if ($error != '') {
2314
+    			    	return $error;
2315
+    			    } else {
2316
+    			    	return self::check_version(true);
2317
+    			    }
2100 2318
     			} elseif ($result['value'] == '37') {
2101 2319
     			    $error = self::update_from_37();
2102
-    			    if ($error != '') return $error;
2103
-    			    else return self::check_version(true);
2320
+    			    if ($error != '') {
2321
+    			    	return $error;
2322
+    			    } else {
2323
+    			    	return self::check_version(true);
2324
+    			    }
2104 2325
     			} elseif ($result['value'] == '38') {
2105 2326
     			    $error = self::update_from_38();
2106
-    			    if ($error != '') return $error;
2107
-    			    else return self::check_version(true);
2327
+    			    if ($error != '') {
2328
+    			    	return $error;
2329
+    			    } else {
2330
+    			    	return self::check_version(true);
2331
+    			    }
2108 2332
     			} elseif ($result['value'] == '39') {
2109 2333
     			    $error = self::update_from_39();
2110
-    			    if ($error != '') return $error;
2111
-    			    else return self::check_version(true);
2112
-    			} else return '';
2334
+    			    if ($error != '') {
2335
+    			    	return $error;
2336
+    			    } else {
2337
+    			    	return self::check_version(true);
2338
+    			    }
2339
+    			} else {
2340
+    				return '';
2341
+    			}
2342
+    		    } else {
2343
+    		    	return $result['value'];
2113 2344
     		    }
2114
-    		    else return $result['value'];
2115 2345
 		}
2116 2346
 		
2117
-	    } else return $version;
2347
+	    } else {
2348
+	    	return $version;
2349
+	    }
2118 2350
     	}
2119 2351
     	
2120 2352
 }
Please login to merge, or discard this patch.