Predict_SGPObs::Calculate_Obs() - Code Metrics - Inspection of "Add satellite support, add manufacturer in aircraf..." - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d35909...f740b5 )

by Yannick

created 2016-10-03 13:14 UTC

Predict_SGPObs::Calculate_Obs() A

↳ Parent: Predict_SGPObs

Complexity

Conditions	4
Paths	8

Size

Total Lines	55
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	37
nc	8
nop	5
dl	0
loc	55
rs	9.078
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * Predict_SGPObs
 *
 * Ported to PHP by Bill Shupp.  Original comments below
 */

require_once 'Math.php';
require_once 'Time.php';
//require_once 'Predict.php';
require_once 'Vector.php';
require_once 'ObsSet.php';

/*
 * Unit SGP_Obs
 *           Author:  Dr TS Kelso
 * Original Version:  1992 Jun 02
 * Current Revision:  1992 Sep 28
 *          Version:  1.40
 *        Copyright:  1992, All Rights Reserved
 *
 *   Ported to C by:  Neoklis Kyriazis  April 9 2001
 *   Ported to PHP by Bill Shupp August, 2011
 */
class Predict_SGPObs
{
    /* Procedure Calculate_User_PosVel passes the user's geodetic position */
    /* and the time of interest and returns the ECI position and velocity  */
    /* of the observer. The velocity calculation assumes the geodetic      */
    /* position is stationary relative to the earth's surface.             */
    public static function Calculate_User_PosVel(
        $_time, Predict_Geodetic $geodetic, Predict_Vector $obs_pos, Predict_Vector $obs_vel
    )
    {
        /* Reference:  The 1992 Astronomical Almanac, page K11. */

        $sinGeodeticLat = sin($geodetic->lat); /* Only run sin($geodetic->lat) once */

        $geodetic->theta = Predict_Math::FMod2p(Predict_Time::ThetaG_JD($_time) + $geodetic->lon);/*LMST*/
        $c = 1 / sqrt(1 + Predict::__f * (Predict::__f - 2) * $sinGeodeticLat * $sinGeodeticLat);
        $sq = (1 - Predict::__f) * (1 - Predict::__f) * $c;
        $achcp = (Predict::xkmper * $c + $geodetic->alt) * cos($geodetic->lat);
        $obs_pos->x = $achcp * cos($geodetic->theta); /*kilometers*/
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_pos->y = $achcp * sin($geodetic->theta);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_pos->z = (Predict::xkmper * $sq + $geodetic->alt) * $sinGeodeticLat;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_vel->x = -Predict::mfactor * $obs_pos->y; /*kilometers/second*/
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_vel->y =  Predict::mfactor * $obs_pos->x;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_vel->z =  0;
        $obs_pos->w = sqrt($obs_pos->x * $obs_pos->x + $obs_pos->y * $obs_pos->y + $obs_pos->z * $obs_pos->z);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $obs_vel->w = sqrt($obs_vel->x * $obs_vel->x + $obs_vel->y * $obs_vel->y + $obs_vel->z * $obs_vel->z);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /* Procedure Calculate_LatLonAlt will calculate the geodetic  */
    /* position of an object given its ECI position pos and time. */
    /* It is intended to be used to determine the ground track of */
    /* a satellite.  The calculations  assume the earth to be an  */
    /* oblate spheroid as defined in WGS '72.                     */
    public static function Calculate_LatLonAlt($_time, Predict_Vector $pos,  Predict_Geodetic $geodetic)
    {
        /* Reference:  The 1992 Astronomical Almanac, page K12. */

        /* double r,e2,phi,c; */

        $geodetic->theta = Predict_Math::AcTan($pos->y, $pos->x); /*radians*/
        $geodetic->lon = Predict_Math::FMod2p($geodetic->theta - Predict_Time::ThetaG_JD($_time)); /*radians*/
        $r = sqrt(($pos->x * $pos->x) + ($pos->y * $pos->y));
        $e2 = Predict::__f * (2 - Predict::__f);
        $geodetic->lat = Predict_Math::AcTan($pos->z, $r); /*radians*/

        do {
            $phi    = $geodetic->lat;
            $sinPhi = sin($phi);
            $c      = 1 / sqrt(1 - $e2 * ($sinPhi * $sinPhi));
            $geodetic->lat = Predict_Math::AcTan($pos->z + Predict::xkmper * $c * $e2 * $sinPhi, $r);
        } while (abs($geodetic->lat - $phi) >= 1E-10);

        $geodetic->alt = $r / cos($geodetic->lat) - Predict::xkmper * $c;/*kilometers*/

        if ($geodetic->lat > Predict::pio2) {
            $geodetic->lat -= Predict::twopi;
        }
    }

    /* The procedures Calculate_Obs and Calculate_RADec calculate         */
    /* the *topocentric* coordinates of the object with ECI position,     */
    /* {pos}, and velocity, {vel}, from location {geodetic} at {time}.    */
    /* The {obs_set} returned for Calculate_Obs consists of azimuth,      */
    /* elevation, range, and range rate (in that order) with units of     */
    /* radians, radians, kilometers, and kilometers/second, respectively. */
    /* The WGS '72 geoid is used and the effect of atmospheric refraction */
    /* (under standard temperature and pressure) is incorporated into the */
    /* elevation calculation; the effect of atmospheric refraction on     */
    /* range and range rate has not yet been quantified.                  */

    /* The {obs_set} for Calculate_RADec consists of right ascension and  */
    /* declination (in that order) in radians.  Again, calculations are   */
    /* based on *topocentric* position using the WGS '72 geoid and        */
    /* incorporating atmospheric refraction.                              */
    public static function Calculate_Obs($_time, Predict_Vector $pos, Predict_Vector $vel, Predict_Geodetic $geodetic, Predict_ObsSet $obs_set)
    {
        $obs_pos = new Predict_Vector();
        $obs_vel = new Predict_Vector();
        $range   = new Predict_Vector();
        $rgvel   = new Predict_Vector();

        self::Calculate_User_PosVel($_time, $geodetic, $obs_pos, $obs_vel);

        $range->x = $pos->x - $obs_pos->x;
        $range->y = $pos->y - $obs_pos->y;
        $range->z = $pos->z - $obs_pos->z;

        $rgvel->x = $vel->x - $obs_vel->x;
        $rgvel->y = $vel->y - $obs_vel->y;
        $rgvel->z = $vel->z - $obs_vel->z;

        $range->w = sqrt($range->x * $range->x + $range->y * $range->y + $range->z * $range->z);
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        $sin_lat   = sin($geodetic->lat);
        $cos_lat   = cos($geodetic->lat);
        $sin_theta = sin($geodetic->theta);
        $cos_theta = cos($geodetic->theta);
        $top_s = $sin_lat * $cos_theta * $range->x
            + $sin_lat * $sin_theta * $range->y
            - $cos_lat * $range->z;
        $top_e = -$sin_theta * $range->x
            + $cos_theta * $range->y;
        $top_z = $cos_lat * $cos_theta * $range->x
            + $cos_lat * $sin_theta * $range->y
            + $sin_lat * $range->z;
        $azim = atan(-$top_e / $top_s); /*Azimuth*/
        if ($top_s > 0) {
            $azim = $azim + Predict::pi;
        }
        if ($azim < 0 ) {
            $azim = $azim + Predict::twopi;
        }
        $el = Predict_Math::ArcSin($top_z / $range->w);
        $obs_set->az = $azim;        /* Azimuth (radians)  */
        $obs_set->el = $el;          /* Elevation (radians)*/
        $obs_set->range = $range->w; /* Range (kilometers) */

        /* Range Rate (kilometers/second)*/
        $obs_set->range_rate = Predict_Math::Dot($range, $rgvel) / $range->w;

        /* Corrections for atmospheric refraction */
        /* Reference:  Astronomical Algorithms by Jean Meeus, pp. 101-104    */
        /* Correction is meaningless when apparent elevation is below horizon */
        //	obs_set->el = obs_set->el + Radians((1.02/tan(Radians(Degrees(el)+
        //							      10.3/(Degrees(el)+5.11))))/60);
        if ($obs_set->el < 0) {
            $obs_set->el = $el;  /*Reset to true elevation*/
        }
    }
}


1			<?php
2
3			/**
4			* Predict_SGPObs
5			*
6			* Ported to PHP by Bill Shupp. Original comments below
7			*/
8
9			require_once 'Math.php';
10			require_once 'Time.php';
11			//require_once 'Predict.php';
12			require_once 'Vector.php';
13			require_once 'ObsSet.php';
14
15			/*
16			* Unit SGP_Obs
17			* Author: Dr TS Kelso
18			* Original Version: 1992 Jun 02
19			* Current Revision: 1992 Sep 28
20			* Version: 1.40
21			* Copyright: 1992, All Rights Reserved
22			*
23			* Ported to C by: Neoklis Kyriazis April 9 2001
24			* Ported to PHP by Bill Shupp August, 2011
25			*/
26			class Predict_SGPObs
27			{
28			/* Procedure Calculate_User_PosVel passes the user's geodetic position */
29			/* and the time of interest and returns the ECI position and velocity */
30			/* of the observer. The velocity calculation assumes the geodetic */
31			/* position is stationary relative to the earth's surface. */
32			public static function Calculate_User_PosVel(
33			$_time, Predict_Geodetic $geodetic, Predict_Vector $obs_pos, Predict_Vector $obs_vel
34			)
35			{
36			/* Reference: The 1992 Astronomical Almanac, page K11. */
37
38			$sinGeodeticLat = sin($geodetic->lat); /* Only run sin($geodetic->lat) once */
39
40			$geodetic->theta = Predict_Math::FMod2p(Predict_Time::ThetaG_JD($_time) + $geodetic->lon);/LMST/
41			$c = 1 / sqrt(1 + Predict::__f * (Predict::__f - 2) * $sinGeodeticLat * $sinGeodeticLat);
42			$sq = (1 - Predict::__f) * (1 - Predict::__f) * $c;
43			$achcp = (Predict::xkmper * $c + $geodetic->alt) * cos($geodetic->lat);
44			$obs_pos->x = $achcp * cos($geodetic->theta); /kilometers/
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$x` was declared of type `integer`, but `$achcp * cos($geodetic->theta)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
45			$obs_pos->y = $achcp * sin($geodetic->theta);
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$y` was declared of type `integer`, but `$achcp * sin($geodetic->theta)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
46			$obs_pos->z = (Predict::xkmper * $sq + $geodetic->alt) * $sinGeodeticLat;
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$z` was declared of type `integer`, but `(\Predict::xkmper * $sq ...>alt) * $sinGeodeticLat` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
47			$obs_vel->x = -Predict::mfactor * $obs_pos->y; /kilometers/second/
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$x` was declared of type `integer`, but `-\Predict::mfactor * $obs_pos->y` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
48			$obs_vel->y = Predict::mfactor * $obs_pos->x;
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$y` was declared of type `integer`, but `\Predict::mfactor * $obs_pos->x` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
49			$obs_vel->z = 0;
50			$obs_pos->w = sqrt($obs_pos->x * $obs_pos->x + $obs_pos->y * $obs_pos->y + $obs_pos->z * $obs_pos->z);
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$w` was declared of type `integer`, but `sqrt($obs_pos->x * $obs_...s_pos->z * $obs_pos->z)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
51			$obs_vel->w = sqrt($obs_vel->x * $obs_vel->x + $obs_vel->y * $obs_vel->y + $obs_vel->z * $obs_vel->z);
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$w` was declared of type `integer`, but `sqrt($obs_vel->x * $obs_...s_vel->z * $obs_vel->z)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
52			}
53
54			/* Procedure Calculate_LatLonAlt will calculate the geodetic */
55			/* position of an object given its ECI position pos and time. */
56			/* It is intended to be used to determine the ground track of */
57			/* a satellite. The calculations assume the earth to be an */
58			/* oblate spheroid as defined in WGS '72. */
59			public static function Calculate_LatLonAlt($_time, Predict_Vector $pos, Predict_Geodetic $geodetic)
60			{
61			/* Reference: The 1992 Astronomical Almanac, page K12. */
62
63			/* double r,e2,phi,c; */
64
65			$geodetic->theta = Predict_Math::AcTan($pos->y, $pos->x); /radians/
66			$geodetic->lon = Predict_Math::FMod2p($geodetic->theta - Predict_Time::ThetaG_JD($_time)); /radians/
67			$r = sqrt(($pos->x * $pos->x) + ($pos->y * $pos->y));
68			$e2 = Predict::__f * (2 - Predict::__f);
69			$geodetic->lat = Predict_Math::AcTan($pos->z, $r); /radians/
70
71			do {
72			$phi = $geodetic->lat;
73			$sinPhi = sin($phi);
74			$c = 1 / sqrt(1 - $e2 * ($sinPhi * $sinPhi));
75			$geodetic->lat = Predict_Math::AcTan($pos->z + Predict::xkmper * $c * $e2 * $sinPhi, $r);
76			} while (abs($geodetic->lat - $phi) >= 1E-10);
77
78			$geodetic->alt = $r / cos($geodetic->lat) - Predict::xkmper * $c;/kilometers/
79
80			if ($geodetic->lat > Predict::pio2) {
81			$geodetic->lat -= Predict::twopi;
82			}
83			}
84
85			/* The procedures Calculate_Obs and Calculate_RADec calculate */
86			/* the topocentric coordinates of the object with ECI position, */
87			/* {pos}, and velocity, {vel}, from location {geodetic} at {time}. */
88			/* The {obs_set} returned for Calculate_Obs consists of azimuth, */
89			/* elevation, range, and range rate (in that order) with units of */
90			/* radians, radians, kilometers, and kilometers/second, respectively. */
91			/* The WGS '72 geoid is used and the effect of atmospheric refraction */
92			/* (under standard temperature and pressure) is incorporated into the */
93			/* elevation calculation; the effect of atmospheric refraction on */
94			/* range and range rate has not yet been quantified. */
95
96			/* The {obs_set} for Calculate_RADec consists of right ascension and */
97			/* declination (in that order) in radians. Again, calculations are */
98			/* based on topocentric position using the WGS '72 geoid and */
99			/* incorporating atmospheric refraction. */
100			public static function Calculate_Obs($_time, Predict_Vector $pos, Predict_Vector $vel, Predict_Geodetic $geodetic, Predict_ObsSet $obs_set)
101			{
102			$obs_pos = new Predict_Vector();
103			$obs_vel = new Predict_Vector();
104			$range = new Predict_Vector();
105			$rgvel = new Predict_Vector();
106
107			self::Calculate_User_PosVel($_time, $geodetic, $obs_pos, $obs_vel);
108
109			$range->x = $pos->x - $obs_pos->x;
110			$range->y = $pos->y - $obs_pos->y;
111			$range->z = $pos->z - $obs_pos->z;
112
113			$rgvel->x = $vel->x - $obs_vel->x;
114			$rgvel->y = $vel->y - $obs_vel->y;
115			$rgvel->z = $vel->z - $obs_vel->z;
116
117			$range->w = sqrt($range->x * $range->x + $range->y * $range->y + $range->z * $range->z);
			0 ignored issues – show Documentation Bug introduced 2016-10-03 13:20 UTC by Report Bug Copy Issue Report The property `$w` was declared of type `integer`, but `sqrt($range->x * $range-... $range->z * $range->z)` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
118
119			$sin_lat = sin($geodetic->lat);
120			$cos_lat = cos($geodetic->lat);
121			$sin_theta = sin($geodetic->theta);
122			$cos_theta = cos($geodetic->theta);
123			$top_s = $sin_lat * $cos_theta * $range->x
124			+ $sin_lat * $sin_theta * $range->y
125			- $cos_lat * $range->z;
126			$top_e = -$sin_theta * $range->x
127			+ $cos_theta * $range->y;
128			$top_z = $cos_lat * $cos_theta * $range->x
129			+ $cos_lat * $sin_theta * $range->y
130			+ $sin_lat * $range->z;
131			$azim = atan(-$top_e / $top_s); /Azimuth/
132			if ($top_s > 0) {
133			$azim = $azim + Predict::pi;
134			}
135			if ($azim < 0 ) {
136			$azim = $azim + Predict::twopi;
137			}
138			$el = Predict_Math::ArcSin($top_z / $range->w);
139			$obs_set->az = $azim; /* Azimuth (radians) */
140			$obs_set->el = $el; /* Elevation (radians)*/
141			$obs_set->range = $range->w; /* Range (kilometers) */
142
143			/* Range Rate (kilometers/second)*/
144			$obs_set->range_rate = Predict_Math::Dot($range, $rgvel) / $range->w;
145
146			/* Corrections for atmospheric refraction */
147			/* Reference: Astronomical Algorithms by Jean Meeus, pp. 101-104 */
148			/* Correction is meaningless when apparent elevation is below horizon */
149			// obs_set->el = obs_set->el + Radians((1.02/tan(Radians(Degrees(el)+
150			// 10.3/(Degrees(el)+5.11))))/60);
151			if ($obs_set->el < 0) {
152			$obs_set->el = $el; /Reset to true elevation/
153			}
154			}
155			}
156

Ysurac / FlightAirMap

Push — master ( d35909...f740b5 )

Predict_SGPObs::Calculate_Obs() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like