Inspection of "Add great circle route to arrival airport suggeste..." - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b40ad5...583e49 )

by Yannick

created 2017-10-02 11:17 UTC

Status

Braces +110 added lines, -48 removed lines patch added patch discarded remove patch

@@ -37,8 +37,11 @@  discard block
 block discarded – undo
 		} else {
 			curl_setopt($ch, CURLOPT_USERAGENT, $useragent);
 		}
-		if ($timeout == '') curl_setopt($ch, CURLOPT_TIMEOUT, 10); 
-		else curl_setopt($ch, CURLOPT_TIMEOUT, $timeout); 
+		if ($timeout == '') {
+			curl_setopt($ch, CURLOPT_TIMEOUT, 10);
+		} else {
+			curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
+		}
 		curl_setopt($ch, CURLOPT_HEADERFUNCTION, array('Common',"curlResponseHeaderCallback"));
 		if ($type == 'post') {
 			curl_setopt($ch, CURLOPT_CUSTOMREQUEST, "POST");
@@ -51,7 +54,9 @@  discard block
 block discarded – undo
 			} else {
 				curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
 			}
-		} elseif ($type != 'get' && $type != '') curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $type);
+		} elseif ($type != 'get' && $type != '') {
+			curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $type);
+		}
 		if ($headers != '') {
 			curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
 		}
@@ -95,8 +100,9 @@  discard block
 block discarded – undo
 	private function curlResponseHeaderCallback($ch, $headerLine) {
 		//global $cookies;
 		$cookies = array();
-		if (preg_match('/^Set-Cookie:\s*([^;]*)/mi', $headerLine, $cookie) == 1)
-			$cookies[] = $cookie;
+		if (preg_match('/^Set-Cookie:\s*([^;]*)/mi', $headerLine, $cookie) == 1) {
+					$cookies[] = $cookie;
+		}
 		return strlen($headerLine); // Needed by curl
 	}
 
@@ -107,7 +113,9 @@  discard block
 block discarded – undo
 		curl_setopt($ch, CURLOPT_URL, $url);
 		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
 		curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
-		if ($referer != '') curl_setopt($ch, CURLOPT_REFERER, $referer);
+		if ($referer != '') {
+			curl_setopt($ch, CURLOPT_REFERER, $referer);
+		}
 		if (isset($globalForceIPv4) && $globalForceIPv4) {
 			if (defined('CURLOPT_IPRESOLVE') && defined('CURL_IPRESOLVE_V4')){
 				curl_setopt($ch, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
@@ -119,7 +127,9 @@  discard block
 block discarded – undo
 		curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 GTB5');
 		curl_setopt($ch, CURLOPT_FILE, $fp);
 		curl_exec($ch);
-		if (curl_errno($ch) && $globalDebug) echo 'Download error: '.curl_error($ch);
+		if (curl_errno($ch) && $globalDebug) {
+			echo 'Download error: '.curl_error($ch);
+		}
 		curl_close($ch);
 		fclose($fp);
 	}
@@ -127,12 +137,16 @@  discard block
 block discarded – undo
 	public static function gunzip($in_file,$out_file_name = '') {
 		//echo $in_file.' -> '.$out_file_name."\n";
 		$buffer_size = 4096; // read 4kb at a time
-		if ($out_file_name == '') $out_file_name = str_replace('.gz', '', $in_file); 
+		if ($out_file_name == '') {
+			$out_file_name = str_replace('.gz', '', $in_file);
+		}
 		if ($in_file != '' && file_exists($in_file)) {
 			// PHP version of Ubuntu use gzopen64 instead of gzopen
-			if (function_exists('gzopen')) $file = gzopen($in_file,'rb');
-			elseif (function_exists('gzopen64')) $file = gzopen64($in_file,'rb');
-			else {
+			if (function_exists('gzopen')) {
+				$file = gzopen($in_file,'rb');
+			} elseif (function_exists('gzopen64')) {
+				$file = gzopen64($in_file,'rb');
+			} else {
 				echo 'gzopen not available';
 				die;
 			}
@@ -148,11 +162,14 @@  discard block
 block discarded – undo
 	public static function bunzip2($in_file,$out_file_name = '') {
 		//echo $in_file.' -> '.$out_file_name."\n";
 		$buffer_size = 4096; // read 4kb at a time
-		if ($out_file_name == '') $out_file_name = str_replace('.bz2', '', $in_file); 
+		if ($out_file_name == '') {
+			$out_file_name = str_replace('.bz2', '', $in_file);
+		}
 		if ($in_file != '' && file_exists($in_file)) {
 			// PHP version of Ubuntu use gzopen64 instead of gzopen
-			if (function_exists('bzopen')) $file = bzopen($in_file,'rb');
-			else {
+			if (function_exists('bzopen')) {
+				$file = bzopen($in_file,'rb');
+			} else {
 				echo 'bzopen not available';
 				die;
 			}
@@ -171,10 +188,16 @@  discard block
 block discarded – undo
 	* @return Array array of the tables in HTML page
 	*/
 	public function table2array($data) {
-		if (!is_string($data)) return array();
-		if ($data == '') return array();
+		if (!is_string($data)) {
+			return array();
+		}
+		if ($data == '') {
+			return array();
+		}
 		$html = str_get_html($data);
-		if ($html === false) return array();
+		if ($html === false) {
+			return array();
+		}
 		$tabledata=array();
 		foreach($html->find('tr') as $element)
 		{
@@ -209,7 +232,9 @@  discard block
 block discarded – undo
 	*/
 	public function text2array($data) {
 		$html = str_get_html($data);
-		if ($html === false) return array();
+		if ($html === false) {
+			return array();
+		}
 		$tabledata=array();
 		foreach($html->find('p') as $element)
 		{
@@ -230,7 +255,9 @@  discard block
 block discarded – undo
 	* @return Float Distance in $unit
 	*/
 	public function distance($lat, $lon, $latc, $lonc, $unit = 'km') {
-		if ($lat == $latc && $lon == $lonc) return 0;
+		if ($lat == $latc && $lon == $lonc) {
+			return 0;
+		}
 		$dist = rad2deg(acos(sin(deg2rad(floatval($lat)))*sin(deg2rad(floatval($latc)))+ cos(deg2rad(floatval($lat)))*cos(deg2rad(floatval($latc)))*cos(deg2rad(floatval($lon)-floatval($lonc)))))*60*1.1515;
 		if ($unit == "km") {
 			return round($dist * 1.609344);
@@ -269,7 +296,9 @@  discard block
 block discarded – undo
 		$dX = $latc - $lat;
 		$dY = $lonc - $lon;
 		$azimuth = rad2deg(atan2($dY,$dX));
-		if ($azimuth < 0) return $azimuth+360;
+		if ($azimuth < 0) {
+			return $azimuth+360;
+		}
 		return $azimuth;
 	}
 	
@@ -283,10 +312,16 @@  discard block
 block discarded – undo
 	public function withinThreshold ($timeDifference, $distance) {
 		$x = abs($timeDifference);
 		$d = abs($distance);
-		if ($x == 0 || $d == 0) return true;
+		if ($x == 0 || $d == 0) {
+			return true;
+		}
 		// may be due to Internet jitter; distance is realistic
-		if ($x < 0.7 && $d < 2000) return true;
-		else return $d/$x < 1500*0.27778; // 1500 km/h max
+		if ($x < 0.7 && $d < 2000) {
+			return true;
+		} else {
+			return $d/$x < 1500*0.27778;
+		}
+		// 1500 km/h max
 	}
 
 
@@ -314,11 +349,17 @@  discard block
 block discarded – undo
 	
 	public function convertDM($coord,$latlong) {
 		if ($latlong == 'latitude') {
-			if ($coord < 0) $NSEW = 'S';
-			else $NSEW = 'N';
+			if ($coord < 0) {
+				$NSEW = 'S';
+			} else {
+				$NSEW = 'N';
+			}
 		} else {
-			if ($coord < 0) $NSEW = 'W';
-			else $NSEW = 'E';
+			if ($coord < 0) {
+				$NSEW = 'W';
+			} else {
+				$NSEW = 'E';
+			}
 		}
 		$coord = abs($coord);
 		$deg = floor($coord);
@@ -361,7 +402,9 @@  discard block
 block discarded – undo
 	public function hex2str($hex) {
 		$str = '';
 		$hexln = strlen($hex);
-		for($i=0;$i<$hexln;$i+=2) $str .= chr(hexdec(substr($hex,$i,2)));
+		for($i=0;$i<$hexln;$i+=2) {
+			$str .= chr(hexdec(substr($hex,$i,2)));
+		}
 		return $str;
 	}
 	
@@ -398,8 +441,11 @@  discard block
 block discarded – undo
 		$b = $lat2 - $lat1;
 		$c = -($a*$lat1+$b*$lon1);
 		$d = $a*$lat3+$b*$lon3+$c;
-		if ($d > -$approx && $d < $approx) return true;
-		else return false;
+		if ($d > -$approx && $d < $approx) {
+			return true;
+		} else {
+			return false;
+		}
 	}
 	
 	public function array_merge_noappend() {
@@ -458,7 +504,9 @@  discard block
 block discarded – undo
 			return $result;
 		}
 		$handle = @opendir('./locale');
-		if ($handle === false) return $result;
+		if ($handle === false) {
+			return $result;
+		}
 		while (false !== ($file = readdir($handle))) {
 			$path = './locale'.'/'.$file.'/LC_MESSAGES/fam.mo';
 			if ($file != "." && $file != ".." && @file_exists($path)) {
@@ -529,8 +577,9 @@  discard block
 block discarded – undo
 		$error = false; 
 		if ($fp_out = gzopen($dest, $mode)) { 
 			if ($fp_in = fopen($source,'rb')) { 
-				while (!feof($fp_in)) 
-					gzwrite($fp_out, fread($fp_in, 1024 * 512)); 
+				while (!feof($fp_in)) {
+									gzwrite($fp_out, fread($fp_in, 1024 * 512));
+				}
 				fclose($fp_in); 
 			} else {
 				$error = true; 
@@ -539,14 +588,17 @@  discard block
 block discarded – undo
 		} else {
 			$error = true; 
 		}
-		if ($error)
-			return false; 
-		else
-			return $dest; 
+		if ($error) {
+					return false;
+		} else {
+					return $dest;
+		}
 	} 
 	
 	public function remove_accents($string) {
-		if ( !preg_match('/[\x80-\xff]/', $string) ) return $string;
+		if ( !preg_match('/[\x80-\xff]/', $string) ) {
+			return $string;
+		}
 		$chars = array(
 		    // Decompositions for Latin-1 Supplement
 		    chr(195).chr(128) => 'A', chr(195).chr(129) => 'A',
@@ -670,7 +722,9 @@  discard block
 block discarded – undo
 		$ip = gethostbyname($host);
 		$s = socket_create(AF_INET, SOCK_STREAM, 0);
 		$r = @socket_connect($s, $ip, $port);
-		if (!socket_set_nonblock($s)) echo "Unable to set nonblock on socket\n";
+		if (!socket_set_nonblock($s)) {
+			echo "Unable to set nonblock on socket\n";
+		}
 		if ($r || socket_last_error() == 114 || socket_last_error() == 115) {
 			return $s;
 		}
@@ -715,18 +769,22 @@  discard block
 block discarded – undo
 		//NOTE: use a trailing slash for folders!!!
 		//see http://bugs.php.net/bug.php?id=27609
 		//see http://bugs.php.net/bug.php?id=30931
-		if ($path{strlen($path)-1}=='/') // recursively return a temporary file path
+		if ($path{strlen($path)-1}=='/') {
+			// recursively return a temporary file path
 			return $this->is__writable($path.uniqid(mt_rand()).'.tmp');
-		else if (is_dir($path))
-			return $this->is__writable($path.'/'.uniqid(mt_rand()).'.tmp');
+		} else if (is_dir($path)) {
+					return $this->is__writable($path.'/'.uniqid(mt_rand()).'.tmp');
+		}
 		// check tmp file for read/write capabilities
 		$rm = file_exists($path);
 		$f = @fopen($path, 'a');
-		if ($f===false)
-			return false;
+		if ($f===false) {
+					return false;
+		}
 		fclose($f);
-		if (!$rm)
-			unlink($path);
+		if (!$rm) {
+					unlink($path);
+		}
 		return true;
 	}
 	
@@ -742,7 +800,9 @@  discard block
 block discarded – undo
 	 * @return Array Coordinate of the route
 	*/
 	public function greatcircle($begin_lat,$begin_lon,$end_lat,$end_lon,$nbpts = 20, $offset = 10) {
-		if ($nbpts <= 2) return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
+		if ($nbpts <= 2) {
+			return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
+		}
 		$sx = deg2rad($begin_lon);
 		$sy = deg2rad($begin_lat);
 		$ex = deg2rad($end_lon);
@@ -751,7 +811,9 @@  discard block
 block discarded – undo
 		$h = $sy - $ey;
 		$z = pow(sin($h/2.0),2) + cos($sy)*cos($ey)*pow(sin($w/2.0),2);
 		$g = 2.0*asin(sqrt($z));
-		if ($g == pi() || is_nan($g)) return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
+		if ($g == pi() || is_nan($g)) {
+			return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
+		}
 		$first_pass = array();
 		$delta = 1.0/($nbpts-1);
 		for ($i =0; $i < $nbpts; ++$i) {

Please login to merge, or discard this patch.

live-geojson.php 1 patch

Braces +321 added lines, -130 removed lines patch added patch discarded remove patch

@@ -12,7 +12,9 @@  discard block
 block discarded – undo
 $tracker = false;
 $marine = false;
 $usecoord = false;
-if (isset($_GET['test'])) exit();
+if (isset($_GET['test'])) {
+	exit();
+}
 if (isset($_GET['tracker'])) {
     $tracker = true;
 }
@@ -57,28 +59,55 @@  discard block
 block discarded – undo
 }
 header('Content-Type: text/javascript');
 
-if (!isset($globalJsonCompress)) $compress = true;
-else $compress = $globalJsonCompress;
+if (!isset($globalJsonCompress)) {
+	$compress = true;
+} else {
+	$compress = $globalJsonCompress;
+}
 
 $from_archive = false;
 $min = true;
 $allhistory = false;
 $filter['source'] = array();
-if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalVATSIM) && $globalVATSIM && isset($_COOKIE['filter_ShowVATSIM']) && $_COOKIE['filter_ShowVATSIM'] == 'true') $filter['source'] = array_merge($filter['source'],array('vatsimtxt'));
-if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalIVAO) && $globalIVAO && isset($_COOKIE['filter_ShowIVAO']) && $_COOKIE['filter_ShowIVAO'] == 'true') $filter['source'] = array_merge($filter['source'],array('whazzup'));
-if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalphpVMS) && $globalphpVMS && isset($_COOKIE['filter_ShowVMS']) && $_COOKIE['filter_ShowVMS'] == 'true') $filter['source'] = array_merge($filter['source'],array('phpvmacars'));
-if ((!isset($globalMapchoose) || $globalMapchoose) && isset($globalSBS1) && $globalSBS1 && isset($_COOKIE['filter_ShowSBS1']) && $_COOKIE['filter_ShowSBS1'] == 'true') $filter['source'] = array_merge($filter['source'],array('sbs','famaprs'));
-if ((!isset($globalMapchoose) || $globalMapchoose) && isset($globalAPRS) && $globalAPRS && isset($_COOKIE['filter_ShowAPRS']) && $_COOKIE['filter_ShowAPRS'] == 'true') $filter['source'] = array_merge($filter['source'],array('aprs'));
-if (isset($_COOKIE['filter_ident']) && $_COOKIE['filter_ident'] != '') $filter['ident'] = filter_var($_COOKIE['filter_ident'],FILTER_SANITIZE_STRING);
-if (isset($_COOKIE['filter_mmsi']) && $_COOKIE['filter_mmsi'] != '') $filter['mmsi'] = filter_var($_COOKIE['filter_mmsi'],FILTER_SANITIZE_STRING);
-if (isset($_COOKIE['filter_Airlines']) && $_COOKIE['filter_Airlines'] != '') $filter['airlines'] = filter_var_array(explode(',',$_COOKIE['filter_Airlines']),FILTER_SANITIZE_STRING);
-if (isset($_COOKIE['filter_Sources']) && $_COOKIE['filter_Sources'] != '') $filter['source_aprs'] = filter_var_array(explode(',',$_COOKIE['filter_Sources']),FILTER_SANITIZE_STRING);
-if (isset($_COOKIE['filter_airlinestype']) && $_COOKIE['filter_airlinestype'] != 'all') $filter['airlinestype'] = filter_var($_COOKIE['filter_airlinestype'],FILTER_SANITIZE_STRING);
-if (isset($_COOKIE['filter_alliance']) && $_COOKIE['filter_alliance'] != 'all') $filter['alliance'] = filter_var($_COOKIE['filter_alliance'],FILTER_SANITIZE_STRING);
+if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalVATSIM) && $globalVATSIM && isset($_COOKIE['filter_ShowVATSIM']) && $_COOKIE['filter_ShowVATSIM'] == 'true') {
+	$filter['source'] = array_merge($filter['source'],array('vatsimtxt'));
+}
+if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalIVAO) && $globalIVAO && isset($_COOKIE['filter_ShowIVAO']) && $_COOKIE['filter_ShowIVAO'] == 'true') {
+	$filter['source'] = array_merge($filter['source'],array('whazzup'));
+}
+if ((!isset($globalMapVAchoose) || $globalMapVAchoose) && isset($globalphpVMS) && $globalphpVMS && isset($_COOKIE['filter_ShowVMS']) && $_COOKIE['filter_ShowVMS'] == 'true') {
+	$filter['source'] = array_merge($filter['source'],array('phpvmacars'));
+}
+if ((!isset($globalMapchoose) || $globalMapchoose) && isset($globalSBS1) && $globalSBS1 && isset($_COOKIE['filter_ShowSBS1']) && $_COOKIE['filter_ShowSBS1'] == 'true') {
+	$filter['source'] = array_merge($filter['source'],array('sbs','famaprs'));
+}
+if ((!isset($globalMapchoose) || $globalMapchoose) && isset($globalAPRS) && $globalAPRS && isset($_COOKIE['filter_ShowAPRS']) && $_COOKIE['filter_ShowAPRS'] == 'true') {
+	$filter['source'] = array_merge($filter['source'],array('aprs'));
+}
+if (isset($_COOKIE['filter_ident']) && $_COOKIE['filter_ident'] != '') {
+	$filter['ident'] = filter_var($_COOKIE['filter_ident'],FILTER_SANITIZE_STRING);
+}
+if (isset($_COOKIE['filter_mmsi']) && $_COOKIE['filter_mmsi'] != '') {
+	$filter['mmsi'] = filter_var($_COOKIE['filter_mmsi'],FILTER_SANITIZE_STRING);
+}
+if (isset($_COOKIE['filter_Airlines']) && $_COOKIE['filter_Airlines'] != '') {
+	$filter['airlines'] = filter_var_array(explode(',',$_COOKIE['filter_Airlines']),FILTER_SANITIZE_STRING);
+}
+if (isset($_COOKIE['filter_Sources']) && $_COOKIE['filter_Sources'] != '') {
+	$filter['source_aprs'] = filter_var_array(explode(',',$_COOKIE['filter_Sources']),FILTER_SANITIZE_STRING);
+}
+if (isset($_COOKIE['filter_airlinestype']) && $_COOKIE['filter_airlinestype'] != 'all') {
+	$filter['airlinestype'] = filter_var($_COOKIE['filter_airlinestype'],FILTER_SANITIZE_STRING);
+}
+if (isset($_COOKIE['filter_alliance']) && $_COOKIE['filter_alliance'] != 'all') {
+	$filter['alliance'] = filter_var($_COOKIE['filter_alliance'],FILTER_SANITIZE_STRING);
+}
 
 if (isset($globalMapPopup) && !$globalMapPopup && !(isset($_COOKIE['flightpopup']) && $_COOKIE['flightpopup'] == 'true')) {
 	$min = true;
-} else $min = false;
+} else {
+	$min = false;
+}
 
 $spotter_array = array();
 
@@ -189,24 +218,38 @@  discard block
 block discarded – undo
 			$flightcnt = $SpotterLive->getLiveSpotterCount($filter);
 		}
 	}
-	if ($flightcnt == '') $flightcnt = 0;
-} else $flightcnt = 0;
+	if ($flightcnt == '') {
+		$flightcnt = 0;
+	}
+	} else {
+	$flightcnt = 0;
+}
 
 $sqltime = round(microtime(true)-$begintime,2);
 
 $currenttime = filter_input(INPUT_GET,'currenttime',FILTER_SANITIZE_NUMBER_INT);
-if ($currenttime != '') $currenttime = round($currenttime/1000);
+if ($currenttime != '') {
+	$currenttime = round($currenttime/1000);
+}
 
-if ((!isset($_COOKIE['flightestimation']) && isset($globalMapEstimation) && $globalMapEstimation == FALSE) || (isset($_COOKIE['flightestimation']) && $_COOKIE['flightestimation'] == 'false')) $usenextlatlon = false;
-else $usenextlatlon = true;
-if ($usenextlatlon === false) $currenttime = '';
+if ((!isset($_COOKIE['flightestimation']) && isset($globalMapEstimation) && $globalMapEstimation == FALSE) || (isset($_COOKIE['flightestimation']) && $_COOKIE['flightestimation'] == 'false')) {
+	$usenextlatlon = false;
+} else {
+	$usenextlatlon = true;
+}
+if ($usenextlatlon === false) {
+	$currenttime = '';
+}
 $j = 0;
 $prev_flightaware_id = '';
 $aircrafts_shadow = array();
 $output = '{';
 	$output .= '"type": "FeatureCollection",';
-		if ($min) $output .= '"minimal": "true",';
-		else $output .= '"minimal": "false",';
+		if ($min) {
+			$output .= '"minimal": "true",';
+		} else {
+			$output .= '"minimal": "false",';
+		}
 		//$output .= '"fc": "'.$flightcnt.'",';
 		$output .= '"sqt": "'.$sqltime.'",';
 
@@ -251,18 +294,29 @@  discard block
 block discarded – undo
 						}
 						$output .= '"properties": {';
 						if (isset($spotter_item['flightaware_id'])) {
-							if ($compress) $output .= '"fi": "'.$spotter_item['flightaware_id'].'",';
-							else $output .= '"flightaware_id": "'.$spotter_item['flightaware_id'].'",';
+							if ($compress) {
+								$output .= '"fi": "'.$spotter_item['flightaware_id'].'",';
+							} else {
+								$output .= '"flightaware_id": "'.$spotter_item['flightaware_id'].'",';
+							}
 						} elseif (isset($spotter_item['famtrackid'])) {
-							if ($compress) $output .= '"fti": "'.$spotter_item['famtrackid'].'",';
-							else $output .= '"famtrackid": "'.$spotter_item['famtrackid'].'",';
+							if ($compress) {
+								$output .= '"fti": "'.$spotter_item['famtrackid'].'",';
+							} else {
+								$output .= '"famtrackid": "'.$spotter_item['famtrackid'].'",';
+							}
 						} elseif (isset($spotter_item['fammarine_id'])) {
-							if ($compress) $output .= '"fmi": "'.$spotter_item['fammarine_id'].'",';
-							else $output .= '"fammarineid": "'.$spotter_item['fammarine_id'].'",';
+							if ($compress) {
+								$output .= '"fmi": "'.$spotter_item['fammarine_id'].'",';
+							} else {
+								$output .= '"fammarineid": "'.$spotter_item['fammarine_id'].'",';
+							}
 						}
 							$output .= '"fc": "'.$flightcnt.'",';
 							$output .= '"sqt": "'.$sqltime.'",';
-							if (isset($begindate)) $output .= '"archive_date": "'.$begindate.'",';
+							if (isset($begindate)) {
+								$output .= '"archive_date": "'.$begindate.'",';
+							}
 
 /*
 							if ($min) $output .= '"minimal": "true",';
@@ -270,14 +324,22 @@  discard block
 block discarded – undo
 */
 							//$output .= '"fc": "'.$spotter_item['nb'].'",';
 						if (isset($spotter_item['ident']) && $spotter_item['ident'] != '') {
-							if ($compress) $output .= '"c": "'.str_replace('\\','',$spotter_item['ident']).'",';
-							else $output .= '"callsign": "'.str_replace('\\','',$spotter_item['ident']).'",';
+							if ($compress) {
+								$output .= '"c": "'.str_replace('\\','',$spotter_item['ident']).'",';
+							} else {
+								$output .= '"callsign": "'.str_replace('\\','',$spotter_item['ident']).'",';
+							}
 							//"
 						} else {
-							if ($compress) $output .= '"c": "NA",';
-							else $output .= '"callsign": "NA",';
+							if ($compress) {
+								$output .= '"c": "NA",';
+							} else {
+								$output .= '"callsign": "NA",';
+							}
+						}
+						if (isset($spotter_item['registration'])) {
+							$output .= '"registration": "'.$spotter_item['registration'].'",';
 						}
-						if (isset($spotter_item['registration'])) $output .= '"registration": "'.$spotter_item['registration'].'",';
 						if (isset($spotter_item['aircraft_name']) && isset($spotter_item['aircraft_type'])) {
 							$output .= '"aircraft_name": "'.$spotter_item['aircraft_name'].' ('.$spotter_item['aircraft_type'].')",';
 							$output .= '"aircraft_wiki": "http://'.strtolower($globalLanguage).'.wikipedia.org/wiki/'.urlencode(str_replace(' ','_',$spotter_item['aircraft_name'])).'",';
@@ -290,16 +352,23 @@  discard block
 block discarded – undo
 							$output .= '"aircraft_icao": "'.$spotter_item['aircraft_icao'].'",';
 						}
 						if (!isset($spotter_item['aircraft_shadow']) && !$tracker) {
-							if (!isset($spotter_item['aircraft_icao']) || $spotter_item['aircraft_icao'] == '') $spotter_item['aircraft_shadow'] = '';
-							else {
+							if (!isset($spotter_item['aircraft_icao']) || $spotter_item['aircraft_icao'] == '') {
+								$spotter_item['aircraft_shadow'] = '';
+							} else {
 								$aircraft_icao = $spotter_item['aircraft_icao'];
-								if (isset($aircrafts_shadow[$aircraft_icao])) $spotter_item['aircraft_shadow'] = $aircrafts_shadow[$aircraft_icao];
-								else {
+								if (isset($aircrafts_shadow[$aircraft_icao])) {
+									$spotter_item['aircraft_shadow'] = $aircrafts_shadow[$aircraft_icao];
+								} else {
 									$aircraft_info = $Spotter->getAllAircraftInfo($spotter_item['aircraft_icao']);
-									if (count($aircraft_info) > 0) $spotter_item['aircraft_shadow'] = $aircraft_info[0]['aircraft_shadow'];
-									elseif (isset($spotter_item['format_source']) && $spotter_item['format_source'] == 'aprs') $spotter_item['aircraft_shadow'] = 'PA18.png';
-									elseif ($aircraft_icao == 'PARAGLIDER') $spotter_item['aircraft_shadow'] = 'PARAGLIDER.png';
-									else $spotter_item['aircraft_shadow'] = '';
+									if (count($aircraft_info) > 0) {
+										$spotter_item['aircraft_shadow'] = $aircraft_info[0]['aircraft_shadow'];
+									} elseif (isset($spotter_item['format_source']) && $spotter_item['format_source'] == 'aprs') {
+										$spotter_item['aircraft_shadow'] = 'PA18.png';
+									} elseif ($aircraft_icao == 'PARAGLIDER') {
+										$spotter_item['aircraft_shadow'] = 'PARAGLIDER.png';
+									} else {
+										$spotter_item['aircraft_shadow'] = '';
+									}
 									$aircrafts_shadow[$aircraft_icao] = $spotter_item['aircraft_shadow'];
 								}
 							}
@@ -307,73 +376,139 @@  discard block
 block discarded – undo
 						if (!isset($spotter_item['aircraft_shadow']) || $spotter_item['aircraft_shadow'] == '') {
 							if ($tracker) {
 								if (isset($spotter_item['type']) && $spotter_item['type'] == 'Ambulance') {
-									if ($compress) $output .= '"as": "ambulance.png",';
-									else $output .= '"aircraft_shadow": "ambulance.png",';
+									if ($compress) {
+										$output .= '"as": "ambulance.png",';
+									} else {
+										$output .= '"aircraft_shadow": "ambulance.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Police') {
-									if ($compress) $output .= '"as": "police.png",';
-									else $output .= '"aircraft_shadow": "police.png",';
+									if ($compress) {
+										$output .= '"as": "police.png",';
+									} else {
+										$output .= '"aircraft_shadow": "police.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Yacht (Sail)') {
-									if ($compress) $output .= '"as": "ship.png",';
-									else $output .= '"aircraft_shadow": "ship.png",';
+									if ($compress) {
+										$output .= '"as": "ship.png",';
+									} else {
+										$output .= '"aircraft_shadow": "ship.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Ship (Power Boat)') {
-									if ($compress) $output .= '"as": "ship.png",';
-									else $output .= '"aircraft_shadow": "ship.png",';
+									if ($compress) {
+										$output .= '"as": "ship.png",';
+									} else {
+										$output .= '"aircraft_shadow": "ship.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Shuttle') {
-									if ($compress) $output .= '"as": "ship.png",';
-									else $output .= '"aircraft_shadow": "ship.png",';
+									if ($compress) {
+										$output .= '"as": "ship.png",';
+									} else {
+										$output .= '"aircraft_shadow": "ship.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Truck') {
-									if ($compress) $output .= '"as": "truck.png",';
-									else $output .= '"aircraft_shadow": "truck.png",';
+									if ($compress) {
+										$output .= '"as": "truck.png",';
+									} else {
+										$output .= '"aircraft_shadow": "truck.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Truck (18 Wheeler)') {
-									if ($compress) $output .= '"as": "truck.png",';
-									else $output .= '"aircraft_shadow": "truck.png",';
+									if ($compress) {
+										$output .= '"as": "truck.png",';
+									} else {
+										$output .= '"aircraft_shadow": "truck.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Aircraft (small)') {
-									if ($compress) $output .= '"as": "aircraft.png",';
-									else $output .= '"aircraft_shadow": "aircraft.png",';
+									if ($compress) {
+										$output .= '"as": "aircraft.png",';
+									} else {
+										$output .= '"aircraft_shadow": "aircraft.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Large Aircraft') {
-									if ($compress) $output .= '"as": "aircraft.png",';
-									else $output .= '"aircraft_shadow": "aircraft.png",';
+									if ($compress) {
+										$output .= '"as": "aircraft.png",';
+									} else {
+										$output .= '"aircraft_shadow": "aircraft.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Helicopter') {
-									if ($compress) $output .= '"as": "helico.png",';
-									else $output .= '"aircraft_shadow": "helico.png",';
+									if ($compress) {
+										$output .= '"as": "helico.png",';
+									} else {
+										$output .= '"aircraft_shadow": "helico.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Railroad Engine') {
-									if ($compress) $output .= '"as": "rail.png",';
-									else $output .= '"aircraft_shadow": "rail.png",';
+									if ($compress) {
+										$output .= '"as": "rail.png",';
+									} else {
+										$output .= '"aircraft_shadow": "rail.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Firetruck') {
-									if ($compress) $output .= '"as": "firetruck.png",';
-									else $output .= '"aircraft_shadow": "firetruck.png",';
+									if ($compress) {
+										$output .= '"as": "firetruck.png",';
+									} else {
+										$output .= '"aircraft_shadow": "firetruck.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Bus') {
-									if ($compress) $output .= '"as": "bus.png",';
-									else $output .= '"aircraft_shadow": "bus.png",';
+									if ($compress) {
+										$output .= '"as": "bus.png",';
+									} else {
+										$output .= '"aircraft_shadow": "bus.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Phone') {
-									if ($compress) $output .= '"as": "phone.png",';
-									else $output .= '"aircraft_shadow": "phone.png",';
+									if ($compress) {
+										$output .= '"as": "phone.png",';
+									} else {
+										$output .= '"aircraft_shadow": "phone.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Jogger') {
-									if ($compress) $output .= '"as": "jogger.png",';
-									else $output .= '"aircraft_shadow": "jogger.png",';
+									if ($compress) {
+										$output .= '"as": "jogger.png",';
+									} else {
+										$output .= '"aircraft_shadow": "jogger.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Bike') {
-									if ($compress) $output .= '"as": "bike.png",';
-									else $output .= '"aircraft_shadow": "bike.png",';
+									if ($compress) {
+										$output .= '"as": "bike.png",';
+									} else {
+										$output .= '"aircraft_shadow": "bike.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Motorcycle') {
-									if ($compress) $output .= '"as": "motorcycle.png",';
-									else $output .= '"aircraft_shadow": "motorcycle.png",';
+									if ($compress) {
+										$output .= '"as": "motorcycle.png",';
+									} else {
+										$output .= '"aircraft_shadow": "motorcycle.png",';
+									}
 								} elseif (isset($spotter_item['type']) && $spotter_item['type'] == 'Balloon') {
-									if ($compress) $output .= '"as": "balloon.png",';
-									else $output .= '"aircraft_shadow": "balloon.png",';
+									if ($compress) {
+										$output .= '"as": "balloon.png",';
+									} else {
+										$output .= '"aircraft_shadow": "balloon.png",';
+									}
 								} else {
-									if ($compress) $output .= '"as": "car.png",';
-									else $output .= '"aircraft_shadow": "car.png",';
+									if ($compress) {
+										$output .= '"as": "car.png",';
+									} else {
+										$output .= '"aircraft_shadow": "car.png",';
+									}
 								}
 							} elseif ($marine) {
-								if ($compress) $output .= '"as": "ship.png",';
-								else $output .= '"aircraft_shadow": "ship.png",';
+								if ($compress) {
+									$output .= '"as": "ship.png",';
+								} else {
+									$output .= '"aircraft_shadow": "ship.png",';
+								}
 							} else {
-								if ($compress) $output .= '"as": "default.png",';
-								else $output .= '"aircraft_shadow": "default.png",';
+								if ($compress) {
+									$output .= '"as": "default.png",';
+								} else {
+									$output .= '"aircraft_shadow": "default.png",';
+								}
 							}
 						} else {
-							if ($compress) $output .= '"as": "'.$spotter_item['aircraft_shadow'].'",';
-							else $output .= '"aircraft_shadow": "'.$spotter_item['aircraft_shadow'].'",';
+							if ($compress) {
+								$output .= '"as": "'.$spotter_item['aircraft_shadow'].'",';
+							} else {
+								$output .= '"aircraft_shadow": "'.$spotter_item['aircraft_shadow'].'",';
+							}
 						}
 						if (isset($spotter_item['airline_name'])) {
 							$output .= '"airline_name": "'.$spotter_item['airline_name'].'",';
@@ -381,8 +516,11 @@  discard block
 block discarded – undo
 							$output .= '"airline_name": "NA",';
 						}
 						if (isset($spotter_item['departure_airport'])) {
-							if ($compress) $output .= '"dac": "'.$spotter_item['departure_airport'].'",';
-							else $output .= '"departure_airport_code": "'.$spotter_item['departure_airport'].'",';
+							if ($compress) {
+								$output .= '"dac": "'.$spotter_item['departure_airport'].'",';
+							} else {
+								$output .= '"departure_airport_code": "'.$spotter_item['departure_airport'].'",';
+							}
 						}
 						if (isset($spotter_item['departure_airport_city'])) {
 							$output .= '"departure_airport": "'.$spotter_item['departure_airport_city'].', '.$spotter_item['departure_airport_country'].'",';
@@ -394,8 +532,11 @@  discard block
 block discarded – undo
 							$output .= '"arrival_airport_time": "'.$spotter_item['arrival_airport_time'].'",';
 						}
 						if (isset($spotter_item['arrival_airport'])) {
-							if ($compress) $output .= '"aac": "'.$spotter_item['arrival_airport'].'",';
-							else $output .= '"arrival_airport_code": "'.$spotter_item['arrival_airport'].'",';
+							if ($compress) {
+								$output .= '"aac": "'.$spotter_item['arrival_airport'].'",';
+							} else {
+								$output .= '"arrival_airport_code": "'.$spotter_item['arrival_airport'].'",';
+							}
 						}
 						if (isset($spotter_item['arrival_airport_city'])) {
 							$output .= '"arrival_airport": "'.$spotter_item['arrival_airport_city'].', '.$spotter_item['arrival_airport_country'].'",';
@@ -414,8 +555,11 @@  discard block
 block discarded – undo
 						}
 						
 						if (isset($spotter_item['altitude'])) {
-							if ($compress) $output .= '"a": "'.$spotter_item['altitude'].'",';
-							else $output .= '"altitude": "'.$spotter_item['altitude'].'",';
+							if ($compress) {
+								$output .= '"a": "'.$spotter_item['altitude'].'",';
+							} else {
+								$output .= '"altitude": "'.$spotter_item['altitude'].'",';
+							}
 						}
 						
 						$heading = $spotter_item['heading'];
@@ -439,19 +583,24 @@  discard block
 block discarded – undo
 							}
 						}
 						
-						if ($compress)$output .= '"h": "'.$heading.'",';
-						else $output .= '"heading": "'.$heading.'",';
+						if ($compress) {
+							$output .= '"h": "'.$heading.'",';
+						} else {
+							$output .= '"heading": "'.$heading.'",';
+						}
 						if ($currenttime != '') {
 							if (strtotime($spotter_item['date']) < $currenttime) {
 								if (isset($archivespeed)) {
 									$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$heading,$archivespeed,($currenttime-strtotime($spotter_item['date'])+$globalMapRefresh));
 									$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-									if (!isset($idistance) || $fdistance < $idistance) $output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
-									else {
+									if (!isset($idistance) || $fdistance < $idistance) {
+										$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
+									} else {
 										$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$cheading,$archivespeed,($currenttime-strtotime($spotter_item['date'])+$globalMapRefresh));
 										$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-										if (!isset($idistance) || $fdistance < $idistance) $output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
-										else {
+										if (!isset($idistance) || $fdistance < $idistance) {
+											$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
+										} else {
 											$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$heading,$archivespeed);
 											$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
 										}
@@ -459,12 +608,14 @@  discard block
 block discarded – undo
 								} elseif ($usenextlatlon) {
 									$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$heading,1,($currenttime-strtotime($spotter_item['date'])+$globalMapRefresh));
 									$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-									if (!isset($idistance) || $fdistance < $idistance) $output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
-									else {
+									if (!isset($idistance) || $fdistance < $idistance) {
+										$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
+									} else {
 										$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$cheading,1,($currenttime-strtotime($spotter_item['date'])+$globalMapRefresh));
 										$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-										if (!isset($idistance) || $fdistance < $idistance) $output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
-										else {
+										if (!isset($idistance) || $fdistance < $idistance) {
+											$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
+										} else {
 											$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$heading);
 											$output .= '"nextlatlon": ['.$nextcoord['latitude'].','.$nextcoord['longitude'].'],';
 										}
@@ -503,7 +654,9 @@  discard block
 block discarded – undo
 							}
 						}
 
-						if (!$min) $output .= '"image": "'.$image.'",';
+						if (!$min) {
+							$output .= '"image": "'.$image.'",';
+						}
 						if (isset($spotter_item['image_copyright']) && $spotter_item['image_copyright'] != '') {
 							$output .= '"image_copyright": "'.str_replace('"',"'",trim(str_replace(array("\r\n","\r","\n","\\r","\\n","\\r\\n"),'',$spotter_item['image_copyright']))).'",';
 						}
@@ -511,8 +664,11 @@  discard block
 block discarded – undo
 							$output .= '"image_source_website": "'.urlencode($spotter_item['image_source_website']).'",';
 						}
 						if (isset($spotter_item['squawk'])) {
-							if ($compress) $output .= '"sq": "'.$spotter_item['squawk'].'",';
-							else $output .= '"squawk": "'.$spotter_item['squawk'].'",';
+							if ($compress) {
+								$output .= '"sq": "'.$spotter_item['squawk'].'",';
+							} else {
+								$output .= '"squawk": "'.$spotter_item['squawk'].'",';
+							}
 						}
 						if (isset($spotter_item['squawk_usage'])) {
 							$output .= '"squawk_usage": "'.$spotter_item['squawk_usage'].'",';
@@ -531,14 +687,23 @@  discard block
 block discarded – undo
 						}
 						// type when not aircraft ?
 						if (isset($spotter_item['type'])) {
-							if ($compress) $output .= '"t": "'.$spotter_item['type'].'"';
-							else $output .= '"type": "'.$spotter_item['type'].'"';
+							if ($compress) {
+								$output .= '"t": "'.$spotter_item['type'].'"';
+							} else {
+								$output .= '"type": "'.$spotter_item['type'].'"';
+							}
 						} elseif ($marine) {
-							if ($compress) $output .= '"t": "ship"';
-							else $output .= '"type": "ship"';
+							if ($compress) {
+								$output .= '"t": "ship"';
+							} else {
+								$output .= '"type": "ship"';
+							}
 						} else {
-							if ($compress) $output .= '"t": "aircraft"';
-							else $output .= '"type": "aircraft"';
+							if ($compress) {
+								$output .= '"t": "aircraft"';
+							} else {
+								$output .= '"type": "aircraft"';
+							}
 						}
 						$output .= '},';
 						$output .= '"geometry": {';
@@ -546,15 +711,19 @@  discard block
 block discarded – undo
 								$output .= '"coordinates": [';
 								if ($currenttime != '') {
 									if (strtotime($spotter_item['date']) < $currenttime) {
-										if (!isset($archivespeed)) $archivespeed = 1;
+										if (!isset($archivespeed)) {
+											$archivespeed = 1;
+										}
 										$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$heading,$archivespeed,($currenttime-strtotime($spotter_item['date'])));
 										$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-										if (!isset($idistance) || $fdistance < $idistance) $output .= $nextcoord['longitude'].','.$nextcoord['latitude'];
-										else {
+										if (!isset($idistance) || $fdistance < $idistance) {
+											$output .= $nextcoord['longitude'].','.$nextcoord['latitude'];
+										} else {
 											$nextcoord = $Common->nextcoord($spotter_item['latitude'],$spotter_item['longitude'],$spotter_item['ground_speed'],$cheading,$archivespeed,($currenttime-strtotime($spotter_item['date'])));
 											$fdistance = $Common->distance($spotter_item['latitude'],$spotter_item['longitude'],$nextcoord['latitude'],$nextcoord['longitude']);
-											if (!isset($idistance) || $fdistance < $idistance) $output .= $nextcoord['longitude'].','.$nextcoord['latitude'];
-											else {
+											if (!isset($idistance) || $fdistance < $idistance) {
+												$output .= $nextcoord['longitude'].','.$nextcoord['latitude'];
+											} else {
 												$output .= $spotter_item['longitude'].', ';
 												$output .= $spotter_item['latitude'];
 											}
@@ -632,7 +801,9 @@  discard block
 block discarded – undo
 			}
 */
 				$history = filter_input(INPUT_GET,'history',FILTER_SANITIZE_STRING);
-				if ($history == '' && isset($_COOKIE['history'])) $history = $_COOKIE['history'];
+				if ($history == '' && isset($_COOKIE['history'])) {
+					$history = $_COOKIE['history'];
+				}
 				
 				if (
 				    (isset($_COOKIE['flightpath']) && $_COOKIE['flightpath'] == 'true') 
@@ -702,8 +873,11 @@  discard block
 block discarded – undo
 									$output_history .= ']}},';
 									$output .= $output_history;
 								}
-								if ($compress) $output_history = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "history","a": "'.$alt.'"},"geometry": {"type": "LineString","coordinates": [';
-								else $output_history = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "history","altitude": "'.$alt.'"},"geometry": {"type": "LineString","coordinates": [';
+								if ($compress) {
+									$output_history = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "history","a": "'.$alt.'"},"geometry": {"type": "LineString","coordinates": [';
+								} else {
+									$output_history = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "history","altitude": "'.$alt.'"},"geometry": {"type": "LineString","coordinates": [';
+								}
 							}
 							$output_history .= '[';
 							$output_history .=  $spotter_history['longitude'].', ';
@@ -724,10 +898,15 @@  discard block
 block discarded – undo
 							if ($d == false) {
 								if ($compress) {
 									$output_history = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'",';
-									if (isset($spotter_history_array[0]['mapmatching_engine']) && $spotter_history_array[0]['mapmatching_engine'] == 'graphhopper') $output_history .= '"atr": "Powered by <a href=\"https://www.graphhopper.com/\">GraphHopper API</a>", Map matching engine use data from © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>",';
-									elseif (isset($spotter_history_array[0]['mapmatching_engine'])) $output_history .= '"atr": "Map matching engine use data from © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>",';
+									if (isset($spotter_history_array[0]['mapmatching_engine']) && $spotter_history_array[0]['mapmatching_engine'] == 'graphhopper') {
+										$output_history .= '"atr": "Powered by <a href=\"https://www.graphhopper.com/\">GraphHopper API</a>", Map matching engine use data from © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>",';
+									} elseif (isset($spotter_history_array[0]['mapmatching_engine'])) {
+										$output_history .= '"atr": "Map matching engine use data from © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>",';
+									}
 									$output_history .= '"t": "history"},"geometry": {"type": "LineString","coordinates": [';
-								} else $output_history = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "history"},"geometry": {"type": "LineString","coordinates": [';
+								} else {
+									$output_history = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "history"},"geometry": {"type": "LineString","coordinates": [';
+								}
 								$d = true;
 							}
 							$output_history .= '[';
@@ -750,7 +929,9 @@  discard block
 block discarded – undo
 							$output_historyd = '[';
 							$output_historyd .=  $spotter_item['longitude'].', ';
 							$output_historyd .=  $spotter_item['latitude'];
-							if (isset($spotter_history['altitude'])) $output_historyd .=  ','.$spotter_item['altitude']*30.48;
+							if (isset($spotter_history['altitude'])) {
+								$output_historyd .=  ','.$spotter_item['altitude']*30.48;
+							}
 							$output_historyd .= '],';
 							//$output_history = $output_historyd.$output_history;
 							$output_history = $output_history.$output_historyd;
@@ -777,8 +958,11 @@  discard block
 block discarded – undo
 				        && $spotter_item['arrival_airport'] != 'NA' 
 				        && ((isset($_COOKIE['MapRoute']) && $_COOKIE['MapRoute'] == "true") 
 				    	    || (!isset($_COOKIE['MapRoute']) && isset($globalMapRoute) && $globalMapRoute)))) {
-				    if ($compress) $output_air = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "route"},"geometry": {"type": "LineString","coordinates": [';
-				    else $output_air = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "route"},"geometry": {"type": "LineString","coordinates": [';
+				    if ($compress) {
+				    	$output_air = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "route"},"geometry": {"type": "LineString","coordinates": [';
+				    } else {
+				    	$output_air = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "route"},"geometry": {"type": "LineString","coordinates": [';
+				    }
 				    if (isset($spotter_item['departure_airport_latitude'])) {
 					$output_air .= '['.$spotter_item['departure_airport_longitude'].','.$spotter_item['departure_airport_latitude'].'],';
 				    } elseif (isset($spotter_item['departure_airport']) && $spotter_item['departure_airport'] != 'NA') {
@@ -811,8 +995,11 @@  discard block
 block discarded – undo
 				    	    || (!isset($_COOKIE['MapRemainingRoute']) && (!isset($globalMapRemainingRoute) 
 				    	    || (isset($globalMapRemainingRoute) && $globalMapRemainingRoute)))))) {
 				    $havedata = false;
-				    if ($compress) $output_dest = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "routedest"},"geometry": {"type": "LineString","coordinates": [';
-				    else $output_dest = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "routedest"},"geometry": {"type": "LineString","coordinates": [';
+				    if ($compress) {
+				    	$output_dest = '{"type": "Feature","properties": {"c": "'.$spotter_item['ident'].'","t": "routedest"},"geometry": {"type": "LineString","coordinates": [';
+				    } else {
+				    	$output_dest = '{"type": "Feature","properties": {"callsign": "'.$spotter_item['ident'].'","type": "routedest"},"geometry": {"type": "LineString","coordinates": [';
+				    }
 				    
 				    //$output_dest .= '['.$spotter_item['longitude'].','.$spotter_item['latitude'].'],';
 				    if (isset($spotter_item['arrival_airport_latitude'])) {
@@ -837,7 +1024,9 @@  discard block
 block discarded – undo
 					$output_dest  = substr($output_dest, 0, -1);
 				    }
 				    $output_dest .= ']}},';
-				    if ($havedata) $output .= $output_dest;
+				    if ($havedata) {
+				    	$output .= $output_dest;
+				    }
 				    unset($output_dest);
 				}
 			}
@@ -845,7 +1034,9 @@  discard block
 block discarded – undo
 			$output .= ']';
 			$output .= ',"initial_sqltime": "'.$sqltime.'",';
 			$output .= '"totaltime": "'.round(microtime(true)-$begintime,2).'",';
-			if (isset($begindate)) $output .= '"archive_date": "'.$begindate.'",';
+			if (isset($begindate)) {
+				$output .= '"archive_date": "'.$begindate.'",';
+			}
 			$output .= '"fc": "'.$j.'"';
 		} else {
 			$output .= '"features": ';

Please login to merge, or discard this patch.

		@@ -37,8 +37,11 @@ discard block
		block discarded – undo
37	37	} else {
38	38	curl_setopt($ch, CURLOPT_USERAGENT, $useragent);
39	39	}
40		- if ($timeout == '') curl_setopt($ch, CURLOPT_TIMEOUT, 10);
41		- else curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
	40	+ if ($timeout == '') {
	41	+ curl_setopt($ch, CURLOPT_TIMEOUT, 10);
	42	+ } else {
	43	+ curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
	44	+ }
42	45	curl_setopt($ch, CURLOPT_HEADERFUNCTION, array('Common',"curlResponseHeaderCallback"));
43	46	if ($type == 'post') {
44	47	curl_setopt($ch, CURLOPT_CUSTOMREQUEST, "POST");
		@@ -51,7 +54,9 @@ discard block
		block discarded – undo
51	54	} else {
52	55	curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
53	56	}
54		- } elseif ($type != 'get' && $type != '') curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $type);
	57	+ } elseif ($type != 'get' && $type != '') {
	58	+ curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $type);
	59	+ }
55	60	if ($headers != '') {
56	61	curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
57	62	}
		@@ -95,8 +100,9 @@ discard block
		block discarded – undo
95	100	private function curlResponseHeaderCallback($ch, $headerLine) {
96	101	//global $cookies;
97	102	$cookies = array();
98		- if (preg_match('/^Set-Cookie:\s([^;])/mi', $headerLine, $cookie) == 1)
99		- $cookies[] = $cookie;
	103	+ if (preg_match('/^Set-Cookie:\s([^;])/mi', $headerLine, $cookie) == 1) {
	104	+ $cookies[] = $cookie;
	105	+ }
100	106	return strlen($headerLine); // Needed by curl
101	107	}
102	108
		@@ -107,7 +113,9 @@ discard block
		block discarded – undo
107	113	curl_setopt($ch, CURLOPT_URL, $url);
108	114	curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
109	115	curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
110		- if ($referer != '') curl_setopt($ch, CURLOPT_REFERER, $referer);
	116	+ if ($referer != '') {
	117	+ curl_setopt($ch, CURLOPT_REFERER, $referer);
	118	+ }
111	119	if (isset($globalForceIPv4) && $globalForceIPv4) {
112	120	if (defined('CURLOPT_IPRESOLVE') && defined('CURL_IPRESOLVE_V4')){
113	121	curl_setopt($ch, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
		@@ -119,7 +127,9 @@ discard block
		block discarded – undo
119	127	curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 GTB5');
120	128	curl_setopt($ch, CURLOPT_FILE, $fp);
121	129	curl_exec($ch);
122		- if (curl_errno($ch) && $globalDebug) echo 'Download error: '.curl_error($ch);
	130	+ if (curl_errno($ch) && $globalDebug) {
	131	+ echo 'Download error: '.curl_error($ch);
	132	+ }
123	133	curl_close($ch);
124	134	fclose($fp);
125	135	}
		@@ -127,12 +137,16 @@ discard block
		block discarded – undo
127	137	public static function gunzip($in_file,$out_file_name = '') {
128	138	//echo $in_file.' -> '.$out_file_name."\n";
129	139	$buffer_size = 4096; // read 4kb at a time
130		- if ($out_file_name == '') $out_file_name = str_replace('.gz', '', $in_file);
	140	+ if ($out_file_name == '') {
	141	+ $out_file_name = str_replace('.gz', '', $in_file);
	142	+ }
131	143	if ($in_file != '' && file_exists($in_file)) {
132	144	// PHP version of Ubuntu use gzopen64 instead of gzopen
133		- if (function_exists('gzopen')) $file = gzopen($in_file,'rb');
134		- elseif (function_exists('gzopen64')) $file = gzopen64($in_file,'rb');
135		- else {
	145	+ if (function_exists('gzopen')) {
	146	+ $file = gzopen($in_file,'rb');
	147	+ } elseif (function_exists('gzopen64')) {
	148	+ $file = gzopen64($in_file,'rb');
	149	+ } else {
136	150	echo 'gzopen not available';
137	151	die;
138	152	}
		@@ -148,11 +162,14 @@ discard block
		block discarded – undo
148	162	public static function bunzip2($in_file,$out_file_name = '') {
149	163	//echo $in_file.' -> '.$out_file_name."\n";
150	164	$buffer_size = 4096; // read 4kb at a time
151		- if ($out_file_name == '') $out_file_name = str_replace('.bz2', '', $in_file);
	165	+ if ($out_file_name == '') {
	166	+ $out_file_name = str_replace('.bz2', '', $in_file);
	167	+ }
152	168	if ($in_file != '' && file_exists($in_file)) {
153	169	// PHP version of Ubuntu use gzopen64 instead of gzopen
154		- if (function_exists('bzopen')) $file = bzopen($in_file,'rb');
155		- else {
	170	+ if (function_exists('bzopen')) {
	171	+ $file = bzopen($in_file,'rb');
	172	+ } else {
156	173	echo 'bzopen not available';
157	174	die;
158	175	}
		@@ -171,10 +188,16 @@ discard block
		block discarded – undo
171	188	* @return Array array of the tables in HTML page
172	189	*/
173	190	public function table2array($data) {
174		- if (!is_string($data)) return array();
175		- if ($data == '') return array();
	191	+ if (!is_string($data)) {
	192	+ return array();
	193	+ }
	194	+ if ($data == '') {
	195	+ return array();
	196	+ }
176	197	$html = str_get_html($data);
177		- if ($html === false) return array();
	198	+ if ($html === false) {
	199	+ return array();
	200	+ }
178	201	$tabledata=array();
179	202	foreach($html->find('tr') as $element)
180	203	{
		@@ -209,7 +232,9 @@ discard block
		block discarded – undo
209	232	*/
210	233	public function text2array($data) {
211	234	$html = str_get_html($data);
212		- if ($html === false) return array();
	235	+ if ($html === false) {
	236	+ return array();
	237	+ }
213	238	$tabledata=array();
214	239	foreach($html->find('p') as $element)
215	240	{
		@@ -230,7 +255,9 @@ discard block
		block discarded – undo
230	255	* @return Float Distance in $unit
231	256	*/
232	257	public function distance($lat, $lon, $latc, $lonc, $unit = 'km') {
233		- if ($lat == $latc && $lon == $lonc) return 0;
	258	+ if ($lat == $latc && $lon == $lonc) {
	259	+ return 0;
	260	+ }
234	261	$dist = rad2deg(acos(sin(deg2rad(floatval($lat)))sin(deg2rad(floatval($latc)))+ cos(deg2rad(floatval($lat)))cos(deg2rad(floatval($latc)))cos(deg2rad(floatval($lon)-floatval($lonc)))))60*1.1515;
235	262	if ($unit == "km") {
236	263	return round($dist * 1.609344);
		@@ -269,7 +296,9 @@ discard block
		block discarded – undo
269	296	$dX = $latc - $lat;
270	297	$dY = $lonc - $lon;
271	298	$azimuth = rad2deg(atan2($dY,$dX));
272		- if ($azimuth < 0) return $azimuth+360;
	299	+ if ($azimuth < 0) {
	300	+ return $azimuth+360;
	301	+ }
273	302	return $azimuth;
274	303	}
275	304
		@@ -283,10 +312,16 @@ discard block
		block discarded – undo
283	312	public function withinThreshold ($timeDifference, $distance) {
284	313	$x = abs($timeDifference);
285	314	$d = abs($distance);
286		- if ($x == 0 \|\| $d == 0) return true;
	315	+ if ($x == 0 \|\| $d == 0) {
	316	+ return true;
	317	+ }
287	318	// may be due to Internet jitter; distance is realistic
288		- if ($x < 0.7 && $d < 2000) return true;
289		- else return $d/$x < 1500*0.27778; // 1500 km/h max
	319	+ if ($x < 0.7 && $d < 2000) {
	320	+ return true;
	321	+ } else {
	322	+ return $d/$x < 1500*0.27778;
	323	+ }
	324	+ // 1500 km/h max
290	325	}
291	326
292	327
		@@ -314,11 +349,17 @@ discard block
		block discarded – undo
314	349
315	350	public function convertDM($coord,$latlong) {
316	351	if ($latlong == 'latitude') {
317		- if ($coord < 0) $NSEW = 'S';
318		- else $NSEW = 'N';
	352	+ if ($coord < 0) {
	353	+ $NSEW = 'S';
	354	+ } else {
	355	+ $NSEW = 'N';
	356	+ }
319	357	} else {
320		- if ($coord < 0) $NSEW = 'W';
321		- else $NSEW = 'E';
	358	+ if ($coord < 0) {
	359	+ $NSEW = 'W';
	360	+ } else {
	361	+ $NSEW = 'E';
	362	+ }
322	363	}
323	364	$coord = abs($coord);
324	365	$deg = floor($coord);
		@@ -361,7 +402,9 @@ discard block
		block discarded – undo
361	402	public function hex2str($hex) {
362	403	$str = '';
363	404	$hexln = strlen($hex);
364		- for($i=0;$i<$hexln;$i+=2) $str .= chr(hexdec(substr($hex,$i,2)));
	405	+ for($i=0;$i<$hexln;$i+=2) {
	406	+ $str .= chr(hexdec(substr($hex,$i,2)));
	407	+ }
365	408	return $str;
366	409	}
367	410
		@@ -398,8 +441,11 @@ discard block
		block discarded – undo
398	441	$b = $lat2 - $lat1;
399	442	$c = -($a$lat1+$b$lon1);
400	443	$d = $a$lat3+$b$lon3+$c;
401		- if ($d > -$approx && $d < $approx) return true;
402		- else return false;
	444	+ if ($d > -$approx && $d < $approx) {
	445	+ return true;
	446	+ } else {
	447	+ return false;
	448	+ }
403	449	}
404	450
405	451	public function array_merge_noappend() {
		@@ -458,7 +504,9 @@ discard block
		block discarded – undo
458	504	return $result;
459	505	}
460	506	$handle = @opendir('./locale');
461		- if ($handle === false) return $result;
	507	+ if ($handle === false) {
	508	+ return $result;
	509	+ }
462	510	while (false !== ($file = readdir($handle))) {
463	511	$path = './locale'.'/'.$file.'/LC_MESSAGES/fam.mo';
464	512	if ($file != "." && $file != ".." && @file_exists($path)) {
		@@ -529,8 +577,9 @@ discard block
		block discarded – undo
529	577	$error = false;
530	578	if ($fp_out = gzopen($dest, $mode)) {
531	579	if ($fp_in = fopen($source,'rb')) {
532		- while (!feof($fp_in))
533		- gzwrite($fp_out, fread($fp_in, 1024 * 512));
	580	+ while (!feof($fp_in)) {
	581	+ gzwrite($fp_out, fread($fp_in, 1024 * 512));
	582	+ }
534	583	fclose($fp_in);
535	584	} else {
536	585	$error = true;
		@@ -539,14 +588,17 @@ discard block
		block discarded – undo
539	588	} else {
540	589	$error = true;
541	590	}
542		- if ($error)
543		- return false;
544		- else
545		- return $dest;
	591	+ if ($error) {
	592	+ return false;
	593	+ } else {
	594	+ return $dest;
	595	+ }
546	596	}
547	597
548	598	public function remove_accents($string) {
549		- if ( !preg_match('/[\x80-\xff]/', $string) ) return $string;
	599	+ if ( !preg_match('/[\x80-\xff]/', $string) ) {
	600	+ return $string;
	601	+ }
550	602	$chars = array(
551	603	// Decompositions for Latin-1 Supplement
552	604	chr(195).chr(128) => 'A', chr(195).chr(129) => 'A',
		@@ -670,7 +722,9 @@ discard block
		block discarded – undo
670	722	$ip = gethostbyname($host);
671	723	$s = socket_create(AF_INET, SOCK_STREAM, 0);
672	724	$r = @socket_connect($s, $ip, $port);
673		- if (!socket_set_nonblock($s)) echo "Unable to set nonblock on socket\n";
	725	+ if (!socket_set_nonblock($s)) {
	726	+ echo "Unable to set nonblock on socket\n";
	727	+ }
674	728	if ($r \|\| socket_last_error() == 114 \|\| socket_last_error() == 115) {
675	729	return $s;
676	730	}
		@@ -715,18 +769,22 @@ discard block
		block discarded – undo
715	769	//NOTE: use a trailing slash for folders!!!
716	770	//see http://bugs.php.net/bug.php?id=27609
717	771	//see http://bugs.php.net/bug.php?id=30931
718		- if ($path{strlen($path)-1}=='/') // recursively return a temporary file path
	772	+ if ($path{strlen($path)-1}=='/') {
	773	+ // recursively return a temporary file path
719	774	return $this->is__writable($path.uniqid(mt_rand()).'.tmp');
720		- else if (is_dir($path))
721		- return $this->is__writable($path.'/'.uniqid(mt_rand()).'.tmp');
	775	+ } else if (is_dir($path)) {
	776	+ return $this->is__writable($path.'/'.uniqid(mt_rand()).'.tmp');
	777	+ }
722	778	// check tmp file for read/write capabilities
723	779	$rm = file_exists($path);
724	780	$f = @fopen($path, 'a');
725		- if ($f===false)
726		- return false;
	781	+ if ($f===false) {
	782	+ return false;
	783	+ }
727	784	fclose($f);
728		- if (!$rm)
729		- unlink($path);
	785	+ if (!$rm) {
	786	+ unlink($path);
	787	+ }
730	788	return true;
731	789	}
732	790
		@@ -742,7 +800,9 @@ discard block
		block discarded – undo
742	800	* @return Array Coordinate of the route
743	801	*/
744	802	public function greatcircle($begin_lat,$begin_lon,$end_lat,$end_lon,$nbpts = 20, $offset = 10) {
745		- if ($nbpts <= 2) return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
	803	+ if ($nbpts <= 2) {
	804	+ return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
	805	+ }
746	806	$sx = deg2rad($begin_lon);
747	807	$sy = deg2rad($begin_lat);
748	808	$ex = deg2rad($end_lon);
		@@ -751,7 +811,9 @@ discard block
		block discarded – undo
751	811	$h = $sy - $ey;
752	812	$z = pow(sin($h/2.0),2) + cos($sy)cos($ey)pow(sin($w/2.0),2);
753	813	$g = 2.0*asin(sqrt($z));
754		- if ($g == pi() \|\| is_nan($g)) return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
	814	+ if ($g == pi() \|\| is_nan($g)) {
	815	+ return array(array($begin_lon,$begin_lat),array($end_lon,$end_lat));
	816	+ }
755	817	$first_pass = array();
756	818	$delta = 1.0/($nbpts-1);
757	819	for ($i =0; $i < $nbpts; ++$i) {

Ysurac / FlightAirMap

Push — master ( b40ad5...583e49 )

Status

Category

Braces +110 added lines, -48 removed lines patch added patch discarded remove patch

Braces +321 added lines, -130 removed lines patch added patch discarded remove patch