Ysurac /
FlightAirMap
| Conditions | 19 |
| Paths | 92 |
| Total Lines | 52 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 4 | public function buildcloudlayer($metar) { |
||
| 5 | //print_r($metar); |
||
| 6 | $result = array(); |
||
| 7 | foreach($metar['cloud'] as $key => $data) { |
||
| 8 | $alt_m = $metar['cloud'][$key]['level']; |
||
| 9 | $alt_ft = $alt_m*3.28084; |
||
| 10 | $pressure = $metar['QNH']; |
||
| 11 | $cumulus_base = 122.0 * ($metar['temperature'] - $metar['dew']); |
||
| 12 | $stratus_base = 100.0 * (100.0 * $metar['rh'])*0.3048; |
||
| 13 | $coverage_norm = 0.0; |
||
| 14 | if ($metar['cloud'][$key]['type'] == 'Few') { |
||
| 15 | $coverage_norm = 2.0/8.0; |
||
| 16 | } elseif ($metar['cloud'][$key]['type'] == 'Scattered') { |
||
| 17 | $coverage_norm = 4.0/8.0; |
||
| 18 | } elseif ($metar['cloud'][$key]['type'] == 'Broken') { |
||
| 19 | $coverage_norm = 6.0/8.0; |
||
| 20 | } elseif ($metar['cloud'][$key]['type'] == 'Overcast/Full cloud coverage') { |
||
| 21 | $coverage_norm = 8.0/8.0; |
||
| 22 | } |
||
| 23 | $layer_type = 'nn'; |
||
|
|
|||
| 24 | if ($metar['cloud'][$key]['significant'] == 'cirrus') { |
||
| 25 | $layer_type = 'ci'; |
||
| 26 | } elseif ($alt_ft > 16500) { |
||
| 27 | $layer_type = 'ci'; |
||
| 28 | } elseif ($alt_ft > 6500) { |
||
| 29 | $layer_type = 'ac'; |
||
| 30 | if ($pressure < 1005.0 && $coverage_norm >= 0.5) { |
||
| 31 | $layer_type = 'ns'; |
||
| 32 | } |
||
| 33 | } else { |
||
| 34 | if ($cumulus_base * 0.80 < $alt_m && $cumulus_base * 1.20 > $alt_m) { |
||
| 35 | $layer_type = 'cu'; |
||
| 36 | } elseif ($stratus_base * 0.80 < $alt_m && $stratus_base * 1.40 > $alt_m) { |
||
| 37 | $layer_type = 'st'; |
||
| 38 | } else { |
||
| 39 | if ($alt_ft < 2000) { |
||
| 40 | $layer_type = 'st'; |
||
| 41 | } elseif ($alt_ft < 4500) { |
||
| 42 | $layer_type = 'cu'; |
||
| 43 | } else { |
||
| 44 | $layer_type = 'sc'; |
||
| 45 | } |
||
| 46 | } |
||
| 47 | } |
||
| 48 | //echo 'coverage norm : '.$coverage_norm.' - layer_type: '.$layer_type."\n"; |
||
| 49 | $result[] = array('cov' => $coverage_norm, 'type' => $layer_type,'alt' => $alt_m,'rh' => $metar['rh']); |
||
| 50 | } |
||
| 51 | if (count($result) < 2 && $metar['rh'] > 60) { |
||
| 52 | $result[] = array('cov' => 0.75, 'type' => 'ci','alt' => 4000,'rh' => $metar['rh']); |
||
| 53 | } |
||
| 54 | return $result; |
||
| 55 | } |
||
| 56 | |||
| 142 | ?> |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.