Connection::createDBConnection() - Code Metrics - Inspection of "fix install" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d8c574...a11679 )

by Yannick

created 2016-08-03 15:11 UTC

Connection::createDBConnection() F

↳ Parent: Connection

Complexity

Conditions	25
Paths	1056

Size

Total Lines	74
Code Lines	61

Duplication

Lines	12
Ratio	16.22 %

Importance

Changes	7
Bugs	3	Features	1

Metric	Value
cc	25
eloc	61
c	7
b	3
f	1
nc	1056
nop	3
dl	12
loc	74
rs	2.4918

How to fix Long Method Complexity

<?php
require_once(dirname(__FILE__).'/settings.php');

class Connection{
	public $db = null;
	public $dbs = array();
	public $latest_schema = 23;
	
	public function __construct($dbc = null,$dbname = null,$user = null,$pass = null) {
	    global $globalDBdriver;
	    if ($dbc === null) {
		if ($this->db === null && $dbname === null) {
		    if ($user === null && $pass === null) {
			$this->createDBConnection();
		    } else {
			$this->createDBConnection(null,$user,$pass);
		    }
		} else {
		    $this->createDBConnection($dbname);
		}
	    } elseif ($dbname === null || $dbname === 'default') {
		$this->db = $dbc;
		if ($this->connectionExists() === false) {
			/*

			echo 'Restart Connection !!!'."\n";
			$e = new \Exception;
			var_dump($e->getTraceAsString());
			*/
			$this->createDBConnection();
		}
	    } else {
		//$this->connectionExists();

		$this->dbs[$dbname] = $dbc;
	    }
	}


	/**
	* Creates the database connection
	*
	* @return Boolean of the database connection
	*
	*/

	public function createDBConnection($DBname = null, $user = null, $pass = null)
	{
		global $globalDBdriver, $globalDBhost, $globalDBuser, $globalDBpass, $globalDBname, $globalDebug, $globalDB, $globalDBport, $globalDBTimeOut, $globalDBretry, $globalDBPersistent;
		if ($DBname === null) {
			if ($user === null && $pass === null) {
				$DBname = 'default';
				$globalDBSdriver = $globalDBdriver;
				$globalDBShost = $globalDBhost;
				$globalDBSname = $globalDBname;
				$globalDBSuser = $globalDBuser;
				$globalDBSpass = $globalDBpass;
				if (!isset($globalDBport) || $globalDBport === NULL || $globalDBport = '') $globalDBSport = 3306;

				else $globalDBSport = intval($globalDBport);
			} else {
				$DBname = 'default';
				$globalDBSdriver = $globalDBdriver;
				$globalDBShost = $globalDBhost;
				$globalDBSname = $globalDBname;
				$globalDBSuser = $user;
				$globalDBSpass = $pass;
				if (!isset($globalDBport) || $globalDBport === NULL || $globalDBport = '') $globalDBSport = 3306;

				else $globalDBSport = intval($globalDBport);
			}
		} else {
			$globalDBSdriver = $globalDB[$DBname]['driver'];
			$globalDBShost = $globalDB[$DBname]['host'];
			$globalDBSname = $globalDB[$DBname]['name'];
			$globalDBSuser = $globalDB[$DBname]['user'];
			$globalDBSpass = $globalDB[$DBname]['pass'];
			if (isset($globalDB[$DBname]['port'])) $globalDBSport = intval($globalDB[$DBname]['port']);
			else $globalDBSport = 3306;
		}
		// Set number of try to connect to DB
		if (!isset($globalDBretry) || $globalDBretry == '' || $globalDBretry === NULL) $globalDBretry = 5;
		$i = 0;
		while (true) {
			try {
				if ($globalDBSdriver == 'mysql') {
					$this->dbs[$DBname] = new PDO("$globalDBSdriver:host=$globalDBShost;port=$globalDBSport;dbname=$globalDBSname;charset=utf8", $globalDBSuser,  $globalDBSpass);
					$this->dbs[$DBname]->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'utf8'");
					$this->dbs[$DBname]->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
					$this->dbs[$DBname]->setAttribute(PDO::ATTR_CASE,PDO::CASE_LOWER);
					if (!isset($globalDBTimeOut)) $this->dbs[$DBname]->setAttribute(PDO::ATTR_TIMEOUT,200);

					else $this->dbs[$DBname]->setAttribute(PDO::ATTR_TIMEOUT,$globalDBTimeOut);
					if (!isset($globalDBPersistent)) $this->dbs[$DBname]->setAttribute(PDO::ATTR_PERSISTENT,true);

					else $this->dbs[$DBname]->setAttribute(PDO::ATTR_PERSISTENT,$globalDBPersistent);
					$this->dbs[$DBname]->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
					$this->dbs[$DBname]->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);
					// Workaround against "ONLY_FULL_GROUP_BY" mode
					// to enable it : $this->dbs[$DBname]->exec('SET sql_mode = "NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,ONLY_FULL_GROUP_BY"');

					$this->dbs[$DBname]->exec('SET sql_mode = "NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"');
				} else {
					$this->dbs[$DBname] = new PDO("$globalDBSdriver:host=$globalDBShost;port=$globalDBSport;dbname=$globalDBSname;options='--client_encoding=utf8'", $globalDBSuser,  $globalDBSpass);
					//$this->dbs[$DBname]->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'utf8'");

					$this->dbs[$DBname]->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
					$this->dbs[$DBname]->setAttribute(PDO::ATTR_CASE,PDO::CASE_LOWER);
					if (!isset($globalDBTimeOut)) $this->dbs[$DBname]->setAttribute(PDO::ATTR_TIMEOUT,200);

					else $this->dbs[$DBname]->setAttribute(PDO::ATTR_TIMEOUT,$globalDBTimeOut);
					if (!isset($globalDBPersistent)) $this->dbs[$DBname]->setAttribute(PDO::ATTR_PERSISTENT,true);

					else $this->dbs[$DBname]->setAttribute(PDO::ATTR_PERSISTENT,$globalDBPersistent);
					$this->dbs[$DBname]->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
				}
				break;
			} catch(PDOException $e) {
				$i++;
				if (isset($globalDebug) && $globalDebug) echo $e->getMessage()."\n";
				//exit;
				if ($i > $globalDBretry) return false;
				//return false;
			}
		}
		if ($DBname === 'default') $this->db = $this->dbs['default'];
		return true;
	}

	public function tableExists($table)
	{
		global $globalDBdriver, $globalDBname;
		if ($globalDBdriver == 'mysql') {
			$query = "SHOW TABLES LIKE '".$table."'";
		} elseif ($globalDBdriver == 'pgsql') {
			$query = "SELECT * FROM pg_catalog.pg_tables WHERE tablename = '".$table."'";
		}
		if ($this->db == NULL) return false;
		try {
			//$Connection = new Connection();

			$results = $this->db->query($query);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		} catch(PDOException $e) {
			return false;
		}
		if($results->rowCount()>0) {
		    return true; 
		}
		else return false;
	}

	public function connectionExists()
	{
		global $globalDBdriver, $globalDBCheckConnection;
		if (isset($globalDBCheckConnection) && $globalDBCheckConnection === FALSE) return true;
		$query = "SELECT 1 + 1";
		if ($this->db == NULL) return false;
		try {
			$sum = @$this->db->query($query);

			if ($sum instanceof \PDOStatement) {
				$sum = $sum->fetchColumn(0);
			} else $sum = 0;
			if (intval($sum) !== 2) {
			     return false;
			}
			
		} catch(PDOException $e) {
			if($e->getCode() != 'HY000' || !stristr($e->getMessage(), 'server has gone away')) {
            			throw $e;
	                }
	                //echo 'error ! '.$e->getMessage();

			return false;
		}
		return true; 
	}

	/*
	* Check if index exist
	*/
	public function indexExists($table,$index)
	{
		global $globalDBdriver, $globalDBname;
		if ($globalDBdriver == 'mysql') {
			$query = "SELECT COUNT(1) IndexIsThere FROM INFORMATION_SCHEMA.STATISTICS WHERE table_schema=DATABASE() AND table_name='".$table."' AND index_name='".$index."'";
		} elseif ($globalDBdriver == 'pgsql') {
			$query = "SELECT 1 FROM   pg_class c JOIN   pg_namespace n ON n.oid = c.relnamespace WHERE c.relname = '".$index."' AND n.nspname = '".$table."'";
		}
		try {
			//$Connection = new Connection();

			$results = $this->db->query($query);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		} catch(PDOException $e) {
			return false;
		}
		if($results->rowCount()>0) {
		    return true; 
		}
		else return false;
	}

	/*
	* Get columns name of a table
	* @return Array all column name in table
	*/
	public function getColumnName($table)
	{
		$query = "SELECT * FROM ".$table." LIMIT 0";
		try {
			$results = $this->db->query($query);

		} catch(PDOException $e) {
			return "error : ".$e->getMessage()."\n";
		}
		$columns = array();
		$colcnt = $results->columnCount();
		for ($i = 0; $i < $colcnt; $i++) {

			$col = $results->getColumnMeta($i);
			$columns[] = $col['name'];
		}
		return $columns;
	}

	/*
	* Check if a column name exist in a table
	* @return Boolean column exist or not
	*/
	public function checkColumnName($table,$name)
	{
		$query = "SELECT * FROM ".$table." LIMIT 0";
		try {
			$results = $this->db->query($query);

		} catch(PDOException $e) {
			return "error : ".$e->getMessage()."\n";
		}
		$colcnt = $results->columnCount();
		for ($i = 0; $i < $colcnt; $i++) {

			$col = $results->getColumnMeta($i);
			if ($name == $col['name']) return true;
		}
		return false;
	}

	/*
	* Get schema version
	* @return integer schema version
	*/
	public function check_schema_version() {
		$version = 0;
		if ($this->tableExists('aircraft')) {
			if (!$this->tableExists('config')) {
	    			$version = '1';
	    			return $version;
			} else {
				$Connection = new Connection();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				$query = "SELECT value FROM config WHERE name = 'schema_version' LIMIT 1";
				try {
					$sth = $this->db->prepare($query);

					$sth->execute();
				} catch(PDOException $e) {
					return "error : ".$e->getMessage()."\n";
				}
				$result = $sth->fetch(PDO::FETCH_ASSOC);
				return $result['value'];
			}
		} else return $version;
	}
	
	/*
	* Check if schema version is latest_schema
	* @return Boolean if latest version or not
	*/
	public function latest() {
	    if ($this->check_schema_version() == $this->latest_schema) return true;
	    else return false;
	}

}
?>



Push — master ( d8c574...a11679 )

Connection::createDBConnection() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

1			<?php
2			require_once(dirname(__FILE__).'/settings.php');
3
4			class Connection{
5			public $db = null;
6			public $dbs = array();
7			public $latest_schema = 23;
8
9			public function __construct($dbc = null,$dbname = null,$user = null,$pass = null) {
10			global $globalDBdriver;
11			if ($dbc === null) {
12			if ($this->db === null && $dbname === null) {
13			if ($user === null && $pass === null) {
14			$this->createDBConnection();
15			} else {
16			$this->createDBConnection(null,$user,$pass);
17			}
18			} else {
19			$this->createDBConnection($dbname);
20			}
21			} elseif ($dbname === null \|\| $dbname === 'default') {
22			$this->db = $dbc;
23			if ($this->connectionExists() === false) {
24			/*
			1 ignored issue – show Unused Code Comprehensibility introduced 2016-08-01 12:53 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
25			echo 'Restart Connection !!!'."\n";
26			$e = new \Exception;
27			var_dump($e->getTraceAsString());
28			*/
29			$this->createDBConnection();
30			}
31			} else {
32			//$this->connectionExists();
			1 ignored issue – show Unused Code Comprehensibility introduced 2016-08-01 12:53 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33			$this->dbs[$dbname] = $dbc;
34			}
35			}
36
37
38			/**

Ysurac / FlightAirMap

Push — master ( d8c574...a11679 )

Connection::createDBConnection() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like