Ysurac / FlightAirMap

require/class.SpotterArchive.php

<?php
class SpotterArchive {
    public $global_query = "SELECT spotter_archive.* FROM spotter_archive";
    public $db;

    function __construct($dbc = null) {
            $Connection = new Connection($dbc);
            $this->db = $Connection->db;
    }


    // Spotter_archive
    
    function addSpotterArchiveData($flightaware_id = '', $ident = '', $registration = '', $airline_name = '', $airline_icao = '', $airline_country = '', $airline_type = '', $aircraft_icao = '', $aircraft_shadow = '', $aircraft_name = '', $aircraft_manufacturer = '', $departure_airport_icao = '', $departure_airport_name = '', $departure_airport_city = '', $departure_airport_country = '', $departure_airport_time = '',$arrival_airport_icao = '', $arrival_airport_name = '', $arrival_airport_city ='', $arrival_airport_country = '', $arrival_airport_time = '', $route_stop = '', $date = '',$latitude = '', $longitude = '', $waypoints = '', $altitude = '', $heading = '', $ground_speed = '', $squawk = '', $ModeS = '', $pilot_id = '', $pilot_name = '',$verticalrate = '',$format_source = '', $source_name = '', $over_country = '') {
	require_once(dirname(__FILE__).'/class.Spotter.php');
        if ($over_country == '') {
	        $Spotter = new Spotter($this->db);
	        $data_country = $Spotter->getCountryFromLatitudeLongitude($latitude,$longitude);
		if (!empty($data_country)) $country = $data_country['iso2'];
		else $country = '';
	} else $country = $over_country;
	if ($airline_type === NULL) $airline_type ='';
	
	//if ($country == '') echo "\n".'************ UNKNOW COUNTRY ****************'."\n";
	//else echo "\n".'*/*/*/*/*/*/*/ Country : '.$country.' */*/*/*/*/*/*/*/*/'."\n";

	// Route is not added in spotter_archive
	$query  = "INSERT INTO spotter_archive (flightaware_id, ident, registration, airline_name, airline_icao, airline_country, airline_type, aircraft_icao, aircraft_shadow, aircraft_name, aircraft_manufacturer, departure_airport_icao, departure_airport_name, departure_airport_city, departure_airport_country, departure_airport_time,arrival_airport_icao, arrival_airport_name, arrival_airport_city, arrival_airport_country, arrival_airport_time, route_stop, date,latitude, longitude, waypoints, altitude, heading, ground_speed, squawk, ModeS, pilot_id, pilot_name, verticalrate,format_source,over_country,source_name)
                VALUES (:flightaware_id, :ident, :registration, :airline_name, :airline_icao, :airline_country, :airline_type, :aircraft_icao, :aircraft_shadow, :aircraft_name, :aircraft_manufacturer, :departure_airport_icao, :departure_airport_name, :departure_airport_city, :departure_airport_country, :departure_airport_time,:arrival_airport_icao, :arrival_airport_name, :arrival_airport_city, :arrival_airport_country, :arrival_airport_time, :route_stop, :date,:latitude, :longitude, :waypoints, :altitude, :heading, :ground_speed, :squawk, :ModeS, :pilot_id, :pilot_name, :verticalrate, :format_source, :over_country, :source_name)";

        $query_values = array(':flightaware_id' => $flightaware_id, ':ident' => $ident, ':registration' => $registration, ':airline_name' => $airline_name, ':airline_icao' => $airline_icao, ':airline_country' => $airline_country, ':airline_type' => $airline_type, ':aircraft_icao' => $aircraft_icao, ':aircraft_shadow' => $aircraft_shadow, ':aircraft_name' => $aircraft_name, ':aircraft_manufacturer' => $aircraft_manufacturer, ':departure_airport_icao' => $departure_airport_icao, ':departure_airport_name' => $departure_airport_name, ':departure_airport_city' => $departure_airport_city, ':departure_airport_country' => $departure_airport_country, ':departure_airport_time' => $departure_airport_time,':arrival_airport_icao' => $arrival_airport_icao, ':arrival_airport_name' => $arrival_airport_name, ':arrival_airport_city' => $arrival_airport_city, ':arrival_airport_country' => $arrival_airport_country, ':arrival_airport_time' => $arrival_airport_time, ':route_stop' => $route_stop, ':date' => $date,':latitude' => $latitude, ':longitude' => $longitude, ':waypoints' => $waypoints, ':altitude' => $altitude, ':heading' => $heading, ':ground_speed' => $ground_speed, ':squawk' => $squawk, ':ModeS' => $ModeS, ':pilot_id' => $pilot_id, ':pilot_name' => $pilot_name, ':verticalrate' => $verticalrate, ':format_source' => $format_source, ':over_country' => $country, ':source_name' => $source_name);
        try {
            $sth = $this->db->prepare($query);
            $sth->execute($query_values);
        } catch(PDOException $e) {
            return "error : ".$e->getMessage();
        }
        return "success";
    }


        /**
        * Gets all the spotter information based on a particular callsign
        *
        * @return Array the spotter information
        *
        */
        public function getLastArchiveSpotterDataByIdent($ident)
        {
		$Spotter = new Spotter($this->db);
                date_default_timezone_set('UTC');

                $ident = filter_var($ident, FILTER_SANITIZE_STRING);
                //$query  = "SELECT spotter_archive.* FROM spotter_archive INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE l.ident = :ident GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate LIMIT 1";
                $query  = "SELECT spotter_archive.* FROM spotter_archive WHERE ident = :ident ORDER BY date DESC LIMIT 1";

                $spotter_array = $Spotter->getDataFromDB($query,array(':ident' => $ident));

                return $spotter_array;
        }


        /**
        * Gets last the spotter information based on a particular id
        *
        * @return Array the spotter information
        *
        */
        public function getLastArchiveSpotterDataById($id)
        {
    		$Spotter = new Spotter($this->db);
                date_default_timezone_set('UTC');
                $id = filter_var($id, FILTER_SANITIZE_STRING);
                //$query  = SpotterArchive->$global_query." WHERE spotter_archive.flightaware_id = :id";
                //$query  = "SELECT spotter_archive.* FROM spotter_archive INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE l.flightaware_id = :id GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate LIMIT 1";
                $query  = "SELECT * FROM spotter_archive WHERE flightaware_id = :id ORDER BY date DESC LIMIT 1";

//              $spotter_array = Spotter->getDataFromDB($query,array(':id' => $id));
                  /*
                try {
                        $Connection = new Connection();
                        $sth = Connection->$db->prepare($query);
                        $sth->execute(array(':id' => $id));
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO->FETCH_ASSOC);
                */
                $spotter_array = $Spotter->getDataFromDB($query,array(':id' => $id));

                return $spotter_array;
        }

        /**
        * Gets all the spotter information based on a particular id
        *
        * @return Array the spotter information
        *
        */
        public function getAllArchiveSpotterDataById($id)
        {
                date_default_timezone_set('UTC');
                $id = filter_var($id, FILTER_SANITIZE_STRING);
                $query  = $this->global_query." WHERE spotter_archive.flightaware_id = :id";

//              $spotter_array = Spotter->getDataFromDB($query,array(':id' => $id));

                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute(array(':id' => $id));
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }

        /**
        * Gets coordinate & time spotter information based on a particular id
        *
        * @return Array the spotter information
        *
        */
        public function getCoordArchiveSpotterDataById($id)

This method seems to be duplicated in your project.

        {
                date_default_timezone_set('UTC');
                $id = filter_var($id, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_archive.latitude, spotter_archive.longitude, spotter_archive.date FROM spotter_archive WHERE spotter_archive.flightaware_id = :id";

//              $spotter_array = Spotter->getDataFromDB($query,array(':id' => $id));

62% of this comment could be valid code. Did you maybe forget this after debugging?

                try {
                        $sth = $this->db->prepare($query);

The method prepare cannot be called on $this->db (of type null).

                        $sth->execute(array(':id' => $id));
                } catch(PDOException $e) {
                        return $e->getMessage();

The return type of return $e->getMessage(); (string) is incompatible with the return type documented by SpotterArchive::getCoordArchiveSpotterDataById of type array.

                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }


        /**
        * Gets altitude information based on a particular callsign
        *
        * @return Array the spotter information
        *
        */
        public function getAltitudeArchiveSpotterDataByIdent($ident)
        {

                date_default_timezone_set('UTC');

                $ident = filter_var($ident, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_archive.altitude, spotter_archive.date FROM spotter_archive WHERE spotter_archive.ident = :ident";

                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute(array(':ident' => $ident));
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }

        /**
        * Gets altitude information based on a particular id
        *
        * @return Array the spotter information
        *
        */
        public function getAltitudeArchiveSpotterDataById($id)
        {

                date_default_timezone_set('UTC');

                $id = filter_var($id, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_archive.altitude, spotter_archive.date FROM spotter_archive WHERE spotter_archive.flightaware_id = :id";

                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute(array(':id' => $id));
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }

        /**
        * Gets altitude & speed information based on a particular id
        *
        * @return Array the spotter information
        *
        */
        public function getAltitudeSpeedArchiveSpotterDataById($id)
        {

                date_default_timezone_set('UTC');

                $id = filter_var($id, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_archive.altitude, spotter_archive.ground_speed, spotter_archive.date FROM spotter_archive WHERE spotter_archive.flightaware_id = :id";

                try {
                        $sth = $this->db->prepare($query);

The method prepare cannot be called on $this->db (of type null).

                        $sth->execute(array(':id' => $id));
                } catch(PDOException $e) {
		        return "error : ".$e->getMessage();
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }


        /**
        * Gets altitude information based on a particular callsign
        *
        * @return Array the spotter information
        *
        */
        public function getLastAltitudeArchiveSpotterDataByIdent($ident)
        {

                date_default_timezone_set('UTC');

                $ident = filter_var($ident, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_archive.altitude, spotter_archive.date FROM spotter_archive INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE l.ident = :ident GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate LIMIT 1";
//                $query  = "SELECT spotter_archive.altitude, spotter_archive.date FROM spotter_archive WHERE spotter_archive.ident = :ident";

                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute(array(':ident' => $ident));
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }



       /**
        * Gets all the archive spotter information
        *
        * @return Array the spotter information
        *
        */
        public function getSpotterArchiveData($ident,$flightaware_id,$date)
        {
    		$Spotter = new Spotter($this->db);
                $ident = filter_var($ident, FILTER_SANITIZE_STRING);
                $query  = "SELECT spotter_live.* FROM spotter_live INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_live l WHERE l.ident = :ident AND l.flightaware_id = :flightaware_id AND l.date LIKE :date GROUP BY l.flightaware_id) s on spotter_live.flightaware_id = s.flightaware_id AND spotter_live.date = s.maxdate";

                $spotter_array = $Spotter->getDataFromDB($query,array(':ident' => $ident,':flightaware_id' => $flightaware_id,':date' => $date.'%'));

                return $spotter_array;
        }
        
        public function deleteSpotterArchiveTrackData()
        {
		global $globalArchiveKeepTrackMonths;
                date_default_timezone_set('UTC');
		$query = 'DELETE FROM spotter_archive WHERE spotter_archive.date < DATE_SUB(UTC_TIMESTAMP(), INTERVAL '.$globalArchiveKeepTrackMonths.' MONTH)';
                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute();
                } catch(PDOException $e) {
                        return "error";
                }
	}

	/**
        * Gets Minimal Live Spotter data
        *
        * @return Array the spotter information
        *
        */
        public function getMinLiveSpotterData($begindate,$enddate,$filter = array())
        {
                global $globalDBdriver, $globalLiveInterval;
                date_default_timezone_set('UTC');

                $filter_query = '';
                if (isset($filter['source']) && !empty($filter['source'])) {

This code seems to be duplicated across your project.

                        $filter_query .= " AND format_source IN ('".implode("','",$filter['source'])."') ";
                }
                // Use spotter_output also ?
                if (isset($filter['airlines']) && !empty($filter['airlines'])) {
                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_archive_output WHERE spotter_archive_output.airline_icao IN ('".implode("','",$filter['airlines'])."')) so ON so.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['airlinestype']) && !empty($filter['airlinestype'])) {
                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_archive_output WHERE spotter_archive_output.airline_type = '".$filter['airlinestype']."') sa ON sa.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['source_aprs']) && !empty($filter['source_aprs'])) {

This code seems to be duplicated across your project.

                        $filter_query = " AND format_source = 'aprs' AND source_name IN ('".implode("','",$filter['source_aprs'])."')";
                }

                //if (!isset($globalLiveInterval)) $globalLiveInterval = '200';
                if ($globalDBdriver == 'mysql') {
                        /*

52% of this comment could be valid code. Did you maybe forget this after debugging?

                        $query  = 'SELECT a.aircraft_shadow, spotter_archive.ident, spotter_archive.flightaware_id, spotter_archive.aircraft_icao, spotter_archive.departure_airport_icao as departure_airport, spotter_archive.arrival_airport_icao as arrival_airport, spotter_archive.latitude, spotter_archive.longitude, spotter_archive.altitude, spotter_archive.heading, spotter_archive.ground_speed, spotter_archive.squawk 
                    		    FROM spotter_archive 
                    		    INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE (l.date BETWEEN '."'".$begindate."'".' AND '."'".$enddate."'".') GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate '.$filter_query.'LEFT JOIN (SELECT aircraft_shadow,icao FROM aircraft) a ON spotter_archive.aircraft_icao = a.icao';
			*/
			$query  = 'SELECT a.aircraft_shadow, spotter_archive.ident, spotter_archive.flightaware_id, spotter_archive.aircraft_icao, spotter_archive.departure_airport_icao as departure_airport, spotter_archive.arrival_airport_icao as arrival_airport, spotter_archive.latitude, spotter_archive.longitude, spotter_archive.altitude, spotter_archive.heading, spotter_archive.ground_speed, spotter_archive.squawk 
				    FROM spotter_archive 
				    INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate 
						FROM spotter_archive l 
						WHERE (l.date BETWEEN DATE_SUB('."'".$begindate."'".',INTERVAL '.$globalLiveInterval.' SECOND) AND '."'".$begindate."'".') 
						GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id 
				    AND spotter_archive.date = s.maxdate '.$filter_query.'LEFT JOIN (SELECT aircraft_shadow,icao FROM aircraft) a ON spotter_archive.aircraft_icao = a.icao';
                } else if ($globalDBdriver == 'pgsql') {
                        $query  = 'SELECT spotter_archive.ident, spotter_archive.flightaware_id, spotter_archive.aircraft_icao, spotter_archive.departure_airport_icao as departure_airport, spotter_archive.arrival_airport_icao as arrival_airport, spotter_archive.latitude, spotter_archive.longitude, spotter_archive.altitude, spotter_archive.heading, spotter_archive.ground_speed, spotter_archive.squawk, a.aircraft_shadow FROM spotter_archive INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE DATE_SUB(UTC_TIMESTAMP(),INTERVAL '.$globalLiveInterval.' SECOND) <= l.date GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate '.$filter_query.'INNER JOIN (SELECT * FROM aircraft) a on spotter_archive.aircraft_icao = a.icao';
                }
                //echo $query;
                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute();
                } catch(PDOException $e) {
                        return "error";
                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }

	/**
        * Gets Minimal Live Spotter data
        *
        * @return Array the spotter information
        *
        */
        public function getMinLiveSpotterDataPlayback($begindate,$enddate,$filter = array())
        {
                global $globalDBdriver, $globalLiveInterval;
                date_default_timezone_set('UTC');

                $filter_query = '';
                if (isset($filter['source']) && !empty($filter['source'])) {

This code seems to be duplicated across your project.

                        $filter_query .= " AND format_source IN ('".implode("','",$filter['source'])."') ";
                }
                // FIXME : use spotter_output also
                if (isset($filter['airlines']) && !empty($filter['airlines'])) {

This code seems to be duplicated across your project.

                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_archive_output WHERE spotter_archive_output.airline_icao IN ('".implode("','",$filter['airlines'])."')) so ON so.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['airlinestype']) && !empty($filter['airlinestype'])) {

This code seems to be duplicated across your project.

                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_archive_output WHERE spotter_archive_output.airline_type = '".$filter['airlinestype']."') sa ON sa.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['source_aprs']) && !empty($filter['source_aprs'])) {

This code seems to be duplicated across your project.

                        $filter_query = " AND format_source = 'aprs' AND source_name IN ('".implode("','",$filter['source_aprs'])."')";
                }

                //if (!isset($globalLiveInterval)) $globalLiveInterval = '200';

69% of this comment could be valid code. Did you maybe forget this after debugging?

                if ($globalDBdriver == 'mysql') {
                        /*

52% of this comment could be valid code. Did you maybe forget this after debugging?

                        $query  = 'SELECT a.aircraft_shadow, spotter_archive.ident, spotter_archive.flightaware_id, spotter_archive.aircraft_icao, spotter_archive.departure_airport_icao as departure_airport, spotter_archive.arrival_airport_icao as arrival_airport, spotter_archive.latitude, spotter_archive.longitude, spotter_archive.altitude, spotter_archive.heading, spotter_archive.ground_speed, spotter_archive.squawk 
                    		    FROM spotter_archive 
                    		    INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive l WHERE (l.date BETWEEN '."'".$begindate."'".' AND '."'".$enddate."'".') GROUP BY l.flightaware_id) s on spotter_archive.flightaware_id = s.flightaware_id AND spotter_archive.date = s.maxdate '.$filter_query.'LEFT JOIN (SELECT aircraft_shadow,icao FROM aircraft) a ON spotter_archive.aircraft_icao = a.icao';
			*/
			$query  = 'SELECT a.aircraft_shadow, spotter_archive_output.ident, spotter_archive_output.flightaware_id, spotter_archive_output.aircraft_icao, spotter_archive_output.departure_airport_icao as departure_airport, spotter_archive_output.arrival_airport_icao as arrival_airport, spotter_archive_output.latitude, spotter_archive_output.longitude, spotter_archive_output.altitude, spotter_archive_output.heading, spotter_archive_output.ground_speed, spotter_archive_output.squawk 
				    FROM spotter_archive_output 
				    LEFT JOIN (SELECT aircraft_shadow,icao FROM aircraft) a ON spotter_archive_output.aircraft_icao = a.icao 
				    WHERE (spotter_archive_output.date BETWEEN '."'".$begindate."'".' AND '."'".$enddate."'".') 
                        	    '.$filter_query.' GROUP BY spotter_archive_output.flightaware_id, spotter_archive_output.ident, spotter_archive_output.aircraft_icao, spotter_archive_output.departure_airport_icao, spotter_archive_output.arrival_airport_icao, spotter_archive_output.latitude, spotter_archive_output.longitude, spotter_archive_output.altitude, spotter_archive_output.heading, spotter_archive_output.ground_speed, spotter_archive_output.squawk, a.aircraft_shadow';

                } else if ($globalDBdriver == 'pgsql') {
                        //$query  = 'SELECT spotter_archive_output.ident, spotter_archive_output.flightaware_id, spotter_archive_output.aircraft_icao, spotter_archive_output.departure_airport_icao as departure_airport, spotter_archive_output.arrival_airport_icao as arrival_airport, spotter_archive_output.latitude, spotter_archive_output.longitude, spotter_archive_output.altitude, spotter_archive_output.heading, spotter_archive_output.ground_speed, spotter_archive_output.squawk, a.aircraft_shadow FROM spotter_archive_output INNER JOIN (SELECT l.flightaware_id, max(l.date) as maxdate FROM spotter_archive_output l WHERE DATE_SUB(UTC_TIMESTAMP(),INTERVAL '.$globalLiveInterval.' SECOND) <= l.date GROUP BY l.flightaware_id) s on spotter_archive_output.flightaware_id = s.flightaware_id AND spotter_archive_output.date = s.maxdate '.$filter_query.'INNER JOIN (SELECT * FROM aircraft) a on spotter_archive_output.aircraft_icao = a.icao';

50% of this comment could be valid code. Did you maybe forget this after debugging?

                        $query  = 'SELECT spotter_archive_output.ident, spotter_archive_output.flightaware_id, spotter_archive_output.aircraft_icao, spotter_archive_output.departure_airport_icao as departure_airport, spotter_archive_output.arrival_airport_icao as arrival_airport, spotter_archive_output.latitude, spotter_archive_output.longitude, spotter_archive_output.altitude, spotter_archive_output.heading, spotter_archive_output.ground_speed, spotter_archive_output.squawk, a.aircraft_shadow

$query is not used, you could remove the assignment.

                        	    FROM spotter_archive_output 
                        	    INNER JOIN (SELECT * FROM aircraft) a on spotter_archive_output.aircraft_icao = a.icao
                        	    WHERE spotter_archive_output.date >= '."'".$begindate."'".' AND spotter_archive_output.date <= '."'".$enddate."'".'
                        	    '.$filter_query.' GROUP BY spotter_archive_output.flightaware_id, spotter_archive_output.ident, spotter_archive_output.aircraft_icao, spotter_archive_output.departure_airport_icao, spotter_archive_output.arrival_airport_icao, spotter_archive_output.latitude, spotter_archive_output.longitude, spotter_archive_output.altitude, spotter_archive_output.heading, spotter_archive_output.ground_speed, spotter_archive_output.squawk, a.aircraft_shadow';
                        $query  = 'SELECT DISTINCT spotter_output.flightaware_id, spotter_output.ident, spotter_output.aircraft_icao, spotter_output.departure_airport_icao as departure_airport, spotter_output.arrival_airport_icao as arrival_airport, spotter_output.latitude, spotter_output.longitude, spotter_output.altitude, spotter_output.heading, spotter_output.ground_speed, spotter_output.squawk, a.aircraft_shadow
                        	    FROM spotter_output 
                        	    INNER JOIN (SELECT * FROM aircraft) a on spotter_output.aircraft_icao = a.icao
                        	    WHERE spotter_output.date >= '."'".$begindate."'".' AND spotter_output.date <= '."'".$enddate."'".'
                        	    '.$filter_query.' LIMIT 200 OFFSET 0';
//                        	    .' GROUP BY spotter_output.flightaware_id, spotter_output.ident, spotter_output.aircraft_icao, spotter_output.departure_airport_icao, spotter_output.arrival_airport_icao, spotter_output.latitude, spotter_output.longitude, spotter_output.altitude, spotter_output.heading, spotter_output.ground_speed, spotter_output.squawk, a.aircraft_shadow';
                        	    
                }
                //echo $query;
                try {
                        $sth = $this->db->prepare($query);

The variable $query does not seem to be defined for all execution paths leading up to this point.

The method prepare cannot be called on $this->db (of type null).

                        $sth->execute();
                } catch(PDOException $e) {
                        return $e->getMessage();

The return type of return $e->getMessage(); (string) is incompatible with the return type documented by SpotterArchive::getMinLiveSpotterDataPlayback of type array.

                }
                $spotter_array = $sth->fetchAll(PDO::FETCH_ASSOC);

                return $spotter_array;
        }

	 /**
        * Gets count Live Spotter data
        *
        * @return Array the spotter information
        *
        */
        public function getLiveSpotterCount($begindate,$enddate,$filter = array())
        {
                global $globalDBdriver, $globalLiveInterval;
                date_default_timezone_set('UTC');

                $filter_query = '';
                if (isset($filter['source']) && !empty($filter['source'])) {

This code seems to be duplicated across your project.

                        $filter_query .= " AND format_source IN ('".implode("','",$filter['source'])."') ";
                }
                if (isset($filter['airlines']) && !empty($filter['airlines'])) {
                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_output WHERE spotter_output.airline_icao IN ('".implode("','",$filter['airlines'])."')) so ON so.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['airlinestype']) && !empty($filter['airlinestype'])) {
                        $filter_query .= " INNER JOIN (SELECT flightaware_id FROM spotter_output WHERE spotter_output.airline_type = '".$filter['airlinestype']."') sa ON sa.flightaware_id = spotter_archive.flightaware_id ";
                }
                if (isset($filter['source_aprs']) && !empty($filter['source_aprs'])) {

This code seems to be duplicated across your project.

                        $filter_query = " AND format_source = 'aprs' AND source_name IN ('".implode("','",$filter['source_aprs'])."')";
                }

                //if (!isset($globalLiveInterval)) $globalLiveInterval = '200';
                if ($globalDBdriver == 'mysql') {
			$query = 'SELECT COUNT(DISTINCT flightaware_id) as nb 
			FROM spotter_archive l 
			WHERE (l.date BETWEEN DATE_SUB('."'".$begindate."'".',INTERVAL '.$globalLiveInterval.' SECOND) AND '."'".$begindate."'".')'.$filter_query;

                } else if ($globalDBdriver == 'pgsql') {
			$query = 'SELECT COUNT(DISTINCT flightaware_id) as nb FROM spotter_archive l WHERE (l.date BETWEEN '."'".$begindate."' - INTERVAL '".$globalLiveInterval." SECONDS' AND "."'".$enddate."'".')'.$filter_query;
                }
                //echo $query;
                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute();
                } catch(PDOException $e) {
                        return "error";
                }
		$result = $sth->fetch(PDO::FETCH_ASSOC);
                return $result['nb'];

        }



	// Spotter_Archive_output
	
    /**
    * Gets all the spotter information
    *
    * @return Array the spotter information
    *
    */
    public function searchSpotterData($q = '', $registration = '', $aircraft_icao = '', $aircraft_manufacturer = '', $highlights = '', $airline_icao = '', $airline_country = '', $airline_type = '', $airport = '', $airport_country = '', $callsign = '', $departure_airport_route = '', $arrival_airport_route = '', $owner = '',$pilot_id = '',$pilot_name = '',$altitude = '', $date_posted = '', $limit = '', $sort = '', $includegeodata = '',$origLat = '',$origLon = '',$dist = '')
    {
	global $globalTimezone, $globalDbdriver;
	require_once(dirname(__FILE__).'/class.Translation.php');
	$Translation = new Translation();

	date_default_timezone_set('UTC');
	
	$query_values = array();
	$additional_query = '';
	if ($q != "")
	{
	    if (!is_string($q))
	    {
		return false;
	    } else {
	        
		$q_array = explode(" ", $q);
		
		foreach ($q_array as $q_item){
		    $additional_query .= " AND (";
		    $additional_query .= "(spotter_archive_output.spotter_id like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.aircraft_icao like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.aircraft_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.aircraft_manufacturer like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.airline_icao like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.airline_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.airline_country like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.departure_airport_icao like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.departure_airport_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.departure_airport_city like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.departure_airport_country like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.arrival_airport_icao like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.arrival_airport_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.arrival_airport_city like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.arrival_airport_country like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.registration like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.owner_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.pilot_id like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.pilot_name like '%".$q_item."%') OR ";
		    $additional_query .= "(spotter_archive_output.ident like '%".$q_item."%') OR ";
		    $translate = $Translation->ident2icao($q_item);
		    if ($translate != $q_item) $additional_query .= "(spotter_archive_output.ident like '%".$translate."%') OR ";
		    $additional_query .= "(spotter_archive_output.highlight like '%".$q_item."%')";
		    $additional_query .= ")";
		}
	    }
	}
	
	if ($registration != "")
	{
	    $registration = filter_var($registration,FILTER_SANITIZE_STRING);
	    if (!is_string($registration))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.registration = '".$registration."')";
	    }
	}
	
	if ($aircraft_icao != "")
	{
	    $aircraft_icao = filter_var($aircraft_icao,FILTER_SANITIZE_STRING);
	    if (!is_string($aircraft_icao))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.aircraft_icao = '".$aircraft_icao."')";
	    }
	}
	
	if ($aircraft_manufacturer != "")
	{
	    $aircraft_manufacturer = filter_var($aircraft_manufacturer,FILTER_SANITIZE_STRING);
	    if (!is_string($aircraft_manufacturer))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.aircraft_manufacturer = '".$aircraft_manufacturer."')";
	    }
	}
	
	if ($highlights == "true")
	{
	    if (!is_string($highlights))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.highlight <> '')";
	    }
	}
	
	if ($airline_icao != "")
	{
	    $registration = filter_var($airline_icao,FILTER_SANITIZE_STRING);
	    if (!is_string($airline_icao))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.airline_icao = '".$airline_icao."')";
	    }
	}
	
	if ($airline_country != "")
	{
	    $airline_country = filter_var($airline_country,FILTER_SANITIZE_STRING);
	    if (!is_string($airline_country))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.airline_country = '".$airline_country."')";
	    }
	}
	
	if ($airline_type != "")
	{
	    $airline_type = filter_var($airline_type,FILTER_SANITIZE_STRING);
	    if (!is_string($airline_type))
	    {
		return false;
	    } else {
		if ($airline_type == "passenger")
		{
		    $additional_query .= " AND (spotter_archive_output.airline_type = 'passenger')";
		}
		if ($airline_type == "cargo")
		{
		    $additional_query .= " AND (spotter_archive_output.airline_type = 'cargo')";
		}
		if ($airline_type == "military")
		{
		    $additional_query .= " AND (spotter_archive_output.airline_type = 'military')";
		}
	    }
	}
	
	if ($airport != "")
	{
	    $airport = filter_var($airport,FILTER_SANITIZE_STRING);
	    if (!is_string($airport))
	    {
		return false;
	    } else {
		$additional_query .= " AND ((spotter_archive_output.departure_airport_icao = '".$airport."') OR (spotter_archive_output.arrival_airport_icao = '".$airport."'))";
	    }
	}
	
	if ($airport_country != "")
	{
	    $airport_country = filter_var($airport_country,FILTER_SANITIZE_STRING);
	    if (!is_string($airport_country))
	    {
		return false;
	    } else {
		$additional_query .= " AND ((spotter_archive_output.departure_airport_country = '".$airport_country."') OR (spotter_archive_output.arrival_airport_country = '".$airport_country."'))";
	    }
	}
    
	if ($callsign != "")
	{
	    $callsign = filter_var($callsign,FILTER_SANITIZE_STRING);
	    if (!is_string($callsign))
	    {
		return false;
	    } else {
		$translate = $Translation->ident2icao($callsign);
		if ($translate != $callsign) {
			$additional_query .= " AND (spotter_archive_output.ident = :callsign OR spotter_archive_output.ident = :translate)";
			$query_values = array_merge($query_values,array(':callsign' => $callsign,':translate' => $translate));
		} else {
			$additional_query .= " AND (spotter_archive_output.ident = '".$callsign."')";
		}
	    }
	}

	if ($owner != "")
	{
	    $owner = filter_var($owner,FILTER_SANITIZE_STRING);
	    if (!is_string($owner))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.owner_name = '".$owner."')";
	    }
	}

	if ($pilot_name != "")
	{
	    $pilot_name = filter_var($pilot_name,FILTER_SANITIZE_STRING);
	    if (!is_string($pilot_name))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.pilot_name = '".$pilot_name."')";
	    }
	}
	
	if ($pilot_id != "")
	{
	    $pilot_id = filter_var($pilot_id,FILTER_SANITIZE_NUMBER_INT);
	    if (!is_string($pilot_id))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.pilot_id = '".$pilot_id."')";
	    }
	}
	
	if ($departure_airport_route != "")
	{
	    $departure_airport_route = filter_var($departure_airport_route,FILTER_SANITIZE_STRING);
	    if (!is_string($departure_airport_route))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.departure_airport_icao = '".$departure_airport_route."')";
	    }
	}
	
	if ($arrival_airport_route != "")
	{
	    $arrival_airport_route = filter_var($arrival_airport_route,FILTER_SANITIZE_STRING);
	    if (!is_string($arrival_airport_route))
	    {
		return false;
	    } else {
		$additional_query .= " AND (spotter_archive_output.arrival_airport_icao = '".$arrival_airport_route."')";
	    }
	}
	
	if ($altitude != "")
	{
	    $altitude_array = explode(",", $altitude);
	    
	    $altitude_array[0] = filter_var($altitude_array[0],FILTER_SANITIZE_NUMBER_FLOAT,FILTER_FLAG_ALLOW_FRACTION);
	    $altitude_array[1] = filter_var($altitude_array[1],FILTER_SANITIZE_NUMBER_FLOAT,FILTER_FLAG_ALLOW_FRACTION);
	    

	    if ($altitude_array[1] != "")
	    {                
		$altitude_array[0] = substr($altitude_array[0], 0, -2);
		$altitude_array[1] = substr($altitude_array[1], 0, -2);
		$additional_query .= " AND altitude BETWEEN '".$altitude_array[0]."' AND '".$altitude_array[1]."' ";
	    } else {
		$altitude_array[0] = substr($altitude_array[0], 0, -2);
		$additional_query .= " AND altitude <= '".$altitude_array[0]."' ";
	    }
	}
	
	if ($date_posted != "")
	{
	    $date_array = explode(",", $date_posted);
	    
	    $date_array[0] = filter_var($date_array[0],FILTER_SANITIZE_STRING);
	    $date_array[1] = filter_var($date_array[1],FILTER_SANITIZE_STRING);
	    
	    if ($globalTimezone != '') {
		date_default_timezone_set($globalTimezone);
		$datetime = new DateTime();
		$offset = $datetime->format('P');
	    } else $offset = '+00:00';


	    if ($date_array[1] != "")
	    {                
		$date_array[0] = date("Y-m-d H:i:s", strtotime($date_array[0]));
		$date_array[1] = date("Y-m-d H:i:s", strtotime($date_array[1]));
		if ($globalDBdriver == 'mysql') {
			$additional_query .= " AND TIMESTAMP(CONVERT_TZ(spotter_archive_output.date,'+00:00', '".$offset."')) >= '".$date_array[0]."' AND TIMESTAMP(CONVERT_TZ(spotter_archive_output.date,'+00:00', '".$offset."')) <= '".$date_array[1]."' ";
		} else {
			$additional_query .= " AND spotter_archive_output.date::timestamp AT TIME ZONE INTERVAL ".$offset." >= CAST('".$date_array[0]."' AS TIMESTAMP) AND spotter_archive_output.date::timestamp AT TIME ZONE INTERVAL ".$offset." <= CAST('".$date_array[1]."' AS TIMESTAMP) ";
		}
	    } else {
		$date_array[0] = date("Y-m-d H:i:s", strtotime($date_array[0]));
                if ($globalDBdriver == 'mysql') {
			$additional_query .= " AND TIMESTAMP(CONVERT_TZ(spotter_archive_output.date,'+00:00', '".$offset."')) >= '".$date_array[0]."' ";
		} else {
			$additional_query .= " AND spotter_archive_output.date::timestamp AT TIME ZONE INTERVAL ".$offset." >= CAST('".$date_array[0]."' AS TIMESTAMP) ";
		}
	    }
	}
	
	if ($limit != "")
	{
	    $limit_array = explode(",", $limit);
	    
	    $limit_array[0] = filter_var($limit_array[0],FILTER_SANITIZE_NUMBER_INT);
	    $limit_array[1] = filter_var($limit_array[1],FILTER_SANITIZE_NUMBER_INT);
	    
	    if ($limit_array[0] >= 0 && $limit_array[1] >= 0)
	    {
		//$limit_query = " LIMIT ".$limit_array[0].",".$limit_array[1];
		$limit_query = " LIMIT ".$limit_array[1]." OFFSET ".$limit_array[0];
	    }
	}
	

	if ($origLat != "" && $origLon != "" && $dist != "") {
		$dist = number_format($dist*0.621371,2,'.','');
		$query="SELECT spotter_output.*, 3956 * 2 * ASIN(SQRT( POWER(SIN(($origLat - ABS(CAST(spotter_archive.latitude as double precision)))*pi()/180/2),2)+COS( $origLat *pi()/180)*COS(ABS(CAST(spotter_archive.latitude as double precision))*pi()/180)*POWER(SIN(($origLon-CAST(spotter_archive.longitude as double precision))*pi()/180/2),2))) as distance 
                          FROM spotter_output_archive, spotter_archive WHERE spotter_output_archive.flightaware_id = spotter_archive.flightaware_id AND spotter_output.ident <> '' ".$additional_query."AND CAST(spotter_archive.longitude as double precision) between ($origLon-$dist/ABS(cos(radians($origLat))*69)) and ($origLon+$dist/ABS(cos(radians($origLat))*69)) and CAST(spotter_archive.latitude as double precision) between ($origLat-($dist/69)) and ($origLat+($dist/69)) 
                          AND (3956 * 2 * ASIN(SQRT( POWER(SIN(($origLat - ABS(CAST(spotter_archive.latitude as double precision)))*pi()/180/2),2)+COS( $origLat *pi()/180)*COS(ABS(CAST(spotter_archive.latitude as double precision))*pi()/180)*POWER(SIN(($origLon-CAST(spotter_archive.longitude as double precision))*pi()/180/2),2)))) < $dist ORDER BY distance";
	} else {
		if ($sort != "")
		{
			$search_orderby_array = $this->getOrderBy();
			$orderby_query = $search_orderby_array[$sort]['sql'];
		} else {
			$orderby_query = " ORDER BY spotter_archive_output.date DESC";
		}
	
		if ($includegeodata == "true")
		{
			$additional_query .= " AND (spotter_archive_output.waypoints <> '')";
		}

		$query  = "SELECT spotter_archive_output.* FROM spotter_archive_output 
		    WHERE spotter_archive_output.ident <> '' 
		    ".$additional_query."
		    ".$orderby_query;
	}
	$Spotter = new Spotter($this->db);
	$spotter_array = $Spotter->getDataFromDB($query, array(),$limit_query);

	return $spotter_array;
    }

    public function deleteSpotterArchiveData()
    {
		global $globalArchiveKeepMonths, $globalDBdriver;
                date_default_timezone_set('UTC');
                if ($globalDBdriver == 'mysql') {
			$query = 'DELETE FROM spotter_archive_output WHERE spotter_archive_output.date < DATE_SUB(UTC_TIMESTAMP(), INTERVAL '.$globalArchiveKeepMonths.' MONTH)';
		} else {
			$query = "DELETE FROM spotter_archive_output WHERE spotter_archive_output.date < CURRENT_TIMESTAMP AT TIME ZONE 'UTC' - INTERVAL '".$globalArchiveKeepMonths." MONTH'";
		}
                try {
                        $sth = $this->db->prepare($query);
                        $sth->execute();
                } catch(PDOException $e) {
                        return "error";
                }
	}

    /**
    * Gets all the spotter information based on the callsign
    *
    * @return Array the spotter information
    *
    */
    public function getSpotterDataByIdent($ident = '', $limit = '', $sort = '')
    {
	$global_query = "SELECT spotter_archive_output.* FROM spotter_archive_output";
	
	date_default_timezone_set('UTC');
	
	$query_values = array();
	
	if ($ident != "")
	{
	    if (!is_string($ident))
	    {
		return false;
	    } else {
		$additional_query = " AND (spotter_archive_output.ident = :ident)";
		$query_values = array(':ident' => $ident);
	    }
	}
	
	if ($limit != "")
	{
	    $limit_array = explode(",", $limit);
	    
	    $limit_array[0] = filter_var($limit_array[0],FILTER_SANITIZE_NUMBER_INT);
	    $limit_array[1] = filter_var($limit_array[1],FILTER_SANITIZE_NUMBER_INT);
	    
	    if ($limit_array[0] >= 0 && $limit_array[1] >= 0)
	    {
		//$limit_query = " LIMIT ".$limit_array[0].",".$limit_array[1];
		$limit_query = " LIMIT ".$limit_array[1]." OFFSET ".$limit_array[0];
	    }
	}

	if ($sort != "")
	{
	    $search_orderby_array = $this->getOrderBy();
	    $orderby_query = $search_orderby_array[$sort]['sql'];
	} else {
	    $orderby_query = " ORDER BY spotter_archive_output.date DESC";
	}

	$query = $global_query." WHERE spotter_archive_output.ident <> '' ".$additional_query." ".$orderby_query;

	$Spotter = new Spotter($this->db);
	$spotter_array = $Spotter->getDataFromDB($query, $query_values, $limit_query);

	return $spotter_array;
    }

    /**
    * Gets all number of flight over countries
    *
    * @return Array the airline country list
    *
    */
    public function countAllFlightOverCountries($limit = true,$olderthanmonths = 0,$sincedate = '')
    {
	global $globalDBdriver;
	/*

56% of this comment could be valid code. Did you maybe forget this after debugging?

	$query = "SELECT c.name, c.iso3, c.iso2, count(c.name) as nb 
		    FROM countries c, spotter_archive s
		    WHERE Within(GeomFromText(CONCAT('POINT(',s.longitude,' ',s.latitude,')')), ogc_geom) ";
	*/
	$query = "SELECT c.name, c.iso3, c.iso2, count(c.name) as nb
		    FROM countries c, spotter_archive s
		    WHERE c.iso2 = s.over_country ";
                if ($olderthanmonths > 0) {
            		if ($globalDBdriver == 'mysql') {
				$query .= 'AND date < DATE_SUB(UTC_TIMESTAMP(),INTERVAL '.$olderthanmonths.' MONTH) ';
			} else {
				$query .= "AND date < CURRENT_TIMESTAMP AT TIME ZONE 'UTC' - INTERVAL '".$olderthanmonths." MONTHS'";
			}
		}
                if ($sincedate != '') $query .= "AND date > '".$sincedate."' ";
	$query .= "GROUP BY c.name, c.iso3, c.iso2 ORDER BY nb DESC";
	if ($limit) $query .= " LIMIT 0,10";
      
	
	$sth = $this->db->prepare($query);

The method prepare cannot be called on $this->db (of type null).

	$sth->execute();
 
	$flight_array = array();
	$temp_array = array();
        
	while($row = $sth->fetch(PDO::FETCH_ASSOC))
	{
	    $temp_array['flight_count'] = $row['nb'];
	    $temp_array['flight_country'] = $row['name'];
	    $temp_array['flight_country_iso3'] = $row['iso3'];
	    $temp_array['flight_country_iso2'] = $row['iso2'];
	    $flight_array[] = $temp_array;
	}
	return $flight_array;
    }

}
?>