Inspection of "Fix menu for acars" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 73f088...7f17b6 )

by Yannick

created 2016-08-04 14:18 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['aircraft_manufacturer'])) {
-        header('Location: '.$globalURL.'/manufacturer');
-        die();
+		header('Location: '.$globalURL.'/manufacturer');
+		die();
 }
 $Spotter = new Spotter();
 $manufacturer = ucwords(str_replace("-", " ", filter_input(INPUT_GET,'aircraft_manufacturer',FILTER_SANITIZE_STRING)));

Please login to merge, or discard this patch.

airport-statistics-route.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['airport'])) {
-        header('Location: '.$globalURL.'/airport');
-        die();
+		header('Location: '.$globalURL.'/airport');
+		die();
 }
 $airport = filter_input(INPUT_GET,'airport',FILTER_SANITIZE_STRING);
 $Spotter = new Spotter();

Please login to merge, or discard this patch.

country-statistics-aircraft.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['country'])) {
-        header('Location: '.$globalURL.'/country');
-        die();
+		header('Location: '.$globalURL.'/country');
+		die();
 }
 $Spotter = new Spotter();
 $country = ucwords(str_replace("-", " ", filter_input(INPUT_GET,'country',FILTER_SANITIZE_STRING)));

Please login to merge, or discard this patch.

search-gpx.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -4,55 +4,55 @@
 block discarded – undo
 require_once('require/class.Language.php');
 $Spotter = new Spotter();
 if (isset($_GET['start_date'])) {
-        //for the date manipulation into the query
-        if($_GET['start_date'] != "" && $_GET['end_date'] != ""){
-                $start_date = $_GET['start_date'].":00";
-                $end_date = $_GET['end_date'].":00";
-                $sql_date = $start_date.",".$end_date;
-        } else if($_GET['start_date'] != ""){
-                $start_date = $_GET['start_date'].":00";
-                $sql_date = $start_date;
-        } else if($_GET['start_date'] == "" && $_GET['end_date'] != ""){
-                $end_date = date("Y-m-d H:i:s", strtotime("2014-04-12")).",".$_GET['end_date'].":00";
-                $sql_date = $end_date;
-        } else $sql_date = '';
+		//for the date manipulation into the query
+		if($_GET['start_date'] != "" && $_GET['end_date'] != ""){
+				$start_date = $_GET['start_date'].":00";
+				$end_date = $_GET['end_date'].":00";
+				$sql_date = $start_date.",".$end_date;
+		} else if($_GET['start_date'] != ""){
+				$start_date = $_GET['start_date'].":00";
+				$sql_date = $start_date;
+		} else if($_GET['start_date'] == "" && $_GET['end_date'] != ""){
+				$end_date = date("Y-m-d H:i:s", strtotime("2014-04-12")).",".$_GET['end_date'].":00";
+				$sql_date = $end_date;
+		} else $sql_date = '';
 } else $sql_date = '';
 
 if (isset($_GET['highest_altitude'])) {
-        //for altitude manipulation
-        if($_GET['highest_altitude'] != "" && $_GET['lowest_altitude'] != ""){
-                $end_altitude = $_GET['highest_altitude'];
-                $start_altitude = $_GET['lowest_altitude'];
-                $sql_altitude = $start_altitude.",".$end_altitude;
-        } else if($_GET['highest_altitude'] != ""){
-                $end_altitude = $_GET['highest_altitude'];
-                $sql_altitude = $end_altitude;
-        } else if($_GET['highest_altitude'] == "" && $_GET['lowest_altitude'] != ""){
-                $start_altitude = $_GET['lowest_altitude'].",60000";
-                $sql_altitude = $start_altitude;
-        } else $sql_altitude = '';
+		//for altitude manipulation
+		if($_GET['highest_altitude'] != "" && $_GET['lowest_altitude'] != ""){
+				$end_altitude = $_GET['highest_altitude'];
+				$start_altitude = $_GET['lowest_altitude'];
+				$sql_altitude = $start_altitude.",".$end_altitude;
+		} else if($_GET['highest_altitude'] != ""){
+				$end_altitude = $_GET['highest_altitude'];
+				$sql_altitude = $end_altitude;
+		} else if($_GET['highest_altitude'] == "" && $_GET['lowest_altitude'] != ""){
+				$start_altitude = $_GET['lowest_altitude'].",60000";
+				$sql_altitude = $start_altitude;
+		} else $sql_altitude = '';
 } else $sql_altitude = '';
 
 //calculuation for the pagination
 if(!isset($_GET['limit']))
 {
-        if (!isset($_GET['number_results']))
-        {
-                $limit_start = 0;
-                $limit_end = 25;
-                $absolute_difference = 25;
-        } else {
-                if ($_GET['number_results'] > 1000){
-                        $_GET['number_results'] = 1000;
-                }
-                $limit_start = 0;
-                $limit_end = $_GET['number_results'];
-                $absolute_difference = $_GET['number_results'];
-        }
+		if (!isset($_GET['number_results']))
+		{
+				$limit_start = 0;
+				$limit_end = 25;
+				$absolute_difference = 25;
+		} else {
+				if ($_GET['number_results'] > 1000){
+						$_GET['number_results'] = 1000;
+				}
+				$limit_start = 0;
+				$limit_end = $_GET['number_results'];
+				$absolute_difference = $_GET['number_results'];
+		}
 }  else {
-        $limit_explode = explode(",", $_GET['limit']);
-        $limit_start = $limit_explode[0];
-        $limit_end = $limit_explode[1];
+		$limit_explode = explode(",", $_GET['limit']);
+		$limit_start = $limit_explode[0];
+		$limit_end = $limit_explode[1];
 }
 
 $absolute_difference = abs($limit_start - $limit_end);

Please login to merge, or discard this patch.

country-statistics-manufacturer.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['country'])) {
-        header('Location: '.$globalURL.'/country');
-        die();
+		header('Location: '.$globalURL.'/country');
+		die();
 }
 $Spotter = new Spotter();
 $country = ucwords(str_replace("-", " ", filter_input(INPUT_GET,'country',FILTER_SANITIZE_STRING)));

Please login to merge, or discard this patch.

ident-statistics-departure-airport-country.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['ident'])) {
-        header('Location: '.$globalURL.'/ident');
-        die();
+		header('Location: '.$globalURL.'/ident');
+		die();
 }
 $Spotter = new Spotter();
 $ident = filter_input(INPUT_GET,'ident',FILTER_SANITIZE_STRING);

Please login to merge, or discard this patch.

aircraft-statistics-registration.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,8 +4,8 @@
 block discarded – undo
 require_once('require/class.Language.php');
 
 if (!isset($_GET['aircraft_type'])) {
-        header('Location: '.$globalURL.'/aircraft');
-        die();
+		header('Location: '.$globalURL.'/aircraft');
+		die();
 }
 $aircraft_type = filter_input(INPUT_GET,'aircraft_type',FILTER_SANITIZE_STRING);
 $Spotter = new Spotter();

Please login to merge, or discard this patch.

airline-statistics-route.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,8 @@
 block discarded – undo
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['airline'])) {
-        header('Location: '.$globalURL.'/airline');
-        die();
+		header('Location: '.$globalURL.'/airline');
+		die();
 }
 $airline = filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
 $Spotter = new Spotter();

Please login to merge, or discard this patch.

route-statistics-time.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
           function drawChart() {
             var data = google.visualization.arrayToDataTable([
             	["'._("Hour").'", "'._("# of Flights").'"], ';
-            	$hour_data = '';
+				$hour_data = '';
 	foreach($hour_array as $hour_item)
 	{
 		$hour_data .= '[ "'.date("ga", strtotime($hour_item['hour_name'].":00")).'",'.$hour_item['hour_count'].'],';

Please login to merge, or discard this patch.

		@@ -3,8 +3,8 @@
		block discarded – undo
3	3	require_once('require/class.Spotter.php');
4	4	require_once('require/class.Language.php');
5	5	if (!isset($_GET['aircraft_manufacturer'])) {
6		- header('Location: '.$globalURL.'/manufacturer');
7		- die();
	6	+ header('Location: '.$globalURL.'/manufacturer');
	7	+ die();
8	8	}
9	9	$Spotter = new Spotter();
10	10	$manufacturer = ucwords(str_replace("-", " ", filter_input(INPUT_GET,'aircraft_manufacturer',FILTER_SANITIZE_STRING)));

		@@ -4,55 +4,55 @@
		block discarded – undo
4	4	require_once('require/class.Language.php');
5	5	$Spotter = new Spotter();
6	6	if (isset($_GET['start_date'])) {
7		- //for the date manipulation into the query
8		- if($_GET['start_date'] != "" && $_GET['end_date'] != ""){
9		- $start_date = $_GET['start_date'].":00";
10		- $end_date = $_GET['end_date'].":00";
11		- $sql_date = $start_date.",".$end_date;
12		- } else if($_GET['start_date'] != ""){
13		- $start_date = $_GET['start_date'].":00";
14		- $sql_date = $start_date;
15		- } else if($_GET['start_date'] == "" && $_GET['end_date'] != ""){
16		- $end_date = date("Y-m-d H:i:s", strtotime("2014-04-12")).",".$_GET['end_date'].":00";
17		- $sql_date = $end_date;
18		- } else $sql_date = '';
	7	+ //for the date manipulation into the query
	8	+ if($_GET['start_date'] != "" && $_GET['end_date'] != ""){
	9	+ $start_date = $_GET['start_date'].":00";
	10	+ $end_date = $_GET['end_date'].":00";
	11	+ $sql_date = $start_date.",".$end_date;
	12	+ } else if($_GET['start_date'] != ""){
	13	+ $start_date = $_GET['start_date'].":00";
	14	+ $sql_date = $start_date;
	15	+ } else if($_GET['start_date'] == "" && $_GET['end_date'] != ""){
	16	+ $end_date = date("Y-m-d H:i:s", strtotime("2014-04-12")).",".$_GET['end_date'].":00";
	17	+ $sql_date = $end_date;
	18	+ } else $sql_date = '';
19	19	} else $sql_date = '';
20	20
21	21	if (isset($_GET['highest_altitude'])) {
22		- //for altitude manipulation
23		- if($_GET['highest_altitude'] != "" && $_GET['lowest_altitude'] != ""){
24		- $end_altitude = $_GET['highest_altitude'];
25		- $start_altitude = $_GET['lowest_altitude'];
26		- $sql_altitude = $start_altitude.",".$end_altitude;
27		- } else if($_GET['highest_altitude'] != ""){
28		- $end_altitude = $_GET['highest_altitude'];
29		- $sql_altitude = $end_altitude;
30		- } else if($_GET['highest_altitude'] == "" && $_GET['lowest_altitude'] != ""){
31		- $start_altitude = $_GET['lowest_altitude'].",60000";
32		- $sql_altitude = $start_altitude;
33		- } else $sql_altitude = '';
	22	+ //for altitude manipulation
	23	+ if($_GET['highest_altitude'] != "" && $_GET['lowest_altitude'] != ""){
	24	+ $end_altitude = $_GET['highest_altitude'];
	25	+ $start_altitude = $_GET['lowest_altitude'];
	26	+ $sql_altitude = $start_altitude.",".$end_altitude;
	27	+ } else if($_GET['highest_altitude'] != ""){
	28	+ $end_altitude = $_GET['highest_altitude'];
	29	+ $sql_altitude = $end_altitude;
	30	+ } else if($_GET['highest_altitude'] == "" && $_GET['lowest_altitude'] != ""){
	31	+ $start_altitude = $_GET['lowest_altitude'].",60000";
	32	+ $sql_altitude = $start_altitude;
	33	+ } else $sql_altitude = '';
34	34	} else $sql_altitude = '';
35	35
36	36	//calculuation for the pagination
37	37	if(!isset($_GET['limit']))
38	38	{
39		- if (!isset($_GET['number_results']))
40		- {
41		- $limit_start = 0;
42		- $limit_end = 25;
43		- $absolute_difference = 25;
44		- } else {
45		- if ($_GET['number_results'] > 1000){
46		- $_GET['number_results'] = 1000;
47		- }
48		- $limit_start = 0;
49		- $limit_end = $_GET['number_results'];
50		- $absolute_difference = $_GET['number_results'];
51		- }
	39	+ if (!isset($_GET['number_results']))
	40	+ {
	41	+ $limit_start = 0;
	42	+ $limit_end = 25;
	43	+ $absolute_difference = 25;
	44	+ } else {
	45	+ if ($_GET['number_results'] > 1000){
	46	+ $_GET['number_results'] = 1000;
	47	+ }
	48	+ $limit_start = 0;
	49	+ $limit_end = $_GET['number_results'];
	50	+ $absolute_difference = $_GET['number_results'];
	51	+ }
52	52	} else {
53		- $limit_explode = explode(",", $_GET['limit']);
54		- $limit_start = $limit_explode[0];
55		- $limit_end = $limit_explode[1];
	53	+ $limit_explode = explode(",", $_GET['limit']);
	54	+ $limit_start = $limit_explode[0];
	55	+ $limit_end = $limit_explode[1];
56	56	}
57	57
58	58	$absolute_difference = abs($limit_start - $limit_end);

		@@ -4,8 +4,8 @@
		block discarded – undo
4	4	require_once('require/class.Language.php');
5	5
6	6	if (!isset($_GET['aircraft_type'])) {
7		- header('Location: '.$globalURL.'/aircraft');
8		- die();
	7	+ header('Location: '.$globalURL.'/aircraft');
	8	+ die();
9	9	}
10	10	$aircraft_type = filter_input(INPUT_GET,'aircraft_type',FILTER_SANITIZE_STRING);
11	11	$Spotter = new Spotter();

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34	function drawChart() {
35	35	var data = google.visualization.arrayToDataTable([
36	36	["'._("Hour").'", "'._("# of Flights").'"], ';
37		- $hour_data = '';
	37	+ $hour_data = '';
38	38	foreach($hour_array as $hour_item)
39	39	{
40	40	$hour_data .= '[ "'.date("ga", strtotime($hour_item['hour_name'].":00")).'",'.$hour_item['hour_count'].'],';

Ysurac / FlightAirMap

Push — master ( 73f088...7f17b6 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch