Inspection of "Fix previous fix" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 637022...8149d9 )

by Yannick

created 2017-10-04 18:19 UTC

Status

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -41,7 +41,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($ariline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($ariline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($_GET['airline'] == $airline_name['airline_icao'])
@@ -64,8 +66,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-time.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-aircraft.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-departure-airport.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-route.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-manufacturer.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

airline-statistics-departure-airport-country.php 1 patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,9 @@  discard block
 block discarded – undo
 	}
 	$Stats = new Stats();
 	$airline_names = $Stats->getAllAirlineNames();
-	if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+	if (empty($airline_names)) {
+		$airline_names = $Spotter->getAllAirlineNames();
+	}
 	foreach($airline_names as $airline_name)
 	{
 		if($airline == $airline_name['airline_icao'])
@@ -65,8 +67,7 @@  discard block
 block discarded – undo
 			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
-			}
-			elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
+			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
 			{
 				print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
 			}

Please login to merge, or discard this patch.

search-ajax.php 1 patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

@@ -25,7 +25,9 @@  discard block
 block discarded – undo
 	echo json_encode($marinecnt);
 } elseif ($ask == 'manufacturer') {
 	$manufacturers = $Stats->getAllManufacturers();
-	if (empty($manufacturers)) $manufacturers = $Spotter->getAllManufacturers();
+	if (empty($manufacturers)) {
+		$manufacturers = $Spotter->getAllManufacturers();
+	}
 	$all_manufacturers = array();
 	foreach($manufacturers as $manufacturer)
 	{
@@ -34,7 +36,9 @@  discard block
 block discarded – undo
 	echo json_encode($all_manufacturers);
 } elseif ($ask == 'aircrafttypes') {
 	$aircraft_types = $Stats->getAllAircraftTypes();
-	if (empty($aircraft_types)) $aircraft_types = $Spotter->getAllAircraftTypes();
+	if (empty($aircraft_types)) {
+		$aircraft_types = $Spotter->getAllAircraftTypes();
+	}
 	$all_aircraft_types = array();
 	foreach($aircraft_types as $aircraft_type)
 	{
@@ -59,7 +63,9 @@  discard block
 block discarded – undo
 	echo json_encode($all_airline_countries);
 } elseif ($ask == 'airportnames' || $ask == 'departureairportnames' || $ask == 'arrivalairportnames') {
 	$airport_names = $Stats->getAllAirportNames();
-	if (empty($airport_names)) $airport_names = $Spotter->getAllAirportNames();
+	if (empty($airport_names)) {
+		$airport_names = $Spotter->getAllAirportNames();
+	}
 	ksort($airport_names);
 	$all_airport_names = array();
 	foreach($airport_names as $airport_name)

Please login to merge, or discard this patch.

space-data.php 1 patch

Braces +8 added lines, -3 removed lines patch added patch discarded remove patch

@@ -81,10 +81,15 @@
 block discarded – undo
 //	$launch_date = '15 November 1974';
 } else {
 	$ident = $sat;
-	if (strpos($sat,'(')) $satname = $sat;
-	else $satname = str_replace(array(' '),'-',$sat);
+	if (strpos($sat,'(')) {
+		$satname = $sat;
+	} else {
+		$satname = str_replace(array(' '),'-',$sat);
+	}
+	}
+if (!isset($satname)) {
+	$satname = $sat;
 }
-if (!isset($satname)) $satname = $sat;
 $info = $Satellite->get_info(strtolower(trim($satname)));
 $position = $Satellite->position($sat);
 $ground_speed = $position['speed'];

Please login to merge, or discard this patch.

		@@ -81,10 +81,15 @@
		block discarded – undo
81	81	// $launch_date = '15 November 1974';
82	82	} else {
83	83	$ident = $sat;
84		- if (strpos($sat,'(')) $satname = $sat;
85		- else $satname = str_replace(array(' '),'-',$sat);
	84	+ if (strpos($sat,'(')) {
	85	+ $satname = $sat;
	86	+ } else {
	87	+ $satname = str_replace(array(' '),'-',$sat);
	88	+ }
	89	+ }
	90	+if (!isset($satname)) {
	91	+ $satname = $sat;
86	92	}
87		-if (!isset($satname)) $satname = $sat;
88	93	$info = $Satellite->get_info(strtolower(trim($satname)));
89	94	$position = $Satellite->position($sat);
90	95	$ground_speed = $position['speed'];

		@@ -41,7 +41,9 @@ discard block
		block discarded – undo
41	41	}
42	42	$Stats = new Stats();
43	43	$airline_names = $Stats->getAllAirlineNames();
44		- if (empty($ariline_names)) $airline_names = $Spotter->getAllAirlineNames();
	44	+ if (empty($ariline_names)) {
	45	+ $airline_names = $Spotter->getAllAirlineNames();
	46	+ }
45	47	foreach($airline_names as $airline_name)
46	48	{
47	49	if($_GET['airline'] == $airline_name['airline_icao'])
		@@ -64,8 +66,7 @@ discard block
		block discarded – undo
64	66	if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
65	67	{
66	68	print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
67		- }
68		- elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
	69	+ } elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
69	70	{
70	71	print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
71	72	}

		@@ -42,7 +42,9 @@ discard block
		block discarded – undo
42	42	}
43	43	$Stats = new Stats();
44	44	$airline_names = $Stats->getAllAirlineNames();
45		- if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
	45	+ if (empty($airline_names)) {
	46	+ $airline_names = $Spotter->getAllAirlineNames();
	47	+ }
46	48	foreach($airline_names as $airline_name)
47	49	{
48	50	if($airline == $airline_name['airline_icao'])
		@@ -65,8 +67,7 @@ discard block
		block discarded – undo
65	67	if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif'))
66	68	{
67	69	print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.gif" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
68		- }
69		- elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
	70	+ } elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png'))
70	71	{
71	72	print '<img src="'.$globalURL.'/images/airlines/'.$spotter_array[0]['airline_icao'].'.png" alt="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" title="'.$spotter_array[0]['airline_name'].' ('.$spotter_array[0]['airline_icao'].')" class="logo" />';
72	73	}

		@@ -25,7 +25,9 @@ discard block
		block discarded – undo
25	25	echo json_encode($marinecnt);
26	26	} elseif ($ask == 'manufacturer') {
27	27	$manufacturers = $Stats->getAllManufacturers();
28		- if (empty($manufacturers)) $manufacturers = $Spotter->getAllManufacturers();
	28	+ if (empty($manufacturers)) {
	29	+ $manufacturers = $Spotter->getAllManufacturers();
	30	+ }
29	31	$all_manufacturers = array();
30	32	foreach($manufacturers as $manufacturer)
31	33	{
		@@ -34,7 +36,9 @@ discard block
		block discarded – undo
34	36	echo json_encode($all_manufacturers);
35	37	} elseif ($ask == 'aircrafttypes') {
36	38	$aircraft_types = $Stats->getAllAircraftTypes();
37		- if (empty($aircraft_types)) $aircraft_types = $Spotter->getAllAircraftTypes();
	39	+ if (empty($aircraft_types)) {
	40	+ $aircraft_types = $Spotter->getAllAircraftTypes();
	41	+ }
38	42	$all_aircraft_types = array();
39	43	foreach($aircraft_types as $aircraft_type)
40	44	{
		@@ -59,7 +63,9 @@ discard block
		block discarded – undo
59	63	echo json_encode($all_airline_countries);
60	64	} elseif ($ask == 'airportnames' \|\| $ask == 'departureairportnames' \|\| $ask == 'arrivalairportnames') {
61	65	$airport_names = $Stats->getAllAirportNames();
62		- if (empty($airport_names)) $airport_names = $Spotter->getAllAirportNames();
	66	+ if (empty($airport_names)) {
	67	+ $airport_names = $Spotter->getAllAirportNames();
	68	+ }
63	69	ksort($airport_names);
64	70	$all_airport_names = array();
65	71	foreach($airport_names as $airport_name)

Ysurac / FlightAirMap

Push — master ( 637022...8149d9 )

Status

Category

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +4 added lines, -3 removed lines patch added patch discarded remove patch

Braces +9 added lines, -3 removed lines patch added patch discarded remove patch

Braces +8 added lines, -3 removed lines patch added patch discarded remove patch