Inspection of "All Google charts replaced by C3" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f80fe...90f8d8 )

by Yannick

created 2017-06-19 16:05 UTC

Status

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -7,18 +7,18 @@  discard block
 block discarded – undo
         die();
 }
 $Spotter = new Spotter();
-$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
-$owner = filter_input(INPUT_GET,'owner',FILTER_SANITIZE_STRING);
-$year = filter_input(INPUT_GET,'year',FILTER_SANITIZE_NUMBER_INT);
-$month = filter_input(INPUT_GET,'month',FILTER_SANITIZE_NUMBER_INT);
+$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
+$owner = filter_input(INPUT_GET, 'owner', FILTER_SANITIZE_STRING);
+$year = filter_input(INPUT_GET, 'year', FILTER_SANITIZE_NUMBER_INT);
+$month = filter_input(INPUT_GET, 'month', FILTER_SANITIZE_NUMBER_INT);
 $filter = array();
-if ($year != '') $filter = array_merge($filter,array('year' => $year));
-if ($month != '') $filter = array_merge($filter,array('month' => $month));
-$spotter_array = $Spotter->getSpotterDataByOwner($owner,"0,1", $sort,$filter);
+if ($year != '') $filter = array_merge($filter, array('year' => $year));
+if ($month != '') $filter = array_merge($filter, array('month' => $month));
+$spotter_array = $Spotter->getSpotterDataByOwner($owner, "0,1", $sort, $filter);
 
 if (!empty($spotter_array))
 {
-	$title = sprintf(_("Most Common Time of Day of %s"),$spotter_array[0]['aircraft_owner']);
+	$title = sprintf(_("Most Common Time of Day of %s"), $spotter_array[0]['aircraft_owner']);
 	require_once('header.php');
 	print '<div class="info column">';
 	print '<h1>'.$spotter_array[0]['aircraft_owner'].'</h1>';
@@ -29,9 +29,9 @@  discard block
 block discarded – undo
 	include('owner-sub-menu.php');
 	print '<div class="column">';
 	print '<h2>'._("Most Common Time of Day").'</h2>';
-	print '<p>'.sprintf(_("The statistic below shows the most common time of day of flights owned by <strong>%s</strong>."),$spotter_array[0]['aircraft_owner']).'</p>';
+	print '<p>'.sprintf(_("The statistic below shows the most common time of day of flights owned by <strong>%s</strong>."), $spotter_array[0]['aircraft_owner']).'</p>';
 
-	$hour_array = $Spotter->countAllHoursByOwner($owner,$filter);
+	$hour_array = $Spotter->countAllHoursByOwner($owner, $filter);
 	print '<link href="'.$globalURL.'/css/c3.min.css" rel="stylesheet" type="text/css">';
 	print '<script type="text/javascript" src="'.$globalURL.'/js/d3.min.js"></script>';
 	print '<script type="text/javascript" src="'.$globalURL.'/js/c3.min.js"></script>';
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
 	$hour_data = '';
 	$hour_cnt = '';
 	$last = 0;
-	foreach($hour_array as $hour_item)
+	foreach ($hour_array as $hour_item)
 	{
-		while($last != $hour_item['hour_name']) {
+		while ($last != $hour_item['hour_name']) {
 			$hour_data .= '"'.$last.':00",';
 			$hour_cnt .= '0,';
 			$last++;
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 		$hour_cnt .= $hour_item['hour_count'].',';
 	}
 	$hour_data = "['x',".substr($hour_data, 0, -1)."]";
-	$hour_cnt = "['flights',".substr($hour_cnt,0,-1)."]";
+	$hour_cnt = "['flights',".substr($hour_cnt, 0, -1)."]";
 	print 'c3.generate({
 	    bindto: "#chartHour",
 	    data: {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
 		print '</thead>';
 		print '<tbody>';
 		$i = 1;
-		foreach($hour_array as $hour_item)
+		foreach ($hour_array as $hour_item)
 		{
 			print '<tr>';
 			print '<td>'.$hour_item['hour_name'].':00</td>';

Please login to merge, or discard this patch.

owner-statistics-arrival-airport-country.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -7,18 +7,18 @@  discard block
 block discarded – undo
         die();
 }
 $Spotter = new Spotter();
-$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
-$owner = filter_input(INPUT_GET,'owner',FILTER_SANITIZE_STRING);
-$year = filter_input(INPUT_GET,'year',FILTER_SANITIZE_NUMBER_INT);
-$month = filter_input(INPUT_GET,'month',FILTER_SANITIZE_NUMBER_INT);
+$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
+$owner = filter_input(INPUT_GET, 'owner', FILTER_SANITIZE_STRING);
+$year = filter_input(INPUT_GET, 'year', FILTER_SANITIZE_NUMBER_INT);
+$month = filter_input(INPUT_GET, 'month', FILTER_SANITIZE_NUMBER_INT);
 $filter = array();
-if ($year != '') $filter = array_merge($filter,array('year' => $year));
-if ($month != '') $filter = array_merge($filter,array('month' => $month));
-$spotter_array = $Spotter->getSpotterDataByOwner($owner,"0,1", $sort, $filter);
+if ($year != '') $filter = array_merge($filter, array('year' => $year));
+if ($month != '') $filter = array_merge($filter, array('month' => $month));
+$spotter_array = $Spotter->getSpotterDataByOwner($owner, "0,1", $sort, $filter);
 
 if (!empty($spotter_array))
 {
-	$title = sprintf(_("Most Common Arrival Airports by Country of %s"),$spotter_array[0]['aircraft_owner']);
+	$title = sprintf(_("Most Common Arrival Airports by Country of %s"), $spotter_array[0]['aircraft_owner']);
 	require_once('header.php');
 	print '<div class="info column">';
 	print '<h1>'.$spotter_array[0]['aircraft_owner'].'</h1>';
@@ -29,15 +29,15 @@  discard block
 block discarded – undo
 	include('owner-sub-menu.php');
 	print '<div class="column">';
 	print '<h2>'._("Most Common Arrival Airports by Country").'</h2>';
-	print '<p>'.sprintf(_("The statistic below shows all arrival airports by Country of origin of flights owned by <strong>%s</strong>."),$spotter_array[0]['aircraft_owner']).'</p>';
-	$airport_country_array = $Spotter->countAllArrivalAirportCountriesByOwner($owner,$filter);
+	print '<p>'.sprintf(_("The statistic below shows all arrival airports by Country of origin of flights owned by <strong>%s</strong>."), $spotter_array[0]['aircraft_owner']).'</p>';
+	$airport_country_array = $Spotter->countAllArrivalAirportCountriesByOwner($owner, $filter);
 	print '<script type="text/javascript" src="'.$globalURL.'/js/d3.min.js"></script>';
 	print '<script type="text/javascript" src="'.$globalURL.'/js/topojson.v2.min.js"></script>';
 	print '<script type="text/javascript" src="'.$globalURL.'/js/datamaps.world.min.js"></script>';
 	print '<div id="chartCountry" class="chart" width="100%"></div><script>';
 	print 'var series = [';
 	$country_data = '';
-	foreach($airport_country_array as $airport_item)
+	foreach ($airport_country_array as $airport_item)
 	{
 		$country_data .= '[ "'.$airport_item['airport_arrival_country_iso3'].'",'.$airport_item['airport_arrival_country_count'].'],';
 	}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
 		print '</thead>';
 		print '<tbody>';
 		$i = 1;
-		foreach($airport_country_array as $airport_item)
+		foreach ($airport_country_array as $airport_item)
 		{
 			print '<tr>';
 			print '<td><strong>'.$i.'</strong></td>';

Please login to merge, or discard this patch.

		@@ -7,18 +7,18 @@ discard block
		block discarded – undo
7	7	die();
8	8	}
9	9	$Spotter = new Spotter();
10		-$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
11		-$owner = filter_input(INPUT_GET,'owner',FILTER_SANITIZE_STRING);
12		-$year = filter_input(INPUT_GET,'year',FILTER_SANITIZE_NUMBER_INT);
13		-$month = filter_input(INPUT_GET,'month',FILTER_SANITIZE_NUMBER_INT);
	10	+$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
	11	+$owner = filter_input(INPUT_GET, 'owner', FILTER_SANITIZE_STRING);
	12	+$year = filter_input(INPUT_GET, 'year', FILTER_SANITIZE_NUMBER_INT);
	13	+$month = filter_input(INPUT_GET, 'month', FILTER_SANITIZE_NUMBER_INT);
14	14	$filter = array();
15		-if ($year != '') $filter = array_merge($filter,array('year' => $year));
16		-if ($month != '') $filter = array_merge($filter,array('month' => $month));
17		-$spotter_array = $Spotter->getSpotterDataByOwner($owner,"0,1", $sort,$filter);
	15	+if ($year != '') $filter = array_merge($filter, array('year' => $year));
	16	+if ($month != '') $filter = array_merge($filter, array('month' => $month));
	17	+$spotter_array = $Spotter->getSpotterDataByOwner($owner, "0,1", $sort, $filter);
18	18
19	19	if (!empty($spotter_array))
20	20	{
21		- $title = sprintf(_("Most Common Time of Day of %s"),$spotter_array[0]['aircraft_owner']);
	21	+ $title = sprintf(_("Most Common Time of Day of %s"), $spotter_array[0]['aircraft_owner']);
22	22	require_once('header.php');
23	23	print '<div class="info column">';
24	24	print '<h1>'.$spotter_array[0]['aircraft_owner'].'</h1>';
		@@ -29,9 +29,9 @@ discard block
		block discarded – undo
29	29	include('owner-sub-menu.php');
30	30	print '<div class="column">';
31	31	print '<h2>'._("Most Common Time of Day").'</h2>';
32		- print '<p>'.sprintf(_("The statistic below shows the most common time of day of flights owned by <strong>%s</strong>."),$spotter_array[0]['aircraft_owner']).'</p>';
	32	+ print '<p>'.sprintf(_("The statistic below shows the most common time of day of flights owned by <strong>%s</strong>."), $spotter_array[0]['aircraft_owner']).'</p>';
33	33
34		- $hour_array = $Spotter->countAllHoursByOwner($owner,$filter);
	34	+ $hour_array = $Spotter->countAllHoursByOwner($owner, $filter);
35	35	print '<link href="'.$globalURL.'/css/c3.min.css" rel="stylesheet" type="text/css">';
36	36	print '<script type="text/javascript" src="'.$globalURL.'/js/d3.min.js"></script>';
37	37	print '<script type="text/javascript" src="'.$globalURL.'/js/c3.min.js"></script>';
		@@ -39,9 +39,9 @@ discard block
		block discarded – undo
39	39	$hour_data = '';
40	40	$hour_cnt = '';
41	41	$last = 0;
42		- foreach($hour_array as $hour_item)
	42	+ foreach ($hour_array as $hour_item)
43	43	{
44		- while($last != $hour_item['hour_name']) {
	44	+ while ($last != $hour_item['hour_name']) {
45	45	$hour_data .= '"'.$last.':00",';
46	46	$hour_cnt .= '0,';
47	47	$last++;
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51	$hour_cnt .= $hour_item['hour_count'].',';
52	52	}
53	53	$hour_data = "['x',".substr($hour_data, 0, -1)."]";
54		- $hour_cnt = "['flights',".substr($hour_cnt,0,-1)."]";
	54	+ $hour_cnt = "['flights',".substr($hour_cnt, 0, -1)."]";
55	55	print 'c3.generate({
56	56	bindto: "#chartHour",
57	57	data: {
		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	print '</thead>';
77	77	print '<tbody>';
78	78	$i = 1;
79		- foreach($hour_array as $hour_item)
	79	+ foreach ($hour_array as $hour_item)
80	80	{
81	81	print '<tr>';
82	82	print '<td>'.$hour_item['hour_name'].':00</td>';

Ysurac / FlightAirMap

Push — master ( 7f80fe...90f8d8 )

Status

Category

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch