Ysurac / FlightAirMap

require/libs/geoPHP/tests/test.php

Doc Comments +6 added lines

@@ -112,6 +112,9 @@ 
   $geometry->m();
 }
 
+/**
+ * @param string $input
+ */
 function test_adapters($geometry, $format, $input) {
   // Test adapter output and input. Do a round-trip and re-test
   foreach (geoPHP::getAdapterMap() as $adapter_key => $adapter_class) {
@@ -234,6 +237,9 @@ 
   }
 }
 
+/**
+ * @param string $value
+ */
 function test_detection($value, $format, $file) {
   $detected = geoPHP::detectFormat($value);
   if ($detected != $format) {

Indentation +106 added lines, -106 removed lines

@@ -11,24 +11,24 @@ 
   include_once('../geoPHP.inc');
 
   if (geoPHP::geosInstalled()) {
-    print "GEOS is installed.\n";
+	print "GEOS is installed.\n";
   }
   else {
-    print "GEOS is not installed.\n";
+	print "GEOS is not installed.\n";
   }
 
   foreach (scandir('./input') as $file) {
-    $parts = explode('.',$file);
-    if ($parts[0]) {
-      $format = $parts[1];
-      $value = file_get_contents('./input/'.$file);
-      print '---- Testing '.$file."\n";
-      $geometry = geoPHP::load($value, $format);
-      test_adapters($geometry, $format, $value);
-      test_methods($geometry);
-      test_geometry($geometry);
-      test_detection($value, $format, $file);
-    }
+	$parts = explode('.',$file);
+	if ($parts[0]) {
+	  $format = $parts[1];
+	  $value = file_get_contents('./input/'.$file);
+	  print '---- Testing '.$file."\n";
+	  $geometry = geoPHP::load($value, $format);
+	  test_adapters($geometry, $format, $value);
+	  test_methods($geometry);
+	  test_geometry($geometry);
+	  test_detection($value, $format, $file);
+	}
   }
   print "Testing Done!";
 }
@@ -115,21 +115,21 @@ 
 function test_adapters($geometry, $format, $input) {
   // Test adapter output and input. Do a round-trip and re-test
   foreach (geoPHP::getAdapterMap() as $adapter_key => $adapter_class) {
-    if ($adapter_key != 'google_geocode') { //Don't test google geocoder regularily. Uncomment to test
-      $output = $geometry->out($adapter_key);
-      if ($output) {
-        $adapter_loader = new $adapter_class();
-        $test_geom_1 = $adapter_loader->read($output);
-        $test_geom_2 = $adapter_loader->read($test_geom_1->out($adapter_key));
-
-        if ($test_geom_1->out('wkt') != $test_geom_2->out('wkt')) {
-          print "Mismatched adapter output in ".$adapter_class."\n";
-        }
-      }
-      else {
-        print "Empty output on "  . $adapter_key . "\n";
-      }
-    }
+	if ($adapter_key != 'google_geocode') { //Don't test google geocoder regularily. Uncomment to test
+	  $output = $geometry->out($adapter_key);
+	  if ($output) {
+		$adapter_loader = new $adapter_class();
+		$test_geom_1 = $adapter_loader->read($output);
+		$test_geom_2 = $adapter_loader->read($test_geom_1->out($adapter_key));
+
+		if ($test_geom_1->out('wkt') != $test_geom_2->out('wkt')) {
+		  print "Mismatched adapter output in ".$adapter_class."\n";
+		}
+	  }
+	  else {
+		print "Empty output on "  . $adapter_key . "\n";
+	  }
+	}
   }
 
   // Test to make sure adapter work the same wether GEOS is ON or OFF
@@ -137,30 +137,30 @@ 
   if (!geoPHP::geosInstalled()) return;
 
   foreach (geoPHP::getAdapterMap() as $adapter_key => $adapter_class) {
-    if ($adapter_key != 'google_geocode') { //Don't test google geocoder regularily. Uncomment to test
-      // Turn GEOS on
-      geoPHP::geosInstalled(TRUE);
+	if ($adapter_key != 'google_geocode') { //Don't test google geocoder regularily. Uncomment to test
+	  // Turn GEOS on
+	  geoPHP::geosInstalled(TRUE);
 
-      $output = $geometry->out($adapter_key);
-      if ($output) {
-        $adapter_loader = new $adapter_class();
+	  $output = $geometry->out($adapter_key);
+	  if ($output) {
+		$adapter_loader = new $adapter_class();
 
-        $test_geom_1 = $adapter_loader->read($output);
+		$test_geom_1 = $adapter_loader->read($output);
 
-        // Turn GEOS off
-        geoPHP::geosInstalled(FALSE);
+		// Turn GEOS off
+		geoPHP::geosInstalled(FALSE);
 
-        $test_geom_2 = $adapter_loader->read($output);
+		$test_geom_2 = $adapter_loader->read($output);
 
-        // Turn GEOS back On
-        geoPHP::geosInstalled(TRUE);
+		// Turn GEOS back On
+		geoPHP::geosInstalled(TRUE);
 
-        // Check to make sure a both are the same with geos and without
-        if ($test_geom_1->out('wkt') != $test_geom_2->out('wkt')) {
-          print "Mismatched adapter output between GEOS and NORM in ".$adapter_class."\n";
-        }
-      }
-    }
+		// Check to make sure a both are the same with geos and without
+		if ($test_geom_1->out('wkt') != $test_geom_2->out('wkt')) {
+		  print "Mismatched adapter output between GEOS and NORM in ".$adapter_class."\n";
+		}
+	  }
+	}
   }
 }
 
@@ -170,75 +170,75 @@ 
   if (!geoPHP::geosInstalled()) return;
 
   $methods = array(
-    //'boundary', //@@TODO: Uncomment this and fix errors
-    'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
-    'getBBox',
-    'x',
-    'y',
-    'startPoint',
-    'endPoint',
-    'isRing',
-    'isClosed',
-    'numPoints',
+	//'boundary', //@@TODO: Uncomment this and fix errors
+	'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
+	'getBBox',
+	'x',
+	'y',
+	'startPoint',
+	'endPoint',
+	'isRing',
+	'isClosed',
+	'numPoints',
   );
 
   foreach ($methods as $method) {
-    // Turn GEOS on
-    geoPHP::geosInstalled(TRUE);
-    $geos_result = $geometry->$method();
-
-    // Turn GEOS off
-    geoPHP::geosInstalled(FALSE);
-    $norm_result = $geometry->$method();
-
-    // Turn GEOS back On
-    geoPHP::geosInstalled(TRUE);
-
-    $geos_type = gettype($geos_result);
-    $norm_type = gettype($norm_result);
-
-    if ($geos_type != $norm_type) {
-      print 'Type mismatch on '.$method."\n";
-      continue;
-    }
-
-    // Now check base on type
-    if ($geos_type == 'object') {
-      $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
-
-      // Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
-      // Using Pythagorean theorem
-      $bb = $geos_result->getBBox();
-      $scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
-
-      // The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
-      if ($haus_dist / $scale > 0.5) {
-        print 'Output mismatch on '.$method.":\n";
-        print 'GEOS : '.$geos_result->out('wkt')."\n";
-        print 'NORM : '.$norm_result->out('wkt')."\n";
-        continue;
-      }
-    }
-
-    if ($geos_type == 'boolean' || $geos_type == 'string') {
-      if ($geos_result !== $norm_result) {
-        print 'Output mismatch on '.$method.":\n";
-        print 'GEOS : '.(string) $geos_result."\n";
-        print 'NORM : '.(string) $norm_result."\n";
-        continue;
-      }
-    }
-
-    //@@TODO: Run tests for output of types arrays and float
-    //@@TODO: centroid function is non-compliant for collections and strings
+	// Turn GEOS on
+	geoPHP::geosInstalled(TRUE);
+	$geos_result = $geometry->$method();
+
+	// Turn GEOS off
+	geoPHP::geosInstalled(FALSE);
+	$norm_result = $geometry->$method();
+
+	// Turn GEOS back On
+	geoPHP::geosInstalled(TRUE);
+
+	$geos_type = gettype($geos_result);
+	$norm_type = gettype($norm_result);
+
+	if ($geos_type != $norm_type) {
+	  print 'Type mismatch on '.$method."\n";
+	  continue;
+	}
+
+	// Now check base on type
+	if ($geos_type == 'object') {
+	  $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
+
+	  // Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
+	  // Using Pythagorean theorem
+	  $bb = $geos_result->getBBox();
+	  $scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
+
+	  // The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
+	  if ($haus_dist / $scale > 0.5) {
+		print 'Output mismatch on '.$method.":\n";
+		print 'GEOS : '.$geos_result->out('wkt')."\n";
+		print 'NORM : '.$norm_result->out('wkt')."\n";
+		continue;
+	  }
+	}
+
+	if ($geos_type == 'boolean' || $geos_type == 'string') {
+	  if ($geos_result !== $norm_result) {
+		print 'Output mismatch on '.$method.":\n";
+		print 'GEOS : '.(string) $geos_result."\n";
+		print 'NORM : '.(string) $norm_result."\n";
+		continue;
+	  }
+	}
+
+	//@@TODO: Run tests for output of types arrays and float
+	//@@TODO: centroid function is non-compliant for collections and strings
   }
 }
 
 function test_detection($value, $format, $file) {
   $detected = geoPHP::detectFormat($value);
   if ($detected != $format) {
-    if ($detected) print 'detected as ' . $detected . "\n";
-    else print "not detected\n";
+	if ($detected) print 'detected as ' . $detected . "\n";
+	else print "not detected\n";
   }
   // Make sure it loads using auto-detect
   geoPHP::load($value);

Spacing +7 added lines, -7 removed lines

@@ -18,7 +18,7 @@ 
   }
 
   foreach (scandir('./input') as $file) {
-    $parts = explode('.',$file);
+    $parts = explode('.', $file);
     if ($parts[0]) {
       $format = $parts[1];
       $value = file_get_contents('./input/'.$file);
@@ -88,7 +88,7 @@ 
   $geometry->difference($geometry);
   $geometry->symDifference($geometry);
   $geometry->union($geometry);
-  $geometry->simplify(0);// @@TODO: Adjust this once we can deal with empty geometries
+  $geometry->simplify(0); // @@TODO: Adjust this once we can deal with empty geometries
   $geometry->disjoint($geometry);
   $geometry->touches($geometry);
   $geometry->intersects($geometry);
@@ -127,7 +127,7 @@ 
         }
       }
       else {
-        print "Empty output on "  . $adapter_key . "\n";
+        print "Empty output on ".$adapter_key."\n";
       }
     }
   }
@@ -171,7 +171,7 @@ 
 
   $methods = array(
     //'boundary', //@@TODO: Uncomment this and fix errors
-    'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
+    'envelope', //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
     'getBBox',
     'x',
     'y',
@@ -204,7 +204,7 @@ 
 
     // Now check base on type
     if ($geos_type == 'object') {
-      $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
+      $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'), 'wkt'));
 
       // Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
       // Using Pythagorean theorem
@@ -212,7 +212,7 @@ 
       $scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
 
       // The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
-      if ($haus_dist / $scale > 0.5) {
+      if ($haus_dist/$scale > 0.5) {
         print 'Output mismatch on '.$method.":\n";
         print 'GEOS : '.$geos_result->out('wkt')."\n";
         print 'NORM : '.$norm_result->out('wkt')."\n";
@@ -237,7 +237,7 @@ 
 function test_detection($value, $format, $file) {
   $detected = geoPHP::detectFormat($value);
   if ($detected != $format) {
-    if ($detected) print 'detected as ' . $detected . "\n";
+    if ($detected) print 'detected as '.$detected."\n";
     else print "not detected\n";
   }
   // Make sure it loads using auto-detect

Braces +13 added lines, -8 removed lines

@@ -12,8 +12,7 @@ 
 
   if (geoPHP::geosInstalled()) {
     print "GEOS is installed.\n";
-  }
-  else {
+  } else {
     print "GEOS is not installed.\n";
   }
 
@@ -125,8 +124,7 @@ 
         if ($test_geom_1->out('wkt') != $test_geom_2->out('wkt')) {
           print "Mismatched adapter output in ".$adapter_class."\n";
         }
-      }
-      else {
+      } else {
         print "Empty output on "  . $adapter_key . "\n";
       }
     }
@@ -134,7 +132,9 @@ 
 
   // Test to make sure adapter work the same wether GEOS is ON or OFF
   // Cannot test methods if GEOS is not intstalled
-  if (!geoPHP::geosInstalled()) return;
+  if (!geoPHP::geosInstalled()) {
+  	return;
+  }
 
   foreach (geoPHP::getAdapterMap() as $adapter_key => $adapter_class) {
     if ($adapter_key != 'google_geocode') { //Don't test google geocoder regularily. Uncomment to test
@@ -167,7 +167,9 @@ 
 
 function test_methods($geometry) {
   // Cannot test methods if GEOS is not intstalled
-  if (!geoPHP::geosInstalled()) return;
+  if (!geoPHP::geosInstalled()) {
+  	return;
+  }
 
   $methods = array(
     //'boundary', //@@TODO: Uncomment this and fix errors
@@ -237,8 +239,11 @@ 
 function test_detection($value, $format, $file) {
   $detected = geoPHP::detectFormat($value);
   if ($detected != $format) {
-    if ($detected) print 'detected as ' . $detected . "\n";
-    else print "not detected\n";
+    if ($detected) {
+    	print 'detected as ' . $detected . "\n";
+    } else {
+    	print "not detected\n";
+    }
   }
   // Make sure it loads using auto-detect
   geoPHP::load($value);

require/libs/geoPHP/tests/tests/methodsTest.php

Doc Comments +4 added lines

@@ -58,6 +58,10 @@
     }
   }
 
+  /**
+   * @param string $method_name
+   * @param string|null $argument
+   */
   function _methods_tester($geometry, $method_name, $argument) {
 
     if (!method_exists($geometry, $method_name)) {

Indentation +328 added lines, -328 removed lines

@@ -9,357 +9,357 @@
   }
 
   function testMethods() {
-    foreach (scandir('./input') as $file) {
-      $parts = explode('.',$file);
-      if ($parts[0]) {
-        $format = $parts[1];
-        $value = file_get_contents('./input/'.$file);
-        $geometry = geoPHP::load($value, $format);
+	foreach (scandir('./input') as $file) {
+	  $parts = explode('.',$file);
+	  if ($parts[0]) {
+		$format = $parts[1];
+		$value = file_get_contents('./input/'.$file);
+		$geometry = geoPHP::load($value, $format);
 
-        $methods = array(
-          array('name' => 'area'),
-          array('name' => 'boundary'),
-          array('name' => 'getBBox'),
-          array('name' => 'centroid'),
-          array('name' => 'length'),
-          array('name' => 'greatCircleLength'),
-          array('name' => 'haversineLength'),
-          array('name' => 'y'),
-          array('name' => 'x'),
-          array('name' => 'numGeometries'),
-          array('name' => 'geometryN', 'argument' => '1'),
-          array('name' => 'startPoint'),
-          array('name' => 'endPoint'),
-          array('name' => 'isRing'),
-          array('name' => 'isClosed'),
-          array('name' => 'numPoints'),
-          array('name' => 'pointN', 'argument' => '1'),
-          array('name' => 'exteriorRing'),
-          array('name' => 'numInteriorRings'),
-          array('name' => 'interiorRingN', 'argument' => '1'),
-          array('name' => 'dimension'),
-          array('name' => 'geometryType'),
-          array('name' => 'SRID'),
-          array('name' => 'setSRID', 'argument' => '4326'),
-        );
+		$methods = array(
+		  array('name' => 'area'),
+		  array('name' => 'boundary'),
+		  array('name' => 'getBBox'),
+		  array('name' => 'centroid'),
+		  array('name' => 'length'),
+		  array('name' => 'greatCircleLength'),
+		  array('name' => 'haversineLength'),
+		  array('name' => 'y'),
+		  array('name' => 'x'),
+		  array('name' => 'numGeometries'),
+		  array('name' => 'geometryN', 'argument' => '1'),
+		  array('name' => 'startPoint'),
+		  array('name' => 'endPoint'),
+		  array('name' => 'isRing'),
+		  array('name' => 'isClosed'),
+		  array('name' => 'numPoints'),
+		  array('name' => 'pointN', 'argument' => '1'),
+		  array('name' => 'exteriorRing'),
+		  array('name' => 'numInteriorRings'),
+		  array('name' => 'interiorRingN', 'argument' => '1'),
+		  array('name' => 'dimension'),
+		  array('name' => 'geometryType'),
+		  array('name' => 'SRID'),
+		  array('name' => 'setSRID', 'argument' => '4326'),
+		);
 
-        foreach($methods as $method) {
-          $argument = NULL;
-          $method_name = $method['name'];
-          if (isset($method['argument'])) {
-            $argument = $method['argument'];
-          }
+		foreach($methods as $method) {
+		  $argument = NULL;
+		  $method_name = $method['name'];
+		  if (isset($method['argument'])) {
+			$argument = $method['argument'];
+		  }
 
-          $this->_methods_tester($geometry, $method_name, $argument);
-        }
+		  $this->_methods_tester($geometry, $method_name, $argument);
+		}
 
-        $this->_methods_tester_with_geos($geometry);
-      }
-    }
+		$this->_methods_tester_with_geos($geometry);
+	  }
+	}
   }
 
   function _methods_tester($geometry, $method_name, $argument) {
 
-    if (!method_exists($geometry, $method_name)) {
-      $this->fail("Method ".$method_name.'() doesn\'t exists.');
-      return;
-    }
+	if (!method_exists($geometry, $method_name)) {
+	  $this->fail("Method ".$method_name.'() doesn\'t exists.');
+	  return;
+	}
 
-    switch ($method_name) {
-      case 'y':
-      case 'x':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'geometryN':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'startPoint':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          //TODO: Add a method startPoint() to MultiLineString.
-          //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'endPoint':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          //TODO: Add a method endPoint() to MultiLineString.
-          //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'isRing':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'isClosed':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'pointN':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          //TODO: Add a method pointN() to MultiLineString.
-          //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'exteriorRing':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'numInteriorRings':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'interiorRingN':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'SRID':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'getBBox':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'centroid':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'length':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'numGeometries':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'numPoints':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'dimension':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'boundary':
-        if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        }
-        break;
-      case 'haversineLength':
-        //TODO: Check if output is a float >= 0.
-        //TODO: Sometimes haversineLength() returns NAN, needs to check why.
-        break;
-      case 'greatCircleLength':
-      case 'area':
-        $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        break;
-      case 'geometryType':
-        $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
-        break;
-      case 'setSRID':
-        //TODO: The method setSRID() should return TRUE.
-        break;
-      default:
-        $this->assertTrue($geometry->$method_name($argument), 'Failed on ' . $method_name);
-    }
+	switch ($method_name) {
+	  case 'y':
+	  case 'x':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'geometryN':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'startPoint':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  //TODO: Add a method startPoint() to MultiLineString.
+		  //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'endPoint':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  //TODO: Add a method endPoint() to MultiLineString.
+		  //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'isRing':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'isClosed':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'pointN':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  //TODO: Add a method pointN() to MultiLineString.
+		  //$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'exteriorRing':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'numInteriorRings':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'interiorRingN':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'SRID':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'getBBox':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'centroid':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'length':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'numGeometries':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'numPoints':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'dimension':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'boundary':
+		if ($geometry->geometryType() == 'Point') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'LineString') {
+		  $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		if ($geometry->geometryType() == 'MultiLineString') {
+		  $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		}
+		break;
+	  case 'haversineLength':
+		//TODO: Check if output is a float >= 0.
+		//TODO: Sometimes haversineLength() returns NAN, needs to check why.
+		break;
+	  case 'greatCircleLength':
+	  case 'area':
+		$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		break;
+	  case 'geometryType':
+		$this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+		break;
+	  case 'setSRID':
+		//TODO: The method setSRID() should return TRUE.
+		break;
+	  default:
+		$this->assertTrue($geometry->$method_name($argument), 'Failed on ' . $method_name);
+	}
 
   }
 
   function _methods_tester_with_geos($geometry) {
-    // Cannot test methods if GEOS is not intstalled
-    if (!geoPHP::geosInstalled()) return;
+	// Cannot test methods if GEOS is not intstalled
+	if (!geoPHP::geosInstalled()) return;
 
-    $methods = array(
-      //'boundary', //@@TODO: Uncomment this and fix errors
-      'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
-      'getBBox',
-      'x',
-      'y',
-      'startPoint',
-      'endPoint',
-      'isRing',
-      'isClosed',
-      'numPoints',
-    );
+	$methods = array(
+	  //'boundary', //@@TODO: Uncomment this and fix errors
+	  'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
+	  'getBBox',
+	  'x',
+	  'y',
+	  'startPoint',
+	  'endPoint',
+	  'isRing',
+	  'isClosed',
+	  'numPoints',
+	);
 
-    foreach ($methods as $method) {
-      // Turn GEOS on
-      geoPHP::geosInstalled(TRUE);
-      $geos_result = $geometry->$method();
+	foreach ($methods as $method) {
+	  // Turn GEOS on
+	  geoPHP::geosInstalled(TRUE);
+	  $geos_result = $geometry->$method();
 
-      // Turn GEOS off
-      geoPHP::geosInstalled(FALSE);
-      $norm_result = $geometry->$method();
+	  // Turn GEOS off
+	  geoPHP::geosInstalled(FALSE);
+	  $norm_result = $geometry->$method();
 
-      // Turn GEOS back On
-      geoPHP::geosInstalled(TRUE);
+	  // Turn GEOS back On
+	  geoPHP::geosInstalled(TRUE);
 
-      $geos_type = gettype($geos_result);
-      $norm_type = gettype($norm_result);
+	  $geos_type = gettype($geos_result);
+	  $norm_type = gettype($norm_result);
 
-      if ($geos_type != $norm_type) {
-        $this->fail('Type mismatch on '.$method);
-        $this->dump($geos_type);
-        $this->dump($norm_type);
-        continue;
-      }
+	  if ($geos_type != $norm_type) {
+		$this->fail('Type mismatch on '.$method);
+		$this->dump($geos_type);
+		$this->dump($norm_type);
+		continue;
+	  }
 
-      // Now check base on type
-      if ($geos_type == 'object') {
-        $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
+	  // Now check base on type
+	  if ($geos_type == 'object') {
+		$haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
 
-        // Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
-        // Using Pythagorean theorem
-        $bb = $geos_result->getBBox();
-        $scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
+		// Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
+		// Using Pythagorean theorem
+		$bb = $geos_result->getBBox();
+		$scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
 
-        // The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
-        if ($haus_dist / $scale > 0.5) {
-          $this->fail('Output mismatch on '.$method);
-          $this->dump('GEOS : ');
-          $this->dump($geos_result->out('wkt'));
-          $this->dump('NORM : ');
-          $this->dump($norm_result->out('wkt'));
-          continue;
-        }
-      }
+		// The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
+		if ($haus_dist / $scale > 0.5) {
+		  $this->fail('Output mismatch on '.$method);
+		  $this->dump('GEOS : ');
+		  $this->dump($geos_result->out('wkt'));
+		  $this->dump('NORM : ');
+		  $this->dump($norm_result->out('wkt'));
+		  continue;
+		}
+	  }
 
-      if ($geos_type == 'boolean' || $geos_type == 'string') {
-        if ($geos_result !== $norm_result) {
-          $this->fail('Output mismatch on '.$method);
-          $this->dump('GEOS : ');
-          $this->dump((string) $geos_result);
-          $this->dump('NORM : ');
-          $this->dump((string) $norm_result);
-          continue;
-        }
-      }
+	  if ($geos_type == 'boolean' || $geos_type == 'string') {
+		if ($geos_result !== $norm_result) {
+		  $this->fail('Output mismatch on '.$method);
+		  $this->dump('GEOS : ');
+		  $this->dump((string) $geos_result);
+		  $this->dump('NORM : ');
+		  $this->dump((string) $norm_result);
+		  continue;
+		}
+	  }
 
-      //@@TODO: Run tests for output of types arrays and float
-      //@@TODO: centroid function is non-compliant for collections and strings
-    }
+	  //@@TODO: Run tests for output of types arrays and float
+	  //@@TODO: centroid function is non-compliant for collections and strings
+	}
   }
 }

Spacing +59 added lines, -59 removed lines

@@ -10,7 +10,7 @@ 
 
   function testMethods() {
     foreach (scandir('./input') as $file) {
-      $parts = explode('.',$file);
+      $parts = explode('.', $file);
       if ($parts[0]) {
         $format = $parts[1];
         $value = file_get_contents('./input/'.$file);
@@ -43,7 +43,7 @@ 
           array('name' => 'setSRID', 'argument' => '4326'),
         );
 
-        foreach($methods as $method) {
+        foreach ($methods as $method) {
           $argument = NULL;
           $method_name = $method['name'];
           if (isset($method['argument'])) {
@@ -69,32 +69,32 @@ 
       case 'y':
       case 'x':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'geometryN':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'startPoint':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
           //TODO: Add a method startPoint() to MultiLineString.
@@ -103,10 +103,10 @@ 
         break;
       case 'endPoint':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
           //TODO: Add a method endPoint() to MultiLineString.
@@ -115,32 +115,32 @@ 
         break;
       case 'isRing':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'isClosed':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'pointN':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
           //TODO: Add a method pointN() to MultiLineString.
@@ -149,123 +149,123 @@ 
         break;
       case 'exteriorRing':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'numInteriorRings':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'interiorRingN':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'SRID':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'getBBox':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'centroid':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'length':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'numGeometries':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'numPoints':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'dimension':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'boundary':
         if ($geometry->geometryType() == 'Point') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'LineString') {
-          $this->assertNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         if ($geometry->geometryType() == 'MultiLineString') {
-          $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+          $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         }
         break;
       case 'haversineLength':
@@ -274,16 +274,16 @@ 
         break;
       case 'greatCircleLength':
       case 'area':
-        $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+        $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         break;
       case 'geometryType':
-        $this->assertNotNull($geometry->$method_name($argument), 'Failed on ' . $method_name);
+        $this->assertNotNull($geometry->$method_name($argument), 'Failed on '.$method_name);
         break;
       case 'setSRID':
         //TODO: The method setSRID() should return TRUE.
         break;
       default:
-        $this->assertTrue($geometry->$method_name($argument), 'Failed on ' . $method_name);
+        $this->assertTrue($geometry->$method_name($argument), 'Failed on '.$method_name);
     }
 
   }
@@ -294,7 +294,7 @@ 
 
     $methods = array(
       //'boundary', //@@TODO: Uncomment this and fix errors
-      'envelope',   //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
+      'envelope', //@@TODO: Testing reveales errors in this method -- POINT vs. POLYGON
       'getBBox',
       'x',
       'y',
@@ -329,7 +329,7 @@ 
 
       // Now check base on type
       if ($geos_type == 'object') {
-        $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'),'wkt'));
+        $haus_dist = $geos_result->hausdorffDistance(geoPHP::load($norm_result->out('wkt'), 'wkt'));
 
         // Get the length of the diagonal of the bbox - this is used to scale the haustorff distance
         // Using Pythagorean theorem
@@ -337,7 +337,7 @@ 
         $scale = sqrt((($bb['maxy'] - $bb['miny'])^2) + (($bb['maxx'] - $bb['minx'])^2));
 
         // The difference in the output of GEOS and native-PHP methods should be less than 0.5 scaled haustorff units
-        if ($haus_dist / $scale > 0.5) {
+        if ($haus_dist/$scale > 0.5) {
           $this->fail('Output mismatch on '.$method);
           $this->dump('GEOS : ');
           $this->dump($geos_result->out('wkt'));

Braces +3 added lines, -1 removed lines

@@ -290,7 +290,9 @@
 
   function _methods_tester_with_geos($geometry) {
     // Cannot test methods if GEOS is not intstalled
-    if (!geoPHP::geosInstalled()) return;
+    if (!geoPHP::geosInstalled()) {
+    	return;
+    }
 
     $methods = array(
       //'boundary', //@@TODO: Uncomment this and fix errors

require/libs/uagent/uagent.php

Doc Comments +3 added lines

@@ -122,6 +122,9 @@
         return self::array_random( empty( $lang ) ? self::$languages : $lang );
     }
 
+    /**
+     * @param string $os
+     */
     private static function get_processor( $os )
     {
         return self::array_random( self::$processors[$os] );

Indentation +342 added lines, -342 removed lines

@@ -8,347 +8,347 @@
 
 class UAgent
 {
-    // General token that says the browser is Mozilla compatible, 
-    // and is common to almost every browser today.
-    const MOZILLA = 'Mozilla/5.0 ';
-
-    /**
-     * Processors by Arch.
-     */
-    public static $processors = array(
-        'lin' => array( 'i686', 'x86_64' ),
-        'mac' => array( 'Intel', 'PPC', 'U; Intel', 'U; PPC' ),
-        'win' => array( 'foo' )
-    );
-
-    /**
-     * Browsers
-     * 
-     * Weighting is based on market share to determine frequency.
-     */
-    public static $browsers = array(
-        34 => array(
-            89 => array( 'chrome', 'win' ),
-            9  => array( 'chrome', 'mac' ),
-            2  => array( 'chrome', 'lin' )
-        ),
-        32 => array(
-            100 => array( 'iexplorer', 'win' )
-        ),
-        25 => array(
-            83 => array( 'firefox', 'win' ),
-            16 => array( 'firefox', 'mac' ),
-            1  => array( 'firefox', 'lin' )
-        ),
-        7 => array(
-            95 => array( 'safari', 'mac' ),
-            4  => array( 'safari', 'win' ),
-            1  => array( 'safari', 'lin' )
-        ),
-        2 => array(
-            91 => array( 'opera', 'win' ),
-            6  => array( 'opera', 'lin' ),
-            3  => array( 'opera', 'mac' )
-        )
-    );
-
-    /**
-     * List of Lanuge Culture Codes (ISO 639-1)
-     *
-     * @see: http://msdn.microsoft.com/en-gb/library/ee825488(v=cs.20).aspx
-     */
-    public static $languages = array(
-        'af-ZA', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB',
-        'ar-LY', 'ar-MA', 'ar-OM', 'ar-QA', 'ar-SA', 'ar-SY', 'ar-TN', 'ar-YE', 'be-BY',
-        'bg-BG', 'ca-ES', 'cs-CZ', 'Cy-az-AZ', 'Cy-sr-SP', 'Cy-uz-UZ', 'da-DK', 'de-AT',
-        'de-CH', 'de-DE', 'de-LI', 'de-LU', 'div-MV', 'el-GR', 'en-AU', 'en-BZ', 'en-CA', 
-        'en-CB', 'en-GB', 'en-IE', 'en-JM', 'en-NZ', 'en-PH', 'en-TT', 'en-US', 'en-ZA', 
-        'en-ZW', 'es-AR', 'es-BO', 'es-CL', 'es-CO',  'es-CR', 'es-DO', 'es-EC', 'es-ES',
-        'es-GT', 'es-HN', 'es-MX', 'es-NI', 'es-PA', 'es-PE', 'es-PR', 'es-PY', 'es-SV',
-        'es-UY', 'es-VE', 'et-EE', 'eu-ES', 'fa-IR', 'fi-FI', 'fo-FO', 'fr-BE', 'fr-CA',
-        'fr-CH', 'fr-FR', 'fr-LU', 'fr-MC', 'gl-ES', 'gu-IN', 'he-IL', 'hi-IN', 'hr-HR', 
-        'hu-HU', 'hy-AM', 'id-ID', 'is-IS', 'it-CH', 'it-IT', 'ja-JP', 'ka-GE', 'kk-KZ',
-        'kn-IN', 'kok-IN', 'ko-KR', 'ky-KZ', 'Lt-az-AZ', 'lt-LT', 'Lt-sr-SP', 'Lt-uz-UZ', 
-        'lv-LV', 'mk-MK', 'mn-MN', 'mr-IN', 'ms-BN', 'ms-MY', 'nb-NO', 'nl-BE', 'nl-NL', 
-        'nn-NO', 'pa-IN', 'pl-PL', 'pt-BR', 'pt-PT', 'ro-RO', 'ru-RU', 'sa-IN', 'sk-SK', 
-        'sl-SI', 'sq-AL', 'sv-FI', 'sv-SE', 'sw-KE', 'syr-SY', 'ta-IN', 'te-IN', 'th-TH', 
-        'tr-TR', 'tt-RU', 'uk-UA', 'ur-PK', 'vi-VN', 'zh-CHS', 'zh-CHT', 'zh-CN', 'zh-HK', 
-        'zh-MO', 'zh-SG', 'zh-TW',   
-    );    
-
-    /**
-     * Generate Device Platform
-     *
-     * Uses a random result with a weighting related to frequencies.
-     */
-    public static function generate_platform()
-    {
-        $rand = mt_rand( 1, 100 );
-        $sum = 0;
-
-        foreach ( self::$browsers as $share => $freq_os )
-        {
-            $sum += $share;
-
-            if ( $rand <= $sum )
-            {
-                $rand = mt_rand( 1, 100 );
-                $sum = 0;
-
-                foreach ( $freq_os as $share => $choice )
-                {
-                    $sum += $share;
-
-                    if ( $rand <= $sum )
-                    {
-                        return $choice;
-                    }
-                }
-            }
-        }
-
-        throw new Exception( 'Sum of $browsers frequency is not 100.' );
-    }
-
-    private static function array_random( $array )
-    {
-        $i = array_rand( $array, 1 );
-
-        return $array[$i];
-    }
-
-    private static function get_language( $lang = array() )
-    {
-        return self::array_random( empty( $lang ) ? self::$languages : $lang );
-    }
-
-    private static function get_processor( $os )
-    {
-        return self::array_random( self::$processors[$os] );
-    }
-
-    private static function get_version_nt()
-    {   
-        // Win2k (5.0) to Win 7 (6.1).
-        return mt_rand( 5, 6 ) . '.' . mt_rand( 0, 1 );
-    }
-
-    private static function get_version_osx()
-    {
-        return '10_' . mt_rand( 5, 7 ) . '_' . mt_rand( 0, 9 );
-    }
-
-    private static function get_version_webkit()
-    {
-        return mt_rand( 531, 536 ) . mt_rand( 0, 2 );
-    }
-
-    private static function get_verison_chrome()
-    {
-        return mt_rand( 13, 15 ) . '.0.' . mt_rand( 800, 899 ) . '.0';
-    }
-
-    private static function get_version_gecko()
-    {
-        return mt_rand( 17, 31 ) . '.0';
-    }
-
-    private static function get_version_ie()
-    {
-        return mt_rand( 7, 9 ) . '.0';
-    }
-
-    private static function get_version_trident()
-    {
-        // IE8 (4.0) to IE11 (7.0).
-        return mt_rand( 4, 7 ) . '.0';
-    }
-
-    private static function get_version_net()
-    {
-        // generic .NET Framework common language run time (CLR) version numbers.
-        $frameworks = array(
-            '2.0.50727',
-            '3.0.4506',
-            '3.5.30729',
-        );
-
-        $rev = '.' . mt_rand( 26, 648 );
-
-        return self::array_random( $frameworks ) . $rev;
-    }
-
-    private static function get_version_safari()
-    {
-        if ( mt_rand( 0, 1 ) == 0 )
-        {
-            $ver = mt_rand( 4, 5 ) . '.' . mt_rand( 0, 1 );
-        }
-        else
-        {
-            $ver = mt_rand( 4, 5 ) . '.0.' . mt_rand( 1, 5 );
-        }
-
-        return $ver;
-    }
-
-    private static function get_version_opera()
-    {
-        return mt_rand( 15, 19 ) . '.0.' . mt_rand( 1147, 1284 ) . mt_rand( 49, 100 );
-    }
-
-    /**
-     * Opera
-     * 
-     * @see: http://dev.opera.com/blog/opera-user-agent-strings-opera-15-and-beyond/
-     */
-    public static function opera( $arch )
-    {
-        $opera = ' OPR/' . self::get_version_opera();
-
-        // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
-        $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $chrome = ' Chrome/' . self::get_verison_chrome();
-        $safari = ' Safari/' . $engine;
-
-        switch ( $arch )
-        {
-            case 'lin':
-                return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari . $opera;
-            case 'mac':
-                $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari . $opera;
-            case 'win':
-                // fall through.
-            default:
-                $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . '; WOW64) ' . $webkit . $chrome . $safari . $opera;
-        }
-    }    
-
-    /**
-     * Safari
-     *
-     */
-    public static function safari( $arch )
-    {
-        $version = ' Version/' . self::get_version_safari();
-
-        // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
-        $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $safari = ' Safari/' . $engine;
-
-        switch ( $arch )
-        {
-            case 'mac':
-                $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . '; {lang})' . $webkit . $version . $safari;
-            case 'win':
-                // fall through.
-            default:
-                $nt = self::get_version_nt();
-                return '(Windows; U; Windows NT ' . $nt . ')' . $webkit . $version . $safari;
-        }
-
-    }
-
-    /**
-     * Internet Explorer
-     * 
-     * @see: http://msdn.microsoft.com/en-gb/library/ms537503(v=vs.85).aspx
-     */
-    public static function iexplorer( $arch )
-    {
-        $nt = self::get_version_nt();
-        $ie = self::get_version_ie();
-        $trident = self::get_version_trident();
-        $net = self::get_version_net();
-
-        return '(compatible' 
-            . '; MSIE ' . $ie 
-            . '; Windows NT ' . $nt 
-            . '; WOW64' // A 32-bit version of Internet Explorer is running on a 64-bit processor.
-            . '; Trident/' . $trident 
-            . '; .NET CLR ' . $net
-            . ')';
-    }
-
-    /**
-     * Firefox User-Agent
-     *
-     * @see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Gecko_user_agent_string_reference
-     */
-    public static function firefox( $arch )
-    {
-        // The release version of Gecko. 
-        $gecko = self::get_version_gecko();
-
-        // On desktop, the gecko trail is fixed.
-        $trail = '20100101';
-
-        $release = 'rv:' . $gecko;
-        $version = 'Gecko/' . $trail . ' Firefox/' . $gecko;
-
-        switch ( $arch )
-        {
-            case 'lin':
-                return '(X11; Linux {proc}; ' . $release . ') ' . $version;
-            case 'mac':
-                $osx = self::get_version_osx();
-                return '(Macintosh; {proc} Mac OS X ' . $osx . '; ' . $release . ') ' . $version;
-            case 'win':
-                // fall through.
-            default:
-                $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . '; {lang}; ' . $release . ') ' . $version;
-        }
-    }
-
-    public static function chrome( $arch )
-    {
-        $chrome = ' Chrome/' . self::get_verison_chrome();
-
-        // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
-        $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $safari = ' Safari/' . $engine;
-
-        switch ( $arch )
-        {
-            case 'lin':
-                return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari;
-            case 'mac':
-                $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari;
-            case 'win':
-                // fall through.
-            default:
-                $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . ') ' . $webkit . $chrome . $safari;
-        }
-    }
-
-    public static function random( $lang = array( 'en-US' ) )
-    {
-        list( $browser, $os ) = self::generate_platform();
-
-        return self::generate( $browser, $os, $lang );
-    }
-
-    public static function generate( $browser = 'chrome', $os = 'win', $lang = array( 'en-US' ) )
-    {
-        $ua = self::MOZILLA . call_user_func( 'UAgent::' . $browser, $os );
-
-        $tags = array(
-            '{proc}' => self::get_processor( $os ),
-            '{lang}' => self::get_language( $lang ),
-        );
-
-        $ua = str_replace( array_keys( $tags ), array_values( $tags ), $ua );
-
-        return $ua;
-    }
+	// General token that says the browser is Mozilla compatible, 
+	// and is common to almost every browser today.
+	const MOZILLA = 'Mozilla/5.0 ';
+
+	/**
+	 * Processors by Arch.
+	 */
+	public static $processors = array(
+		'lin' => array( 'i686', 'x86_64' ),
+		'mac' => array( 'Intel', 'PPC', 'U; Intel', 'U; PPC' ),
+		'win' => array( 'foo' )
+	);
+
+	/**
+	 * Browsers
+	 * 
+	 * Weighting is based on market share to determine frequency.
+	 */
+	public static $browsers = array(
+		34 => array(
+			89 => array( 'chrome', 'win' ),
+			9  => array( 'chrome', 'mac' ),
+			2  => array( 'chrome', 'lin' )
+		),
+		32 => array(
+			100 => array( 'iexplorer', 'win' )
+		),
+		25 => array(
+			83 => array( 'firefox', 'win' ),
+			16 => array( 'firefox', 'mac' ),
+			1  => array( 'firefox', 'lin' )
+		),
+		7 => array(
+			95 => array( 'safari', 'mac' ),
+			4  => array( 'safari', 'win' ),
+			1  => array( 'safari', 'lin' )
+		),
+		2 => array(
+			91 => array( 'opera', 'win' ),
+			6  => array( 'opera', 'lin' ),
+			3  => array( 'opera', 'mac' )
+		)
+	);
+
+	/**
+	 * List of Lanuge Culture Codes (ISO 639-1)
+	 *
+	 * @see: http://msdn.microsoft.com/en-gb/library/ee825488(v=cs.20).aspx
+	 */
+	public static $languages = array(
+		'af-ZA', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB',
+		'ar-LY', 'ar-MA', 'ar-OM', 'ar-QA', 'ar-SA', 'ar-SY', 'ar-TN', 'ar-YE', 'be-BY',
+		'bg-BG', 'ca-ES', 'cs-CZ', 'Cy-az-AZ', 'Cy-sr-SP', 'Cy-uz-UZ', 'da-DK', 'de-AT',
+		'de-CH', 'de-DE', 'de-LI', 'de-LU', 'div-MV', 'el-GR', 'en-AU', 'en-BZ', 'en-CA', 
+		'en-CB', 'en-GB', 'en-IE', 'en-JM', 'en-NZ', 'en-PH', 'en-TT', 'en-US', 'en-ZA', 
+		'en-ZW', 'es-AR', 'es-BO', 'es-CL', 'es-CO',  'es-CR', 'es-DO', 'es-EC', 'es-ES',
+		'es-GT', 'es-HN', 'es-MX', 'es-NI', 'es-PA', 'es-PE', 'es-PR', 'es-PY', 'es-SV',
+		'es-UY', 'es-VE', 'et-EE', 'eu-ES', 'fa-IR', 'fi-FI', 'fo-FO', 'fr-BE', 'fr-CA',
+		'fr-CH', 'fr-FR', 'fr-LU', 'fr-MC', 'gl-ES', 'gu-IN', 'he-IL', 'hi-IN', 'hr-HR', 
+		'hu-HU', 'hy-AM', 'id-ID', 'is-IS', 'it-CH', 'it-IT', 'ja-JP', 'ka-GE', 'kk-KZ',
+		'kn-IN', 'kok-IN', 'ko-KR', 'ky-KZ', 'Lt-az-AZ', 'lt-LT', 'Lt-sr-SP', 'Lt-uz-UZ', 
+		'lv-LV', 'mk-MK', 'mn-MN', 'mr-IN', 'ms-BN', 'ms-MY', 'nb-NO', 'nl-BE', 'nl-NL', 
+		'nn-NO', 'pa-IN', 'pl-PL', 'pt-BR', 'pt-PT', 'ro-RO', 'ru-RU', 'sa-IN', 'sk-SK', 
+		'sl-SI', 'sq-AL', 'sv-FI', 'sv-SE', 'sw-KE', 'syr-SY', 'ta-IN', 'te-IN', 'th-TH', 
+		'tr-TR', 'tt-RU', 'uk-UA', 'ur-PK', 'vi-VN', 'zh-CHS', 'zh-CHT', 'zh-CN', 'zh-HK', 
+		'zh-MO', 'zh-SG', 'zh-TW',   
+	);    
+
+	/**
+	 * Generate Device Platform
+	 *
+	 * Uses a random result with a weighting related to frequencies.
+	 */
+	public static function generate_platform()
+	{
+		$rand = mt_rand( 1, 100 );
+		$sum = 0;
+
+		foreach ( self::$browsers as $share => $freq_os )
+		{
+			$sum += $share;
+
+			if ( $rand <= $sum )
+			{
+				$rand = mt_rand( 1, 100 );
+				$sum = 0;
+
+				foreach ( $freq_os as $share => $choice )
+				{
+					$sum += $share;
+
+					if ( $rand <= $sum )
+					{
+						return $choice;
+					}
+				}
+			}
+		}
+
+		throw new Exception( 'Sum of $browsers frequency is not 100.' );
+	}
+
+	private static function array_random( $array )
+	{
+		$i = array_rand( $array, 1 );
+
+		return $array[$i];
+	}
+
+	private static function get_language( $lang = array() )
+	{
+		return self::array_random( empty( $lang ) ? self::$languages : $lang );
+	}
+
+	private static function get_processor( $os )
+	{
+		return self::array_random( self::$processors[$os] );
+	}
+
+	private static function get_version_nt()
+	{   
+		// Win2k (5.0) to Win 7 (6.1).
+		return mt_rand( 5, 6 ) . '.' . mt_rand( 0, 1 );
+	}
+
+	private static function get_version_osx()
+	{
+		return '10_' . mt_rand( 5, 7 ) . '_' . mt_rand( 0, 9 );
+	}
+
+	private static function get_version_webkit()
+	{
+		return mt_rand( 531, 536 ) . mt_rand( 0, 2 );
+	}
+
+	private static function get_verison_chrome()
+	{
+		return mt_rand( 13, 15 ) . '.0.' . mt_rand( 800, 899 ) . '.0';
+	}
+
+	private static function get_version_gecko()
+	{
+		return mt_rand( 17, 31 ) . '.0';
+	}
+
+	private static function get_version_ie()
+	{
+		return mt_rand( 7, 9 ) . '.0';
+	}
+
+	private static function get_version_trident()
+	{
+		// IE8 (4.0) to IE11 (7.0).
+		return mt_rand( 4, 7 ) . '.0';
+	}
+
+	private static function get_version_net()
+	{
+		// generic .NET Framework common language run time (CLR) version numbers.
+		$frameworks = array(
+			'2.0.50727',
+			'3.0.4506',
+			'3.5.30729',
+		);
+
+		$rev = '.' . mt_rand( 26, 648 );
+
+		return self::array_random( $frameworks ) . $rev;
+	}
+
+	private static function get_version_safari()
+	{
+		if ( mt_rand( 0, 1 ) == 0 )
+		{
+			$ver = mt_rand( 4, 5 ) . '.' . mt_rand( 0, 1 );
+		}
+		else
+		{
+			$ver = mt_rand( 4, 5 ) . '.0.' . mt_rand( 1, 5 );
+		}
+
+		return $ver;
+	}
+
+	private static function get_version_opera()
+	{
+		return mt_rand( 15, 19 ) . '.0.' . mt_rand( 1147, 1284 ) . mt_rand( 49, 100 );
+	}
+
+	/**
+	 * Opera
+	 * 
+	 * @see: http://dev.opera.com/blog/opera-user-agent-strings-opera-15-and-beyond/
+	 */
+	public static function opera( $arch )
+	{
+		$opera = ' OPR/' . self::get_version_opera();
+
+		// WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
+		$engine = self::get_version_webkit();
+		$webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
+		$chrome = ' Chrome/' . self::get_verison_chrome();
+		$safari = ' Safari/' . $engine;
+
+		switch ( $arch )
+		{
+			case 'lin':
+				return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari . $opera;
+			case 'mac':
+				$osx = self::get_version_osx();
+				return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari . $opera;
+			case 'win':
+				// fall through.
+			default:
+				$nt = self::get_version_nt();
+				return '(Windows NT ' . $nt . '; WOW64) ' . $webkit . $chrome . $safari . $opera;
+		}
+	}    
+
+	/**
+	 * Safari
+	 *
+	 */
+	public static function safari( $arch )
+	{
+		$version = ' Version/' . self::get_version_safari();
+
+		// WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
+		$engine = self::get_version_webkit();
+		$webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
+		$safari = ' Safari/' . $engine;
+
+		switch ( $arch )
+		{
+			case 'mac':
+				$osx = self::get_version_osx();
+				return '(Macintosh; U; {proc} Mac OS X ' . $osx . '; {lang})' . $webkit . $version . $safari;
+			case 'win':
+				// fall through.
+			default:
+				$nt = self::get_version_nt();
+				return '(Windows; U; Windows NT ' . $nt . ')' . $webkit . $version . $safari;
+		}
+
+	}
+
+	/**
+	 * Internet Explorer
+	 * 
+	 * @see: http://msdn.microsoft.com/en-gb/library/ms537503(v=vs.85).aspx
+	 */
+	public static function iexplorer( $arch )
+	{
+		$nt = self::get_version_nt();
+		$ie = self::get_version_ie();
+		$trident = self::get_version_trident();
+		$net = self::get_version_net();
+
+		return '(compatible' 
+			. '; MSIE ' . $ie 
+			. '; Windows NT ' . $nt 
+			. '; WOW64' // A 32-bit version of Internet Explorer is running on a 64-bit processor.
+			. '; Trident/' . $trident 
+			. '; .NET CLR ' . $net
+			. ')';
+	}
+
+	/**
+	 * Firefox User-Agent
+	 *
+	 * @see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Gecko_user_agent_string_reference
+	 */
+	public static function firefox( $arch )
+	{
+		// The release version of Gecko. 
+		$gecko = self::get_version_gecko();
+
+		// On desktop, the gecko trail is fixed.
+		$trail = '20100101';
+
+		$release = 'rv:' . $gecko;
+		$version = 'Gecko/' . $trail . ' Firefox/' . $gecko;
+
+		switch ( $arch )
+		{
+			case 'lin':
+				return '(X11; Linux {proc}; ' . $release . ') ' . $version;
+			case 'mac':
+				$osx = self::get_version_osx();
+				return '(Macintosh; {proc} Mac OS X ' . $osx . '; ' . $release . ') ' . $version;
+			case 'win':
+				// fall through.
+			default:
+				$nt = self::get_version_nt();
+				return '(Windows NT ' . $nt . '; {lang}; ' . $release . ') ' . $version;
+		}
+	}
+
+	public static function chrome( $arch )
+	{
+		$chrome = ' Chrome/' . self::get_verison_chrome();
+
+		// WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
+		$engine = self::get_version_webkit();
+		$webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
+		$safari = ' Safari/' . $engine;
+
+		switch ( $arch )
+		{
+			case 'lin':
+				return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari;
+			case 'mac':
+				$osx = self::get_version_osx();
+				return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari;
+			case 'win':
+				// fall through.
+			default:
+				$nt = self::get_version_nt();
+				return '(Windows NT ' . $nt . ') ' . $webkit . $chrome . $safari;
+		}
+	}
+
+	public static function random( $lang = array( 'en-US' ) )
+	{
+		list( $browser, $os ) = self::generate_platform();
+
+		return self::generate( $browser, $os, $lang );
+	}
+
+	public static function generate( $browser = 'chrome', $os = 'win', $lang = array( 'en-US' ) )
+	{
+		$ua = self::MOZILLA . call_user_func( 'UAgent::' . $browser, $os );
+
+		$tags = array(
+			'{proc}' => self::get_processor( $os ),
+			'{lang}' => self::get_language( $lang ),
+		);
+
+		$ua = str_replace( array_keys( $tags ), array_values( $tags ), $ua );
+
+		return $ua;
+	}
 }
 ?>

Spacing +87 added lines, -87 removed lines

@@ -16,9 +16,9 @@ 
      * Processors by Arch.
      */
     public static $processors = array(
-        'lin' => array( 'i686', 'x86_64' ),
-        'mac' => array( 'Intel', 'PPC', 'U; Intel', 'U; PPC' ),
-        'win' => array( 'foo' )
+        'lin' => array('i686', 'x86_64'),
+        'mac' => array('Intel', 'PPC', 'U; Intel', 'U; PPC'),
+        'win' => array('foo')
     );
 
     /**
@@ -28,27 +28,27 @@ 
      */
     public static $browsers = array(
         34 => array(
-            89 => array( 'chrome', 'win' ),
-            9  => array( 'chrome', 'mac' ),
-            2  => array( 'chrome', 'lin' )
+            89 => array('chrome', 'win'),
+            9  => array('chrome', 'mac'),
+            2  => array('chrome', 'lin')
         ),
         32 => array(
-            100 => array( 'iexplorer', 'win' )
+            100 => array('iexplorer', 'win')
         ),
         25 => array(
-            83 => array( 'firefox', 'win' ),
-            16 => array( 'firefox', 'mac' ),
-            1  => array( 'firefox', 'lin' )
+            83 => array('firefox', 'win'),
+            16 => array('firefox', 'mac'),
+            1  => array('firefox', 'lin')
         ),
         7 => array(
-            95 => array( 'safari', 'mac' ),
-            4  => array( 'safari', 'win' ),
-            1  => array( 'safari', 'lin' )
+            95 => array('safari', 'mac'),
+            4  => array('safari', 'win'),
+            1  => array('safari', 'lin')
         ),
         2 => array(
-            91 => array( 'opera', 'win' ),
-            6  => array( 'opera', 'lin' ),
-            3  => array( 'opera', 'mac' )
+            91 => array('opera', 'win'),
+            6  => array('opera', 'lin'),
+            3  => array('opera', 'mac')
         )
     );
 
@@ -63,7 +63,7 @@ 
         'bg-BG', 'ca-ES', 'cs-CZ', 'Cy-az-AZ', 'Cy-sr-SP', 'Cy-uz-UZ', 'da-DK', 'de-AT',
         'de-CH', 'de-DE', 'de-LI', 'de-LU', 'div-MV', 'el-GR', 'en-AU', 'en-BZ', 'en-CA', 
         'en-CB', 'en-GB', 'en-IE', 'en-JM', 'en-NZ', 'en-PH', 'en-TT', 'en-US', 'en-ZA', 
-        'en-ZW', 'es-AR', 'es-BO', 'es-CL', 'es-CO',  'es-CR', 'es-DO', 'es-EC', 'es-ES',
+        'en-ZW', 'es-AR', 'es-BO', 'es-CL', 'es-CO', 'es-CR', 'es-DO', 'es-EC', 'es-ES',
         'es-GT', 'es-HN', 'es-MX', 'es-NI', 'es-PA', 'es-PE', 'es-PR', 'es-PY', 'es-SV',
         'es-UY', 'es-VE', 'et-EE', 'eu-ES', 'fa-IR', 'fi-FI', 'fo-FO', 'fr-BE', 'fr-CA',
         'fr-CH', 'fr-FR', 'fr-LU', 'fr-MC', 'gl-ES', 'gu-IN', 'he-IL', 'hi-IN', 'hr-HR', 
@@ -83,23 +83,23 @@ 
      */
     public static function generate_platform()
     {
-        $rand = mt_rand( 1, 100 );
+        $rand = mt_rand(1, 100);
         $sum = 0;
 
-        foreach ( self::$browsers as $share => $freq_os )
+        foreach (self::$browsers as $share => $freq_os)
         {
             $sum += $share;
 
-            if ( $rand <= $sum )
+            if ($rand <= $sum)
             {
-                $rand = mt_rand( 1, 100 );
+                $rand = mt_rand(1, 100);
                 $sum = 0;
 
-                foreach ( $freq_os as $share => $choice )
+                foreach ($freq_os as $share => $choice)
                 {
                     $sum += $share;
 
-                    if ( $rand <= $sum )
+                    if ($rand <= $sum)
                     {
                         return $choice;
                     }
@@ -107,61 +107,61 @@ 
             }
         }
 
-        throw new Exception( 'Sum of $browsers frequency is not 100.' );
+        throw new Exception('Sum of $browsers frequency is not 100.');
     }
 
-    private static function array_random( $array )
+    private static function array_random($array)
     {
-        $i = array_rand( $array, 1 );
+        $i = array_rand($array, 1);
 
         return $array[$i];
     }
 
-    private static function get_language( $lang = array() )
+    private static function get_language($lang = array())
     {
-        return self::array_random( empty( $lang ) ? self::$languages : $lang );
+        return self::array_random(empty($lang) ? self::$languages : $lang);
     }
 
-    private static function get_processor( $os )
+    private static function get_processor($os)
     {
-        return self::array_random( self::$processors[$os] );
+        return self::array_random(self::$processors[$os]);
     }
 
     private static function get_version_nt()
     {   
         // Win2k (5.0) to Win 7 (6.1).
-        return mt_rand( 5, 6 ) . '.' . mt_rand( 0, 1 );
+        return mt_rand(5, 6).'.'.mt_rand(0, 1);
     }
 
     private static function get_version_osx()
     {
-        return '10_' . mt_rand( 5, 7 ) . '_' . mt_rand( 0, 9 );
+        return '10_'.mt_rand(5, 7).'_'.mt_rand(0, 9);
     }
 
     private static function get_version_webkit()
     {
-        return mt_rand( 531, 536 ) . mt_rand( 0, 2 );
+        return mt_rand(531, 536).mt_rand(0, 2);
     }
 
     private static function get_verison_chrome()
     {
-        return mt_rand( 13, 15 ) . '.0.' . mt_rand( 800, 899 ) . '.0';
+        return mt_rand(13, 15).'.0.'.mt_rand(800, 899).'.0';
     }
 
     private static function get_version_gecko()
     {
-        return mt_rand( 17, 31 ) . '.0';
+        return mt_rand(17, 31).'.0';
     }
 
     private static function get_version_ie()
     {
-        return mt_rand( 7, 9 ) . '.0';
+        return mt_rand(7, 9).'.0';
     }
 
     private static function get_version_trident()
     {
         // IE8 (4.0) to IE11 (7.0).
-        return mt_rand( 4, 7 ) . '.0';
+        return mt_rand(4, 7).'.0';
     }
 
     private static function get_version_net()
@@ -173,20 +173,20 @@ 
             '3.5.30729',
         );
 
-        $rev = '.' . mt_rand( 26, 648 );
+        $rev = '.'.mt_rand(26, 648);
 
-        return self::array_random( $frameworks ) . $rev;
+        return self::array_random($frameworks).$rev;
     }
 
     private static function get_version_safari()
     {
-        if ( mt_rand( 0, 1 ) == 0 )
+        if (mt_rand(0, 1) == 0)
         {
-            $ver = mt_rand( 4, 5 ) . '.' . mt_rand( 0, 1 );
+            $ver = mt_rand(4, 5).'.'.mt_rand(0, 1);
         }
         else
         {
-            $ver = mt_rand( 4, 5 ) . '.0.' . mt_rand( 1, 5 );
+            $ver = mt_rand(4, 5).'.0.'.mt_rand(1, 5);
         }
 
         return $ver;
@@ -194,7 +194,7 @@ 
 
     private static function get_version_opera()
     {
-        return mt_rand( 15, 19 ) . '.0.' . mt_rand( 1147, 1284 ) . mt_rand( 49, 100 );
+        return mt_rand(15, 19).'.0.'.mt_rand(1147, 1284).mt_rand(49, 100);
     }
 
     /**
@@ -202,28 +202,28 @@ 
      * 
      * @see: http://dev.opera.com/blog/opera-user-agent-strings-opera-15-and-beyond/
      */
-    public static function opera( $arch )
+    public static function opera($arch)
     {
-        $opera = ' OPR/' . self::get_version_opera();
+        $opera = ' OPR/'.self::get_version_opera();
 
         // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
         $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $chrome = ' Chrome/' . self::get_verison_chrome();
-        $safari = ' Safari/' . $engine;
+        $webkit = ' AppleWebKit/'.$engine.' (KHTML, like Gecko)';
+        $chrome = ' Chrome/'.self::get_verison_chrome();
+        $safari = ' Safari/'.$engine;
 
-        switch ( $arch )
+        switch ($arch)
         {
             case 'lin':
-                return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari . $opera;
+                return '(X11; Linux {proc}) '.$webkit.$chrome.$safari.$opera;
             case 'mac':
                 $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari . $opera;
+                return '(Macintosh; U; {proc} Mac OS X '.$osx.')'.$webkit.$chrome.$safari.$opera;
             case 'win':
                 // fall through.
             default:
                 $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . '; WOW64) ' . $webkit . $chrome . $safari . $opera;
+                return '(Windows NT '.$nt.'; WOW64) '.$webkit.$chrome.$safari.$opera;
         }
     }    
 
@@ -231,25 +231,25 @@ 
      * Safari
      *
      */
-    public static function safari( $arch )
+    public static function safari($arch)
     {
-        $version = ' Version/' . self::get_version_safari();
+        $version = ' Version/'.self::get_version_safari();
 
         // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
         $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $safari = ' Safari/' . $engine;
+        $webkit = ' AppleWebKit/'.$engine.' (KHTML, like Gecko)';
+        $safari = ' Safari/'.$engine;
 
-        switch ( $arch )
+        switch ($arch)
         {
             case 'mac':
                 $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . '; {lang})' . $webkit . $version . $safari;
+                return '(Macintosh; U; {proc} Mac OS X '.$osx.'; {lang})'.$webkit.$version.$safari;
             case 'win':
                 // fall through.
             default:
                 $nt = self::get_version_nt();
-                return '(Windows; U; Windows NT ' . $nt . ')' . $webkit . $version . $safari;
+                return '(Windows; U; Windows NT '.$nt.')'.$webkit.$version.$safari;
         }
 
     }
@@ -259,7 +259,7 @@ 
      * 
      * @see: http://msdn.microsoft.com/en-gb/library/ms537503(v=vs.85).aspx
      */
-    public static function iexplorer( $arch )
+    public static function iexplorer($arch)
     {
         $nt = self::get_version_nt();
         $ie = self::get_version_ie();
@@ -267,11 +267,11 @@ 
         $net = self::get_version_net();
 
         return '(compatible' 
-            . '; MSIE ' . $ie 
-            . '; Windows NT ' . $nt 
+            . '; MSIE '.$ie 
+            . '; Windows NT '.$nt 
             . '; WOW64' // A 32-bit version of Internet Explorer is running on a 64-bit processor.
-            . '; Trident/' . $trident 
-            . '; .NET CLR ' . $net
+            . '; Trident/'.$trident 
+            . '; .NET CLR '.$net
             . ')';
     }
 
@@ -280,7 +280,7 @@ 
      *
      * @see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Gecko_user_agent_string_reference
      */
-    public static function firefox( $arch )
+    public static function firefox($arch)
     {
         // The release version of Gecko. 
         $gecko = self::get_version_gecko();
@@ -288,65 +288,65 @@ 
         // On desktop, the gecko trail is fixed.
         $trail = '20100101';
 
-        $release = 'rv:' . $gecko;
-        $version = 'Gecko/' . $trail . ' Firefox/' . $gecko;
+        $release = 'rv:'.$gecko;
+        $version = 'Gecko/'.$trail.' Firefox/'.$gecko;
 
-        switch ( $arch )
+        switch ($arch)
         {
             case 'lin':
-                return '(X11; Linux {proc}; ' . $release . ') ' . $version;
+                return '(X11; Linux {proc}; '.$release.') '.$version;
             case 'mac':
                 $osx = self::get_version_osx();
-                return '(Macintosh; {proc} Mac OS X ' . $osx . '; ' . $release . ') ' . $version;
+                return '(Macintosh; {proc} Mac OS X '.$osx.'; '.$release.') '.$version;
             case 'win':
                 // fall through.
             default:
                 $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . '; {lang}; ' . $release . ') ' . $version;
+                return '(Windows NT '.$nt.'; {lang}; '.$release.') '.$version;
         }
     }
 
-    public static function chrome( $arch )
+    public static function chrome($arch)
     {
-        $chrome = ' Chrome/' . self::get_verison_chrome();
+        $chrome = ' Chrome/'.self::get_verison_chrome();
 
         // WebKit Rendering Engine (WebKit = Backend, Safari = Frontend).
         $engine = self::get_version_webkit();
-        $webkit = ' AppleWebKit/' . $engine . ' (KHTML, like Gecko)';
-        $safari = ' Safari/' . $engine;
+        $webkit = ' AppleWebKit/'.$engine.' (KHTML, like Gecko)';
+        $safari = ' Safari/'.$engine;
 
-        switch ( $arch )
+        switch ($arch)
         {
             case 'lin':
-                return '(X11; Linux {proc}) ' . $webkit . $chrome . $safari;
+                return '(X11; Linux {proc}) '.$webkit.$chrome.$safari;
             case 'mac':
                 $osx = self::get_version_osx();
-                return '(Macintosh; U; {proc} Mac OS X ' . $osx . ')' . $webkit . $chrome . $safari;
+                return '(Macintosh; U; {proc} Mac OS X '.$osx.')'.$webkit.$chrome.$safari;
             case 'win':
                 // fall through.
             default:
                 $nt = self::get_version_nt();
-                return '(Windows NT ' . $nt . ') ' . $webkit . $chrome . $safari;
+                return '(Windows NT '.$nt.') '.$webkit.$chrome.$safari;
         }
     }
 
-    public static function random( $lang = array( 'en-US' ) )
+    public static function random($lang = array('en-US'))
     {
-        list( $browser, $os ) = self::generate_platform();
+        list($browser, $os) = self::generate_platform();
 
-        return self::generate( $browser, $os, $lang );
+        return self::generate($browser, $os, $lang);
     }
 
-    public static function generate( $browser = 'chrome', $os = 'win', $lang = array( 'en-US' ) )
+    public static function generate($browser = 'chrome', $os = 'win', $lang = array('en-US'))
     {
-        $ua = self::MOZILLA . call_user_func( 'UAgent::' . $browser, $os );
+        $ua = self::MOZILLA.call_user_func('UAgent::'.$browser, $os);
 
         $tags = array(
-            '{proc}' => self::get_processor( $os ),
-            '{lang}' => self::get_language( $lang ),
+            '{proc}' => self::get_processor($os),
+            '{lang}' => self::get_language($lang),
         );
 
-        $ua = str_replace( array_keys( $tags ), array_values( $tags ), $ua );
+        $ua = str_replace(array_keys($tags), array_values($tags), $ua);
 
         return $ua;
     }

Braces +1 added lines, -2 removed lines

@@ -183,8 +183,7 @@
         if ( mt_rand( 0, 1 ) == 0 )
         {
             $ver = mt_rand( 4, 5 ) . '.' . mt_rand( 0, 1 );
-        }
-        else
+        } else
         {
             $ver = mt_rand( 4, 5 ) . '.0.' . mt_rand( 1, 5 );
         }

country-statistics-aircraft.php

Indentation +2 added lines, -2 removed lines

@@ -3,8 +3,8 @@
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['country'])) {
-        header('Location: '.$globalURL.'/country');
-        die();
+		header('Location: '.$globalURL.'/country');
+		die();
 }
 $Spotter = new Spotter();
 

Spacing +8 added lines, -8 removed lines

@@ -8,13 +8,13 @@ 
 }
 $Spotter = new Spotter();
 
-$country = ucwords(str_replace("-", " ", urldecode(filter_input(INPUT_GET,'country',FILTER_SANITIZE_STRING))));
-$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
+$country = ucwords(str_replace("-", " ", urldecode(filter_input(INPUT_GET, 'country', FILTER_SANITIZE_STRING))));
+$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
 $spotter_array = $Spotter->getSpotterDataByCountry($country, "0,1", $sort);
 
 if (!empty($spotter_array))
 {
-	$title = sprintf(_("Most Common Aircraft from %s"),$country);
+	$title = sprintf(_("Most Common Aircraft from %s"), $country);
 
 	require_once('header.php');
 	print '<div class="select-item">';
@@ -22,9 +22,9 @@ 
 	print '<select name="country" class="selectpicker" data-live-search="true">';
 	print '<option></option>';
 	$all_countries = $Spotter->getAllCountries();
-	foreach($all_countries as $all_country)
+	foreach ($all_countries as $all_country)
 	{
-		if($country == $all_country['country'])
+		if ($country == $all_country['country'])
 		{
 			print '<option value="'.strtolower(str_replace(" ", "-", $all_country['country'])).'" selected="selected">'.$all_country['country'].'</option>';
 		} else {
@@ -39,7 +39,7 @@ 
 	if ($_GET['country'] != "NA")
 	{
 		print '<div class="info column">';
-		print '<h1>'.sprintf(_("Airports &amp; Airlines from %s"),$country).'</h1>';
+		print '<h1>'.sprintf(_("Airports &amp; Airlines from %s"), $country).'</h1>';
 		print '</div>';
 	} else {
 		print '<div class="alert alert-warning">'._("This special country profile shows all flights that do <u>not</u> have a country of a airline or departure/arrival airport associated with them.").'</div>';
@@ -48,7 +48,7 @@ 
 	include('country-sub-menu.php');
 	print '<div class="column">';
 	print '<h2>'._("Most Common Aircraft").'</h2>';
-	print '<p>'.sprintf(_("The statistic below shows the most common aircrafts of flights from <strong>%s</strong>."),$country).'</p>';
+	print '<p>'.sprintf(_("The statistic below shows the most common aircrafts of flights from <strong>%s</strong>."), $country).'</p>';
 
 	$aircraft_array = $Spotter->countAllAircraftTypesByCountry($country);
 	if (!empty($aircraft_array))
@@ -62,7 +62,7 @@ 
 		print '</thead>';
 		print '<tbody>';
 		$i = 1;
-		foreach($aircraft_array as $aircraft_item)
+		foreach ($aircraft_array as $aircraft_item)
 		{
 			print '<tr>';
 			print '<td><strong>'.$i.'</strong></td>';

registration-detailed.php

Spacing +7 added lines, -7 removed lines

@@ -3,17 +3,17 @@ 
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 
-if (!isset($_GET['registration'])){
+if (!isset($_GET['registration'])) {
 	header('Location: '.$globalURL.'');
 } else {
 	$Spotter = new Spotter();
 	//calculuation for the pagination
-	if(!isset($_GET['limit']))
+	if (!isset($_GET['limit']))
 	{
 		$limit_start = 0;
 		$limit_end = 25;
 		$absolute_difference = 25;
-	}  else {
+	} else {
 		$limit_explode = explode(",", $_GET['limit']);
 		$limit_start = $limit_explode[0];
 		$limit_end = $limit_explode[1];
@@ -26,8 +26,8 @@ 
 	$limit_next = $limit_end + $absolute_difference;
 	$limit_previous_1 = $limit_start - $absolute_difference;
 	$limit_previous_2 = $limit_end - $absolute_difference;
-	$registration = filter_input(INPUT_GET,'registration',FILTER_SANITIZE_STRING);
-	$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
+	$registration = filter_input(INPUT_GET, 'registration', FILTER_SANITIZE_STRING);
+	$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
 	
 	$page_url = $globalURL.'/registration/'.$registration;
 	
@@ -40,7 +40,7 @@ 
 	
 	if (!empty($spotter_array))
 	{
-		$title = sprintf(_("Detailed View of aircraft with registration %s"),$registration);
+		$title = sprintf(_("Detailed View of aircraft with registration %s"), $registration);
 		require_once('header.php');
 		print '<div class="info column">';
 		print '<h1>'.$registration.' - '.$aircraft_array[0]['aircraft_name'].' ('.$aircraft_array[0]['aircraft_icao'].')</h1>';
@@ -51,7 +51,7 @@ 
 		
 		include('registration-sub-menu.php');
 		print '<div class="table column">';
-		print '<p>'.sprintf(_("The table below shows the detailed information of all flights of aircraft with the registration <strong>%s</strong>."),$registration).'</p>';
+		print '<p>'.sprintf(_("The table below shows the detailed information of all flights of aircraft with the registration <strong>%s</strong>."), $registration).'</p>';
 
 		include('table-output.php');
 		print '<div class="pagination">';

Braces +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 		$limit_start = 0;
 		$limit_end = 25;
 		$absolute_difference = 25;
-	}  else {
+	} else {
 		$limit_explode = explode(",", $_GET['limit']);
 		$limit_start = $limit_explode[0];
 		$limit_end = $limit_explode[1];

contribute.php

Braces +13 added lines, -2 removed lines

@@ -11,10 +11,21 @@
     <p>You can contribute to <?php print $globalName; ?> if you have an ADS-B receiver.</p>
     <h3>You need to : </h3>
     <ul>
-	<li>Create an account on <a href="<?php if (isset($globalContributeLogin)) print $globalContributeLogin.'">'.$globalContributeLogin; else print 'https://login.flightairmap.fr">login.flightairmap.fr'; ?></a></li>
+	<li>Create an account on <a href="<?php if (isset($globalContributeLogin)) {
+	print $globalContributeLogin.'">'.$globalContributeLogin;
+} else {
+	print 'https://login.flightairmap.fr">login.flightairmap.fr';
+}
+?></a></li>
 	<li>Download dump1090 fork from <a href="https://github.com/Ysurac/dump1090">https://github.com/Ysurac/dump1090</a></li>
 	<li>Compile zfamup1090 with <em>make zfamup1090</em> (you need to have libcurl installed)</li>
-	<li>Run zfamup1090 : <em>./zfamup1090 --net-zfam-user YourUsername --net-zfam-pass YourPassword<?php if (isset($globalContributeURL)) print ' --net-zfam-addr '.$globalContributeURL; if (isset($globalContributePort)) print ' --net-zfam-port '.$globalContributePort; ?></em> (add <em>--net-bo-ipaddr ipofbeastsource --net-bo-port portofbeastsource</em> if needed, default to 127.0.0.1 and 30005)</li>
+	<li>Run zfamup1090 : <em>./zfamup1090 --net-zfam-user YourUsername --net-zfam-pass YourPassword<?php if (isset($globalContributeURL)) {
+	print ' --net-zfam-addr '.$globalContributeURL;
+}
+if (isset($globalContributePort)) {
+	print ' --net-zfam-port '.$globalContributePort;
+}
+?></em> (add <em>--net-bo-ipaddr ipofbeastsource --net-bo-port portofbeastsource</em> if needed, default to 127.0.0.1 and 30005)</li>
     </ul>
 </div>
 <?php

ident-statistics-manufacturer.php

Spacing +6 added lines, -6 removed lines

@@ -7,13 +7,13 @@ 
         die();
 }
 $Spotter = new Spotter();
-$sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);
-$ident = filter_input(INPUT_GET,'ident',FILTER_SANITIZE_STRING);
-$spotter_array = $Spotter->getSpotterDataByIdent($ident,"0,1", $sort);
+$sort = filter_input(INPUT_GET, 'sort', FILTER_SANITIZE_STRING);
+$ident = filter_input(INPUT_GET, 'ident', FILTER_SANITIZE_STRING);
+$spotter_array = $Spotter->getSpotterDataByIdent($ident, "0,1", $sort);
 
 if (!empty($spotter_array))
 {
-	$title = sprintf(_("Most Common Aircraft Manufacturer of %s"),$spotter_array[0]['ident']);
+	$title = sprintf(_("Most Common Aircraft Manufacturer of %s"), $spotter_array[0]['ident']);
 	require_once('header.php');
 	print '<div class="info column">';
 	print '<h1>'.$spotter_array[0]['ident'].'</h1>';
@@ -24,7 +24,7 @@ 
 	include('ident-sub-menu.php');
 	print '<div class="column">';
 	print '<h2>'._("Most Common Aircraft Manufacturer").'</h2>';
-	print '<p>'.sprintf(_("The statistic below shows the most common Aircraft Manufacturer of flights using the ident/callsign <strong>%s</strong>."),$spotter_array[0]['ident']).'</p>';
+	print '<p>'.sprintf(_("The statistic below shows the most common Aircraft Manufacturer of flights using the ident/callsign <strong>%s</strong>."), $spotter_array[0]['ident']).'</p>';
 
 	$manufacturers_array = $Spotter->countAllAircraftManufacturerByIdent($ident);
 	if (!empty($manufacturers_array))
@@ -39,7 +39,7 @@ 
 		print '</thead>';
 		print '<tbody>';
 		$i = 1;
-		foreach($manufacturers_array as $manufacturer_item)
+		foreach ($manufacturers_array as $manufacturer_item)
 		{
 			print '<tr>';
 			print '<td><strong>'.$i.'</strong></td>';

Indentation +2 added lines, -2 removed lines

@@ -3,8 +3,8 @@
 require_once('require/class.Spotter.php');
 require_once('require/class.Language.php');
 if (!isset($_GET['ident'])) {
-        header('Location: '.$globalURL.'/ident');
-        die();
+		header('Location: '.$globalURL.'/ident');
+		die();
 }
 $Spotter = new Spotter();
 $sort = filter_input(INPUT_GET,'sort',FILTER_SANITIZE_STRING);

footer.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 	<?php
 	    if (isset($sql_time)) {
 	?>
-	<i><?php echo _("Page generated in").' '.round($sql_time+$page_time,2); ?>s (<?php print round($page_time,2); ?>ms PHP - <?php print round($sql_time,2); ?>ms SQL)</i>
+	<i><?php echo _("Page generated in").' '.round($sql_time + $page_time, 2); ?>s (<?php print round($page_time, 2); ?>ms PHP - <?php print round($sql_time, 2); ?>ms SQL)</i>
 	<br />
 	<?php
 	    }

Indentation +2 added lines, -2 removed lines

@@ -6,12 +6,12 @@
 </div>
 <footer class="container">
 	<?php
-	    if (isset($sql_time)) {
+		if (isset($sql_time)) {
 	?>
 	<i><?php echo _("Page generated in").' '.round($sql_time+$page_time,2); ?>s (<?php print round($page_time,2); ?>ms PHP - <?php print round($sql_time,2); ?>ms SQL)</i>
 	<br />
 	<?php
-	    }
+		}
 	?>
 	<span>Developed in Barrie by <a href="http://mtru.nz/" target="_blank">Mario Trunz</a> & at <a href="http://www.zugaina.com" target="_blank">Zugaina</a> by Ycarus</span> - <span><a href="<?php if (isset($globalURL)) print $globalURL; ?>/about#source">Source &amp; Credits</a></span> - <span><a href="https://www.flightairmap.com/" target="_blank">Get source code</a></span>
 </footer>

Braces +8 added lines, -3 removed lines

@@ -1,8 +1,10 @@ 
 </section>
 <div class="pub onmap">
 <?php
-	if (isset($globalPub)) print $globalPub;
-?>
+	if (isset($globalPub)) {
+		print $globalPub;
+	}
+	?>
 </div>
 <footer class="container">
 	<?php
@@ -13,7 +15,10 @@ 
 	<?php
 	    }
 	?>
-	<span>Developed in Barrie by <a href="http://mtru.nz/" target="_blank">Mario Trunz</a> & at <a href="http://www.zugaina.com" target="_blank">Zugaina</a> by Ycarus</span> - <span><a href="<?php if (isset($globalURL)) print $globalURL; ?>/about#source">Source &amp; Credits</a></span> - <span><a href="https://www.flightairmap.com/" target="_blank">Get source code</a></span>
+	<span>Developed in Barrie by <a href="http://mtru.nz/" target="_blank">Mario Trunz</a> & at <a href="http://www.zugaina.com" target="_blank">Zugaina</a> by Ycarus</span> - <span><a href="<?php if (isset($globalURL)) {
+	print $globalURL;
+}
+?>/about#source">Source &amp; Credits</a></span> - <span><a href="https://www.flightairmap.com/" target="_blank">Get source code</a></span>
 </footer>
 
 <div class="notifications bottom-left"></div>

tools-acars.php

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 
 $page_url = $globalURL.'/tools-acars';
 
-$message = filter_input(INPUT_POST,'acars_message',FILTER_SANITIZE_STRING);
+$message = filter_input(INPUT_POST, 'acars_message', FILTER_SANITIZE_STRING);
 
 print '<div class="info column">';
 print '<h1>'._("Parse ACARS messages").'</h1>';

Braces +3 added lines, -1 removed lines

@@ -21,7 +21,9 @@
 print '<fieldset class="form-group">';
 print '<label for="acars_message">'._("ACARS Message").'</label>';
 print '<textarea class="form-control" name="acars_message" id="acars_message" rows="5">';
-if ($message != '') print $message;
+if ($message != '') {
+	print $message;
+}
 print '</textarea>';
 print '</fieldset>';
 print '<button type="submit" class="btn btn-primary">Submit</button>';