Issues in getLatestData-tv.php - All Issues - Inspection of "Fix" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae4662...65be4b )

by Yannick

created 2016-08-04 12:55 UTC

getLatestData-tv.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
require_once('require/class.Connection.php');
require_once('require/class.Spotter.php');
require_once('require/class.Language.php');

header('Content-Type: text/javascript');
$Spotter = new Spotter();
$spotter_array = $Spotter->getRealTimeData($_GET['q']);

$output = '{';
$output .= '"flights": [';
if (!empty($spotter_array)) {
	foreach($spotter_array as $spotter_item)
	{
		$output .= '{';
		$output .= '"flight_id": "'.$spotter_item['spotter_id'].'",';
		$output .= '"html": "';
		$output .= '<tr id=\"table-tr-'.$spotter_item['spotter_id'].'\" style=\"display:none;\">';
		if ($_GET['image'] == "true")
		{
			if ($spotter_item['image'] != "")
			{
				$output .= '<td class=\"aircraft_image\">';
				$output .= '<img src=\"'.$spotter_item['image'].'\" alt=\"Click to see more information about this flight\" title=\"Click to see more information about this flight\" />';
				$output .= '</td>';
			} else {
				$output .= '<td class=\"aircraft_image\">';
				$output .= '<img src=\"'.$globalURL.'/images/placeholder.png\" alt=\"Click to see more information about this flight\" title=\"Click to see more information about this flight\" />';
				$output .= '</td>';
			}
		}
		if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.gif'))
		{
			$output .= '<td class=\"logo\">';
			$output .= '<img src=\"'.$globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.gif\" />';
			$output .= '</td>';
		} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.png'))
		{
			$output .= '<td class=\"logo\">';
			$output .= '<img src=\"'.$globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.png\" />';
			$output .= '</td>';
		} else {
			$output .= '<td class=\"logo-no-image\">';
			if ($spotter_item['airline_name'] != "")
			{
				$output .= $spotter_item['airline_name'];
			}
			$output .= '</td>';
		}
		$output .= '<td class=\"info\">';
		$output .= '<div class=\"flight\">';
		$output .= $spotter_item['departure_airport_city'].' ('.$spotter_item['departure_airport'].') <i class=\"fa fa-arrow-right\"></i> '.$spotter_item['arrival_airport_city'].' ('.$spotter_item['arrival_airport'].')';
		$output .= '</div>';
		if ($_GET['other_i'] == "1")
		{
			$output .= '<div class=\"other1\">';
		} else {
			$output .= '<div class=\"other1\" style=\"display:none;\">';
		}
		if ($spotter_item['registration'] != "")
		{
			$output .= '<span><i class=\"fa fa-align-justify\"></i> '.$spotter_item['registration'].'</span>';
		}
		if ($spotter_item['aircraft_name'] != "")
		{
			$output .= '<span><i class=\"fa fa-plane\"></i> '.$spotter_item['aircraft_name'].'</span>';
		} else {
			if ($spotter_item['aircraft_type'] != "")
			{
				$output .= '<span><i class=\"fa fa-plane\"></i> '.$spotter_item['aircraft_type'].'</span>';
			}
		}
		$output .= '<span><i class=\"fa fa-calendar\"></i> '.date('M j, Y g:i a', strtotime($spotter_item['date_iso_8601'])).'</span>';
		$output .= '</div>';
		if ($_GET['other_i'] == "2")
		{
			$output .= '<div class=\"other2\">';
		} else {
			$output .= '<div class=\"other2\" style=\"display:none;\">';
		}
		$output .= '<span><i class=\"fa fa-arrow-up\"></i> '.$spotter_item['departure_airport_city'].', '.$spotter_item['departure_airport_name'].', '.$spotter_item['departure_airport_country'].'</span>';
		$output .= '<span><i class=\"fa fa-arrow-down\"></i> '.$spotter_item['arrival_airport_city'].', '.$spotter_item['arrival_airport_name'].', '.$spotter_item['arrival_airport_country'].'</span>';
		$output .= '</div>';
		if ($_GET['other_i'] == "3")
		{
			$output .= '<div class=\"other3\">';
		} else {
			$output .= '<div class=\"other3\" style=\"display:none;\">';
		}
		if ($spotter_item['ident'] != "")
		{
			$output .= '<span><i class=\"fa fa-th-list\"></i> '.$spotter_item['ident'].'</span>';
		}
		if ($spotter_item['airline_name'] != "")
		{
			$output .= '<span><i class=\"fa fa-align-justify\"></i> '.$spotter_item['airline_name'].'</span>';
		}
		if ($spotter_item['airline_country'] != "")
		{
			$output .= '<span><i class=\"fa fa-globe\"></i> '.$spotter_item['airline_country'].'</span>';
		}
		$output .= '</div>';
		$output .= '</td>';
		$output .= '</tr>';

		$output .= '"';
		$output .= '},';
	}
	$output = substr($output, 0, -1);
}
$output .= ']';
$output .= '}';
print $output;

?>


1			<?php
2			require_once('require/class.Connection.php');
3			require_once('require/class.Spotter.php');
4			require_once('require/class.Language.php');
5
6			header('Content-Type: text/javascript');
7			$Spotter = new Spotter();
8			$spotter_array = $Spotter->getRealTimeData($_GET['q']);
9
10			$output = '{';
11			$output .= '"flights": [';
12			if (!empty($spotter_array)) {
13			foreach($spotter_array as $spotter_item)
14			{
15			$output .= '{';
16			$output .= '"flight_id": "'.$spotter_item['spotter_id'].'",';
17			$output .= '"html": "';
18			$output .= '<tr id=\"table-tr-'.$spotter_item['spotter_id'].'\" style=\"display:none;\">';
19			if ($_GET['image'] == "true")
20			{
21			if ($spotter_item['image'] != "")
22			{
23			$output .= '<td class=\"aircraft_image\">';
24			$output .= '<img src=\"'.$spotter_item['image'].'\" alt=\"Click to see more information about this flight\" title=\"Click to see more information about this flight\" />';
25			$output .= '</td>';
26			} else {
27			$output .= '<td class=\"aircraft_image\">';
28			$output .= '<img src=\"'.$globalURL.'/images/placeholder.png\" alt=\"Click to see more information about this flight\" title=\"Click to see more information about this flight\" />';
29			$output .= '</td>';
30			}
31			}
32			if ($globalIVAO && @getimagesize($globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.gif'))
33			{
34			$output .= '<td class=\"logo\">';
35			$output .= '<img src=\"'.$globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.gif\" />';
36			$output .= '</td>';
37			} elseif (@getimagesize($globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.png'))
38			{
39			$output .= '<td class=\"logo\">';
40			$output .= '<img src=\"'.$globalURL.'/images/airlines/'.$spotter_item['airline_icao'].'.png\" />';
41			$output .= '</td>';
42			} else {
43			$output .= '<td class=\"logo-no-image\">';
44			if ($spotter_item['airline_name'] != "")
45			{
46			$output .= $spotter_item['airline_name'];
47			}
48			$output .= '</td>';
49			}
50			$output .= '<td class=\"info\">';
51			$output .= '<div class=\"flight\">';
52			$output .= $spotter_item['departure_airport_city'].' ('.$spotter_item['departure_airport'].') <i class=\"fa fa-arrow-right\"></i> '.$spotter_item['arrival_airport_city'].' ('.$spotter_item['arrival_airport'].')';
53			$output .= '</div>';
54			if ($_GET['other_i'] == "1")
55			{
56			$output .= '<div class=\"other1\">';
57			} else {
58			$output .= '<div class=\"other1\" style=\"display:none;\">';
59			}
60			if ($spotter_item['registration'] != "")
61			{
62			$output .= '<span><i class=\"fa fa-align-justify\"></i> '.$spotter_item['registration'].'</span>';
63			}
64			if ($spotter_item['aircraft_name'] != "")
65			{
66			$output .= '<span><i class=\"fa fa-plane\"></i> '.$spotter_item['aircraft_name'].'</span>';
67			} else {
68			if ($spotter_item['aircraft_type'] != "")
69			{
70			$output .= '<span><i class=\"fa fa-plane\"></i> '.$spotter_item['aircraft_type'].'</span>';
71			}
72			}
73			$output .= '<span><i class=\"fa fa-calendar\"></i> '.date('M j, Y g:i a', strtotime($spotter_item['date_iso_8601'])).'</span>';
74			$output .= '</div>';
75			if ($_GET['other_i'] == "2")
76			{
77			$output .= '<div class=\"other2\">';
78			} else {
79			$output .= '<div class=\"other2\" style=\"display:none;\">';
80			}
81			$output .= '<span><i class=\"fa fa-arrow-up\"></i> '.$spotter_item['departure_airport_city'].', '.$spotter_item['departure_airport_name'].', '.$spotter_item['departure_airport_country'].'</span>';
82			$output .= '<span><i class=\"fa fa-arrow-down\"></i> '.$spotter_item['arrival_airport_city'].', '.$spotter_item['arrival_airport_name'].', '.$spotter_item['arrival_airport_country'].'</span>';
83			$output .= '</div>';
84			if ($_GET['other_i'] == "3")
85			{
86			$output .= '<div class=\"other3\">';
87			} else {
88			$output .= '<div class=\"other3\" style=\"display:none;\">';
89			}
90			if ($spotter_item['ident'] != "")
91			{
92			$output .= '<span><i class=\"fa fa-th-list\"></i> '.$spotter_item['ident'].'</span>';
93			}
94			if ($spotter_item['airline_name'] != "")
95			{
96			$output .= '<span><i class=\"fa fa-align-justify\"></i> '.$spotter_item['airline_name'].'</span>';
97			}
98			if ($spotter_item['airline_country'] != "")
99			{
100			$output .= '<span><i class=\"fa fa-globe\"></i> '.$spotter_item['airline_country'].'</span>';
101			}
102			$output .= '</div>';
103			$output .= '</td>';
104			$output .= '</tr>';
105
106			$output .= '"';
107			$output .= '},';
108			}
109			$output = substr($output, 0, -1);
110			}
111			$output .= ']';
112			$output .= '}';
113			print $output;
114
115			?>
			1 ignored issue – show Best Practice introduced 2016-08-01 12:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

Ysurac / FlightAirMap

Push — master ( ae4662...65be4b )

getLatestData-tv.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like