Inspection of "Fix, support for filter_name,..." - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e43ddd...ea120f )

by Yannick

created 2016-10-31 14:31 UTC

Status

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

@@ -5,7 +5,9 @@  discard block
 block discarded – undo
 $Stats = new Stats();
 $title = _("Statistics").' - '._("Most common Country a flight was over");
 
-if (!isset($filter_name)) $filter_name = '';
+if (!isset($filter_name)) {
+	$filter_name = '';
+}
 $airline_icao = (string)filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
 if ($airline_icao == 'all') {
     unset($_COOKIE['stats_airline_icao']);
@@ -14,8 +16,10 @@  discard block
 block discarded – undo
 } elseif ($airline_icao == '' && isset($_COOKIE['stats_airline_icao'])) {
     $airline_icao = $_COOKIE['stats_airline_icao'];
 } elseif ($airline_icao == '' && isset($globalFilter)) {
-    if (isset($globalFilter['airline'])) $airline_icao = $globalFilter['airline'][0];
-}
+    if (isset($globalFilter['airline'])) {
+    	$airline_icao = $globalFilter['airline'][0];
+    }
+    }
 setcookie('stats_airline_icao',$airline_icao);
 
 require_once('header.php');

Please login to merge, or discard this patch.

aircraft-statistics-arrival-airport-country.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,9 @@
 block discarded – undo
 	print '<select name="aircraft_type" class="selectpicker" data-live-search="true">';
 	print '<option></option>';
 	$aircraft_types = $Stats->getAllAircraftTypes();
-	if (empty($aircraft_types)) $aircraft_types = $Spotter->getAllAircraftTypes();
+	if (empty($aircraft_types)) {
+		$aircraft_types = $Spotter->getAllAircraftTypes();
+	}
 	foreach($aircraft_types as $aircraft_type)
 	{
 		if($aircraft_type == $aircrafttype['aircraft_icao'])

Please login to merge, or discard this patch.

statistics-registration.php 1 patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

@@ -5,7 +5,9 @@  discard block
 block discarded – undo
 $Stats = new Stats();
 $title = _("Statistics").' - '._("Most common Aircraft Registrations");
 
-if (!isset($filter_name)) $filter_name = '';
+if (!isset($filter_name)) {
+	$filter_name = '';
+}
 $airline_icao = (string)filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
 if ($airline_icao == 'all') {
     unset($_COOKIE['stats_airline_icao']);
@@ -14,8 +16,10 @@  discard block
 block discarded – undo
 } elseif ($airline_icao == '' && isset($_COOKIE['stats_airline_icao'])) {
     $airline_icao = $_COOKIE['stats_airline_icao'];
 } elseif ($airline_icao == '' && isset($globalFilter)) {
-    if (isset($globalFilter['airline'])) $airline_icao = $globalFilter['airline'][0];
-}
+    if (isset($globalFilter['airline'])) {
+    	$airline_icao = $globalFilter['airline'][0];
+    }
+    }
 setcookie('stats_airline_icao',$airline_icao);
 
 require_once('header.php');

Please login to merge, or discard this patch.

statistics-route-airport.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -5,7 +5,9 @@
 block discarded – undo
 $Spotter = new Spotter();
 $title = _("Statistics").' - '._("Most common Route by Airport");
 require_once('header.php');
-if (!isset($filter_name)) $filter_name = '';
+if (!isset($filter_name)) {
+	$filter_name = '';
+}
 include('statistics-sub-menu.php'); 
 
 print '<script type="text/javascript" src="https://www.google.com/jsapi"></script>

Please login to merge, or discard this patch.

airport-statistics-airline.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,9 @@
 block discarded – undo
 	print '<option></option>';
 	$Stats = new Stats();
 	$airport_names = $tats->getAllAirportNames();
-	if (empty($airport_names)) $airport_names = $Spotter->getAllAirportNames();
+	if (empty($airport_names)) {
+		$airport_names = $Spotter->getAllAirportNames();
+	}
 	ksort($airport_names);
 	foreach($airport_names as $airport_name)
 	{

Please login to merge, or discard this patch.

airline-detailed.php 1 patch

Braces +13 added lines, -5 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 		$limit_start = 0;
 		$limit_end = 25;
 		$absolute_difference = 25;
-	}  else {
+	} else {
 		$limit_explode = explode(",", $_GET['limit']);
 		$limit_start = $limit_explode[0];
 		$limit_end = $limit_explode[1];
@@ -38,7 +38,9 @@  discard block
 block discarded – undo
 	{
 		if (isset($spotter_array[0]['airline_name']) && isset($spotter_array[0]['airline_icao'])) {
 			$title = sprintf(_("Detailed View for %s (%s)"),$spotter_array[0]['airline_name'],$spotter_array[0]['airline_icao']);
-		} else $title = '';
+		} else {
+			$title = '';
+		}
 		require_once('header.php');
 	  
 		print '<div class="select-item">';
@@ -47,7 +49,9 @@  discard block
 block discarded – undo
 		print '<option></option>';
 		$Stats = new Stats();
 		$airline_names = $Stats->getAllAirlineNames();
-		if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
+		if (empty($airline_names)) {
+			$airline_names = $Spotter->getAllAirlineNames();
+		}
 		foreach($airline_names as $airline_name)
 		{
 			if($_GET['airline'] == $airline_name['airline_icao'])
@@ -76,8 +80,12 @@  discard block
 block discarded – undo
 			print '<div><span class="label">'._("Name").'</span>'.$spotter_array[0]['airline_name'].'</div>';
 			print '<div><span class="label">'._("Country").'</span>'.$spotter_array[0]['airline_country'].'</div>';
 			print '<div><span class="label">'._("ICAO").'</span>'.$spotter_array[0]['airline_icao'].'</div>';
-			if (isset($spotter_array[0]['airline_iata'])) print '<div><span class="label">'._("IATA").'</span>'.$spotter_array[0]['airline_iata'].'</div>';
-			if (isset($spotter_array[0]['airline_callsign'])) print '<div><span class="label">'._("Callsign").'</span>'.$spotter_array[0]['airline_callsign'].'</div>'; 
+			if (isset($spotter_array[0]['airline_iata'])) {
+				print '<div><span class="label">'._("IATA").'</span>'.$spotter_array[0]['airline_iata'].'</div>';
+			}
+			if (isset($spotter_array[0]['airline_callsign'])) {
+				print '<div><span class="label">'._("Callsign").'</span>'.$spotter_array[0]['airline_callsign'].'</div>';
+			}
 			print '<div><span class="label">'._("Type").'</span>'.ucwords($spotter_array[0]['airline_type']).'</div>';
 			print '</div>';
 		} else {

Please login to merge, or discard this patch.

statistics-sub-menu.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -7,7 +7,9 @@
 block discarded – undo
 				<?php
 					require_once('require/class.Stats.php');
 					$Stats = new Stats();
-					if (!isset($filter_name)) $filter_name = '';
+					if (!isset($filter_name)) {
+						$filter_name = '';
+					}
 					$airlines = $Stats->getAllAirlineNames($filter_name);
 					if (isset($airline_icao) && ($airline_icao == '' || $airline_icao == 'all')) {
 						print '<option value="all" selected>All</option>';

Please login to merge, or discard this patch.

statistics-owner.php 1 patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

@@ -5,7 +5,9 @@  discard block
 block discarded – undo
 $Stats = new Stats();
 $title = _("Statistics").' - '._("Most common owners");
 
-if (!isset($filter_name)) $filter_name = '';
+if (!isset($filter_name)) {
+	$filter_name = '';
+}
 $airline_icao = (string)filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
 if ($airline_icao == 'all') {
     unset($_COOKIE['stats_airline_icao']);
@@ -14,8 +16,10 @@  discard block
 block discarded – undo
 } elseif ($airline_icao == '' && isset($_COOKIE['stats_airline_icao'])) {
     $airline_icao = $_COOKIE['stats_airline_icao'];
 } elseif ($airline_icao == '' && isset($globalFilter)) {
-    if (isset($globalFilter['airline'])) $airline_icao = $globalFilter['airline'][0];
-}
+    if (isset($globalFilter['airline'])) {
+    	$airline_icao = $globalFilter['airline'][0];
+    }
+    }
 setcookie('stats_airline_icao',$airline_icao);
 
 require_once('header.php');

Please login to merge, or discard this patch.

statistics-airport-departure.php 1 patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

@@ -5,7 +5,9 @@  discard block
 block discarded – undo
 $Stats = new Stats();
 $title = _("Statistics").' - '._("Most common Departure Airport");
 
-if (!isset($filter_name)) $filter_name = '';
+if (!isset($filter_name)) {
+	$filter_name = '';
+}
 $airline_icao = (string)filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
 if ($airline_icao == 'all') {
     unset($_COOKIE['stats_airline_icao']);
@@ -14,8 +16,10 @@  discard block
 block discarded – undo
 } elseif ($airline_icao == '' && isset($_COOKIE['stats_airline_icao'])) {
     $airline_icao = $_COOKIE['stats_airline_icao'];
 } elseif ($airline_icao == '' && isset($globalFilter)) {
-    if (isset($globalFilter['airline'])) $airline_icao = $globalFilter['airline'][0];
-}
+    if (isset($globalFilter['airline'])) {
+    	$airline_icao = $globalFilter['airline'][0];
+    }
+    }
 setcookie('stats_airline_icao',$airline_icao);
 
 require_once('header.php');

Please login to merge, or discard this patch.

		@@ -5,7 +5,9 @@ discard block
		block discarded – undo
5	5	$Stats = new Stats();
6	6	$title = _("Statistics").' - '._("Most common Country a flight was over");
7	7
8		-if (!isset($filter_name)) $filter_name = '';
	8	+if (!isset($filter_name)) {
	9	+ $filter_name = '';
	10	+}
9	11	$airline_icao = (string)filter_input(INPUT_GET,'airline',FILTER_SANITIZE_STRING);
10	12	if ($airline_icao == 'all') {
11	13	unset($_COOKIE['stats_airline_icao']);
		@@ -14,8 +16,10 @@ discard block
		block discarded – undo
14	16	} elseif ($airline_icao == '' && isset($_COOKIE['stats_airline_icao'])) {
15	17	$airline_icao = $_COOKIE['stats_airline_icao'];
16	18	} elseif ($airline_icao == '' && isset($globalFilter)) {
17		- if (isset($globalFilter['airline'])) $airline_icao = $globalFilter['airline'][0];
18		-}
	19	+ if (isset($globalFilter['airline'])) {
	20	+ $airline_icao = $globalFilter['airline'][0];
	21	+ }
	22	+ }
19	23	setcookie('stats_airline_icao',$airline_icao);
20	24
21	25	require_once('header.php');

		@@ -22,7 +22,9 @@
		block discarded – undo
22	22	print '<select name="aircraft_type" class="selectpicker" data-live-search="true">';
23	23	print '<option></option>';
24	24	$aircraft_types = $Stats->getAllAircraftTypes();
25		- if (empty($aircraft_types)) $aircraft_types = $Spotter->getAllAircraftTypes();
	25	+ if (empty($aircraft_types)) {
	26	+ $aircraft_types = $Spotter->getAllAircraftTypes();
	27	+ }
26	28	foreach($aircraft_types as $aircraft_type)
27	29	{
28	30	if($aircraft_type == $aircrafttype['aircraft_icao'])

		@@ -5,7 +5,9 @@
		block discarded – undo
5	5	$Spotter = new Spotter();
6	6	$title = _("Statistics").' - '._("Most common Route by Airport");
7	7	require_once('header.php');
8		-if (!isset($filter_name)) $filter_name = '';
	8	+if (!isset($filter_name)) {
	9	+ $filter_name = '';
	10	+}
9	11	include('statistics-sub-menu.php');
10	12
11	13	print '<script type="text/javascript" src="https://www.google.com/jsapi"></script>

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	$limit_start = 0;
15	15	$limit_end = 25;
16	16	$absolute_difference = 25;
17		- } else {
	17	+ } else {
18	18	$limit_explode = explode(",", $_GET['limit']);
19	19	$limit_start = $limit_explode[0];
20	20	$limit_end = $limit_explode[1];
		@@ -38,7 +38,9 @@ discard block
		block discarded – undo
38	38	{
39	39	if (isset($spotter_array[0]['airline_name']) && isset($spotter_array[0]['airline_icao'])) {
40	40	$title = sprintf(_("Detailed View for %s (%s)"),$spotter_array[0]['airline_name'],$spotter_array[0]['airline_icao']);
41		- } else $title = '';
	41	+ } else {
	42	+ $title = '';
	43	+ }
42	44	require_once('header.php');
43	45
44	46	print '<div class="select-item">';
		@@ -47,7 +49,9 @@ discard block
		block discarded – undo
47	49	print '<option></option>';
48	50	$Stats = new Stats();
49	51	$airline_names = $Stats->getAllAirlineNames();
50		- if (empty($airline_names)) $airline_names = $Spotter->getAllAirlineNames();
	52	+ if (empty($airline_names)) {
	53	+ $airline_names = $Spotter->getAllAirlineNames();
	54	+ }
51	55	foreach($airline_names as $airline_name)
52	56	{
53	57	if($_GET['airline'] == $airline_name['airline_icao'])
		@@ -76,8 +80,12 @@ discard block
		block discarded – undo
76	80	print '<div><span class="label">'._("Name").'</span>'.$spotter_array[0]['airline_name'].'</div>';
77	81	print '<div><span class="label">'._("Country").'</span>'.$spotter_array[0]['airline_country'].'</div>';
78	82	print '<div><span class="label">'._("ICAO").'</span>'.$spotter_array[0]['airline_icao'].'</div>';
79		- if (isset($spotter_array[0]['airline_iata'])) print '<div><span class="label">'._("IATA").'</span>'.$spotter_array[0]['airline_iata'].'</div>';
80		- if (isset($spotter_array[0]['airline_callsign'])) print '<div><span class="label">'._("Callsign").'</span>'.$spotter_array[0]['airline_callsign'].'</div>';
	83	+ if (isset($spotter_array[0]['airline_iata'])) {
	84	+ print '<div><span class="label">'._("IATA").'</span>'.$spotter_array[0]['airline_iata'].'</div>';
	85	+ }
	86	+ if (isset($spotter_array[0]['airline_callsign'])) {
	87	+ print '<div><span class="label">'._("Callsign").'</span>'.$spotter_array[0]['airline_callsign'].'</div>';
	88	+ }
81	89	print '<div><span class="label">'._("Type").'</span>'.ucwords($spotter_array[0]['airline_type']).'</div>';
82	90	print '</div>';
83	91	} else {

		@@ -7,7 +7,9 @@
		block discarded – undo
7	7	<?php
8	8	require_once('require/class.Stats.php');
9	9	$Stats = new Stats();
10		- if (!isset($filter_name)) $filter_name = '';
	10	+ if (!isset($filter_name)) {
	11	+ $filter_name = '';
	12	+ }
11	13	$airlines = $Stats->getAllAirlineNames($filter_name);
12	14	if (isset($airline_icao) && ($airline_icao == '' \|\| $airline_icao == 'all')) {
13	15	print '<option value="all" selected>All</option>';

Ysurac / FlightAirMap

Push — master ( e43ddd...ea120f )

Status

Category

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +13 added lines, -5 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch

Braces +7 added lines, -3 removed lines patch added patch discarded remove patch