Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class TeamWorkerSpec extends ObjectBehavior |
||
| 10 | { |
||
| 11 | function it_is_initializable() |
||
| 12 | { |
||
| 13 | $this->shouldHaveType(TeamWorker::class); |
||
| 14 | } |
||
| 15 | |||
| 16 | function let() |
||
| 17 | { |
||
| 18 | $data = [ |
||
| 19 | 'id' => '1', |
||
| 20 | 'lastName' => 'Bob', |
||
| 21 | 'firstName' => 'Morane', |
||
| 22 | ]; |
||
| 23 | |||
| 24 | $this->beConstructedWith($data); |
||
| 25 | } |
||
| 26 | |||
| 27 | function it_should_be_hydrated() |
||
| 28 | { |
||
| 29 | $this->getId()->shouldReturn(1); |
||
| 30 | $this->getLastName()->shouldReturn('Bob'); |
||
| 31 | $this->getFirstName()->shouldReturn('Morane'); |
||
| 32 | } |
||
| 33 | } |
||
| 34 |