Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class FieldTranslationSpec extends ObjectBehavior |
||
10 | { |
||
11 | function it_is_initializable() |
||
12 | { |
||
13 | $this->shouldHaveType(FieldTranslation::class); |
||
14 | } |
||
15 | |||
16 | function let() |
||
17 | { |
||
18 | $data = [ |
||
19 | 'locale' => 'en', |
||
20 | 'value' => 'Required field', |
||
21 | ]; |
||
22 | |||
23 | $this->beConstructedWith($data); |
||
24 | } |
||
25 | |||
26 | function it_should_be_hydrated() |
||
27 | { |
||
28 | $this->getLocale()->shouldReturn('en'); |
||
29 | $this->getValue()->shouldReturn('Required field'); |
||
30 | } |
||
31 | } |
||
32 |