Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class UploadFileSpec extends ObjectBehavior |
||
10 | { |
||
11 | public function it_is_initializable() |
||
16 | |||
17 | public function it_should_works_if_file_is_a_string() |
||
25 | |||
26 | View Code Duplication | public function it_should_works_if_file_is_an_array_but_without_filename() |
|
34 | |||
35 | View Code Duplication | public function it_should_works_if_file_is_an_array() |
|
43 | |||
44 | public function it_should_fails_if_file_do_not_exists() |
||
49 | } |
||
50 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.