Yproximite\Api\Service\SiteService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	69
Duplicated Lines	47.83 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getSites()	11	11	1
A	getSite()	11	11	1
A	postSite()	0	12	1
A	getPlatformChildren()	11	11	1

<?php
declare(strict_types=1);

namespace Yproximite\Api\Service;

use Yproximite\Api\Model\Site\Site;
use Yproximite\Api\Message\Site\SitePostMessage;
use Yproximite\Api\Message\Site\PlatformChildrenListMessage;

/**
 * Class SiteService
 */
class SiteService extends AbstractService implements ServiceInterface
{
    /**
     * @return Site[]
     */
    public function getSites(): array

This method seems to be duplicated in your project.

    {
        $path = 'sites';

        $response = $this->getClient()->sendRequest('GET', $path);

        /** @var Site[] $models */
        $models = $this->getModelFactory()->createMany(Site::class, $response);

It seems like $response defined by $this->getClient()->sendRequest('GET', $path) on line 22 can also be of type null; however, Yproximite\Api\Factory\ModelFactory::createMany() does only seem to accept array, maybe add an additional type check?

        return $models;
    }

    /**
     * @param int $id
     *
     * @return Site
     */
    public function getSite(int $id): Site

This method seems to be duplicated in your project.

    {
        $path = sprintf('sites/%d', $id);

        $response = $this->getClient()->sendRequest('GET', $path);

        /** @var Site $model */
        $model = $this->getModelFactory()->create(Site::class, $response);

It seems like $response defined by $this->getClient()->sendRequest('GET', $path) on line 39 can also be of type null; however, Yproximite\Api\Factory\ModelFactory::create() does only seem to accept array, maybe add an additional type check?

        return $model;
    }

    /**
     * @param SitePostMessage $message
     *
     * @return Site
     */
    public function postSite(SitePostMessage $message): Site
    {
        $path = 'sites';
        $data = ['api_site' => $message->build()];

        $response = $this->getClient()->sendRequest('POST', $path, $data);

        /** @var Site $model */
        $model = $this->getModelFactory()->create(Site::class, $response);

It seems like $response defined by $this->getClient()->sendRequest('POST', $path, $data) on line 57 can also be of type null; however, Yproximite\Api\Factory\ModelFactory::create() does only seem to accept array, maybe add an additional type check?

        return $model;
    }

    /**
     * @param PlatformChildrenListMessage $message
     *
     * @return Site[]
     */
    public function getPlatformChildren(PlatformChildrenListMessage $message): array

This method seems to be duplicated in your project.

    {
        $path = sprintf('platform/%d/children', $message->getSiteId());

        $response = $this->getClient()->sendRequest('GET', $path);

        /** @var Site[] $models */
        $models = $this->getModelFactory()->createMany(Site::class, $response);

It seems like $response defined by $this->getClient()->sendRequest('GET', $path) on line 74 can also be of type null; however, Yproximite\Api\Factory\ModelFactory::createMany() does only seem to accept array, maybe add an additional type check?

        return $models;
    }
}