Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | View Code Duplication | class FieldService extends AbstractService implements ServiceInterface |
|
|
|||
16 | { |
||
17 | /** |
||
18 | * @param FieldListMessage $message |
||
19 | * |
||
20 | * @return Field[] |
||
21 | */ |
||
22 | public function getFields(FieldListMessage $message): array |
||
33 | |||
34 | /** |
||
35 | * @param FieldPostMessage $message |
||
36 | * |
||
37 | * @return Field |
||
38 | */ |
||
39 | public function postField(FieldPostMessage $message): Field |
||
51 | |||
52 | /** |
||
53 | * @param FieldPatchMessage $message |
||
54 | * |
||
55 | * @return Field |
||
56 | */ |
||
57 | public function patchField(FieldPatchMessage $message): Field |
||
69 | |||
70 | /** |
||
71 | * @param FieldOverrideMessage $message |
||
72 | * |
||
73 | * @return Field |
||
74 | */ |
||
75 | public function overrideField(FieldOverrideMessage $message): Field |
||
86 | } |
||
87 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.