Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | abstract class AbstractFieldMessage implements MessageInterface |
|
|
|||
14 | { |
||
15 | use SiteAwareMessageTrait; |
||
16 | |||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | private $token; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | private $description; |
||
26 | |||
27 | /** |
||
28 | * @var FieldTranslationMessage[] |
||
29 | */ |
||
30 | private $translations = []; |
||
31 | |||
32 | /** |
||
33 | * @return string |
||
34 | */ |
||
35 | public function getToken(): string |
||
39 | |||
40 | /** |
||
41 | * @param string $token |
||
42 | */ |
||
43 | public function setToken(string $token) |
||
47 | |||
48 | /** |
||
49 | * @return string |
||
50 | */ |
||
51 | public function getDescription(): string |
||
55 | |||
56 | /** |
||
57 | * @param string $description |
||
58 | */ |
||
59 | public function setDescription(string $description) |
||
63 | |||
64 | /** |
||
65 | * @return FieldTranslationMessage[] |
||
66 | */ |
||
67 | public function getTranslations(): array |
||
71 | |||
72 | /** |
||
73 | * @param FieldTranslationMessage $translation |
||
74 | */ |
||
75 | public function addTranslation(FieldTranslationMessage $translation) |
||
79 | |||
80 | /** |
||
81 | * @param FieldTranslationMessage $translation |
||
82 | */ |
||
83 | public function removeTranslation(FieldTranslationMessage $translation) |
||
87 | |||
88 | /** |
||
89 | * {@inheritdoc} |
||
90 | */ |
||
91 | public function build() |
||
99 | } |
||
100 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.