Issues in ProjectRepository.php (master) - Issues in master - Yproximite/PRReviewWatcher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entity/ProjectRepository.php (5 issues)

Labels

Duplication 5

Severity

Informational 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PRReviewWatcher\Entity;

class ProjectRepository extends Repository
{
    /**
     * @return array
     */
    public function findAll()

    {
        $sql     = 'SELECT * FROM project AS p LEFT JOIN credential AS c ON p.credential = c.idCred ORDER BY p.id DESC';
        $results = $this->db->prepare($sql);
        $results->execute();
        $results  = $results->fetchAll();
        $projects = array();

        foreach ($results as $row) {
            $projectId            = $row['id'];
            $projects[$projectId] = $this->buildDomainObject($row);
        }

        return $projects;
    }

    /**
     * @param $id
     *
     * @return Project
     */
    public function find($id)

    {
        $sql = 'SELECT p.*,c.idCred FROM project AS p, credential AS c WHERE p.id= :id';
        $row = $this->db->prepare($sql);
        $row->bindValue(':id', $id, SQLITE3_TEXT);
        $row->execute();
        $row = $this->db->fetchAssoc($sql, array($id));

        return $this->buildDomainObject($row);
    }

    /**
     * @param Project $project
     */
    public function save(Project $project)
    {
        $projectData = array(
            'name'       => $project->getName(),
            'branch'     => $project->getBranch(),
            'credential' => $project->getCredential(),
            'comment'    => $project->getComment(),
            'alive'      => $project->getAlive(),
        );

        if ($project->getId()) {
            $projectData['numberTaskList'] = $project->getNumberTaskList();
            $this->getDb()->update('project', $projectData, array('id' => $project->getId()));
        } else {
            $projectData['numberTaskList'] = 0;
            $this->getDb()->insert('project', $projectData);
        }
    }

    /**
     * @param $id
     */
    public function delete($id)
    {
        $this->getDb()->delete('project', array('id' => $id));
    }

    /**
     * @param $repoHook
     *
     * @return array
     */
    public function findBranch($repoHook)

    {
        $sql    = 'SELECT branch FROM project WHERE name = :name AND alive = 1;';
        $result = $this->db->prepare($sql);
        $result->bindValue(':name', $repoHook);
        $result->execute();
        $result   = $result->fetchAll();

        $branches = array();

        foreach ($result as $row) {
            $branch     = $row['branch'];
            $branches[] = $branch;
        }

        return $branches;
    }

    /**
     * @param $repoHook
     * @param $branchHook
     *
     * @return \Doctrine\DBAL\Driver\Statement|mixed
     */
    public function findComment($repoHook, $branchHook)

    {
        if ($branchHook == null) {
            $sql    = 'SELECT comment FROM project WHERE name = :name AND alive = 1;';
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
        } else {
            $sql    = 'SELECT comment FROM project WHERE name = :name AND branch = :branch AND alive = 1';
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
            $result->bindValue(':branch', $branchHook);
        }

        $result->execute();
        $result = $result->fetch();
        $result = $result['comment'];

        return $result;
    }

    /**
     * @param $repoHook
     * @param $branchHook
     *
     * @return \Doctrine\DBAL\Driver\Statement|mixed
     */
    public function findId($repoHook, $branchHook)

    {
        if ($branchHook == null) {
            $sql    = "SELECT id FROM project AS p , credential AS c WHERE name = :name AND branch = 'all';";
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
        } else {
            $sql    = "SELECT id FROM project AS p , credential AS c WHERE name = :name AND branch = :branch;";
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
            $result->bindValue(':branch', $branchHook);
        }

        $result->execute();
        $result = $result->fetch();
        $result = $result['id'];

        return $result;
    }

    /**
     * @param $id
     */
    public function incrementNumber($id)
    {
        $sql    = 'SELECT numberTaskList FROM project WHERE id = :id';
        $result = $this->db->prepare($sql);
        $result->bindValue(':id', $id);
        $result->execute();
        $result = $result->fetch();
        $result = $result['numberTaskList'];
        $result = $result + 1;

        $sql    = 'UPDATE project SET numberTaskList = :numberTaskList where id = :id;';
        $update = $this->db->prepare($sql);
        $update->bindValue(':numberTaskList', $result);
        $update->bindValue(':id', $id);
        $update->execute();
    }

    /**
     * @param $row
     * @return Project
     */
    protected function buildDomainObject($row)
    {
        $credential = new Credential();

        $project = new Project();
        $project->setId($row['id']);
        $project->setName($row['name']);
        $project->setBranch($row['branch']);
        if (array_key_exists('nameCred', $row)) {
            $credential->setNameCred($row['nameCred']);
            $project->setCredential($credential->getNameCred());
        } else {
            $project->setCredential($row['credential']);
        }
        $project->setComment($row['comment']);
        $project->setAlive($row['alive']);
        $project->setNumberTaskList($row['numberTaskList']);

        return $project;
    }
}


1		<?php
2
3		namespace PRReviewWatcher\Entity;
4
5		class ProjectRepository extends Repository
6		{
7		/**
8		* @return array
9		*/
10	View Code Duplication	public function findAll()
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		$sql = 'SELECT * FROM project AS p LEFT JOIN credential AS c ON p.credential = c.idCred ORDER BY p.id DESC';
13		$results = $this->db->prepare($sql);
14		$results->execute();
15		$results = $results->fetchAll();
16		$projects = array();
17
18		foreach ($results as $row) {
19		$projectId = $row['id'];
20		$projects[$projectId] = $this->buildDomainObject($row);
21		}
22
23		return $projects;
24		}
25
26		/**
27		* @param $id
28		*
29		* @return Project
30		*/
31	View Code Duplication	public function find($id)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$sql = 'SELECT p.*,c.idCred FROM project AS p, credential AS c WHERE p.id= :id';
34		$row = $this->db->prepare($sql);
35		$row->bindValue(':id', $id, SQLITE3_TEXT);
36		$row->execute();
37		$row = $this->db->fetchAssoc($sql, array($id));
38
39		return $this->buildDomainObject($row);
40		}
41
42		/**
43		* @param Project $project
44		*/
45		public function save(Project $project)
46		{
47		$projectData = array(
48		'name' => $project->getName(),
49		'branch' => $project->getBranch(),
50		'credential' => $project->getCredential(),
51		'comment' => $project->getComment(),
52		'alive' => $project->getAlive(),
53		);
54
55		if ($project->getId()) {
56		$projectData['numberTaskList'] = $project->getNumberTaskList();
57		$this->getDb()->update('project', $projectData, array('id' => $project->getId()));
58		} else {
59		$projectData['numberTaskList'] = 0;
60		$this->getDb()->insert('project', $projectData);
61		}
62		}
63
64		/**
65		* @param $id
66		*/
67		public function delete($id)
68		{
69		$this->getDb()->delete('project', array('id' => $id));
70		}
71
72		/**
73		* @param $repoHook
74		*
75		* @return array
76		*/
77	View Code Duplication	public function findBranch($repoHook)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$sql = 'SELECT branch FROM project WHERE name = :name AND alive = 1;';
80		$result = $this->db->prepare($sql);
81		$result->bindValue(':name', $repoHook);
82		$result->execute();
83		$result = $result->fetchAll();
84
85		$branches = array();
86
87		foreach ($result as $row) {
88		$branch = $row['branch'];
89		$branches[] = $branch;
90		}
91
92		return $branches;
93		}
94
95		/**
96		* @param $repoHook
97		* @param $branchHook
98		*
99		* @return \Doctrine\DBAL\Driver\Statement\|mixed
100		*/
101	View Code Duplication	public function findComment($repoHook, $branchHook)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		{
103		if ($branchHook == null) {
104		$sql = 'SELECT comment FROM project WHERE name = :name AND alive = 1;';
105		$result = $this->db->prepare($sql);
106		$result->bindValue(':name', $repoHook);
107		} else {
108		$sql = 'SELECT comment FROM project WHERE name = :name AND branch = :branch AND alive = 1';
109		$result = $this->db->prepare($sql);
110		$result->bindValue(':name', $repoHook);
111		$result->bindValue(':branch', $branchHook);
112		}
113
114		$result->execute();
115		$result = $result->fetch();
116		$result = $result['comment'];
117
118		return $result;
119		}
120
121		/**
122		* @param $repoHook
123		* @param $branchHook
124		*
125		* @return \Doctrine\DBAL\Driver\Statement\|mixed
126		*/
127	View Code Duplication	public function findId($repoHook, $branchHook)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128		{
129		if ($branchHook == null) {
130		$sql = "SELECT id FROM project AS p , credential AS c WHERE name = :name AND branch = 'all';";
131		$result = $this->db->prepare($sql);
132		$result->bindValue(':name', $repoHook);
133		} else {
134		$sql = "SELECT id FROM project AS p , credential AS c WHERE name = :name AND branch = :branch;";
135		$result = $this->db->prepare($sql);
136		$result->bindValue(':name', $repoHook);
137		$result->bindValue(':branch', $branchHook);
138		}
139
140		$result->execute();
141		$result = $result->fetch();
142		$result = $result['id'];
143
144		return $result;
145		}
146
147		/**
148		* @param $id
149		*/
150		public function incrementNumber($id)
151		{
152		$sql = 'SELECT numberTaskList FROM project WHERE id = :id';
153		$result = $this->db->prepare($sql);
154		$result->bindValue(':id', $id);
155		$result->execute();
156		$result = $result->fetch();
157		$result = $result['numberTaskList'];
158		$result = $result + 1;
159
160		$sql = 'UPDATE project SET numberTaskList = :numberTaskList where id = :id;';
161		$update = $this->db->prepare($sql);
162		$update->bindValue(':numberTaskList', $result);
163		$update->bindValue(':id', $id);
164		$update->execute();
165		}
166
167		/**
168		* @param $row
169		* @return Project
170		*/
171		protected function buildDomainObject($row)
172		{
173		$credential = new Credential();
174
175		$project = new Project();
176		$project->setId($row['id']);
177		$project->setName($row['name']);
178		$project->setBranch($row['branch']);
179		if (array_key_exists('nameCred', $row)) {
180		$credential->setNameCred($row['nameCred']);
181		$project->setCredential($credential->getNameCred());
182		} else {
183		$project->setCredential($row['credential']);
184		}
185		$project->setComment($row['comment']);
186		$project->setAlive($row['alive']);
187		$project->setNumberTaskList($row['numberTaskList']);
188
189		return $project;
190		}
191		}
192

Yproximite / PRReviewWatcher

Issues (21)

Security Analysis not enabled

src/Entity/ProjectRepository.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like