Issues in CredentialRepository.php (master) - Issues in master - Yproximite/PRReviewWatcher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entity/CredentialRepository.php (4 issues)

Labels

Duplication 4

Severity

Informational 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PRReviewWatcher\Entity;

class CredentialRepository extends Repository
{
    /**
     * Find every credential
     *
     * @return array
     */
    public function findAll()

    {
        $sql    = 'SELECT * FROM credential ORDER BY idCred DESC';
        $result = $this->db->prepare($sql);
        $result->execute();
        $result      = $result->fetchAll();
        $credentials = array();

        foreach ($result as $row) {
            $credentialId               = $row['idCred'];
            $credentials[$credentialId] = $this->buildDomainObject($row);
        }

        return $credentials;
    }

    /**
     * @param integer $id
     *
     * @return Credential
     */
    public function find($id)

    {
        $sql = 'SELECT * FROM credential WHERE idCred= :idCred';
        $row = $this->db->prepare($sql);
        $row->bindValue(':idCred', $id, SQLITE3_TEXT);
        $row->execute();
        $row = $this->db->fetchAssoc($sql, array($id));

        return $this->buildDomainObject($row);
    }

    /**
     * Save credential into db
     *
     * @param Credential $credential
     */
    public function save(Credential $credential)
    {
        $credentialData = array(
            'nameCred' => $credential->getNameCred(),
            'token'    => $credential->getToken(),
        );
        if ($credential->getIdCred()) {
            $this->getDb()->update('credential', $credentialData, array('idCred' => $credential->getIdCred()));
        } else {
            $this->getDb()->insert('credential', $credentialData);
        }
    }

    /**
     * @param $id
     */
    public function delete($id)
    {
        $this->getDb()->delete('credential', array('idCred' => $id));
    }

    /**
     * @return array
     */
    public function findAllAsArray()

    {
        $sql    = 'SELECT idCred, nameCred FROM credential ORDER BY idCred DESC';
        $result = $this->db->prepare($sql);
        $result->execute();
        $result      = $result->fetchAll();
        $credentials = array();

        foreach ($result as $row) {
            $id               = $row['idCred'];
            $credentials[$id] = $row['nameCred'];
        }

        return $credentials;
    }
    
    /**
     * @param $repoHook
     * @param $branchHook
     *
     * @return \Doctrine\DBAL\Driver\Statement|mixed
     */
    public function findToken($repoHook, $branchHook)

    {
        if ($branchHook == null) {
            $sql    = "SELECT token FROM credential AS c JOIN project AS P ON c.idcred = p.credential WHERE p.name = :name AND p.branch = 'all';";
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
        } else {
            $sql    = "SELECT token FROM credential AS c JOIN project AS P ON c.idcred = p.credential WHERE p.name = :name AND p.branch = :branch;";
            $result = $this->db->prepare($sql);
            $result->bindValue(':name', $repoHook);
            $result->bindValue(':branch', $branchHook);
        }

        $result->execute();
        $result = $result->fetch();
        $result = $result['token'];

        return $result;
    }

    /**
     * @param $repoHook
     *
     * @return \Doctrine\DBAL\Driver\Statement|mixed
     */
    public function findNameCredential($repoHook)
    {
        $sql    = 'SELECT nameCred FROM credential AS c JOIN project AS p ON c.idCred = p.credential AND p.name = :name;';
        $result = $this->db->prepare($sql);
        $result->bindValue(':name', $repoHook);
        $result->execute();
        $result = $result->fetch();
        $result = $result['nameCred'];

        return $result;
    }

    /**
     * @param $row
     * @return Credential
     */
    protected function buildDomainObject($row)
    {
        $credential = new Credential();
        $credential->setIdCred($row['idCred']);
        $credential->setNameCred($row['nameCred']);
        $credential->setToken($row['token']);

        return $credential;
    }
}


1		<?php
2
3		namespace PRReviewWatcher\Entity;
4
5		class CredentialRepository extends Repository
6		{
7		/**
8		* Find every credential
9		*
10		* @return array
11		*/
12	View Code Duplication	public function findAll()
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		$sql = 'SELECT * FROM credential ORDER BY idCred DESC';
15		$result = $this->db->prepare($sql);
16		$result->execute();
17		$result = $result->fetchAll();
18		$credentials = array();
19
20		foreach ($result as $row) {
21		$credentialId = $row['idCred'];
22		$credentials[$credentialId] = $this->buildDomainObject($row);
23		}
24
25		return $credentials;
26		}
27
28		/**
29		* @param integer $id
30		*
31		* @return Credential
32		*/
33	View Code Duplication	public function find($id)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$sql = 'SELECT * FROM credential WHERE idCred= :idCred';
36		$row = $this->db->prepare($sql);
37		$row->bindValue(':idCred', $id, SQLITE3_TEXT);
38		$row->execute();
39		$row = $this->db->fetchAssoc($sql, array($id));
40
41		return $this->buildDomainObject($row);
42		}
43
44		/**
45		* Save credential into db
46		*
47		* @param Credential $credential
48		*/
49		public function save(Credential $credential)
50		{
51		$credentialData = array(
52		'nameCred' => $credential->getNameCred(),
53		'token' => $credential->getToken(),
54		);
55		if ($credential->getIdCred()) {
56		$this->getDb()->update('credential', $credentialData, array('idCred' => $credential->getIdCred()));
57		} else {
58		$this->getDb()->insert('credential', $credentialData);
59		}
60		}
61
62		/**
63		* @param $id
64		*/
65		public function delete($id)
66		{
67		$this->getDb()->delete('credential', array('idCred' => $id));
68		}
69
70		/**
71		* @return array
72		*/
73	View Code Duplication	public function findAllAsArray()
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$sql = 'SELECT idCred, nameCred FROM credential ORDER BY idCred DESC';
76		$result = $this->db->prepare($sql);
77		$result->execute();
78		$result = $result->fetchAll();
79		$credentials = array();
80
81		foreach ($result as $row) {
82		$id = $row['idCred'];
83		$credentials[$id] = $row['nameCred'];
84		}
85
86		return $credentials;
87		}
88
89		/**
90		* @param $repoHook
91		* @param $branchHook
92		*
93		* @return \Doctrine\DBAL\Driver\Statement\|mixed
94		*/
95	View Code Duplication	public function findToken($repoHook, $branchHook)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		{
97		if ($branchHook == null) {
98		$sql = "SELECT token FROM credential AS c JOIN project AS P ON c.idcred = p.credential WHERE p.name = :name AND p.branch = 'all';";
99		$result = $this->db->prepare($sql);
100		$result->bindValue(':name', $repoHook);
101		} else {
102		$sql = "SELECT token FROM credential AS c JOIN project AS P ON c.idcred = p.credential WHERE p.name = :name AND p.branch = :branch;";
103		$result = $this->db->prepare($sql);
104		$result->bindValue(':name', $repoHook);
105		$result->bindValue(':branch', $branchHook);
106		}
107
108		$result->execute();
109		$result = $result->fetch();
110		$result = $result['token'];
111
112		return $result;
113		}
114
115		/**
116		* @param $repoHook
117		*
118		* @return \Doctrine\DBAL\Driver\Statement\|mixed
119		*/
120		public function findNameCredential($repoHook)
121		{
122		$sql = 'SELECT nameCred FROM credential AS c JOIN project AS p ON c.idCred = p.credential AND p.name = :name;';
123		$result = $this->db->prepare($sql);
124		$result->bindValue(':name', $repoHook);
125		$result->execute();
126		$result = $result->fetch();
127		$result = $result['nameCred'];
128
129		return $result;
130		}
131
132		/**
133		* @param $row
134		* @return Credential
135		*/
136		protected function buildDomainObject($row)
137		{
138		$credential = new Credential();
139		$credential->setIdCred($row['idCred']);
140		$credential->setNameCred($row['nameCred']);
141		$credential->setToken($row['token']);
142
143		return $credential;
144		}
145		}
146

Yproximite / PRReviewWatcher

Issues (21)

Security Analysis not enabled

src/Entity/CredentialRepository.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like