Issues in CredentialController.php (master) - Issues in master - Yproximite/PRReviewWatcher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/CredentialController.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PRReviewWatcher\Controller;

use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use PRReviewWatcher\Entity\Credential;
use PRReviewWatcher\Form\Type\CredentialType;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\ClientException;

class CredentialController
{
    public function indexAction(Application $app)
    {
        $credentials = $app['credential_repository']->findAll();

        return $app['twig']->render('credList.html.twig', array('credentials' => $credentials));
    }

    public function addCredentialAction(Request $request, Application $app)

    {
        $credential     = new Credential();
        $credentialForm = $app['form.factory']->create(new CredentialType(), $credential, ['mapped' => true, 'disable' => false]);
        $credentialForm->handleRequest($request);

        if ($credentialForm->isSubmitted() && $credentialForm->isValid()) {
            $token      = $credential->getToken();
            $name       = $credential->getNameCred();

            try {
                $client   = new Client();
                $res      = $client->get('https://api.github.com/user', [
                    'auth' => [
                        'token',
                        $token
                    ]
                ]);
                $status   = $res->getStatusCode();
                $testName = json_decode($res->getBody()->getContents(), true);

            } catch (ClientException $e) {
                $status = $e->getResponse()->getStatusCode();
            }
            if ($status == 200) {
                if ($name == $testName['login']) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    $app['credential_repository']->save($credential);
                    $app['session']->getFlashBag()->add('success', 'The credential was successfully created.');
                } else {
                    $app['session']->getFlashBag()->add('danger',
                        'This is not the user assigned at this token.');
                }
            } else {
                $app['session']->getFlashBag()->add('danger',
                    'The token is incorect. (GitHub API error ' . $status . ')');
            }
        }

        return $app['twig']->render('credList_form.html.twig', array(
            'title'          => 'New credential',
            'legend'         => 'New credential',
            'credentialForm' => $credentialForm->createView(),
        ));
    }

    public function editCredentialAction($id, Request $request, Application $app)

    {
        $credential     = $app['credential_repository']->find($id);
        $credentialForm = $app['form.factory']->create(new CredentialType(), $credential, ['mapped' => false, 'disable' => true]);
        $credentialForm->handleRequest($request);

        if ($credentialForm->isSubmitted() && $credentialForm->isValid()) {
            $token      = $credential->getToken();
            $name       = $credential->getNameCred();

            try {
                $client   = new Client();
                $res      = $client->get('https://api.github.com/user', [
                    'auth' => [
                        'token',
                        $token
                    ]
                ]);
                $status   = $res->getStatusCode();
                $testName = json_decode($res->getBody()->getContents(), true);

            } catch (ClientException $e) {
                $status = $e->getResponse()->getStatusCode();
            }
            if ($status == 200) {
                if ($name == $testName['login']) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    $app['credential_repository']->save($credential);
                    $app['session']->getFlashBag()->add('success', 'The credential was successfully updated.');
                } else {
                    $app['session']->getFlashBag()->add('danger',
                        'This is not the user assigned at this token.');
                }
            } else {
                $app['session']->getFlashBag()->add('danger',
                    'The token is incorect. (GitHub API error ' . $status . ')');
            }
        }

        return $app['twig']->render('credList_form.html.twig', array(
            'title'          => 'Edit credential',
            'legend'         => 'Edit credential',
            'credentialForm' => $credentialForm->createView(),
        ));
    }

    public function deleteCredentialAction($id, Application $app)
    {
        $app['credential_repository']->delete($id);
        $app['session']->getFlashBag()->add('success', 'The credential was successfully removed.');

        return $app->redirect('/admin/credential');
    }
}


1		<?php
2
3		namespace PRReviewWatcher\Controller;
4
5		use Silex\Application;
6		use Symfony\Component\HttpFoundation\Request;
7		use PRReviewWatcher\Entity\Credential;
8		use PRReviewWatcher\Form\Type\CredentialType;
9		use GuzzleHttp\Client;
10		use GuzzleHttp\Exception\ClientException;
11
12		class CredentialController
13		{
14		public function indexAction(Application $app)
15		{
16		$credentials = $app['credential_repository']->findAll();
17
18		return $app['twig']->render('credList.html.twig', array('credentials' => $credentials));
19		}
20
21	View Code Duplication	public function addCredentialAction(Request $request, Application $app)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$credential = new Credential();
24		$credentialForm = $app['form.factory']->create(new CredentialType(), $credential, ['mapped' => true, 'disable' => false]);
25		$credentialForm->handleRequest($request);
26
27		if ($credentialForm->isSubmitted() && $credentialForm->isValid()) {
28		$token = $credential->getToken();
29		$name = $credential->getNameCred();
30
31		try {
32		$client = new Client();
33		$res = $client->get('https://api.github.com/user', [
34		'auth' => [
35		'token',
36		$token
37		]
38		]);
39		$status = $res->getStatusCode();
40		$testName = json_decode($res->getBody()->getContents(), true);
41
42		} catch (ClientException $e) {
43		$status = $e->getResponse()->getStatusCode();
44		}
45		if ($status == 200) {
46		if ($name == $testName['login']) {
		0 ignored issues – show Bug introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$testName` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
47		$app['credential_repository']->save($credential);
48		$app['session']->getFlashBag()->add('success', 'The credential was successfully created.');
49		} else {
50		$app['session']->getFlashBag()->add('danger',
51		'This is not the user assigned at this token.');
52		}
53		} else {
54		$app['session']->getFlashBag()->add('danger',
55		'The token is incorect. (GitHub API error ' . $status . ')');
56		}
57		}
58
59		return $app['twig']->render('credList_form.html.twig', array(
60		'title' => 'New credential',
61		'legend' => 'New credential',
62		'credentialForm' => $credentialForm->createView(),
63		));
64		}
65
66	View Code Duplication	public function editCredentialAction($id, Request $request, Application $app)
		0 ignored issues – show Duplication introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		$credential = $app['credential_repository']->find($id);
69		$credentialForm = $app['form.factory']->create(new CredentialType(), $credential, ['mapped' => false, 'disable' => true]);
70		$credentialForm->handleRequest($request);
71
72		if ($credentialForm->isSubmitted() && $credentialForm->isValid()) {
73		$token = $credential->getToken();
74		$name = $credential->getNameCred();
75
76		try {
77		$client = new Client();
78		$res = $client->get('https://api.github.com/user', [
79		'auth' => [
80		'token',
81		$token
82		]
83		]);
84		$status = $res->getStatusCode();
85		$testName = json_decode($res->getBody()->getContents(), true);
86
87		} catch (ClientException $e) {
88		$status = $e->getResponse()->getStatusCode();
89		}
90		if ($status == 200) {
91		if ($name == $testName['login']) {
		0 ignored issues – show Bug introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$testName` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
92		$app['credential_repository']->save($credential);
93		$app['session']->getFlashBag()->add('success', 'The credential was successfully updated.');
94		} else {
95		$app['session']->getFlashBag()->add('danger',
96		'This is not the user assigned at this token.');
97		}
98		} else {
99		$app['session']->getFlashBag()->add('danger',
100		'The token is incorect. (GitHub API error ' . $status . ')');
101		}
102		}
103
104		return $app['twig']->render('credList_form.html.twig', array(
105		'title' => 'Edit credential',
106		'legend' => 'Edit credential',
107		'credentialForm' => $credentialForm->createView(),
108		));
109		}
110
111		public function deleteCredentialAction($id, Application $app)
112		{
113		$app['credential_repository']->delete($id);
114		$app['session']->getFlashBag()->add('success', 'The credential was successfully removed.');
115
116		return $app->redirect('/admin/credential');
117		}
118		}
119

Yproximite / PRReviewWatcher

Issues (21)

Security Analysis not enabled

src/Controller/CredentialController.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like