ApiController - Code Metrics - Yproximite/PRReviewWatcher - Measure and Improve Code Quality continuously with Scrutinizer

ApiController A
last analyzed 2016-11-18 13:41 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	2
dl	0
loc	48
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	createCheckListAction()	0	45	7

<?php

namespace PRReviewWatcher\Controller;

use Silex\Application;
use Symfony\Component\HttpFoundation\Request;
use GuzzleHttp\Client;

class ApiController
{
    public function createCheckListAction(Request $request, Application $app)
    {
        $repoHook      = $request->request->get('pull_request')['head']['repo']['full_name'];
        $branchHook    = $request->request->get('pull_request')['base']['ref'];
        $numberHook    = $request->request->get('number');
        $testOpened    = $request->request->get('action');
        $testStateOpen = $request->request->get('pull_request')['state'];

        //Creation of a pull request and not an issue.
        if (($testOpened == 'opened') && ($testStateOpen == 'open')) {
            $branch = $app['project_repository']->findBranch($repoHook);

            if (in_array('all', $branch)) {
                $comment = $app['project_repository']->findComment($repoHook, null);
                $id = $app['project_repository']->findId($repoHook, null);
                $token  = $app['credential_repository']->findToken($repoHook, null);
            }
            elseif (in_array($branchHook, $branch)){
                $comment = $app['project_repository']->findComment($repoHook, $branchHook);
                $id = $app['project_repository']->findId($repoHook, $branchHook);
                $token  = $app['credential_repository']->findToken($repoHook, $branchHook);
            }

            if (($comment != null) && ($token != null)) {
                $content = [
                    'auth' => [
                        'token',
                        $token,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    ]
                    ,
                    'json' => [
                        'body' => $comment,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    ],
                ];

                $url    = 'https://api.github.com/repos/' . $repoHook . '/issues/' . $numberHook . '/comments';
                $client = new Client();
                $client->post($url, $content);

                $app['project_repository']->incrementNumber($id);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

                return $app->json($content, 201);
            }
        }
    }
}


ApiController A
last analyzed 2016-11-18 13:41 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace PRReviewWatcher\Controller;
4
5			use Silex\Application;
6			use Symfony\Component\HttpFoundation\Request;
7			use GuzzleHttp\Client;
8
9			class ApiController
10			{
11			public function createCheckListAction(Request $request, Application $app)
12			{
13			$repoHook = $request->request->get('pull_request')['head']['repo']['full_name'];
14			$branchHook = $request->request->get('pull_request')['base']['ref'];
15			$numberHook = $request->request->get('number');
16			$testOpened = $request->request->get('action');
17			$testStateOpen = $request->request->get('pull_request')['state'];
18
19			//Creation of a pull request and not an issue.
20			if (($testOpened == 'opened') && ($testStateOpen == 'open')) {
21			$branch = $app['project_repository']->findBranch($repoHook);
22
23			if (in_array('all', $branch)) {
24			$comment = $app['project_repository']->findComment($repoHook, null);
25			$id = $app['project_repository']->findId($repoHook, null);
26			$token = $app['credential_repository']->findToken($repoHook, null);
27			}
28			elseif (in_array($branchHook, $branch)){
29			$comment = $app['project_repository']->findComment($repoHook, $branchHook);
30			$id = $app['project_repository']->findId($repoHook, $branchHook);
31			$token = $app['credential_repository']->findToken($repoHook, $branchHook);
32			}
33
34			if (($comment != null) && ($token != null)) {
35			$content = [
36			'auth' => [
37			'token',
38			$token,
			0 ignored issues – show Bug introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report The variable `$token` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
39			]
40			,
41			'json' => [
42			'body' => $comment,
			0 ignored issues – show Bug introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report The variable `$comment` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
43			],
44			];
45
46			$url = 'https://api.github.com/repos/' . $repoHook . '/issues/' . $numberHook . '/comments';
47			$client = new Client();
48			$client->post($url, $content);
49
50			$app['project_repository']->incrementNumber($id);
			0 ignored issues – show Bug introduced 2016-11-18 13:41 UTC by Report Bug Copy Issue Report The variable `$id` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
51
52			return $app->json($content, 201);
53			}
54			}
55			}
56			}
57

Yproximite / PRReviewWatcher

ApiController A last analyzed 2016-11-18 13:41 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ApiController A
last analyzed 2016-11-18 13:41 UTC