Youshido / GraphQL

Tests/StarWars/Schema/StarWarsData.php

<?php
/**
 * Date: 07.12.15
 *
 * @author Portey Vasil <portey@gmail.com>
 */

namespace Youshido\Tests\StarWars\Schema;


class StarWarsData
{
    private static function luke()

This method seems to be duplicated in your project.

    {
        return [
            'id'         => '1000',
            'name'       => 'Luke Skywalker',
            'friends'    => ['1002', '1003', '2000', '2001'],
            'appearsIn'  => [4, 5, 6],
            'homePlanet' => 'Tatooine',
        ];
    }

    private static function vader()

This method seems to be duplicated in your project.

    {
        return [
            'id'         => '1001',
            'name'       => 'Darth Vader',
            'friends'    => ['1004'],
            'appearsIn'  => [4, 5, 6],
            'homePlanet' => 'Tatooine',
        ];
    }

    private static function han()

This method seems to be duplicated in your project.

    {
        return [
            'id'        => '1002',
            'name'      => 'Han Solo',
            'friends'   => ['1000', '1003', '2001'],
            'appearsIn' => [4, 5, 6],
        ];
    }

    private static function leia()

This method seems to be duplicated in your project.

    {
        return [
            'id'         => '1003',
            'name'       => 'Leia Organa',
            'friends'    => ['1000', '1002', '2000', '2001'],
            'appearsIn'  => [4, 5, 6],
            'homePlanet' => 'Alderaan',
        ];
    }

    private static function tarkin()
    {
        return [
            'id'        => '1004',
            'name'      => 'Wilhuff Tarkin',
            'friends'   => ['1001'],
            'appearsIn' => [4],
        ];
    }

    static function humans()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return [
            '1000' => self::luke(),
            '1001' => self::vader(),
            '1002' => self::han(),
            '1003' => self::leia(),
            '1004' => self::tarkin(),
        ];
    }

    private static function threepio()

This method seems to be duplicated in your project.

    {
        return [
            'id'              => '2000',
            'name'            => 'C-3PO',
            'friends'         => ['1000', '1002', '1003', '2001'],
            'appearsIn'       => [4, 5, 6],
            'primaryFunction' => 'Protocol',
        ];
    }

    /**
     * We export artoo directly because the schema returns him
     * from a root field, and hence needs to reference him.
     */
    static function artoo()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return [

            'id'              => '2001',
            'name'            => 'R2-D2',
            'friends'         => ['1000', '1002', '1003'],
            'appearsIn'       => [4, 5, 6],
            'primaryFunction' => 'Astromech',
        ];
    }

    static function droids()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return [
            '2000' => self::threepio(),
            '2001' => self::artoo(),
        ];
    }

    /**
     * Helper function to get a character by ID.
     */
    static function getCharacter($id)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $humans = self::humans();
        $droids = self::droids();
        if (isset($humans[$id])) {
            return $humans[$id];
        }
        if (isset($droids[$id])) {
            return $droids[$id];
        }

        return null;
    }

    /**
     * @param $episode
     * @return array
     */
    static function getHero($episode)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if ($episode === 5) {
            // Luke is the hero of Episode V.
            return self::luke();
        }

        // Artoo is the hero otherwise.
        return self::artoo();
    }

    /**
     * Allows us to query for a character's friends.
     */
    static function getFriends($character)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return array_map([__CLASS__, 'getCharacter'], $character['friends']);
    }
}