Issues in ConfigTest.php (master) - Issues in master - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Issues (234)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/Library/Config/ConfigTest.php (5 issues)

Labels

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
* This file is a part of GraphQL project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 5/11/16 10:41 PM
*/

namespace Youshido\Tests\Library\Config;

use Youshido\GraphQL\Type\Enum\EnumType;
use Youshido\GraphQL\Type\Object\ObjectType;
use Youshido\GraphQL\Type\Scalar\IdType;
use Youshido\GraphQL\Type\Scalar\IntType;
use Youshido\GraphQL\Type\TypeService;
use Youshido\GraphQL\Validator\ConfigValidator\ConfigValidator;
use Youshido\Tests\DataProvider\TestConfig;
use Youshido\Tests\DataProvider\TestConfigExtraFields;
use Youshido\Tests\DataProvider\TestConfigInvalidRule;

class ConfigTest extends \PHPUnit_Framework_TestCase
{

    /**
     * @expectedException Youshido\GraphQL\Exception\ConfigurationException
     */
    public function testEmptyParams()
    {
        new TestConfig([]);
    }

    /**
     * @expectedException Youshido\GraphQL\Exception\ConfigurationException
     */
    public function testInvalidParams()
    {
        ConfigValidator::getInstance()->assertValidConfig(new TestConfig(['id' => 1]));
    }

    /**
     * @expectedException \Exception
     */
    public function testInvalidMethod()
    {
        $config = new TestConfig(['name' => 'test']);
        $config->doSomethingStrange();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function testMethods()
    {
        $name  = 'Test';
        $rules = [
            'name'    => ['type' => TypeService::TYPE_ANY, 'required' => true],
            'resolve' => ['type' => TypeService::TYPE_CALLABLE, 'final' => true],
        ];

        $config = new TestConfig(['name' => $name]);
        $this->assertEquals($config->getName(), $name);
        $this->assertEquals($config->get('name'), $name);
        $this->assertEquals($config->get('non existing key'), null);
        $this->assertEquals($config->set('name', 'StrangeName'), $config);
        $this->assertEquals($config->get('name'), 'StrangeName');
        $this->assertEquals($config->get('non existing', 'default'), 'default');
        $this->assertEquals($config->isName(), 'StrangeName');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertEquals($config->setName('StrangeName 2'), $config);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $config->set('var', 'value');
        $this->assertEquals($config->getVar(), 'value');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->assertEquals($config->getRules(), $rules);
        $this->assertEquals($config->getContextRules(), $rules);
        $this->assertNull($config->getResolveFunction());

        $object = new ObjectType([
            'name'   => 'TestObject',
            'fields' => [
                'id' => [
                    'type' => new IntType()
                ]
            ]
        ]);

        $finalConfig = new TestConfig(['name' => $name . 'final', 'resolve' => function () { return []; }], $object, true);
        $this->assertEquals($finalConfig->getType(), null);

        $rules['resolve']['required'] = true;
        $this->assertEquals($finalConfig->getContextRules(), $rules);

        $this->assertNotNull($finalConfig->getResolveFunction());

        $configExtraFields = new TestConfigExtraFields([
            'name'       => 'Test',
            'extraField' => 'extraValue'
        ]);
        $this->assertEquals('extraValue', $configExtraFields->get('extraField'));
    }

    /**
     * @expectedException Youshido\GraphQL\Exception\ConfigurationException
     */
    public function testFinalRule()
    {
        ConfigValidator::getInstance()->assertValidConfig(new TestConfig(['name' => 'Test' . 'final'], null, true));
    }

    /**
     * @expectedException Youshido\GraphQL\Exception\ConfigurationException
     */
    public function testInvalidRule()
    {
        ConfigValidator::getInstance()->assertValidConfig(
            new TestConfigInvalidRule(['name' => 'Test', 'invalidRuleField' => 'test'], null, null)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    /**
     * @expectedException Youshido\GraphQL\Exception\ConfigurationException
     */
    public function testEnumConfig()
    {
        $enumType = new EnumType([
            'name'   => 'Status',
            'values' => [
                [
                    'name'   => 'ACTIVE',
                    'values' => 1
                ]
            ]
        ]);
        $object   = new ObjectType([
            'name' => 'Project',
            'fields' => [
                'id' => new IdType(),
                'status' => $enumType
            ]
        ]);
        ConfigValidator::getInstance()->assertValidConfig($object->getConfig());
    }

}


1			<?php
2			/*
3			* This file is a part of GraphQL project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 5/11/16 10:41 PM
7			*/
8
9			namespace Youshido\Tests\Library\Config;
10
11			use Youshido\GraphQL\Type\Enum\EnumType;
12			use Youshido\GraphQL\Type\Object\ObjectType;
13			use Youshido\GraphQL\Type\Scalar\IdType;
14			use Youshido\GraphQL\Type\Scalar\IntType;
15			use Youshido\GraphQL\Type\TypeService;
16			use Youshido\GraphQL\Validator\ConfigValidator\ConfigValidator;
17			use Youshido\Tests\DataProvider\TestConfig;
18			use Youshido\Tests\DataProvider\TestConfigExtraFields;
19			use Youshido\Tests\DataProvider\TestConfigInvalidRule;
20
21			class ConfigTest extends \PHPUnit_Framework_TestCase
22			{
23
24			/**
25			* @expectedException Youshido\GraphQL\Exception\ConfigurationException
26			*/
27			public function testEmptyParams()
28			{
29			new TestConfig([]);
30			}
31
32			/**
33			* @expectedException Youshido\GraphQL\Exception\ConfigurationException
34			*/
35			public function testInvalidParams()
36			{
37			ConfigValidator::getInstance()->assertValidConfig(new TestConfig(['id' => 1]));
38			}
39
40			/**
41			* @expectedException \Exception
42			*/
43			public function testInvalidMethod()
44			{
45			$config = new TestConfig(['name' => 'test']);
46			$config->doSomethingStrange();
			0 ignored issues – show Documentation Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `doSomethingStrange` does not exist on `object<Youshido\Tests\DataProvider\TestConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
47			}
48
49			public function testMethods()
50			{
51			$name = 'Test';
52			$rules = [
53			'name' => ['type' => TypeService::TYPE_ANY, 'required' => true],
54			'resolve' => ['type' => TypeService::TYPE_CALLABLE, 'final' => true],
55			];
56
57			$config = new TestConfig(['name' => $name]);
58			$this->assertEquals($config->getName(), $name);
59			$this->assertEquals($config->get('name'), $name);
60			$this->assertEquals($config->get('non existing key'), null);
61			$this->assertEquals($config->set('name', 'StrangeName'), $config);
62			$this->assertEquals($config->get('name'), 'StrangeName');
63			$this->assertEquals($config->get('non existing', 'default'), 'default');
64			$this->assertEquals($config->isName(), 'StrangeName');
			0 ignored issues – show Documentation Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `isName` does not exist on `object<Youshido\Tests\DataProvider\TestConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
65			$this->assertEquals($config->setName('StrangeName 2'), $config);
			0 ignored issues – show Documentation Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setName` does not exist on `object<Youshido\Tests\DataProvider\TestConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
66
67			$config->set('var', 'value');
68			$this->assertEquals($config->getVar(), 'value');
			0 ignored issues – show Documentation Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getVar` does not exist on `object<Youshido\Tests\DataProvider\TestConfig>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
69
70			$this->assertEquals($config->getRules(), $rules);
71			$this->assertEquals($config->getContextRules(), $rules);
72			$this->assertNull($config->getResolveFunction());
73
74			$object = new ObjectType([
75			'name' => 'TestObject',
76			'fields' => [
77			'id' => [
78			'type' => new IntType()
79			]
80			]
81			]);
82
83			$finalConfig = new TestConfig(['name' => $name . 'final', 'resolve' => function () { return []; }], $object, true);
84			$this->assertEquals($finalConfig->getType(), null);
85
86			$rules['resolve']['required'] = true;
87			$this->assertEquals($finalConfig->getContextRules(), $rules);
88
89			$this->assertNotNull($finalConfig->getResolveFunction());
90
91			$configExtraFields = new TestConfigExtraFields([
92			'name' => 'Test',
93			'extraField' => 'extraValue'
94			]);
95			$this->assertEquals('extraValue', $configExtraFields->get('extraField'));
96			}
97
98			/**
99			* @expectedException Youshido\GraphQL\Exception\ConfigurationException
100			*/
101			public function testFinalRule()
102			{
103			ConfigValidator::getInstance()->assertValidConfig(new TestConfig(['name' => 'Test' . 'final'], null, true));
104			}
105
106			/**
107			* @expectedException Youshido\GraphQL\Exception\ConfigurationException
108			*/
109			public function testInvalidRule()
110			{
111			ConfigValidator::getInstance()->assertValidConfig(
112			new TestConfigInvalidRule(['name' => 'Test', 'invalidRuleField' => 'test'], null, null)
			0 ignored issues – show Documentation introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `null` is of type `null`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
113			);
114			}
115
116			/**
117			* @expectedException Youshido\GraphQL\Exception\ConfigurationException
118			*/
119			public function testEnumConfig()
120			{
121			$enumType = new EnumType([
122			'name' => 'Status',
123			'values' => [
124			[
125			'name' => 'ACTIVE',
126			'values' => 1
127			]
128			]
129			]);
130			$object = new ObjectType([
131			'name' => 'Project',
132			'fields' => [
133			'id' => new IdType(),
134			'status' => $enumType
135			]
136			]);
137			ConfigValidator::getInstance()->assertValidConfig($object->getConfig());
138			}
139
140			}
141

Youshido / GraphQL

Issues (234)

Security Analysis not enabled

Tests/Library/Config/ConfigTest.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like