Youshido\GraphQL\Type\NonNullType

Complexity

Total Complexity

14

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	3
A	getName()	0	4	1
A	getKind()	0	4	1
A	resolve()	0	4	1
A	isValidValue()	0	8	2
A	isCompositeType()	0	4	1
A	isInputType()	0	4	1
A	getNamedType()	0	4	1
A	getNullableType()	0	4	1
A	getTypeOf()	0	4	1
A	parseValue()	0	4	1

<?php
/*
 * This file is a part of GraphQL project.
 *
 * @author Alexandr Viniychuk <a@viniychuk.com>
 * created: 3:40 PM 4/29/16
 */

namespace Youshido\GraphQL\Type;


use Youshido\GraphQL\Config\Traits\ConfigAwareTrait;
use Youshido\GraphQL\Exception\ConfigurationException;

final class NonNullType extends AbstractType implements CompositeTypeInterface
{
    use ConfigAwareTrait;

    private $_typeOf;

    /**
     * NonNullType constructor.
     *
     * @param AbstractType|string $fieldType
     *
     * @throws ConfigurationException
     */
    public function __construct($fieldType)
    {
        if (!TypeService::isGraphQLType($fieldType)) {
            throw new ConfigurationException('NonNullType accepts only GraphpQL Types as argument');
        }
        if (TypeService::isScalarType($fieldType)) {
            $fieldType = TypeFactory::getScalarType($fieldType);

It seems like $fieldType defined by \Youshido\GraphQL\Type\TypeFactory::getScalarType($fieldType) on line 34 can also be of type object<Youshido\GraphQL\Type\AbstractType>; however, Youshido\GraphQL\Type\TypeFactory::getScalarType() does only seem to accept string, maybe add an additional type check?

        }

        $this->_typeOf = $fieldType;
    }

    public function getName()
    {
        return null;
    }

    public function getKind()
    {
        return TypeMap::KIND_NON_NULL;
    }

    public function resolve($value)
    {
        return $value;
    }

    public function isValidValue($value)
    {
        if ($value === null) {
            return false;
        }

        return $this->getNullableType()->isValidValue($value);
    }

    public function isCompositeType()
    {
        return true;
    }

    public function isInputType()
    {
        return true;
    }

    public function getNamedType()
    {
        return $this->getTypeOf();
    }

    public function getNullableType()
    {
        return $this->getTypeOf();
    }

    public function getTypeOf()
    {
        return $this->_typeOf;

The expression $this->_typeOf; of type Youshido\GraphQL\Type\AbstractType|string adds the type string to the return on line 86 which is incompatible with the return type declared by the interface Youshido\GraphQL\Type\CompositeTypeInterface::getTypeOf of type Youshido\GraphQL\Type\AbstractType.

    }

    public function parseValue($value)
    {
        return $this->getNullableType()->parseValue($value);
    }


}