InputValueType - Code Metrics - Inspection of "use json_encode to resolve defaultValue for args" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#44)

by Daniel

created 2016-09-08 13:17 UTC

InputValueType A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	31.25 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	6
Bugs	0	Features	1

Metric	Value
wmc	5
c	6
b	0
f	1
lcom	0
cbo	5
dl	15
loc	48
ccs	18
cts	18
cp	1
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	resolveType()	0	4	1
A	resolveDefaultValue()	0	6	2
A	build()	15	15	1
A	getName()	0	4	1

How to fix Duplicated Code

<?php
/**
 * Date: 03.12.15
 *
 * @author Portey Vasil <[email protected]>
 */

namespace Youshido\GraphQL\Introspection;

use Youshido\GraphQL\Field\Field;
use Youshido\GraphQL\Schema\AbstractSchema;
use Youshido\GraphQL\Type\NonNullType;
use Youshido\GraphQL\Type\Object\AbstractObjectType;
use Youshido\GraphQL\Type\TypeInterface;
use Youshido\GraphQL\Type\TypeMap;

class InputValueType extends AbstractObjectType
{
    /**
     * @param AbstractSchema|Field $value
     *
     * @return TypeInterface
     */
    public function resolveType($value)
    {
        return $value->getConfig()->getType();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param AbstractSchema|Field $value
     *
     * @return string|null
     */
    public function resolveDefaultValue($value)
    {
        $resolvedValue = $value->getConfig()->getDefaultValue();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $resolvedValue === null ? $resolvedValue : json_encode($resolvedValue);
    }

    public function build($config)

    {
        $config
            ->addField('name', new NonNullType(TypeMap::TYPE_STRING))
            ->addField('description', TypeMap::TYPE_STRING)
            ->addField(new Field([
                'name'    => 'type',
                'type'    => new NonNullType(new QueryType()),
                'resolve' => [$this, 'resolveType']
            ]))
            ->addField('defaultValue', [
                'type' => TypeMap::TYPE_STRING,
                'resolve' => [$this, 'resolveDefaultValue']
            ]);
    }

    /**
     * @return string type name
     */
    public function getName()
    {
        return '__InputValue';
    }
}


Pull Request — master (#44)

InputValueType A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Date: 03.12.15
4			*
5			* @author Portey Vasil <[email protected]>
6			*/
7
8			namespace Youshido\GraphQL\Introspection;
9
10			use Youshido\GraphQL\Field\Field;
11			use Youshido\GraphQL\Schema\AbstractSchema;
12			use Youshido\GraphQL\Type\NonNullType;
13			use Youshido\GraphQL\Type\Object\AbstractObjectType;
14			use Youshido\GraphQL\Type\TypeInterface;
15			use Youshido\GraphQL\Type\TypeMap;
16
17			class InputValueType extends AbstractObjectType
18			{
19			/**
20			* @param AbstractSchema\|Field $value
21			*
22			* @return TypeInterface
23			*/
24	2		public function resolveType($value)
25			{
26	2		return $value->getConfig()->getType();
			0 ignored issues – show Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The method `getConfig` does only exist in `Youshido\GraphQL\Field\Field`, but not in `Youshido\GraphQL\Schema\AbstractSchema`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27			}
28
29			/**
30			* @param AbstractSchema\|Field $value
31			*
32			* @return string\|null
33			*/
34	3		public function resolveDefaultValue($value)
35			{
36	3		$resolvedValue = $value->getConfig()->getDefaultValue();
			0 ignored issues – show Bug introduced 2016-09-08 13:24 UTC by Report Bug Copy Issue Report The method `getConfig` does only exist in `Youshido\GraphQL\Field\Field`, but not in `Youshido\GraphQL\Schema\AbstractSchema`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37
38	3		return $resolvedValue === null ? $resolvedValue : json_encode($resolvedValue);
39			}
40
41	5	View Code Duplication	public function build($config)
			0 ignored issues – show Duplication introduced 2016-09-08 13:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42			{
43			$config
44	5		->addField('name', new NonNullType(TypeMap::TYPE_STRING))
45	5		->addField('description', TypeMap::TYPE_STRING)
46	5		->addField(new Field([
47	5		'name' => 'type',
48	5		'type' => new NonNullType(new QueryType()),
49	5		'resolve' => [$this, 'resolveType']
50			]))
51	5		->addField('defaultValue', [
52	5		'type' => TypeMap::TYPE_STRING,
53	5		'resolve' => [$this, 'resolveDefaultValue']
54			]);
55	5		}
56
57			/**
58			* @return string type name
59			*/
60	7		public function getName()
61			{
62	7		return '__InputValue';
63			}
64			}
65

Youshido / GraphQL

Pull Request — master (#44)

InputValueType A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like