Youshido /
GraphQL
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Processor often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Processor, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 42 | class Processor |
||
| 43 | { |
||
| 44 | |||
| 45 | const TYPE_NAME_QUERY = '__typename'; |
||
| 46 | |||
| 47 | /** @var ExecutionContext */ |
||
| 48 | protected $executionContext; |
||
| 49 | |||
| 50 | /** @var ResolveValidatorInterface */ |
||
| 51 | protected $resolveValidator; |
||
| 52 | |||
| 53 | /** @var array */ |
||
| 54 | protected $data; |
||
| 55 | |||
| 56 | /** @var int */ |
||
| 57 | protected $maxComplexity; |
||
| 58 | |||
| 59 | 41 | public function __construct(AbstractSchema $schema) |
|
| 68 | |||
| 69 | 39 | public function processPayload($payload, $variables = [], $reducers = []) |
|
| 70 | { |
||
| 71 | 39 | $this->data = []; |
|
| 72 | |||
| 73 | try { |
||
| 74 | 39 | $this->parseAndCreateRequest($payload, $variables); |
|
| 75 | |||
| 76 | 38 | if ($this->maxComplexity) { |
|
| 77 | 1 | $reducers[] = new MaxComplexityQueryVisitor($this->maxComplexity); |
|
| 78 | 1 | } |
|
| 79 | |||
| 80 | 38 | if ($reducers) { |
|
| 81 | 2 | $reducer = new Reducer(); |
|
| 82 | 2 | $reducer->reduceQuery($this->executionContext, $reducers); |
|
| 83 | 2 | } |
|
| 84 | |||
| 85 | 38 | foreach ($this->executionContext->getRequest()->getAllOperations() as $query) { |
|
| 86 | 38 | if ($operationResult = $this->resolveQuery($query)) { |
|
| 87 | 38 | $this->data = array_merge($this->data, $operationResult); |
|
| 88 | 38 | }; |
|
| 89 | 38 | } |
|
| 90 | 39 | } catch (\Exception $e) { |
|
| 91 | 5 | $this->executionContext->addError($e); |
|
| 92 | } |
||
| 93 | |||
| 94 | 39 | return $this; |
|
| 95 | } |
||
| 96 | |||
| 97 | 39 | public function getResponseData() |
|
| 111 | |||
| 112 | /** |
||
| 113 | * You can access ExecutionContext to check errors and inject dependencies |
||
| 114 | * |
||
| 115 | * @return ExecutionContext |
||
| 116 | */ |
||
| 117 | 10 | public function getExecutionContext() |
|
| 121 | |||
| 122 | /** |
||
| 123 | * @return int |
||
| 124 | */ |
||
| 125 | public function getMaxComplexity() |
||
| 129 | |||
| 130 | /** |
||
| 131 | * @param int $maxComplexity |
||
| 132 | */ |
||
| 133 | 1 | public function setMaxComplexity($maxComplexity) |
|
| 137 | |||
| 138 | 38 | protected function resolveQuery(AstQuery $query) |
|
| 152 | |||
| 153 | 38 | protected function resolveField(FieldInterface $field, AstFieldInterface $ast, $parentValue = null, $fromObject = false) |
|
| 212 | |||
| 213 | 38 | private function prepareAstArguments(FieldInterface $field, AstFieldInterface $query, Request $request) |
|
| 223 | |||
| 224 | 17 | private function prepareArgumentValue($argumentValue, AbstractType $argumentType, Request $request) |
|
| 225 | { |
||
| 226 | 17 | switch ($argumentType->getKind()) { |
|
| 227 | 17 | case TypeMap::KIND_LIST: |
|
| 228 | /** @var $argumentType AbstractListType */ |
||
| 229 | 2 | $result = []; |
|
| 230 | 2 | if ($argumentValue instanceof AstInputList || is_array($argumentValue)) { |
|
| 231 | 2 | $list = is_array($argumentValue) ? $argumentValue : $argumentValue->getValue(); |
|
| 232 | 2 | foreach ($list as $item) { |
|
| 233 | 2 | $result[] = $this->prepareArgumentValue($item, $argumentType->getItemType()->getNullableType(), $request); |
|
| 234 | 2 | } |
|
| 235 | 2 | } else if ($argumentValue instanceof VariableReference) { |
|
| 236 | return $this->getVariableReferenceArgumentValue($argumentValue, $argumentType, $request); |
||
| 237 | } |
||
| 238 | |||
| 239 | 2 | return $result; |
|
| 240 | |||
| 241 | 17 | case TypeMap::KIND_INPUT_OBJECT: |
|
| 242 | /** @var $argumentType AbstractInputObjectType */ |
||
| 243 | 2 | $result = []; |
|
| 244 | 2 | if ($argumentValue instanceof AstInputObject) { |
|
| 245 | 2 | foreach ($argumentValue->getValue() as $key => $item) { |
|
| 246 | 2 | if ($argumentType->hasField($key)) { |
|
| 247 | 2 | $result[$key] = $this->prepareArgumentValue($item, $argumentType->getField($key)->getType()->getNullableType(), $request); |
|
| 248 | 2 | } else { |
|
| 249 | $result[$key] = $item; |
||
| 250 | } |
||
| 251 | 2 | } |
|
| 252 | 2 | } else if ($argumentValue instanceof VariableReference) { |
|
| 253 | return $this->getVariableReferenceArgumentValue($argumentValue, $argumentType, $request); |
||
| 254 | } |
||
| 255 | |||
| 256 | 2 | return $result; |
|
| 257 | |||
| 258 | 17 | case TypeMap::KIND_SCALAR: |
|
| 259 | 17 | case TypeMap::KIND_ENUM: |
|
| 260 | /** @var $argumentValue AstLiteral|VariableReference */ |
||
| 261 | 17 | if ($argumentValue instanceof VariableReference) { |
|
| 262 | 4 | return $this->getVariableReferenceArgumentValue($argumentValue, $argumentType, $request); |
|
| 263 | 14 | } else if ($argumentValue instanceof AstLiteral) { |
|
| 264 | 12 | return $argumentValue->getValue(); |
|
| 265 | } else { |
||
| 266 | 3 | return $argumentValue; |
|
| 267 | } |
||
| 268 | } |
||
| 269 | |||
| 270 | throw new ResolveException('Argument type not supported'); |
||
| 271 | } |
||
| 272 | |||
| 273 | 4 | private function getVariableReferenceArgumentValue(VariableReference $variableReference, AbstractType $argumentType, Request $request) |
|
| 274 | { |
||
| 275 | 4 | $variable = $variableReference->getVariable(); |
|
| 276 | 4 | if ($argumentType->getKind() == TypeMap::KIND_LIST) { |
|
| 277 | if ($variable->getTypeName() != $argumentType->getNamedType()->getName() || !$variable->isArray()) { |
||
| 278 | throw new ResolveException(sprintf('Invalid variable "%s" type, allowed type is "%s"', $variable->getName(), $argumentType->getName()), $variable->getLocation()); |
||
| 279 | } |
||
| 280 | } else { |
||
| 281 | 4 | if ($variable->getTypeName() != $argumentType->getName()) { |
|
| 282 | 1 | throw new ResolveException(sprintf('Invalid variable "%s" type, allowed type is "%s"', $variable->getName(), $argumentType->getName()), $variable->getLocation()); |
|
| 283 | } |
||
| 284 | } |
||
| 285 | |||
| 286 | 3 | $requestValue = $request->getVariable($variable->getName()); |
|
| 287 | 3 | if (!$request->hasVariable($variable->getName()) || (null === $requestValue && $variable->isNullable())) { |
|
| 288 | throw new ResolveException(sprintf('Variable "%s" does not exist in request', $variable->getName()), $variable->getLocation()); |
||
| 289 | } |
||
| 290 | |||
| 291 | 3 | return $requestValue; |
|
| 292 | } |
||
| 293 | |||
| 294 | 25 | protected function resolveObject(FieldInterface $field, AstFieldInterface $ast, $parentValue, $fromUnion = false) |
|
| 295 | { |
||
| 296 | 25 | if (!$fromUnion) { |
|
| 297 | 20 | $resolvedValue = $this->doResolve($field, $ast, $parentValue); |
|
| 298 | 20 | } else { |
|
| 299 | 7 | $resolvedValue = $parentValue; |
|
| 300 | } |
||
| 301 | |||
| 302 | 25 | $this->resolveValidator->assertValidResolvedValueForField($field, $resolvedValue); |
|
| 303 | |||
| 304 | 25 | if (null === $resolvedValue) { |
|
| 305 | 5 | return null; |
|
| 306 | } |
||
| 307 | /** @var AbstractObjectType $type */ |
||
| 308 | 24 | $type = $field->getType()->getNullableType(); |
|
| 309 | |||
| 310 | try { |
||
| 311 | 24 | return $this->collectResult($field, $type, $ast, $resolvedValue); |
|
| 312 | 4 | } catch (\Exception $e) { |
|
| 313 | 4 | return null; |
|
| 314 | } |
||
| 315 | } |
||
| 316 | |||
| 317 | 24 | private function collectResult(FieldInterface $field, AbstractObjectType $type, $ast, $resolvedValue) |
|
| 318 | { |
||
| 319 | /** @var AstQuery $ast */ |
||
| 320 | 24 | $result = []; |
|
| 321 | |||
| 322 | 24 | foreach ($ast->getFields() as $astField) { |
|
| 323 | 24 | switch (true) { |
|
| 324 | 24 | case $astField instanceof TypedFragmentReference: |
|
| 325 | 2 | $astName = $astField->getTypeName(); |
|
| 326 | 2 | $typeName = $type->getName(); |
|
| 327 | |||
| 328 | 2 | View Code Duplication | if ($typeName !== $astName) { |
| 329 | 2 | foreach ($type->getInterfaces() as $interface) { |
|
| 330 | 1 | if ($interface->getName() === $astName) { |
|
| 331 | $result = array_merge($result, $this->collectResult($field, $type, $astField, $resolvedValue)); |
||
| 332 | |||
| 333 | break; |
||
| 334 | } |
||
| 335 | 2 | } |
|
| 336 | |||
| 337 | 2 | continue; |
|
| 338 | } |
||
| 339 | |||
| 340 | 2 | $result = array_merge($result, $this->collectResult($field, $type, $astField, $resolvedValue)); |
|
| 341 | |||
| 342 | 2 | break; |
|
| 343 | |||
| 344 | 24 | case $astField instanceof FragmentReference: |
|
| 345 | 3 | $astFragment = $this->executionContext->getRequest()->getFragment($astField->getName()); |
|
| 346 | 3 | $astFragmentModel = $astFragment->getModel(); |
|
| 347 | 3 | $typeName = $type->getName(); |
|
| 348 | |||
| 349 | 3 | View Code Duplication | if ($typeName !== $astFragmentModel) { |
| 350 | 1 | foreach ($type->getInterfaces() as $interface) { |
|
| 351 | 1 | if ($interface->getName() === $astFragmentModel) { |
|
| 352 | 1 | $result = array_merge($result, $this->collectResult($field, $type, $astFragment, $resolvedValue)); |
|
| 353 | |||
| 354 | 1 | break; |
|
| 355 | } |
||
| 356 | |||
| 357 | 1 | } |
|
| 358 | |||
| 359 | 1 | continue; |
|
| 360 | } |
||
| 361 | |||
| 362 | 3 | $result = array_merge($result, $this->collectResult($field, $type, $astFragment, $resolvedValue)); |
|
| 363 | |||
| 364 | 3 | break; |
|
| 365 | |||
| 366 | 24 | default: |
|
| 367 | 24 | $result[$this->getAlias($astField)] = $this->resolveField($field, $astField, $resolvedValue, true); |
|
| 368 | 24 | } |
|
| 369 | 24 | } |
|
| 370 | |||
| 371 | 24 | return $result; |
|
| 372 | } |
||
| 373 | |||
| 374 | 30 | protected function resolveScalar(FieldInterface $field, AstFieldInterface $ast, $parentValue) |
|
| 385 | |||
| 386 | 14 | protected function resolveList(FieldInterface $field, AstFieldInterface $ast, $parentValue) |
|
| 387 | { |
||
| 388 | /** @var AstQuery $ast */ |
||
| 389 | 14 | $resolvedValue = $this->doResolve($field, $ast, $parentValue); |
|
| 390 | |||
| 391 | 14 | $this->resolveValidator->assertValidResolvedValueForField($field, $resolvedValue); |
|
| 392 | |||
| 393 | 13 | if (null === $resolvedValue) { |
|
| 394 | 5 | return null; |
|
| 395 | } |
||
| 396 | |||
| 397 | /** @var AbstractListType $type */ |
||
| 398 | 12 | $type = $field->getType()->getNullableType(); |
|
| 399 | 12 | $itemType = $type->getNamedType(); |
|
| 400 | |||
| 401 | 12 | $fakeAst = clone $ast; |
|
| 402 | 12 | if ($fakeAst instanceof AstQuery) { |
|
| 403 | 12 | $fakeAst->setArguments([]); |
|
| 404 | 12 | } |
|
| 405 | |||
| 406 | 12 | $fakeField = new Field([ |
|
| 407 | 12 | 'name' => $field->getName(), |
|
| 408 | 12 | 'type' => $itemType, |
|
| 409 | 12 | ]); |
|
| 410 | |||
| 411 | 12 | $result = []; |
|
| 412 | 12 | foreach ($resolvedValue as $resolvedValueItem) { |
|
| 413 | try { |
||
| 414 | 11 | $fakeField->getConfig()->set('resolve', function () use ($resolvedValueItem) { |
|
| 415 | 11 | return $resolvedValueItem; |
|
| 416 | 11 | }); |
|
| 417 | |||
| 418 | 11 | switch ($itemType->getNullableType()->getKind()) { |
|
| 419 | 11 | case TypeMap::KIND_ENUM: |
|
| 420 | 11 | case TypeMap::KIND_SCALAR: |
|
| 421 | 4 | $value = $this->resolveScalar($fakeField, $fakeAst, $resolvedValueItem); |
|
| 422 | |||
| 423 | 3 | break; |
|
| 424 | |||
| 425 | |||
| 426 | 8 | case TypeMap::KIND_OBJECT: |
|
| 427 | 6 | $value = $this->resolveObject($fakeField, $fakeAst, $resolvedValueItem); |
|
| 428 | |||
| 429 | 6 | break; |
|
| 430 | |||
| 431 | 3 | case TypeMap::KIND_UNION: |
|
| 432 | 3 | case TypeMap::KIND_INTERFACE: |
|
| 433 | 3 | $value = $this->resolveComposite($fakeField, $fakeAst, $resolvedValueItem); |
|
| 434 | |||
| 435 | 3 | break; |
|
| 436 | |||
| 437 | default: |
||
| 438 | $value = null; |
||
| 439 | 10 | } |
|
| 440 | 11 | } catch (\Exception $e) { |
|
| 441 | 2 | $this->executionContext->addError($e); |
|
| 442 | |||
| 443 | 2 | $value = null; |
|
| 444 | } |
||
| 445 | |||
| 446 | 11 | $result[] = $value; |
|
| 447 | 12 | } |
|
| 448 | |||
| 449 | 12 | return $result; |
|
| 450 | } |
||
| 451 | |||
| 452 | 7 | protected function resolveComposite(FieldInterface $field, AstFieldInterface $ast, $parentValue) |
|
| 453 | { |
||
| 454 | /** @var AstQuery $ast */ |
||
| 455 | 7 | $resolvedValue = $this->doResolve($field, $ast, $parentValue); |
|
| 456 | |||
| 457 | 7 | $this->resolveValidator->assertValidResolvedValueForField($field, $resolvedValue); |
|
| 458 | |||
| 459 | /** @var AbstractUnionType $type */ |
||
| 460 | 7 | $type = $field->getType()->getNullableType(); |
|
| 461 | 7 | $resolvedType = $type->resolveType($resolvedValue); |
|
| 462 | |||
| 463 | 7 | if (!$resolvedType) { |
|
| 464 | throw new ResolveException('Resoling function must return type'); |
||
| 465 | } |
||
| 466 | |||
| 467 | 7 | if ($type instanceof AbstractInterfaceType) { |
|
| 468 | 6 | $this->resolveValidator->assertTypeImplementsInterface($resolvedType, $type); |
|
| 469 | 6 | } else { |
|
| 470 | 1 | $this->resolveValidator->assertTypeInUnionTypes($resolvedType, $type); |
|
| 471 | } |
||
| 472 | |||
| 473 | 7 | $fakeField = new Field([ |
|
| 474 | 7 | 'name' => $field->getName(), |
|
| 475 | 7 | 'type' => $resolvedType, |
|
| 476 | 7 | ]); |
|
| 477 | |||
| 478 | 7 | return $this->resolveObject($fakeField, $ast, $resolvedValue, true); |
|
| 479 | } |
||
| 480 | |||
| 481 | 39 | protected function parseAndCreateRequest($payload, $variables = []) |
|
| 494 | |||
| 495 | 35 | protected function doResolve(FieldInterface $field, AstFieldInterface $ast, $parentValue = null) |
|
| 503 | |||
| 504 | 35 | protected function parseArgumentsValues(FieldInterface $field, AstFieldInterface $ast) |
|
| 505 | { |
||
| 506 | 35 | $values = []; |
|
| 507 | 35 | $defaults = []; |
|
| 508 | |||
| 509 | 35 | foreach ($field->getArguments() as $argument) { |
|
| 510 | /** @var $argument InputField */ |
||
| 511 | 21 | if ($argument->getConfig()->has('default')) { |
|
| 512 | 6 | $defaults[$argument->getName()] = $argument->getConfig()->getDefaultValue(); |
|
| 513 | 6 | } |
|
| 514 | 35 | } |
|
| 515 | |||
| 516 | 35 | foreach ($ast->getArguments() as $astArgument) { |
|
| 517 | 15 | $argument = $field->getArgument($astArgument->getName()); |
|
| 518 | 15 | $argumentType = $argument->getType()->getNullableType(); |
|
| 519 | |||
| 520 | 15 | $values[$argument->getName()] = $argumentType->parseValue($astArgument->getValue()); |
|
| 521 | |||
| 522 | 15 | if (isset($defaults[$argument->getName()])) { |
|
| 523 | 3 | unset($defaults[$argument->getName()]); |
|
| 524 | 3 | } |
|
| 525 | 35 | } |
|
| 526 | |||
| 527 | 35 | return array_merge($values, $defaults); |
|
| 528 | } |
||
| 529 | |||
| 530 | 38 | private function getAlias(AstFieldInterface $ast) |
|
| 534 | |||
| 535 | 35 | protected function createResolveInfo(FieldInterface $field, array $astFields) |
|
| 539 | |||
| 540 | } |
||
| 541 |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.
In this case you can add the
@ignorePhpDoc annotation to the duplicate definition and it will be ignored.