Parser::parseListValue() - Code Metrics - Inspection of "fixed https://github.com/Youshido/GraphQL/issues/1..." - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7a187...1a4f5e )

by Alexandr

created 2017-03-26 21:53 UTC

Parser::parseListValue() C

↳ Parent: Parser

Complexity

Conditions	10
Paths	10

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	10.0244

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	15
cts	16
cp	0.9375
rs	5.6534
c	0
b	0
f	0
cc	10
eloc	16
nc	10
nop	0
crap	10.0244

How to fix Complexity

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Portey Vasil <[email protected]>
* created: 11/23/15 1:22 AM
*/

namespace Youshido\GraphQL\Parser;


use Youshido\GraphQL\Exception\Parser\SyntaxErrorException;
use Youshido\GraphQL\Parser\Ast\Argument;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputList;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputObject;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\VariableReference;
use Youshido\GraphQL\Parser\Ast\Field;
use Youshido\GraphQL\Parser\Ast\Fragment;
use Youshido\GraphQL\Parser\Ast\FragmentReference;
use Youshido\GraphQL\Parser\Ast\Mutation;
use Youshido\GraphQL\Parser\Ast\Query;
use Youshido\GraphQL\Parser\Ast\TypedFragmentReference;

class Parser extends Tokenizer
{

    /** @var array */
    private $data = [];

    public function parse($source = null)
    {
        $this->init($source);

        while (!$this->end()) {
            $tokenType = $this->peek()->getType();

            switch ($tokenType) {
                case Token::TYPE_LBRACE:
                case Token::TYPE_QUERY:
                    foreach ($this->parseBody() as $query) {
                        $this->data['queries'][] = $query;
                    }

                    break;

                case Token::TYPE_MUTATION:
                    foreach ($this->parseBody(Token::TYPE_MUTATION) as $query) {
                        $this->data['mutations'][] = $query;
                    }

                    break;

                case Token::TYPE_FRAGMENT:
                    $this->data['fragments'][] = $this->parseFragment();

                    break;

                default:
                    throw new SyntaxErrorException('Incorrect request syntax', $this->getLocation());
            }
        }

        return $this->data;
    }

    private function init($source = null)
    {
        $this->initTokenizer($source);

        $this->data = [
            'queries'            => [],
            'mutations'          => [],
            'fragments'          => [],
            'fragmentReferences' => [],
            'variables'          => [],
            'variableReferences' => []
        ];
    }

    protected function parseBody($token = Token::TYPE_QUERY, $highLevel = true)
    {
        $fields = [];
        $first  = true;

        if ($highLevel && $this->peek()->getType() === $token) {
            $this->lex();
            $this->eat(Token::TYPE_IDENTIFIER);

            if ($this->match(Token::TYPE_LPAREN)) {
                $this->parseVariables();
            }
        }

        $this->lex();

        while (!$this->match(Token::TYPE_RBRACE) && !$this->end()) {
            if ($first) {
                $first = false;
            } else {
                $this->eatMulti([Token::TYPE_COMMA]);
            }

            if ($this->match(Token::TYPE_FRAGMENT_REFERENCE)) {
                $this->lex();

                if ($this->eat(Token::TYPE_ON)) {
                    $fields[] = $this->parseBodyItem(Token::TYPE_TYPED_FRAGMENT, $highLevel);
                } else {
                    $fields[] = $this->parseFragmentReference();
                }
            } else {
                $fields[] = $this->parseBodyItem($token, $highLevel);
            }
        }

        $this->expect(Token::TYPE_RBRACE);

        return $fields;
    }

    protected function parseVariables()
    {
        $first = true;
        $this->eat(Token::TYPE_LPAREN);

        while (!$this->match(Token::TYPE_RPAREN) && !$this->end()) {
            if ($first) {
                $first = false;
            } else {
                $this->expect(Token::TYPE_COMMA);
            }

            $variableToken = $this->eat(Token::TYPE_VARIABLE);
            $nameToken     = $this->eatIdentifierToken();
            $this->eat(Token::TYPE_COLON);

            $isArray              = false;
            $arrayElementNullable = true;

            if ($this->match(Token::TYPE_LSQUARE_BRACE)) {
                $isArray = true;

                $this->eat(Token::TYPE_LSQUARE_BRACE);
                $type = $this->eatIdentifierToken()->getData();

                if ($this->match(Token::TYPE_REQUIRED)) {
                    $arrayElementNullable = false;
                    $this->eat(Token::TYPE_REQUIRED);
                }

                $this->eat(Token::TYPE_RSQUARE_BRACE);
            } else {
                $type = $this->eatIdentifierToken()->getData();
            }

            $required = false;
            if ($this->match(Token::TYPE_REQUIRED)) {
                $required = true;
                $this->eat(Token::TYPE_REQUIRED);
            }

            $this->data['variables'][] = new Variable(
                $nameToken->getData(),
                $type,
                $required,
                $isArray,
                new Location($variableToken->getLine(), $variableToken->getColumn()),
                $arrayElementNullable
            );
        }

        $this->expect(Token::TYPE_RPAREN);
    }

    protected function expectMulti($types)
    {
        if ($this->matchMulti($types)) {
            return $this->lex();
        }

        throw $this->createUnexpectedException($this->peek());
    }

    protected function parseVariableReference()
    {
        $startToken = $this->expectMulti([Token::TYPE_VARIABLE]);

        if ($this->match(Token::TYPE_NUMBER) || $this->match(Token::TYPE_IDENTIFIER) || $this->match(Token::TYPE_QUERY)) {
            $name = $this->lex()->getData();

            $variable = $this->findVariable($name);
            if ($variable) {
                $variable->setUsed(true);
            }

            $variableReference = new VariableReference($name, $variable, new Location($startToken->getLine(), $startToken->getColumn()));

            $this->data['variableReferences'][] = $variableReference;

            return $variableReference;
        }

        throw $this->createUnexpectedException($this->peek());
    }

    protected function findVariable($name)
    {
        foreach ($this->data['variables'] as $variable) {
            /** @var $variable Variable */
            if ($variable->getName() == $name) {
                return $variable;
            }
        }

        return null;
    }

    protected function parseFragmentReference()
    {
        $nameToken         = $this->eatIdentifierToken();
        $fragmentReference = new FragmentReference($nameToken->getData(), new Location($nameToken->getLine(), $nameToken->getColumn()));

        $this->data['fragmentReferences'][] = $fragmentReference;

        return $fragmentReference;
    }

    protected function eatIdentifierToken()
    {
        return $this->expectMulti([
            Token::TYPE_IDENTIFIER,
            Token::TYPE_MUTATION,
            Token::TYPE_QUERY,
            Token::TYPE_FRAGMENT,
        ]);
    }

    protected function parseBodyItem($type = Token::TYPE_QUERY, $highLevel = true)
    {
        $nameToken = $this->eatIdentifierToken();
        $alias     = null;

        if ($this->eat(Token::TYPE_COLON)) {
            $alias     = $nameToken->getData();
            $nameToken = $this->eatIdentifierToken();
        }

        $bodyLocation = new Location($nameToken->getLine(), $nameToken->getColumn());
        $arguments    = $this->match(Token::TYPE_LPAREN) ? $this->parseArgumentList() : [];

        if ($this->match(Token::TYPE_LBRACE)) {
            $fields = $this->parseBody($type == Token::TYPE_TYPED_FRAGMENT ? Token::TYPE_QUERY : $type, false);

            if (!$fields) {

                throw $this->createUnexpectedTokenTypeException($this->lookAhead->getType());
            }

            if ($type == Token::TYPE_QUERY) {

                return new Query($nameToken->getData(), $alias, $arguments, $fields, $bodyLocation);
            } elseif ($type == Token::TYPE_TYPED_FRAGMENT) {
                return new TypedFragmentReference($nameToken->getData(), $fields, $bodyLocation);
            } else {
                return new Mutation($nameToken->getData(), $alias, $arguments, $fields, $bodyLocation);
            }
        } else {

            if ($highLevel && $type == Token::TYPE_MUTATION) {
                return new Mutation($nameToken->getData(), $alias, $arguments, [], $bodyLocation);
            } elseif ($highLevel && $type == Token::TYPE_QUERY) {
                return new Query($nameToken->getData(), $alias, $arguments, [], $bodyLocation);
            }

            return new Field($nameToken->getData(), $alias, $arguments, $bodyLocation);
        }
    }

    protected function parseArgumentList()
    {
        $args  = [];
        $first = true;

        $this->expect(Token::TYPE_LPAREN);

        while (!$this->match(Token::TYPE_RPAREN) && !$this->end()) {
            if ($first) {
                $first = false;
            } else {
                if ($this->match(Token::TYPE_COMMA)) {
                    $this->eat(Token::TYPE_COMMA);
                }
            }

            $args[] = $this->parseArgument();
        }

        $this->expect(Token::TYPE_RPAREN);

        return $args;
    }

    protected function parseArgument()
    {
        $nameToken = $this->eatIdentifierToken();
        $this->expect(Token::TYPE_COLON);
        $value = $this->parseValue();

        return new Argument($nameToken->getData(), $value, new Location($nameToken->getLine(), $nameToken->getColumn()));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @return array|InputList|InputObject|Literal|VariableReference
     *
     * @throws SyntaxErrorException
     */
    protected function parseValue()
    {
        switch ($this->lookAhead->getType()) {
            case Token::TYPE_LSQUARE_BRACE:
                return $this->parseList();

            case Token::TYPE_LBRACE:
                return $this->parseObject();

            case Token::TYPE_VARIABLE:
                return $this->parseVariableReference();

            case Token::TYPE_NUMBER:
            case Token::TYPE_STRING:
            case Token::TYPE_IDENTIFIER:
            case Token::TYPE_NULL:
            case Token::TYPE_TRUE:
            case Token::TYPE_FALSE:
                $token = $this->lex();

                return new Literal($token->getData(), new Location($token->getLine(), $token->getColumn()));
        }

        throw $this->createUnexpectedException($this->lookAhead);
    }

    protected function parseList($createType = true)
    {
        $startToken = $this->eat(Token::TYPE_LSQUARE_BRACE);

        $list = [];
        while (!$this->match(Token::TYPE_RSQUARE_BRACE) && !$this->end()) {
            $list[] = $this->parseListValue();

            if ($this->lookAhead->getType() != Token::TYPE_RSQUARE_BRACE) {
                $this->expect(Token::TYPE_COMMA);
            }
        }

        $this->expect(Token::TYPE_RSQUARE_BRACE);

        return $createType ? new InputList($list, new Location($startToken->getLine(), $startToken->getColumn())) : $list;
    }

    protected function parseListValue()
    {
        switch ($this->lookAhead->getType()) {
            case Token::TYPE_NUMBER:
            case Token::TYPE_STRING:
            case Token::TYPE_TRUE:
            case Token::TYPE_FALSE:
            case Token::TYPE_NULL:
            case Token::TYPE_IDENTIFIER:
                return $this->expect($this->lookAhead->getType())->getData();

            case Token::TYPE_VARIABLE:
                return $this->parseVariableReference();

            case Token::TYPE_LBRACE:
                return $this->parseObject(true);

            case Token::TYPE_LSQUARE_BRACE:
                return $this->parseList(false);
        }

        throw new SyntaxErrorException('Can\'t parse argument', $this->getLocation());
    }

    protected function parseObject($createType = true)
    {
        $startToken = $this->eat(Token::TYPE_LBRACE);

        $object = [];
        while (!$this->match(Token::TYPE_RBRACE) && !$this->end()) {
            $key = $this->expectMulti([Token::TYPE_STRING, Token::TYPE_IDENTIFIER])->getData();
            $this->expect(Token::TYPE_COLON);
            $value = $this->parseListValue();

            if ($this->peek()->getType() != Token::TYPE_RBRACE) {
                $this->expect(Token::TYPE_COMMA);
            }

            $object[$key] = $value;
        }

        $this->eat(Token::TYPE_RBRACE);

        return $createType ? new InputObject($object, new Location($startToken->getLine(), $startToken->getColumn())) : $object;
    }

    protected function parseFragment()
    {
        $this->lex();
        $nameToken = $this->eatIdentifierToken();

        $this->eat(Token::TYPE_ON);

        $model  = $this->eatIdentifierToken();
        $fields = $this->parseBody(Token::TYPE_QUERY, false);

        return new Fragment($nameToken->getData(), $model->getData(), $fields, new Location($nameToken->getLine(), $nameToken->getColumn()));
    }

    protected function eat($type)
    {
        if ($this->match($type)) {
            return $this->lex();
        }

        return null;
    }

    protected function eatMulti($types)
    {
        if ($this->matchMulti($types)) {
            return $this->lex();
        }

        return null;
    }

    protected function matchMulti($types)
    {
        foreach ($types as $type) {
            if ($this->peek()->getType() == $type) {
                return true;
            }
        }

        return false;
    }
}


1			<?php
2			/*
3			* This file is a part of graphql-youshido project.
4			*
5			* @author Portey Vasil <[email protected]>
6			* created: 11/23/15 1:22 AM
7			*/
8
9			namespace Youshido\GraphQL\Parser;
10
11
12			use Youshido\GraphQL\Exception\Parser\SyntaxErrorException;
13			use Youshido\GraphQL\Parser\Ast\Argument;
14			use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputList;
15			use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputObject;
16			use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
17			use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
18			use Youshido\GraphQL\Parser\Ast\ArgumentValue\VariableReference;
19			use Youshido\GraphQL\Parser\Ast\Field;
20			use Youshido\GraphQL\Parser\Ast\Fragment;
21			use Youshido\GraphQL\Parser\Ast\FragmentReference;
22			use Youshido\GraphQL\Parser\Ast\Mutation;
23			use Youshido\GraphQL\Parser\Ast\Query;
24			use Youshido\GraphQL\Parser\Ast\TypedFragmentReference;
25
26			class Parser extends Tokenizer
27			{
28
29			/** @var array */
30			private $data = [];
31
32	98		public function parse($source = null)
33			{
34	98		$this->init($source);
35
36	98		while (!$this->end()) {
37	97		$tokenType = $this->peek()->getType();
38
39			switch ($tokenType) {
40	97		case Token::TYPE_LBRACE:
41	45		case Token::TYPE_QUERY:
42	79		foreach ($this->parseBody() as $query) {
43	70		$this->data['queries'][] = $query;
44			}
45
46	73		break;
47
48	26		case Token::TYPE_MUTATION:
49	17		foreach ($this->parseBody(Token::TYPE_MUTATION) as $query) {
50	11		$this->data['mutations'][] = $query;
51			}
52
53	11		break;
54
55	9		case Token::TYPE_FRAGMENT:
56	8		$this->data['fragments'][] = $this->parseFragment();
57
58	8		break;
59
60			default:
61	1		throw new SyntaxErrorException('Incorrect request syntax', $this->getLocation());
62			}
63			}
64
65	85		return $this->data;
66			}
67
68	98		private function init($source = null)
69			{
70	98		$this->initTokenizer($source);
71
72	98		$this->data = [
73			'queries' => [],
74			'mutations' => [],
75			'fragments' => [],
76			'fragmentReferences' => [],
77			'variables' => [],
78			'variableReferences' => []
79			];
80	98		}
81
82	96		protected function parseBody($token = Token::TYPE_QUERY, $highLevel = true)
83			{
84	96		$fields = [];
85	96		$first = true;
86
87	96		if ($highLevel && $this->peek()->getType() === $token) {
88	41		$this->lex();
89	41		$this->eat(Token::TYPE_IDENTIFIER);
90
91	41		if ($this->match(Token::TYPE_LPAREN)) {
92	11		$this->parseVariables();
93			}
94			}
95
96	96		$this->lex();
97
98	96		while (!$this->match(Token::TYPE_RBRACE) && !$this->end()) {
99	93		if ($first) {
100	93		$first = false;
101			} else {
102	32		$this->eatMulti([Token::TYPE_COMMA]);
103			}
104
105	93		if ($this->match(Token::TYPE_FRAGMENT_REFERENCE)) {
106	10		$this->lex();
107
108	10		if ($this->eat(Token::TYPE_ON)) {
109	3		$fields[] = $this->parseBodyItem(Token::TYPE_TYPED_FRAGMENT, $highLevel);
110			} else {
111	10		$fields[] = $this->parseFragmentReference();
112			}
113			} else {
114	93		$fields[] = $this->parseBodyItem($token, $highLevel);
115			}
116			}
117
118	85		$this->expect(Token::TYPE_RBRACE);
119
120	85		return $fields;
121			}
122
123	11		protected function parseVariables()
124			{
125	11		$first = true;
126	11		$this->eat(Token::TYPE_LPAREN);
127
128	11		while (!$this->match(Token::TYPE_RPAREN) && !$this->end()) {
129	11		if ($first) {
130	11		$first = false;
131			} else {
132	2		$this->expect(Token::TYPE_COMMA);
133			}
134
135	11		$variableToken = $this->eat(Token::TYPE_VARIABLE);
136	11		$nameToken = $this->eatIdentifierToken();
137	11		$this->eat(Token::TYPE_COLON);
138
139	11		$isArray = false;
140	11		$arrayElementNullable = true;
141
142	11		if ($this->match(Token::TYPE_LSQUARE_BRACE)) {
143	2		$isArray = true;
144
145	2		$this->eat(Token::TYPE_LSQUARE_BRACE);
146	2		$type = $this->eatIdentifierToken()->getData();
147
148	2		if ($this->match(Token::TYPE_REQUIRED)) {
149	2		$arrayElementNullable = false;
150	2		$this->eat(Token::TYPE_REQUIRED);
151			}
152
153	2		$this->eat(Token::TYPE_RSQUARE_BRACE);
154			} else {
155	10		$type = $this->eatIdentifierToken()->getData();
156			}
157
158	11		$required = false;
159	11		if ($this->match(Token::TYPE_REQUIRED)) {
160	2		$required = true;
161	2		$this->eat(Token::TYPE_REQUIRED);
162			}
163
164	11		$this->data['variables'][] = new Variable(
165	11		$nameToken->getData(),
166			$type,
167			$required,
168			$isArray,
169	11		new Location($variableToken->getLine(), $variableToken->getColumn()),
170			$arrayElementNullable
171			);
172			}
173
174	11		$this->expect(Token::TYPE_RPAREN);
175	11		}
176
177	93		protected function expectMulti($types)
178			{
179	93		if ($this->matchMulti($types)) {
180	93		return $this->lex();
181			}
182
183	3		throw $this->createUnexpectedException($this->peek());
184			}
185
186	11		protected function parseVariableReference()
187			{
188	11		$startToken = $this->expectMulti([Token::TYPE_VARIABLE]);
189
190	11		if ($this->match(Token::TYPE_NUMBER) \|\| $this->match(Token::TYPE_IDENTIFIER) \|\| $this->match(Token::TYPE_QUERY)) {
191	10		$name = $this->lex()->getData();
192
193	10		$variable = $this->findVariable($name);
194	10		if ($variable) {
195	10		$variable->setUsed(true);
196			}
197
198	10		$variableReference = new VariableReference($name, $variable, new Location($startToken->getLine(), $startToken->getColumn()));
199
200	10		$this->data['variableReferences'][] = $variableReference;
201
202	10		return $variableReference;
203			}
204
205	1		throw $this->createUnexpectedException($this->peek());
206			}
207
208	10		protected function findVariable($name)
209			{
210	10		foreach ($this->data['variables'] as $variable) {
211			/** @var $variable Variable */
212	10		if ($variable->getName() == $name) {
213	10		return $variable;
214			}
215			}
216
217			return null;
218			}
219
220	8		protected function parseFragmentReference()
221			{
222	8		$nameToken = $this->eatIdentifierToken();
223	8		$fragmentReference = new FragmentReference($nameToken->getData(), new Location($nameToken->getLine(), $nameToken->getColumn()));
224
225	8		$this->data['fragmentReferences'][] = $fragmentReference;
226
227	8		return $fragmentReference;
228			}
229
230	93		protected function eatIdentifierToken()
231			{
232	93		return $this->expectMulti([
233	93		Token::TYPE_IDENTIFIER,
234	93		Token::TYPE_MUTATION,
235	93		Token::TYPE_QUERY,
236	93		Token::TYPE_FRAGMENT,
237			]);
238			}
239
240	93		protected function parseBodyItem($type = Token::TYPE_QUERY, $highLevel = true)
241			{
242	93		$nameToken = $this->eatIdentifierToken();
243	93		$alias = null;
244
245	93		if ($this->eat(Token::TYPE_COLON)) {
246	17		$alias = $nameToken->getData();
247	17		$nameToken = $this->eatIdentifierToken();
248			}
249
250	93		$bodyLocation = new Location($nameToken->getLine(), $nameToken->getColumn());
251	93		$arguments = $this->match(Token::TYPE_LPAREN) ? $this->parseArgumentList() : [];
252
253	85		if ($this->match(Token::TYPE_LBRACE)) {
254	58		$fields = $this->parseBody($type == Token::TYPE_TYPED_FRAGMENT ? Token::TYPE_QUERY : $type, false);
255
256	55		if (!$fields) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-01 14:21 UTC by Report Bug Copy Issue Report The expression `$fields` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
257	3		throw $this->createUnexpectedTokenTypeException($this->lookAhead->getType());
258			}
259
260	54	View Code Duplication	if ($type == Token::TYPE_QUERY) {
			0 ignored issues – show Duplication introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
261	52		return new Query($nameToken->getData(), $alias, $arguments, $fields, $bodyLocation);
262	6		} elseif ($type == Token::TYPE_TYPED_FRAGMENT) {
263	3		return new TypedFragmentReference($nameToken->getData(), $fields, $bodyLocation);
264			} else {
265	3		return new Mutation($nameToken->getData(), $alias, $arguments, $fields, $bodyLocation);
266			}
267		View Code Duplication	} else {
			0 ignored issues – show Duplication introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
268	83		if ($highLevel && $type == Token::TYPE_MUTATION) {
269	9		return new Mutation($nameToken->getData(), $alias, $arguments, [], $bodyLocation);
270	75		} elseif ($highLevel && $type == Token::TYPE_QUERY) {
271	23		return new Query($nameToken->getData(), $alias, $arguments, [], $bodyLocation);
272			}
273
274	56		return new Field($nameToken->getData(), $alias, $arguments, $bodyLocation);
275			}
276			}
277
278	55		protected function parseArgumentList()
279			{
280	55		$args = [];
281	55		$first = true;
282
283	55		$this->expect(Token::TYPE_LPAREN);
284
285	55		while (!$this->match(Token::TYPE_RPAREN) && !$this->end()) {
286	55		if ($first) {
287	55		$first = false;
288			} else {
289	6		if ($this->match(Token::TYPE_COMMA)) {
290	5		$this->eat(Token::TYPE_COMMA);
291			}
292			}
293
294	55		$args[] = $this->parseArgument();
295			}
296
297	47		$this->expect(Token::TYPE_RPAREN);
298
299	47		return $args;
300			}
301
302	55		protected function parseArgument()
303			{
304	55		$nameToken = $this->eatIdentifierToken();
305	55		$this->expect(Token::TYPE_COLON);
306	54		$value = $this->parseValue();
307
308	48		return new Argument($nameToken->getData(), $value, new Location($nameToken->getLine(), $nameToken->getColumn()));
			0 ignored issues – show Bug introduced 2016-11-19 05:02 UTC by Report Bug Copy Issue Report It seems like `$value` defined by `$this->parseValue()` on line `306` can also be of type `array`; however, `Youshido\GraphQL\Parser\...Argument::__construct()` does only seem to accept `object<Youshido\GraphQL\...erfaces\ValueInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
309			}
310
311			/**
312			* @return array\|InputList\|InputObject\|Literal\|VariableReference
313			*
314			* @throws SyntaxErrorException
315			*/
316	54		protected function parseValue()
317			{
318	54		switch ($this->lookAhead->getType()) {
319	54		case Token::TYPE_LSQUARE_BRACE:
320	7		return $this->parseList();
321
322	47		case Token::TYPE_LBRACE:
323	8		return $this->parseObject();
324
325	39		case Token::TYPE_VARIABLE:
326	11		return $this->parseVariableReference();
327
328	32		case Token::TYPE_NUMBER:
329	24		case Token::TYPE_STRING:
330	11		case Token::TYPE_IDENTIFIER:
331	8		case Token::TYPE_NULL:
332	5		case Token::TYPE_TRUE:
333	1		case Token::TYPE_FALSE:
334	31		$token = $this->lex();
335
336	31		return new Literal($token->getData(), new Location($token->getLine(), $token->getColumn()));
337			}
338
339	1		throw $this->createUnexpectedException($this->lookAhead);
340			}
341
342	9		protected function parseList($createType = true)
343			{
344	9		$startToken = $this->eat(Token::TYPE_LSQUARE_BRACE);
345
346	9		$list = [];
347	9		while (!$this->match(Token::TYPE_RSQUARE_BRACE) && !$this->end()) {
348	9		$list[] = $this->parseListValue();
349
350	8		if ($this->lookAhead->getType() != Token::TYPE_RSQUARE_BRACE) {
351	7		$this->expect(Token::TYPE_COMMA);
352			}
353			}
354
355	8		$this->expect(Token::TYPE_RSQUARE_BRACE);
356
357	8		return $createType ? new InputList($list, new Location($startToken->getLine(), $startToken->getColumn())) : $list;
358			}
359
360	15		protected function parseListValue()
361			{
362	15		switch ($this->lookAhead->getType()) {
363	15		case Token::TYPE_NUMBER:
364	11		case Token::TYPE_STRING:
365	9		case Token::TYPE_TRUE:
366	9		case Token::TYPE_FALSE:
367	9		case Token::TYPE_NULL:
368	5		case Token::TYPE_IDENTIFIER:
369	14		return $this->expect($this->lookAhead->getType())->getData();
370
371	4		case Token::TYPE_VARIABLE:
372			return $this->parseVariableReference();
373
374	4		case Token::TYPE_LBRACE:
375	3		return $this->parseObject(true);
376
377	3		case Token::TYPE_LSQUARE_BRACE:
378	2		return $this->parseList(false);
379			}
380
381	1		throw new SyntaxErrorException('Can\'t parse argument', $this->getLocation());
382			}
383
384	9		protected function parseObject($createType = true)
385			{
386	9		$startToken = $this->eat(Token::TYPE_LBRACE);
387
388	9		$object = [];
389	9		while (!$this->match(Token::TYPE_RBRACE) && !$this->end()) {
390	9		$key = $this->expectMulti([Token::TYPE_STRING, Token::TYPE_IDENTIFIER])->getData();
391	9		$this->expect(Token::TYPE_COLON);
392	9		$value = $this->parseListValue();
393
394	9		if ($this->peek()->getType() != Token::TYPE_RBRACE) {
395	5		$this->expect(Token::TYPE_COMMA);
396			}
397
398	7		$object[$key] = $value;
399			}
400
401	6		$this->eat(Token::TYPE_RBRACE);
402
403	6		return $createType ? new InputObject($object, new Location($startToken->getLine(), $startToken->getColumn())) : $object;
404			}
405
406	8		protected function parseFragment()
407			{
408	8		$this->lex();
409	8		$nameToken = $this->eatIdentifierToken();
410
411	8		$this->eat(Token::TYPE_ON);
412
413	8		$model = $this->eatIdentifierToken();
414	8		$fields = $this->parseBody(Token::TYPE_QUERY, false);
415
416	8		return new Fragment($nameToken->getData(), $model->getData(), $fields, new Location($nameToken->getLine(), $nameToken->getColumn()));
417			}
418
419	95		protected function eat($type)
420			{
421	95		if ($this->match($type)) {
422	49		return $this->lex();
423			}
424
425	90		return null;
426			}
427
428	32		protected function eatMulti($types)
429			{
430	32		if ($this->matchMulti($types)) {
431	24		return $this->lex();
432			}
433
434	9		return null;
435			}
436
437	93		protected function matchMulti($types)
438			{
439	93		foreach ($types as $type) {
440	93		if ($this->peek()->getType() == $type) {
441	93		return true;
442			}
443			}
444
445	12		return false;
446			}
447			}
448

Youshido / GraphQL

Push — master ( c7a187...1a4f5e )

Parser::parseListValue() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like