NonNullType::build() - Code Metrics - Inspection of "updating documentation and refactoring the structu..." - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 461e07...b4459a )

by Alexandr

created 2016-05-07 22:17 UTC

NonNullType::build() A

↳ Parent: NonNullType

Complexity

Conditions	1
Paths	1

Size

Total Lines	1
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Metric	Value
dl	0
loc	1
rs	10
ccs	0
cts	0
cp	0
cc	1
eloc	1
nc	1
nop	1
crap	2

<?php
/*
 * This file is a part of GraphQL project.
 *
 * @author Alexandr Viniychuk <[email protected]>
 * created: 3:40 PM 4/29/16
 */

namespace Youshido\GraphQL\Type;


use Youshido\GraphQL\Type\Config\TypeConfigInterface;

class NonNullType extends AbstractType implements CompositeTypeInterface
{
    private $_typeOf;

    /**
     * NonNullType constructor.
     * @param AbstractType|string $fieldType
     */
    public function __construct($fieldType)
    {
        if (TypeMap::isScalarType($fieldType)) {
            $fieldType = TypeMap::getScalarTypeObject($fieldType);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
        $this->_typeOf = $fieldType;
    }

    public function build($config) {}


    public function getName()
    {
        return null;
    }

    public function getKind()
    {
        return TypeMap::KIND_NON_NULL;
    }

    public function resolve($value)
    {
        return $value;
    }

    public function isValidValue($value)
    {
        return $value !== null;
    }

    public function isCompositeType()
    {
        return true;
    }

    public function getNamedType()
    {
        return $this->getTypeOf();
    }

    public function getNullableType()
    {
        return $this->getTypeOf();
    }

    public function getTypeOf()
    {
        return $this->_typeOf;

    }


}


1		<?php
2		/*
3		* This file is a part of GraphQL project.
4		*
5		* @author Alexandr Viniychuk <[email protected]>
6		* created: 3:40 PM 4/29/16
7		*/
8
9		namespace Youshido\GraphQL\Type;
10
11
12		use Youshido\GraphQL\Type\Config\TypeConfigInterface;
13
14		class NonNullType extends AbstractType implements CompositeTypeInterface
15		{
16		private $_typeOf;
17
18		/**
19		* NonNullType constructor.
20		* @param AbstractType\|string $fieldType
21		*/
22	4	public function __construct($fieldType)
23		{
24	4	if (TypeMap::isScalarType($fieldType)) {
25	4	$fieldType = TypeMap::getScalarTypeObject($fieldType);
		0 ignored issues – show Bug introduced 2016-05-06 05:48 UTC by Report Bug Copy Issue Report It seems like `$fieldType` defined by `\Youshido\GraphQL\Type\T...rTypeObject($fieldType)` on line `25` can also be of type `object<Youshido\GraphQL\Type\AbstractType>`; however, `Youshido\GraphQL\Type\Ty...::getScalarTypeObject()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
26		}
27	4	$this->_typeOf = $fieldType;
28	4	}
29
30		public function build($config) {}
31
32
33	3	public function getName()
34		{
35	3	return null;
36		}
37
38	4	public function getKind()
39		{
40	4	return TypeMap::KIND_NON_NULL;
41		}
42
43		public function resolve($value)
44		{
45		return $value;
46		}
47
48	1	public function isValidValue($value)
49		{
50	1	return $value !== null;
51		}
52
53		public function isCompositeType()
54		{
55		return true;
56		}
57
58		public function getNamedType()
59		{
60		return $this->getTypeOf();
61		}
62
63	4	public function getNullableType()
64		{
65	4	return $this->getTypeOf();
66		}
67
68	4	public function getTypeOf()
69		{
70	4	return $this->_typeOf;
		0 ignored issues – show Bug Compatibility introduced 2016-05-06 05:48 UTC by Report Bug Copy Issue Report The expression `$this->_typeOf;` of type `Youshido\GraphQL\Type\AbstractType\|string` adds the type `string` to the return on line 70 which is incompatible with the return type declared by the interface `Youshido\GraphQL\Type\Co...ypeInterface::getTypeOf` of type `Youshido\GraphQL\Type\AbstractType`. Loading history...
71		}
72
73
74		}
75

Youshido / GraphQL

Push — master ( 461e07...b4459a )

NonNullType::build() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like