InputValueType::build() - Code Metrics - Inspection of "Replace closures in introspection to enable serial..." - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#31)

by Sebastian

created 2016-08-13 08:49 UTC

InputValueType::build() A

↳ Parent: InputValueType

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	9.4285
cc	1
eloc	9
nc	1
nop	1
crap	1

<?php
/**
 * Date: 03.12.15
 *
 * @author Portey Vasil <[email protected]>
 */

namespace Youshido\GraphQL\Introspection;


use Youshido\GraphQL\Field\Field;
use Youshido\GraphQL\Schema\AbstractSchema;
use Youshido\GraphQL\Type\Object\AbstractObjectType;
use Youshido\GraphQL\Type\TypeMap;

class InputValueType extends AbstractObjectType
{

    public static function resolveType($value)
    {
        /** @var AbstractSchema|Field $value */
        return $value->getConfig()->getType();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function build($config)
    {
        $config
            ->addField('name', TypeMap::TYPE_STRING)
            ->addField('description', TypeMap::TYPE_STRING)
            ->addField(new Field([
                'name'    => 'type',
                'type'    => new QueryType(),
                'resolve' => [get_class($this), 'resolveType']
            ]))
            ->addField('defaultValue', TypeMap::TYPE_STRING);
    }

    /**
     * @return String type name
     */
    public function getName()
    {
        return '__InputValue';
    }
}


1		<?php
2		/**
3		* Date: 03.12.15
4		*
5		* @author Portey Vasil <[email protected]>
6		*/
7
8		namespace Youshido\GraphQL\Introspection;
9
10
11		use Youshido\GraphQL\Field\Field;
12		use Youshido\GraphQL\Schema\AbstractSchema;
13		use Youshido\GraphQL\Type\Object\AbstractObjectType;
14		use Youshido\GraphQL\Type\TypeMap;
15
16		class InputValueType extends AbstractObjectType
17		{
18
19	2	public static function resolveType($value)
20		{
21		/** @var AbstractSchema\|Field $value */
22	2	return $value->getConfig()->getType();
		0 ignored issues – show Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The method `getConfig` does only exist in `Youshido\GraphQL\Field\Field`, but not in `Youshido\GraphQL\Schema\AbstractSchema`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23		}
24
25	5	public function build($config)
26		{
27		$config
28	5	->addField('name', TypeMap::TYPE_STRING)
29	5	->addField('description', TypeMap::TYPE_STRING)
30	5	->addField(new Field([
31	5	'name' => 'type',
32	5	'type' => new QueryType(),
33	5	'resolve' => [get_class($this), 'resolveType']
34		]))
35	5	->addField('defaultValue', TypeMap::TYPE_STRING);
36	5	}
37
38		/**
39		* @return String type name
40		*/
41	7	public function getName()
42		{
43	7	return '__InputValue';
44		}
45		}
46

Youshido / GraphQL

Pull Request — master (#31)

InputValueType::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like