ArgumentsAwareConfigTrait - Code Metrics - Inspection of "Merge pull request #209 from mathroc/patch-1" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1f865b...981fed )

by Alexandr

created 2018-07-11 13:45 UTC

ArgumentsAwareConfigTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	14.14 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

97.67%

Importance

Changes

Metric	Value
wmc	18
lcom	1
cbo	1
dl	14
loc	99
ccs	42
cts	43
cp	0.9767
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getArgument()	0	4	2
A	hasArgument()	0	4	1
A	hasArguments()	0	4	1
A	getArguments()	0	4	1
A	buildArguments()	0	11	3
A	addArguments()	0	13	3
A	addArgument()	0	9	2
A	buildConfig()	14	14	3
A	removeArgument()	0	8	2

How to fix Duplicated Code

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/1/15 11:07 PM
*/

namespace Youshido\GraphQL\Config\Traits;


use Youshido\GraphQL\Field\InputField;

trait ArgumentsAwareConfigTrait
{
    protected $arguments = [];
    protected $_isArgumentsBuilt;

    public function buildArguments()
    {
        if ($this->_isArgumentsBuilt) {
            return;
        }

        if (!empty($this->data['args'])) {
            $this->addArguments($this->data['args']);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        $this->_isArgumentsBuilt = true;
    }

    public function addArguments($argsList)
    {
        foreach ($argsList as $argumentName => $argumentInfo) {
            if ($argumentInfo instanceof InputField) {
                $this->arguments[$argumentInfo->getName()] = $argumentInfo;
                continue;
            } else {
                $this->addArgument($argumentName, $this->buildConfig($argumentName, $argumentInfo));
            }
        }

        return $this;
    }

    public function addArgument($argument, $argumentInfo = null)
    {
        if (!($argument instanceof InputField)) {
            $argument = new InputField($this->buildConfig($argument, $argumentInfo));
        }
        $this->arguments[$argument->getName()] = $argument;

        return $this;
    }

    protected function buildConfig($name, $info = null)

    {
        if (!is_array($info)) {
            return [
                'type' => $info,
                'name' => $name
            ];
        }
        if (empty($info['name'])) {
            $info['name'] = $name;
        }

        return $info;
    }

    /**
     * @param $name
     *
     * @return InputField
     */
    public function getArgument($name)
    {
        return $this->hasArgument($name) ? $this->arguments[$name] : null;
    }

    /**
     * @param $name
     *
     * @return bool
     */
    public function hasArgument($name)
    {
        return array_key_exists($name, $this->arguments);
    }

    public function hasArguments()
    {
        return !empty($this->arguments);
    }

    /**
     * @return InputField[]
     */
    public function getArguments()
    {
        return $this->arguments;
    }

    public function removeArgument($name)
    {
        if ($this->hasArgument($name)) {
            unset($this->arguments[$name]);
        }

        return $this;
    }

}


1			<?php
2			/*
3			* This file is a part of graphql-youshido project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 12/1/15 11:07 PM
7			*/
8
9			namespace Youshido\GraphQL\Config\Traits;
10
11
12			use Youshido\GraphQL\Field\InputField;
13
14			trait ArgumentsAwareConfigTrait
15			{
16			protected $arguments = [];
17			protected $_isArgumentsBuilt;
18
19	107		public function buildArguments()
20			{
21	107		if ($this->_isArgumentsBuilt) {
22			return;
23			}
24
25	107		if (!empty($this->data['args'])) {
26	67		$this->addArguments($this->data['args']);
			0 ignored issues – show Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27	67		}
28	107		$this->_isArgumentsBuilt = true;
29	107		}
30
31	68		public function addArguments($argsList)
32			{
33	68		foreach ($argsList as $argumentName => $argumentInfo) {
34	68		if ($argumentInfo instanceof InputField) {
35	23		$this->arguments[$argumentInfo->getName()] = $argumentInfo;
36	23		continue;
37			} else {
38	62		$this->addArgument($argumentName, $this->buildConfig($argumentName, $argumentInfo));
39			}
40	68		}
41
42	68		return $this;
43			}
44
45	78		public function addArgument($argument, $argumentInfo = null)
46			{
47	78		if (!($argument instanceof InputField)) {
48	66		$argument = new InputField($this->buildConfig($argument, $argumentInfo));
49	66		}
50	78		$this->arguments[$argument->getName()] = $argument;
51
52	78		return $this;
53			}
54
55	66	View Code Duplication	protected function buildConfig($name, $info = null)
			0 ignored issues – show Duplication introduced 2017-07-31 11:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56			{
57	66		if (!is_array($info)) {
58			return [
59	51		'type' => $info,
60			'name' => $name
61	51		];
62			}
63	66		if (empty($info['name'])) {
64	28		$info['name'] = $name;
65	28		}
66
67	66		return $info;
68			}
69
70			/**
71			* @param $name
72			*
73			* @return InputField
74			*/
75	38		public function getArgument($name)
76			{
77	38		return $this->hasArgument($name) ? $this->arguments[$name] : null;
78			}
79
80			/**
81			* @param $name
82			*
83			* @return bool
84			*/
85	40		public function hasArgument($name)
86			{
87	40		return array_key_exists($name, $this->arguments);
88			}
89
90	8		public function hasArguments()
91			{
92	8		return !empty($this->arguments);
93			}
94
95			/**
96			* @return InputField[]
97			*/
98	69		public function getArguments()
99			{
100	69		return $this->arguments;
101			}
102
103	2		public function removeArgument($name)
104			{
105	2		if ($this->hasArgument($name)) {
106	2		unset($this->arguments[$name]);
107	2		}
108
109	2		return $this;
110			}
111
112			}
113

Youshido / GraphQL

Push — master ( 1f865b...981fed )

ArgumentsAwareConfigTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like