ResolvableObjectTrait::getResolveFunction() - Code Metrics - Inspection of "Closures in Connection prevent serialization" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#56)

by Frédéric G.

created 2016-10-02 11:47 UTC

ResolvableObjectTrait::getResolveFunction() A

↳ Parent: ResolvableObjectTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Philipp Melab <[email protected]>
*/

namespace Youshido\GraphQL\Config\Traits;

use Youshido\GraphQL\Execution\ResolveInfo;
use Youshido\GraphQL\Type\TypeMap;
use Youshido\GraphQL\Type\TypeService;

trait ResolvableObjectTrait {

  public function resolve($value, array $args, ResolveInfo $info)
  {
    if ($this->resolveFunctionCache === null) {
      $this->resolveFunctionCache = $this->getConfig()->getResolveFunction();
class MyClass { }

$x = new MyClass();
$x->foo = true;

      if (!$this->resolveFunctionCache) {
        $this->resolveFunctionCache = false;
      }
    }
    if ($this->resolveFunctionCache) {
      $resolveFunction = $this->resolveFunctionCache;

      return $resolveFunction($value, $args, $info);
    } else {
      if (is_array($value) && array_key_exists($this->getName(), $value)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return $value[$this->getName()];
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      } elseif (is_object($value)) {
        return TypeService::getPropertyValue($value, $this->getName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      } elseif ($this->getType()->getNamedType()->getKind() == TypeMap::KIND_SCALAR) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return null;
      } else {
        throw new \Exception(sprintf('Property "%s" not found in resolve result', $this->getName()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
      }
    }
  }


  public function getResolveFunction() {
    return $this->getConfig()->getResolveFunction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
  }
}


1		<?php
2		/*
3		* This file is a part of graphql-youshido project.
4		*
5		* @author Philipp Melab <[email protected]>
6		*/
7
8		namespace Youshido\GraphQL\Config\Traits;
9
10		use Youshido\GraphQL\Execution\ResolveInfo;
11		use Youshido\GraphQL\Type\TypeMap;
12		use Youshido\GraphQL\Type\TypeService;
13
14		trait ResolvableObjectTrait {
15
16	25	public function resolve($value, array $args, ResolveInfo $info)
17		{
18	25	if ($this->resolveFunctionCache === null) {
19	25	$this->resolveFunctionCache = $this->getConfig()->getResolveFunction();
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report The property `resolveFunctionCache` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20
21	25	if (!$this->resolveFunctionCache) {
22	20	$this->resolveFunctionCache = false;
23		}
24		}
25	25	if ($this->resolveFunctionCache) {
26	24	$resolveFunction = $this->resolveFunctionCache;
27
28	24	return $resolveFunction($value, $args, $info);
29		} else {
30	20	if (is_array($value) && array_key_exists($this->getName(), $value)) {
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31	14	return $value[$this->getName()];
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32	9	} elseif (is_object($value)) {
33	6	return TypeService::getPropertyValue($value, $this->getName());
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34	3	} elseif ($this->getType()->getNamedType()->getKind() == TypeMap::KIND_SCALAR) {
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35	3	return null;
36		} else {
37		throw new \Exception(sprintf('Property "%s" not found in resolve result', $this->getName()));
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38		}
39		}
40		}
41
42
43		public function getResolveFunction() {
44		return $this->getConfig()->getResolveFunction();
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45		}
46		}
47

Youshido / GraphQL

Pull Request — master (#56)

ResolvableObjectTrait::getResolveFunction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like