Issue151Test::testInternalVariableArgument() - Code Metrics - Inspection of "Merge branch 'issue-fixes'" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a0180...875ce0 )

by Alexandr

created 2017-10-04 06:09 UTC

Issue151Test::testInternalVariableArgument() A

↳ Parent: Issue151Test

Complexity

Conditions	2
Paths	1

Size

Total Lines	74
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	74
rs	9.0335
c	0
b	0
f	0
cc	2
eloc	33
nc	1
nop	0

How to fix Long Method

<?php

namespace Youshido\Tests\Issues\Issue116Test;

use Youshido\GraphQL\Execution\Processor;
use Youshido\GraphQL\Schema\Schema;
use Youshido\GraphQL\Type\ListType\ListType;
use Youshido\GraphQL\Type\Object\ObjectType;
use Youshido\GraphQL\Type\Scalar\IdType;
use Youshido\GraphQL\Type\Scalar\StringType;
use Youshido\GraphQL\Type\Union\UnionType;

class Issue151Test extends \PHPUnit_Framework_TestCase
{
    public function testInternalVariableArgument()
    {
        $type1 = new ObjectType([
            'name'   => 'Type1',
            'fields' => [
                'id'   => new IdType(),
                'name' => new StringType(),
            ],
        ]);
        $type2 = new ObjectType([
            'name'   => 'Type2',
            'fields' => [
                'id'    => new IdType(),
                'title' => new StringType(),
            ],
        ]);

        $unionType = new UnionType([
            'name'        => 'Union',
            'types'       => [$type1, $type2],
            'resolveType' => function ($value) use ($type1, $type2) {
                if (isset($value['name'])) {
                    return $type1;
                }

                return $type2;
            },
        ]);

        $schema    = new Schema([
            'query' => new ObjectType([
                'name'   => 'RootQuery',
                'fields' => [
                    'list' => [
                        'type'    => new ListType($unionType),
                        'resolve' => function () {
                            return [
                                [
                                    'id'   => 1,
                                    'name' => 'name',
                                ],
                                [
                                    'id'    => 2,
                                    'title' => 'title',
                                ],
                            ];
                        },
                    ],
                ],
            ]),
        ]);
        $processor = new Processor($schema);
        $response  = $processor->processPayload('
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
{
    list {
        ...UnitFragment
    }
}

fragment UnitFragment on Union {
    __typename
    
    ... on Type1 {
        id
        name
    }
    ... on Type2 {
        id
        title
    }
}
        ')->getResponseData();

    }
}


1			<?php
2
3			namespace Youshido\Tests\Issues\Issue116Test;
4
5			use Youshido\GraphQL\Execution\Processor;
6			use Youshido\GraphQL\Schema\Schema;
7			use Youshido\GraphQL\Type\ListType\ListType;
8			use Youshido\GraphQL\Type\Object\ObjectType;
9			use Youshido\GraphQL\Type\Scalar\IdType;
10			use Youshido\GraphQL\Type\Scalar\StringType;
11			use Youshido\GraphQL\Type\Union\UnionType;
12
13			class Issue151Test extends \PHPUnit_Framework_TestCase
14			{
15			public function testInternalVariableArgument()
16			{
17			$type1 = new ObjectType([
18			'name' => 'Type1',
19			'fields' => [
20			'id' => new IdType(),
21			'name' => new StringType(),
22			],
23			]);
24			$type2 = new ObjectType([
25			'name' => 'Type2',
26			'fields' => [
27			'id' => new IdType(),
28			'title' => new StringType(),
29			],
30			]);
31
32			$unionType = new UnionType([
33			'name' => 'Union',
34			'types' => [$type1, $type2],
35			'resolveType' => function ($value) use ($type1, $type2) {
36			if (isset($value['name'])) {
37			return $type1;
38			}
39
40			return $type2;
41			},
42			]);
43
44			$schema = new Schema([
45			'query' => new ObjectType([
46			'name' => 'RootQuery',
47			'fields' => [
48			'list' => [
49			'type' => new ListType($unionType),
50			'resolve' => function () {
51			return [
52			[
53			'id' => 1,
54			'name' => 'name',
55			],
56			[
57			'id' => 2,
58			'title' => 'title',
59			],
60			];
61			},
62			],
63			],
64			]),
65			]);
66			$processor = new Processor($schema);
67			$response = $processor->processPayload('
			0 ignored issues – show Unused Code introduced 2017-10-04 06:11 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
68			{
69			list {
70			...UnitFragment
71			}
72			}
73
74			fragment UnitFragment on Union {
75			__typename
76
77			... on Type1 {
78			id
79			name
80			}
81			... on Type2 {
82			id
83			title
84			}
85			}
86			')->getResponseData();
87
88			}
89			}
90

Youshido / GraphQL

Push — master ( 7a0180...875ce0 )

Issue151Test::testInternalVariableArgument() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like