DirectivesAwareConfigTrait - Code Metrics - Inspection of "refactor and merge" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 631929...5231d5 )

by Alexandr

created 2017-07-05 03:07 UTC

DirectivesAwareConfigTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	15
lcom	1
cbo	1
dl	0
loc	82
ccs	0
cts	51
cp	0
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	buildDirectives()	9	3
A	addDirectives()	13	3
A	addDirective()	9	2
A	getDirective()	4	2
A	hasDirective()	4	1
A	hasDirectives()	4	1
A	getDirectives()	4	1
A	removeDirective()	8	2

<?php
/**
 * Date: 03/17/2017
 *
 * @author Volodymyr Rashchepkin <[email protected]>
 */

namespace Youshido\GraphQL\Config\Traits;


use Youshido\GraphQL\Directive\Directive;
use Youshido\GraphQL\Field\InputField;

trait DirectivesAwareConfigTrait
{
    protected $directives = [];
    protected $_isDirectivesBuilt;

    public function buildDirectives()
    {
        if ($this->_isDirectivesBuilt) return true;

        if (!empty($this->data['directives'])) {
            $this->addDirectives($this->data['directives']);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        $this->_isDirectivesBuilt = true;
    }

    public function addDirectives($directiveList)
    {
        foreach ($directiveList as $directiveName => $directiveInfo) {
            if ($directiveInfo instanceof Directive) {
                $this->directives[$directiveInfo->getName()] = $directiveInfo;
                continue;
            } else {
                $this->addDirective($directiveName, $this->buildConfig($directiveName, $directiveInfo));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }

        return $this;
    }

    public function addDirective($directive, $directiveInfo = null)
    {
        if (!($directive instanceof Directive)) {
            $directive = new Directive($this->buildConfig($directive, $directiveInfo));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        $this->directives[$directive->getName()] = $directive;

        return $this;
    }

    /**
     * @param $name
     *
     * @return InputField
     */
    public function getDirective($name)
    {
        return $this->hasDirective($name) ? $this->directives[$name] : null;
    }

    /**
     * @param $name
     *
     * @return bool
     */
    public function hasDirective($name)
    {
        return array_key_exists($name, $this->directives);
    }

    public function hasDirectives()
    {
        return !empty($this->directives);
    }

    /**
     * @return InputField[]
     */
    public function getDirectives()
    {
        return $this->directives;
    }

    public function removeDirective($name)
    {
        if ($this->hasDirective($name)) {
            unset($this->directives[$name]);
        }

        return $this;
    }

}


1			<?php
2			/**
3			* Date: 03/17/2017
4			*
5			* @author Volodymyr Rashchepkin <[email protected]>
6			*/
7
8			namespace Youshido\GraphQL\Config\Traits;
9
10
11			use Youshido\GraphQL\Directive\Directive;
12			use Youshido\GraphQL\Field\InputField;
13
14			trait DirectivesAwareConfigTrait
15			{
16			protected $directives = [];
17			protected $_isDirectivesBuilt;
18
19			public function buildDirectives()
20			{
21			if ($this->_isDirectivesBuilt) return true;
22
23			if (!empty($this->data['directives'])) {
24			$this->addDirectives($this->data['directives']);
			0 ignored issues – show Bug introduced 2017-07-05 03:10 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26			$this->_isDirectivesBuilt = true;
27			}
28
29			public function addDirectives($directiveList)
30			{
31			foreach ($directiveList as $directiveName => $directiveInfo) {
32			if ($directiveInfo instanceof Directive) {
33			$this->directives[$directiveInfo->getName()] = $directiveInfo;
34			continue;
35			} else {
36			$this->addDirective($directiveName, $this->buildConfig($directiveName, $directiveInfo));
			0 ignored issues – show Bug introduced 2017-07-05 03:10 UTC by Report Bug Copy Issue Report It seems like `buildConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			}
38			}
39
40			return $this;
41			}
42
43			public function addDirective($directive, $directiveInfo = null)
44			{
45			if (!($directive instanceof Directive)) {
46			$directive = new Directive($this->buildConfig($directive, $directiveInfo));
			0 ignored issues – show Bug introduced 2017-07-05 03:10 UTC by Report Bug Copy Issue Report It seems like `buildConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47			}
48			$this->directives[$directive->getName()] = $directive;
49
50			return $this;
51			}
52
53			/**
54			* @param $name
55			*
56			* @return InputField
57			*/
58			public function getDirective($name)
59			{
60			return $this->hasDirective($name) ? $this->directives[$name] : null;
61			}
62
63			/**
64			* @param $name
65			*
66			* @return bool
67			*/
68			public function hasDirective($name)
69			{
70			return array_key_exists($name, $this->directives);
71			}
72
73			public function hasDirectives()
74			{
75			return !empty($this->directives);
76			}
77
78			/**
79			* @return InputField[]
80			*/
81			public function getDirectives()
82			{
83			return $this->directives;
84			}
85
86			public function removeDirective($name)
87			{
88			if ($this->hasDirective($name)) {
89			unset($this->directives[$name]);
90			}
91
92			return $this;
93			}
94
95			}
96

Youshido / GraphQL

Push — master ( 631929...5231d5 )

DirectivesAwareConfigTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like