Youshido /
GraphQL
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Processor often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Processor, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 29 | class Processor |
||
| 30 | { |
||
| 31 | |||
| 32 | /** @var array */ |
||
| 33 | protected $data; |
||
| 34 | |||
| 35 | /** @var ResolveValidatorInterface */ |
||
| 36 | protected $resolveValidator; |
||
| 37 | |||
| 38 | /** @var Schema */ |
||
| 39 | protected $schema; |
||
| 40 | |||
| 41 | /** @var PropertyAccessor */ |
||
| 42 | protected $propertyAccessor; |
||
| 43 | |||
| 44 | /** @var Request */ |
||
| 45 | protected $request; |
||
| 46 | |||
| 47 | 4 | public function __construct(ResolveValidatorInterface $validator) |
|
| 48 | { |
||
| 49 | 4 | $this->resolveValidator = $validator; |
|
| 50 | |||
| 51 | 4 | $this->propertyAccessor = PropertyAccess::createPropertyAccessor(); |
|
| 52 | 4 | } |
|
| 53 | |||
| 54 | 4 | public function processQuery($queryString, $variables = []) |
|
| 55 | { |
||
| 56 | 4 | $this->resolveValidator->clearErrors(); |
|
| 57 | 4 | $this->data = []; |
|
| 58 | |||
| 59 | try { |
||
| 60 | 4 | $this->parseAndCreateRequest($queryString, $variables); |
|
| 61 | |||
| 62 | 4 | if ($this->request->hasQueries()) { |
|
| 63 | 4 | foreach ($this->request->getQueries() as $query) { |
|
| 64 | 4 | if ($queryResult = $this->executeQuery($query, $this->getSchema()->getQueryType())) { |
|
| 65 | 4 | $this->data = array_merge($this->data, $queryResult); |
|
| 66 | 4 | }; |
|
| 67 | 4 | } |
|
| 68 | 4 | } |
|
| 69 | |||
| 70 | 4 | if ($this->request->hasMutations()) { |
|
| 71 | foreach ($this->request->getMutations() as $mutation) { |
||
| 72 | if ($mutationResult = $this->executeMutation($mutation, $this->getSchema()->getMutationType())) { |
||
| 73 | $this->data = array_merge($this->data, $mutationResult); |
||
| 74 | } |
||
| 75 | } |
||
| 76 | } |
||
| 77 | 4 | } catch (\Exception $e) { |
|
| 78 | 1 | $this->resolveValidator->clearErrors(); |
|
| 79 | |||
| 80 | $this->resolveValidator->addError($e); |
||
| 81 | } |
||
| 82 | 4 | } |
|
| 83 | |||
| 84 | /** |
||
| 85 | * @param Mutation $mutation |
||
| 86 | * @param InputObjectType $objectType |
||
| 87 | * |
||
| 88 | * @return array|bool|mixed |
||
| 89 | */ |
||
| 90 | protected function executeMutation($mutation, $objectType) |
||
| 91 | { |
||
| 92 | if (!$this->checkFieldExist($objectType, $mutation)) { |
||
| 93 | |||
| 94 | return null; |
||
| 95 | } |
||
| 96 | |||
| 97 | /** @var Field $field */ |
||
| 98 | $field = $objectType->getConfig()->getField($mutation->getName()); |
||
| 99 | |||
| 100 | if (!$this->resolveValidator->validateArguments($field->getType(), $mutation, $this->request)) { |
||
| 101 | return null; |
||
| 102 | } |
||
| 103 | |||
| 104 | $alias = $mutation->hasAlias() ? $mutation->getAlias() : $mutation->getName(); |
||
| 105 | $resolvedValue = $this->resolveValue($field, null, $mutation); |
||
| 106 | |||
| 107 | View Code Duplication | if (!$this->resolveValidator->validateResolvedValue($resolvedValue, $field->getType()->getKind())) { |
|
|
|
|||
| 108 | $this->resolveValidator->addError(new ResolveException(sprintf('Not valid resolved value for mutation "%s"', $field->getType()->getName()))); |
||
| 109 | |||
| 110 | return [$alias => null]; |
||
| 111 | } |
||
| 112 | |||
| 113 | $value = null; |
||
| 114 | if ($mutation->hasFields()) { |
||
| 115 | $outputType = $field->getType()->getConfig()->getOutputType(); |
||
| 116 | |||
| 117 | $value = $this->processQueryFields($mutation, $outputType, $resolvedValue, []); |
||
| 118 | } |
||
| 119 | |||
| 120 | return [$alias => $value]; |
||
| 121 | } |
||
| 122 | |||
| 123 | 4 | protected function parseAndCreateRequest($query, $variables = []) |
|
| 133 | |||
| 134 | /** |
||
| 135 | * @param Query|Field $query |
||
| 136 | * @param ObjectType $currentLevelSchema |
||
| 137 | * @param null $contextValue |
||
| 138 | * @return array|bool|mixed |
||
| 139 | */ |
||
| 140 | 4 | protected function executeQuery($query, $currentLevelSchema, $contextValue = null) |
|
| 192 | |||
| 193 | /** |
||
| 194 | * @param $objectType InputObjectType|ObjectType |
||
| 195 | * @param $query Mutation|Query |
||
| 196 | * @return null |
||
| 197 | */ |
||
| 198 | 4 | private function checkFieldExist($objectType, $query) |
|
| 208 | |||
| 209 | /** |
||
| 210 | * @param $value |
||
| 211 | * @param $query Field |
||
| 212 | * |
||
| 213 | * @throws \Exception |
||
| 214 | * |
||
| 215 | * @return mixed |
||
| 216 | */ |
||
| 217 | 3 | protected function getPreResolvedValue($value, $query) |
|
| 231 | |||
| 232 | /** |
||
| 233 | * @param $field Field |
||
| 234 | * @param $contextValue mixed |
||
| 235 | * @param $query Query |
||
| 236 | * |
||
| 237 | * @return mixed |
||
| 238 | */ |
||
| 239 | 4 | protected function resolveValue($field, $contextValue, $query) |
|
| 243 | |||
| 244 | /** |
||
| 245 | * @param $type TypeInterface|AbstractObjectType |
||
| 246 | * @param $contextValue mixed |
||
| 247 | * @param $query Query |
||
| 248 | * |
||
| 249 | * @return mixed |
||
| 250 | */ |
||
| 251 | 1 | protected function resolveValueByType($type, $contextValue, $query) |
|
| 255 | |||
| 256 | /** |
||
| 257 | * @param $queryType AbstractObjectType |
||
| 258 | * @param $query Query |
||
| 259 | * |
||
| 260 | * @return array |
||
| 261 | */ |
||
| 262 | 4 | public function parseArgumentsValues($queryType, $query) |
|
| 279 | |||
| 280 | /** |
||
| 281 | * @param $query Query |
||
| 282 | * @param $queryType ObjectType|TypeInterface|Field |
||
| 283 | * @param $resolvedValue mixed |
||
| 284 | * @param $value array |
||
| 285 | * |
||
| 286 | * @throws \Exception |
||
| 287 | * |
||
| 288 | * @return array |
||
| 289 | */ |
||
| 290 | 3 | protected function processQueryFields($query, $queryType, $resolvedValue, $value) |
|
| 312 | |||
| 313 | 3 | protected function collectValue($value, $queryValue) |
|
| 323 | |||
| 324 | 4 | public function getSchema() |
|
| 328 | |||
| 329 | 4 | public function setSchema(Schema $schema) |
|
| 342 | |||
| 343 | /** |
||
| 344 | * @return ResolveValidatorInterface |
||
| 345 | */ |
||
| 346 | public function getResolveValidator() |
||
| 350 | |||
| 351 | 4 | public function getResponseData() |
|
| 365 | } |
||
| 366 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.