Youshido / GraphQL

src/Execution/Visitor/MaxComplexityQueryVisitor.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     }
     $this->memo += $cost ?: $this->defaultScore;
     if ($this->memo > $this->maxScore) {
-      throw new \Exception('query exceeded max allowed complexity of ' . $this->maxScore);
+      throw new \Exception('query exceeded max allowed complexity of '.$this->maxScore);
     }
     return $this->memo;
   }

Indentation +24 added lines, -24 removed lines

@@ -16,40 +16,40 @@
 
 class MaxComplexityQueryVisitor extends AbstractQueryVisitor {
 
-  /**
-   * @var int max score allowed before throwing an exception (causing processing to stop)
-   */
-  public $maxScore;
-
-  /**
-   * @var int default score for nodes without explicit cost functions
-   */
-  protected $defaultScore = 1;
-
-  /**
-   * MaxComplexityQueryVisitor constructor.
-   *
-   * @param int $max max allowed complexity score
-   */
-  public function __construct($max) {
+    /**
+     * @var int max score allowed before throwing an exception (causing processing to stop)
+     */
+    public $maxScore;
+
+    /**
+     * @var int default score for nodes without explicit cost functions
+     */
+    protected $defaultScore = 1;
+
+    /**
+     * MaxComplexityQueryVisitor constructor.
+     *
+     * @param int $max max allowed complexity score
+     */
+    public function __construct($max) {
     parent::__construct();
 
     $this->maxScore = $max;
-  }
+    }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0) {
+    /**
+     * {@inheritdoc}
+     */
+    public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0) {
     $cost = $fieldConfig->get('cost');
     if (is_callable($cost)) {
-      $cost = $cost($args, $fieldConfig, $childScore);
+        $cost = $cost($args, $fieldConfig, $childScore);
     }
     $cost = $cost ?: $this->defaultScore;
     $this->memo += $cost;
     if ($this->memo > $this->maxScore) {
-      throw new \Exception('query exceeded max allowed complexity of ' . $this->maxScore);
+        throw new \Exception('query exceeded max allowed complexity of ' . $this->maxScore);
     }
     return $cost;
-  }
+    }
 }
\ No newline at end of file

src/Introspection/QueryType.php

Indentation +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     public static function resolveOfType(AbstractType $value)
     {
         if ($value instanceof CompositeTypeInterface) {
-           return $value->getTypeOf();
+            return $value->getTypeOf();
         }
 
         return null;

src/Type/TypeFactory.php

Spacing +2 added lines, -2 removed lines

@@ -35,13 +35,13 @@
             if (empty(self::$objectsHash[$type])) {
                 $name = ucfirst($type);
 
-                $className                = 'Youshido\GraphQL\Type\Scalar\\' . $name . 'Type';
+                $className                = 'Youshido\GraphQL\Type\Scalar\\'.$name.'Type';
                 self::$objectsHash[$type] = new $className();
             }
 
             return self::$objectsHash[$type];
         } else {
-            throw new ConfigurationException('Configuration problem with type ' . $type);
+            throw new ConfigurationException('Configuration problem with type '.$type);
         }
     }
 

Tests/Library/Type/ScalarExtendTypeTest.php

Spacing +2 added lines, -2 removed lines

@@ -27,13 +27,13 @@
                 'title' => new StringType(),
             ]
         ]);
-        $processor  = new Processor(new Schema([
+        $processor = new Processor(new Schema([
                 'query' => new ObjectType([
                     'name'   => 'RootQueryType',
                     'fields' => [
                         'latestReport' => [
                             'type'    => $reportType,
-                            'resolve' => function () {
+                            'resolve' => function() {
                                 return [
                                     'title' => 'Accident #1',
                                     'time'  => '13:30:12',

src/Execution/Processor.php

Braces +3 added lines, -1 removed lines

@@ -168,7 +168,9 @@
         $value = [];
 
         if ($fieldType->getKind() == TypeMap::KIND_LIST) {
-            if (!$this->resolveValidator->hasArrayAccess($resolvedValue)) return null;
+            if (!$this->resolveValidator->hasArrayAccess($resolvedValue)) {
+                return null;
+            }
             foreach ($resolvedValue as $resolvedValueItem) {
                 $value[] = [];
                 $index   = count($value) - 1;

Doc Comments +3 added lines, -3 removed lines

@@ -110,7 +110,7 @@ 
     }
 
     /**
-     * @param Query|Field        $query
+     * @param Query        $query
      * @param AbstractObjectType $currentLevelSchema
      * @return array|bool|mixed
      */
@@ -317,7 +317,7 @@ 
     }
 
     /**
-     * @param $query         Query|FragmentInterface
+     * @param Query $query         Query|FragmentInterface
      * @param $queryType     AbstractObjectType|TypeInterface|Field|AbstractType
      * @param $resolvedValue mixed
      * @param $value         array
@@ -497,7 +497,7 @@ 
      * Fragments (anonymous and named), and Fields.  The core of the function is simple: recurse until we hit the base
      * case of a Field and yield that back up to the visitor up in `doVisit`.
      *
-     * @param Query|Field|FragmentInterface $queryNode
+     * @param Query $queryNode
      * @param AbstractField                 $currentLevelAST
      *
      * @return \Generator

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use Youshido\GraphQL\Schema\AbstractSchema;
 use Youshido\GraphQL\Type\AbstractType;
 use Youshido\GraphQL\Type\Object\AbstractObjectType;
-use Youshido\GraphQL\Type\Scalar\AbstractScalarType;
 use Youshido\GraphQL\Type\TypeInterface;
 use Youshido\GraphQL\Type\TypeMap;
 use Youshido\GraphQL\Type\TypeService;

Tests/Schema/ProcessorTest.php

Spacing +33 added lines, -33 removed lines

@@ -93,14 +93,14 @@ 
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { list }')->getResponseData();
+        $data = $processor->processPayload(' { list }')->getResponseData();
         $this->assertEquals(['data' => ['list' => null]], $data);
     }
 
@@ -113,20 +113,20 @@ 
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
+        $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
         $this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
     }
 
     public function testSchemaOperations()
     {
-        $schema    = new Schema([
+        $schema = new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -139,13 +139,13 @@ 
                                     'args'    => [
                                         'shorten' => new BooleanType()
                                     ],
-                                    'resolve' => function ($value, $args) {
+                                    'resolve' => function($value, $args) {
                                         return empty($args['shorten']) ? $value : $value;
                                     }
                                 ],
                                 'id_alias'  => [
                                     'type'    => new IdType(),
-                                    'resolve' => function ($value) {
+                                    'resolve' => function($value) {
                                         return $value['id'];
                                     }
                                 ],
@@ -153,7 +153,7 @@ 
                                 'code'      => new StringType(),
                             ]
                         ]),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             $data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
                             if (!empty($args['upper'])) {
                                 foreach ($data as $key => $value) {
@@ -172,19 +172,19 @@ 
                     ],
                     'randomUser'        => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalidField' => 'John'];
                         }
                     ],
                     'invalidValueQuery' => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'stringValue';
                         }
                     ],
                     'labels'            => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['one', 'two'];
                         }
                     ]
@@ -215,7 +215,7 @@ 
                ->addField(new Field([
                    'name'    => 'increaseCounter',
                    'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
+                   'resolve' => function($value, $args, ResolveInfo $info) {
                        return $this->_counter += $args['amount'];
                    },
                    'args'    => [
@@ -227,13 +227,13 @@ 
                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
-                'resolve' => function () {
+                'resolve' => function() {
                     return null;
                 }
             ]))->addField(new Field([
                 'name'    => 'interfacedMutation',
                 'type'    => new TestInterfaceType(),
-                'resolve' => function () {
+                'resolve' => function() {
                     return ['name' => 'John'];
                 }
             ]));
@@ -279,43 +279,43 @@ 
                 'fields' => [
                     'listQuery'                 => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid list';
                         }
                     ],
                     'listEnumQuery'             => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalid enum'];
                         }
                     ],
                     'invalidEnumQuery'          => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid enum';
                         }
                     ],
                     'enumQuery'                 => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 1;
                         }
                     ],
                     'invalidNonNullQuery'       => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ],
                     'invalidNonNullInsideQuery' => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'hello';
                         }
                     ],
                     'objectQuery'               => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'John'];
                         }
                     ],
@@ -327,7 +327,7 @@ 
                                 'enum'   => new TestEnumType(),
                             ],
                         ]),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 'object' => [
                                     'name' => 'John'
@@ -396,10 +396,10 @@ 
             ]
         ]);
 
-        $union        = new UnionType([
+        $union = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object1, $object2) {
+            'resolveType' => function($object) use ($object1, $object2) {
                 if (isset($object['id'])) {
                     return $object1;
                 }
@@ -410,11 +410,11 @@ 
         $invalidUnion = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object3) {
+            'resolveType' => function($object) use ($object3) {
                 return $object3;
             }
         ]);
-        $processor    = new Processor(new Schema([
+        $processor = new Processor(new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -424,7 +424,7 @@ 
                             'type' => ['type' => 'string']
                         ],
                         'cost' => 10,
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             if ($args['type'] == 'object1') {
                                 return [
                                     'id' => 43
@@ -438,7 +438,7 @@ 
                     ],
                     'invalidUnion' => [
                         'type'    => $invalidUnion,
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'name resolved'];
                         }
                     ],
@@ -498,7 +498,7 @@ 
                                               'args'    => [
                                                   'shorten' => new BooleanType()
                                               ],
-                                              'resolve' => function ($value, $args) {
+                                              'resolve' => function($value, $args) {
                                                 return empty($args['shorten']) ? $value : $value;
                                               }
                                           ],
@@ -507,18 +507,18 @@ 
                                           'likes'     => [
                                               'type'    => new IntType(),
                                               'cost'    => 10,
-                                              'resolve' => function () {
+                                              'resolve' => function() {
                                                 return 42;
                                               }
                                           ]
                                       ]
                                   ]
                               ),
-                              'cost' => function ($args, $context, $childCost) {
+                              'cost' => function($args, $context, $childCost) {
                                 $argsCost = isset($args['cost']) ? $args['cost'] : 1;
                                 return 1 + $argsCost * $childCost;
                               },
-                              'resolve' => function ($value, $args) {
+                              'resolve' => function($value, $args) {
                                 $data = ['firstName' => 'John', 'code' => '007'];
 
                                 return $data;
@@ -549,7 +549,7 @@ 
       $processor->processPayload('{ me { badfield } }');
       $this->assertArraySubset(['errors' => [['message' => 'Field "badfield" not found in type "User"']]], $processor->getResponseData());
 
-      foreach (range(1,5) as $cost_multiplier) {
+      foreach (range(1, 5) as $cost_multiplier) {
         $visitor = new \Youshido\GraphQL\Execution\Visitor\MaxComplexityQueryVisitor(1000); // arbitrarily high cost
         $processor->processPayload("{ me (cost: $cost_multiplier) { firstName, lastName, code, likes } }", ['cost' => $cost_multiplier], [$visitor]);
         $expected = 1 + 13 * (1 + $cost_multiplier);

Indentation +76 added lines, -76 removed lines

@@ -212,19 +212,19 @@ 
         $this->assertEquals(['data' => ['labels' => ['one', 'two']]], $processor->getResponseData());
 
         $schema->getMutationType()
-               ->addField(new Field([
-                   'name'    => 'increaseCounter',
-                   'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
-                       return $this->_counter += $args['amount'];
-                   },
-                   'args'    => [
-                       'amount' => [
-                           'type'    => new IntType(),
-                           'default' => 1
-                       ]
-                   ]
-               ]))->addField(new Field([
+                ->addField(new Field([
+                    'name'    => 'increaseCounter',
+                    'type'    => new IntType(),
+                    'resolve' => function ($value, $args, ResolveInfo $info) {
+                        return $this->_counter += $args['amount'];
+                    },
+                    'args'    => [
+                        'amount' => [
+                            'type'    => new IntType(),
+                            'default' => 1
+                        ]
+                    ]
+                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
                 'resolve' => function () {
@@ -482,82 +482,82 @@ 
     }
 
     public function testComplexityReducer() {
-      $schema = new Schema(
-          [
-              'query' => new ObjectType(
-                  [
-                      'name'   => 'RootQuery',
-                      'fields' => [
-                          'me' => [
-                              'type'    => new ObjectType(
-                                  [
-                                      'name'   => 'User',
-                                      'fields' => [
-                                          'firstName' => [
-                                              'type'    => new StringType(),
-                                              'args'    => [
-                                                  'shorten' => new BooleanType()
-                                              ],
-                                              'resolve' => function ($value, $args) {
+        $schema = new Schema(
+            [
+                'query' => new ObjectType(
+                    [
+                        'name'   => 'RootQuery',
+                        'fields' => [
+                            'me' => [
+                                'type'    => new ObjectType(
+                                    [
+                                        'name'   => 'User',
+                                        'fields' => [
+                                            'firstName' => [
+                                                'type'    => new StringType(),
+                                                'args'    => [
+                                                    'shorten' => new BooleanType()
+                                                ],
+                                                'resolve' => function ($value, $args) {
                                                 return empty($args['shorten']) ? $value : $value;
-                                              }
-                                          ],
-                                          'lastName'  => new StringType(),
-                                          'code'      => new StringType(),
-                                          'likes'     => [
-                                              'type'    => new IntType(),
-                                              'cost'    => 10,
-                                              'resolve' => function () {
+                                                }
+                                            ],
+                                            'lastName'  => new StringType(),
+                                            'code'      => new StringType(),
+                                            'likes'     => [
+                                                'type'    => new IntType(),
+                                                'cost'    => 10,
+                                                'resolve' => function () {
                                                 return 42;
-                                              }
-                                          ]
-                                      ]
-                                  ]
-                              ),
-                              'cost' => function ($args, $context, $childCost) {
+                                                }
+                                            ]
+                                        ]
+                                    ]
+                                ),
+                                'cost' => function ($args, $context, $childCost) {
                                 $argsCost = isset($args['cost']) ? $args['cost'] : 1;
                                 return 1 + $argsCost * $childCost;
-                              },
-                              'resolve' => function ($value, $args) {
+                                },
+                                'resolve' => function ($value, $args) {
                                 $data = ['firstName' => 'John', 'code' => '007'];
 
                                 return $data;
-                              },
-                              'args'    => [
-                                  'cost' => [
-                                      'type'    => new IntType(),
-                                      'default' => 1
-                                  ]
-                              ]
-                          ]
-                      ]
-                  ]
-              )
-          ]
-      );
-      $processor = new Processor($schema);
-
-      $processor->setMaxComplexity(10);
-
-      $processor->processPayload('{ me { firstName, lastName } }');
-      $this->assertArrayNotHasKey('error', $processor->getResponseData());
-
-      $processor->processPayload('{ me { firstName, likes } }');
-      $this->assertEquals(['errors' => [['message' => 'query exceeded max allowed complexity of 10']]], $processor->getResponseData());
-
-      // don't let complexity reducer affect query errors
-      $processor->processPayload('{ me { badfield } }');
-      $this->assertArraySubset(['errors' => [['message' => 'Field "badfield" is not found in type "User"']]], $processor->getResponseData());
+                                },
+                                'args'    => [
+                                    'cost' => [
+                                        'type'    => new IntType(),
+                                        'default' => 1
+                                    ]
+                                ]
+                            ]
+                        ]
+                    ]
+                )
+            ]
+        );
+        $processor = new Processor($schema);
 
-      foreach (range(1,5) as $cost_multiplier) {
+        $processor->setMaxComplexity(10);
+
+        $processor->processPayload('{ me { firstName, lastName } }');
+        $this->assertArrayNotHasKey('error', $processor->getResponseData());
+
+        $processor->processPayload('{ me { firstName, likes } }');
+        $this->assertEquals(['errors' => [['message' => 'query exceeded max allowed complexity of 10']]], $processor->getResponseData());
+
+        // don't let complexity reducer affect query errors
+        $processor->processPayload('{ me { badfield } }');
+        $this->assertArraySubset(['errors' => [['message' => 'Field "badfield" is not found in type "User"']]], $processor->getResponseData());
+
+        foreach (range(1,5) as $cost_multiplier) {
         $visitor = new \Youshido\GraphQL\Execution\Visitor\MaxComplexityQueryVisitor(1000); // arbitrarily high cost
         $processor->processPayload("{ me (cost: $cost_multiplier) { firstName, lastName, code, likes } }", ['cost' => $cost_multiplier], [$visitor]);
         $expected = 1 + 13 * (1 + $cost_multiplier);
         $this->assertEquals($expected, $visitor->getMemo());
-      }
+        }
 
-      // TODO, variables not yet supported
-      /*$query = 'query costQuery ($cost: Int) { me (cost: $cost) { firstName, lastName, code, likes } }';
+        // TODO, variables not yet supported
+        /*$query = 'query costQuery ($cost: Int) { me (cost: $cost) { firstName, lastName, code, likes } }';
       foreach (range(1,5) as $cost_multiplier) {
         $visitor = new \Youshido\GraphQL\Execution\Visitor\MaxComplexityQueryVisitor(1000); // arbitrarily high cost
         $processor->processPayload($query, ['cost' => $cost_multiplier], [$visitor]);

src/Execution/Visitor/AbstractQueryVisitor.php

Indentation +28 added lines, -28 removed lines

@@ -29,38 +29,38 @@
 
 abstract class AbstractQueryVisitor {
 
-  /**
-   * @var int initial value of $this->memo
-   */
-  protected $initialValue = 0;
+    /**
+     * @var int initial value of $this->memo
+     */
+    protected $initialValue = 0;
 
-  /**
-   * @var mixed the accumulator
-   */
-  protected $memo;
+    /**
+     * @var mixed the accumulator
+     */
+    protected $memo;
 
-  /**
-   * AbstractQueryVisitor constructor.
-   */
-  public function __construct() {
+    /**
+     * AbstractQueryVisitor constructor.
+     */
+    public function __construct() {
     $this->memo = $this->initialValue;
-  }
+    }
 
-  /**
-   * @return mixed getter for the memo, in case callers want to inspect it after a process run
-   */
-  public function getMemo() {
+    /**
+     * @return mixed getter for the memo, in case callers want to inspect it after a process run
+     */
+    public function getMemo() {
     return $this->memo;
-  }
+    }
 
-  /**
-   * Visit a query node.  See class docstring.
-   *
-   * @param array       $args
-   * @param FieldConfig $fieldConfig
-   * @param int         $childScore
-   *
-   * @return int|null
-   */
-  abstract public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0);
+    /**
+     * Visit a query node.  See class docstring.
+     *
+     * @param array       $args
+     * @param FieldConfig $fieldConfig
+     * @param int         $childScore
+     *
+     * @return int|null
+     */
+    abstract public function visit(array $args, FieldConfig $fieldConfig, $childScore = 0);
 }
\ No newline at end of file

Tests/Performance/LoadTest.php

Spacing +3 added lines, -3 removed lines

@@ -43,12 +43,12 @@ 
             $authors = [];
             while (count($authors) < rand(1, 4)) {
                 $authors[] = [
-                    'name' => 'Author ' . substr(md5(time()), 0, 4)
+                    'name' => 'Author '.substr(md5(time()), 0, 4)
                 ];
             }
             $data[] = [
                 'id'      => $i,
-                'title'   => 'Title of ' . $i,
+                'title'   => 'Title of '.$i,
                 'authors' => $authors,
             ];
         }
@@ -69,7 +69,7 @@ 
 //        return true;
         $p->processPayload('{ posts { id, title, authors { name } } }');
         $res = $p->getResponseData();
-        echo "Count: " . count($res['data']['posts']) . "\n";
+        echo "Count: ".count($res['data']['posts'])."\n";
         printf("Test Time: %04f\n", microtime(true) - $time);
 //        $p->getResponseData();
     }