Completed
Pull Request — master (#200)
by Sebastian
03:22
created
Tests/Issues/Issue151/Issue151Test.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $unionType = new UnionType([
33 33
             'name'        => 'Union',
34 34
             'types'       => [$type1, $type2],
35
-            'resolveType' => function ($value) use ($type1, $type2) {
35
+            'resolveType' => function($value) use ($type1, $type2) {
36 36
                 if (isset($value['name'])) {
37 37
                     return $type1;
38 38
                 }
@@ -41,13 +41,13 @@  discard block
 block discarded – undo
41 41
             },
42 42
         ]);
43 43
 
44
-        $schema    = new Schema([
44
+        $schema = new Schema([
45 45
             'query' => new ObjectType([
46 46
                 'name'   => 'RootQuery',
47 47
                 'fields' => [
48 48
                     'list' => [
49 49
                         'type'    => new ListType($unionType),
50
-                        'resolve' => function () {
50
+                        'resolve' => function() {
51 51
                             return [
52 52
                                 [
53 53
                                     'id'   => 1,
Please login to merge, or discard this patch.
Tests/Issues/Issue149/Issue149Test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function testInternalVariableArgument()
17 17
     {
18
-        $schema    = new Schema([
18
+        $schema = new Schema([
19 19
             'query' => new ObjectType([
20 20
                 'name'   => 'RootQuery',
21 21
                 'fields' => [
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
                                 ])),
37 37
                             ],
38 38
                         ]),
39
-                        'resolve' => function () {
39
+                        'resolve' => function() {
40 40
                             return [
41 41
                                 'id'      => 1,
42 42
                                 'name'    => 'John',
Please login to merge, or discard this patch.
Tests/Schema/IntrospectionTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             'description'       => 'latest description',
137 137
             'deprecationReason' => 'for test',
138 138
             'isDeprecated'      => true,
139
-            'resolve'           => function () {
139
+            'resolve'           => function() {
140 140
                 return [
141 141
                     'id'   => 1,
142 142
                     'name' => 'Alex'
@@ -202,9 +202,9 @@  discard block
 block discarded – undo
202 202
                                 ['name' => 'String', 'fields' => null],
203 203
                                 ['name' => '__Schema', 'fields' => [['name' => 'queryType', 'args' => []], ['name' => 'mutationType', 'args' => []], ['name' => 'subscriptionType', 'args' => []], ['name' => 'types', 'args' => []], ['name' => 'directives', 'args' => []]]],
204 204
                                 ['name' => '__Type', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'kind', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'ofType', 'args' => []], ['name' => 'inputFields', 'args' => []], ['name' => 'enumValues', 'args' => [['defaultValue' => 'false']]], ['name' => 'fields', 'args' => [['defaultValue' => 'false']]], ['name' => 'interfaces', 'args' => []], ['name' => 'possibleTypes', 'args' => []]]],
205
-                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []],]],
205
+                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []], ]],
206 206
                                 ['name' => 'Boolean', 'fields' => null],
207
-                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []],]],
207
+                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ]],
208 208
                                 ['name' => '__Field', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'args', 'args' => []]]],
209 209
                                 ['name' => '__Directive', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'args', 'args' => []], ['name' => 'locations', 'args' => []]]],
210 210
                                 ['name' => '__DirectiveLocation', 'fields' => null],
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
                 'id'   => ['type' => new IntType()],
293 293
                 'name' => ['type' => new IntType()],
294 294
             ],
295
-            'resolveType' => function ($type) {
295
+            'resolveType' => function($type) {
296 296
 
297 297
             }
298 298
         ]);
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         $unionType = new UnionType([
321 321
             'name'        => 'UnionType',
322 322
             'types'       => [$object1, $object2],
323
-            'resolveType' => function () {
323
+            'resolveType' => function() {
324 324
 
325 325
             }
326 326
         ]);
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
             'args'    => [
332 332
                 'id' => ['type' => TypeMap::TYPE_INT]
333 333
             ],
334
-            'resolve' => function () {
334
+            'resolve' => function() {
335 335
                 return [
336 336
                     'id'   => 1,
337 337
                     'name' => 'Alex'
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
                     ]
358 358
                 ])
359 359
             ],
360
-            'resolve' => function () {
360
+            'resolve' => function() {
361 361
                 return null;
362 362
             }
363 363
         ]));
Please login to merge, or discard this patch.
src/Parser/Tokenizer.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -194,6 +194,9 @@  discard block
 block discarded – undo
194 194
         return new Token($this->getKeyword($value), $this->getLine(), $this->getColumn(), $value);
195 195
     }
196 196
 
197
+    /**
198
+     * @param string $name
199
+     */
197 200
     protected function getKeyword($name)
198 201
     {
199 202
         switch ($name) {
@@ -273,6 +276,9 @@  discard block
 block discarded – undo
273 276
         }
274 277
     }
275 278
 
279
+    /**
280
+     * @param string $message
281
+     */
276 282
     protected function createException($message)
277 283
     {
278 284
         return new SyntaxErrorException(sprintf('%s', $message), $this->getLocation());
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -253,9 +253,9 @@  discard block
 block discarded – undo
253 253
         $value = substr($this->source, $start, $this->pos - $start);
254 254
 
255 255
         if (strpos($value, '.') === false) {
256
-            $value = (int) $value;
256
+            $value = (int)$value;
257 257
         } else {
258
-            $value = (float) $value;
258
+            $value = (float)$value;
259 259
         }
260 260
 
261 261
         return new Token(Token::TYPE_NUMBER, $this->getLine(), $this->getColumn(), $value);
@@ -311,10 +311,10 @@  discard block
 block discarded – undo
311 311
                 return $token;
312 312
             }
313 313
             
314
-            if($ch === '\\' && ($this->pos < ($len - 1))) {
314
+            if ($ch === '\\' && ($this->pos < ($len - 1))) {
315 315
                 $this->pos++;
316 316
                 $ch = $this->source[$this->pos];
317
-                switch($ch) {
317
+                switch ($ch) {
318 318
                     case '"':
319 319
                     case '\\':
320 320
                     case '/':
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
                         break;
334 334
                     case 'u':
335 335
                         $codepoint = substr($this->source, $this->pos + 1, 4);
336
-                        if( !preg_match('/[0-9A-Fa-f]{4}/', $codepoint)) {
336
+                        if (!preg_match('/[0-9A-Fa-f]{4}/', $codepoint)) {
337 337
                             throw $this->createException(sprintf('Invalid string unicode escape sequece "%s"', $codepoint));
338 338
                         }
339 339
                         $ch = html_entity_decode("&#x{$codepoint};", ENT_QUOTES, 'UTF-8');
Please login to merge, or discard this patch.
Tests/Parser/ParserTest.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -24,6 +24,10 @@  discard block
 block discarded – undo
24 24
 use Youshido\GraphQL\Parser\Token;
25 25
 
26 26
 class TokenizerTestingParser extends Parser {
27
+
28
+    /**
29
+     * @param string $source
30
+     */
27 31
     public function initTokenizerForTesting($source) {
28 32
         $this->initTokenizer($source);
29 33
     }
@@ -102,6 +106,9 @@  discard block
 block discarded – undo
102 106
         ]);
103 107
     }
104 108
 
109
+    /**
110
+     * @param string $graphQLString
111
+     */
105 112
     private function tokenizeStringContents($graphQLString) {
106 113
         $parser = new TokenizerTestingParser();
107 114
         $parser->initTokenizerForTesting('"' . $graphQLString . '"');
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
 
105 105
     private function tokenizeStringContents($graphQLString) {
106 106
         $parser = new TokenizerTestingParser();
107
-        $parser->initTokenizerForTesting('"' . $graphQLString . '"');
107
+        $parser->initTokenizerForTesting('"'.$graphQLString.'"');
108 108
 
109 109
         return $parser->getTokenForTesting();
110 110
     }
Please login to merge, or discard this patch.