Completed
Pull Request — master (#58)
by Sebastian
03:04
created
src/Type/TypeService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
         if (is_object($data)) {
123 123
             $getter = $path;
124 124
             if (substr($path, 0, 2) != 'is') {
125
-                $getter = 'get' . self::classify($path);
125
+                $getter = 'get'.self::classify($path);
126 126
             }
127 127
 
128 128
             return is_callable([$data, $getter]) ? $data->$getter() : null;
Please login to merge, or discard this patch.
src/Type/InputObject/AbstractInputObjectType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         $typeConfig     = $this->getConfig();
48
-        $requiredFields = array_filter($typeConfig->getFields(), function (FieldInterface $field) {
48
+        $requiredFields = array_filter($typeConfig->getFields(), function(FieldInterface $field) {
49 49
             return $field->getType()->getKind() == TypeMap::KIND_NON_NULL;
50 50
         });
51 51
 
Please login to merge, or discard this patch.
src/Config/Object/InterfaceTypeConfig.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,6 @@
 block discarded – undo
45 45
             return $this->contextObject->resolveType($object);
46 46
         }
47 47
 
48
-        throw new ConfigurationException('There is no valid resolveType for ' . $this->getName());
48
+        throw new ConfigurationException('There is no valid resolveType for '.$this->getName());
49 49
     }
50 50
 }
Please login to merge, or discard this patch.
src/Config/Traits/ConfigCallTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             return $this->config->get($propertyName);
55 55
         }
56 56
 
57
-        throw new \Exception('Call to undefined method ' . $method);
57
+        throw new \Exception('Call to undefined method '.$method);
58 58
     }
59 59
 
60 60
 }
Please login to merge, or discard this patch.
src/Validator/ConfigValidator/Rules/TypeValidationRule.php 1 patch
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -28,7 +28,9 @@  discard block
 block discarded – undo
28 28
 
29 29
     public function validate($data, $ruleInfo)
30 30
     {
31
-        if (!is_string($ruleInfo)) return false;
31
+        if (!is_string($ruleInfo)) {
32
+            return false;
33
+        }
32 34
 
33 35
         switch ($ruleInfo) {
34 36
             case TypeService::TYPE_ANY:
@@ -98,7 +100,9 @@  discard block
 block discarded – undo
98 100
 
99 101
     private function isEnumValues($data)
100 102
     {
101
-        if (!is_array($data) || empty($data)) return false;
103
+        if (!is_array($data) || empty($data)) {
104
+            return false;
105
+        }
102 106
 
103 107
         foreach ($data as $item) {
104 108
             if (!is_array($item) || !array_key_exists('name', $item) || !is_string($item['name']) || !preg_match('/^[_a-zA-Z][_a-zA-Z0-9]*$/', $item['name'])) {
@@ -115,7 +119,9 @@  discard block
 block discarded – undo
115 119
 
116 120
     private static function isArrayOfInterfaces($data)
117 121
     {
118
-        if (!is_array($data)) return false;
122
+        if (!is_array($data)) {
123
+            return false;
124
+        }
119 125
 
120 126
         foreach ($data as $item) {
121 127
             if (!TypeService::isInterface($item)) {
@@ -128,10 +134,14 @@  discard block
 block discarded – undo
128 134
 
129 135
     private function isArrayOfFields($data)
130 136
     {
131
-        if (!is_array($data) || empty($data)) return false;
137
+        if (!is_array($data) || empty($data)) {
138
+            return false;
139
+        }
132 140
 
133 141
         foreach ($data as $name => $item) {
134
-            if (!$this->isField($item, $name)) return false;
142
+            if (!$this->isField($item, $name)) {
143
+                return false;
144
+            }
135 145
         }
136 146
 
137 147
         return true;
@@ -157,10 +167,14 @@  discard block
 block discarded – undo
157 167
 
158 168
     private function isArrayOfInputFields($data)
159 169
     {
160
-        if (!is_array($data)) return false;
170
+        if (!is_array($data)) {
171
+            return false;
172
+        }
161 173
 
162 174
         foreach ($data as $name => $item) {
163
-            if (!$this->isInputField($item)) return false;
175
+            if (!$this->isInputField($item)) {
176
+                return false;
177
+            }
164 178
         }
165 179
 
166 180
         return true;
Please login to merge, or discard this patch.
src/Validator/ConfigValidator/ConfigValidator.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,9 @@  discard block
 block discarded – undo
36 36
 
37 37
     public function validate($data, $rules = [], $extraFieldsAllowed = null)
38 38
     {
39
-        if ($extraFieldsAllowed !== null) $this->setExtraFieldsAllowed($extraFieldsAllowed);
39
+        if ($extraFieldsAllowed !== null) {
40
+            $this->setExtraFieldsAllowed($extraFieldsAllowed);
41
+        }
40 42
 
41 43
         $processedFields = [];
42 44
         foreach ($rules as $fieldName => $fieldRules) {
@@ -54,7 +56,9 @@  discard block
 block discarded – undo
54 56
             } elseif (!array_key_exists($fieldName, $data)) {
55 57
                 continue;
56 58
             }
57
-            if (!empty($fieldRules['final'])) unset($fieldRules['final']);
59
+            if (!empty($fieldRules['final'])) {
60
+                unset($fieldRules['final']);
61
+            }
58 62
 
59 63
             /** Validation of all other rules*/
60 64
             foreach ($fieldRules as $ruleName => $ruleInfo) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     public function assertValidateConfig(AbstractConfig $config)
54 54
     {
55 55
         if (!$this->validate($config->getData(), $this->getConfigFinalRules($config), $config->isExtraFieldsAllowed())) {
56
-            throw new ConfigurationException('Config is not valid for ' . ($config->getContextObject() ? get_class($config->getContextObject()) : null) . "\n" . implode("\n", $this->getErrorsArray(false)));
56
+            throw new ConfigurationException('Config is not valid for '.($config->getContextObject() ? get_class($config->getContextObject()) : null)."\n".implode("\n", $this->getErrorsArray(false)));
57 57
         }
58 58
     }
59 59
 
Please login to merge, or discard this patch.
src/Validator/ResolveValidator/ResolveValidator.php 4 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@  discard block
 block discarded – undo
61 61
     {
62 62
         if (!count($field->getArguments())) return true;
63 63
 
64
-        $requiredArguments = array_filter($field->getArguments(), function (InputField $argument) {
64
+        $requiredArguments = array_filter($field->getArguments(), function(InputField $argument) {
65 65
             return $argument->getType()->getKind() == TypeMap::KIND_NON_NULL;
66 66
         });
67 67
 
68
-        $withDefaultArguments = array_filter($field->getArguments(), function (InputField $argument) {
68
+        $withDefaultArguments = array_filter($field->getArguments(), function(InputField $argument) {
69 69
             return $argument->getConfig()->get('default') !== null;
70 70
         });
71 71
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
     public function assertTypeImplementsInterface(AbstractType $type, AbstractInterfaceType $interface)
134 134
     {
135 135
         if (!$interface->isValidValue($type)) {
136
-            throw new ResolveException('Type ' . $type->getName() . ' does not implement ' . $interface->getName());
136
+            throw new ResolveException('Type '.$type->getName().' does not implement '.$interface->getName());
137 137
         }
138 138
     }
139 139
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         }
153 153
 
154 154
         if (!$valid) {
155
-            throw new ResolveException('Type ' . $type->getName() . ' not exist in types of ' . $unionType->getName());
155
+            throw new ResolveException('Type '.$type->getName().' not exist in types of '.$unionType->getName());
156 156
         }
157 157
     }
158 158
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
 
43 43
     /**
44 44
      * @param AbstractObjectType      $objectType
45
-     * @param Mutation|Query|AstField $field
46
-     * @return null
45
+     * @param AstField $field
46
+     * @return boolean
47 47
      */
48 48
     public function objectHasField($objectType, $field)
49 49
     {
@@ -58,6 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     /**
60 60
      * @inheritdoc
61
+     * @param Query $query
61 62
      */
62 63
     public function validateArguments(AbstractField $field, $query, Request $request)
63 64
     {
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,9 @@
 block discarded – undo
149 149
     {
150 150
         $unionTypes = $unionType->getTypes();
151 151
         $valid      = false;
152
-        if (empty($unionTypes)) return false;
152
+        if (empty($unionTypes)) {
153
+            return false;
154
+        }
153 155
 
154 156
         foreach ($unionTypes as $unionType) {
155 157
             if ($unionType->getName() == $type->getName()) {
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -191,12 +191,12 @@
 block discarded – undo
191 191
     {
192 192
         $fieldType = $field->getType();
193 193
         if (is_null($value)) {
194
-          if ($fieldType->getKind() == TypeMap::KIND_NON_NULL) {
194
+            if ($fieldType->getKind() == TypeMap::KIND_NON_NULL) {
195 195
             $this->executionContext->addError(new ResolveException(sprintf('Cannot return null for non-nullable field %s', $field->getName())));
196 196
             return false;
197
-          }
197
+            }
198 198
 
199
-          return true;
199
+            return true;
200 200
         }
201 201
 
202 202
         $fieldType = $this->resolveTypeIfAbstract($fieldType->getNullableType(), $value);
Please login to merge, or discard this patch.
src/Relay/Connection/ArrayConnection.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      */
28 28
     public static function offsetToCursor($offset)
29 29
     {
30
-        return base64_encode(self::PREFIX . $offset);
30
+        return base64_encode(self::PREFIX.$offset);
31 31
     }
32 32
 
33 33
     /**
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,9 @@
 block discarded – undo
15 15
 
16 16
     public static function cursorForObjectInConnection($data, $object)
17 17
     {
18
-        if (!is_array($data)) return null;
18
+        if (!is_array($data)) {
19
+            return null;
20
+        }
19 21
 
20 22
         $index = array_search($object, $data);
21 23
         return $index === false ? null : self::offsetToCursor($index);
Please login to merge, or discard this patch.
src/Relay/Connection/Connection.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
         $edgeFields = !empty($config['edgeFields']) ? $config['edgeFields'] : [];
53 53
 
54 54
         $edgeType = new ObjectType([
55
-            'name'        => $name . 'Edge',
55
+            'name'        => $name.'Edge',
56 56
             'description' => 'An edge in a connection.',
57 57
             'fields'      => array_merge([
58 58
                 'node'   => [
59 59
                     'type'        => $type,
60 60
                     'description' => 'The item at the end of the edge',
61
-                    'resolve'     => function ($value) {
61
+                    'resolve'     => function($value) {
62 62
                         return $value['node'];
63 63
                     }
64 64
                 ],
@@ -86,20 +86,20 @@  discard block
 block discarded – undo
86 86
         $connectionFields = !empty($config['connectionFields']) ? $config['connectionFields'] : [];
87 87
 
88 88
         $connectionType = new ObjectType([
89
-            'name'        => $name . 'Connection',
89
+            'name'        => $name.'Connection',
90 90
             'description' => 'A connection to a list of items.',
91 91
             'fields'      => array_merge([
92 92
                 'pageInfo' => [
93 93
                     'type'        => new NonNullType(self::getPageInfoType()),
94 94
                     'description' => 'Information to aid in pagination.',
95
-                    'resolve'     => function ($value) {
95
+                    'resolve'     => function($value) {
96 96
                         return isset($value['pageInfo']) ? $value['pageInfo'] : null;
97 97
                     }
98 98
                 ],
99 99
                 'edges'    => [
100 100
                     'type'        => new ListType(self::edgeDefinition($type, $name, $config)),
101 101
                     'description' => 'A list of edges.',
102
-                    'resolve'     => function ($value) {
102
+                    'resolve'     => function($value) {
103 103
                         return isset($value['edges']) ? $value['edges'] : null;
104 104
                     }
105 105
                 ]
Please login to merge, or discard this patch.