ResolvableObjectTrait::resolve() - Code Metrics - Inspection of "Enum values incorrectly marked as deprecated. Fixe..." - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#172)

by Gareth

created 2017-08-29 13:47 UTC

ResolvableObjectTrait::resolve() B

↳ Parent: ResolvableObjectTrait

Complexity

Conditions	6
Paths	5

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	6.0359

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	9
cts	10
cp	0.9
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	12
nc	5
nop	3
crap	6.0359

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Philipp Melab <[email protected]>
*/

namespace Youshido\GraphQL\Config\Traits;

use Youshido\GraphQL\Execution\ResolveInfo;
use Youshido\GraphQL\Type\TypeMap;
use Youshido\GraphQL\Type\TypeService;

trait ResolvableObjectTrait
{

    public function resolve($value, array $args, ResolveInfo $info)
    {
        if ($resolveFunction = $this->getConfig()->getResolveFunction()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $resolveFunction($value, $args, $info);
        } else {
            if (is_array($value) && array_key_exists($this->getName(), $value)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                return $value[$this->getName()];
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            } elseif (is_object($value)) {
                return TypeService::getPropertyValue($value, $this->getName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            } elseif ($this->getType()->getNamedType()->getKind() == TypeMap::KIND_SCALAR) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                return null;
            } else {
                throw new \Exception(sprintf('Property "%s" not found in resolve result', $this->getName()));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }


    public function getResolveFunction()
    {
        return $this->getConfig()->getResolveFunction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2		/*
3		* This file is a part of graphql-youshido project.
4		*
5		* @author Philipp Melab <[email protected]>
6		*/
7
8		namespace Youshido\GraphQL\Config\Traits;
9
10		use Youshido\GraphQL\Execution\ResolveInfo;
11		use Youshido\GraphQL\Type\TypeMap;
12		use Youshido\GraphQL\Type\TypeService;
13
14		trait ResolvableObjectTrait
15		{
16
17	59	public function resolve($value, array $args, ResolveInfo $info)
18		{
19	59	if ($resolveFunction = $this->getConfig()->getResolveFunction()) {
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20	58	return $resolveFunction($value, $args, $info);
21		} else {
22	32	if (is_array($value) && array_key_exists($this->getName(), $value)) {
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23	26	return $value[$this->getName()];
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24	12	} elseif (is_object($value)) {
25	9	return TypeService::getPropertyValue($value, $this->getName());
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26	3	} elseif ($this->getType()->getNamedType()->getKind() == TypeMap::KIND_SCALAR) {
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getType()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27	3	return null;
28		} else {
29		throw new \Exception(sprintf('Property "%s" not found in resolve result', $this->getName()));
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		}
31		}
32		}
33
34
35		public function getResolveFunction()
36		{
37		return $this->getConfig()->getResolveFunction();
		0 ignored issues – show Bug introduced 2016-09-26 10:50 UTC by Report Bug Copy Issue Report It seems like `getConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38		}
39		}
40

Youshido / GraphQL

Pull Request — master (#172)

ResolvableObjectTrait::resolve() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like