Youshido / GraphQL

Tests/Library/Type/InputObjectTypeTest.php

Unused Use Statements -7 removed lines

@@ -9,13 +9,7 @@ 
 namespace Youshido\Tests\Library\Type;
 
 
-use Youshido\GraphQL\Execution\Context\ExecutionContext;
 use Youshido\GraphQL\Execution\Processor;
-use Youshido\GraphQL\Execution\Request;
-use Youshido\GraphQL\Field\Field;
-use Youshido\GraphQL\Parser\Ast\Argument;
-use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
-use Youshido\GraphQL\Parser\Ast\Query;
 use Youshido\GraphQL\Schema\Schema;
 use Youshido\GraphQL\Type\InputObject\InputObjectType;
 use Youshido\GraphQL\Type\ListType\ListType;
@@ -24,7 +18,6 @@ 
 use Youshido\GraphQL\Type\Scalar\BooleanType;
 use Youshido\GraphQL\Type\Scalar\StringType;
 use Youshido\GraphQL\Type\TypeMap;
-use Youshido\GraphQL\Validator\ResolveValidator\ResolveValidator;
 use Youshido\Tests\DataProvider\TestInputObjectType;
 
 class InputObjectTypeTest extends \PHPUnit_Framework_TestCase

Spacing +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
@@ -79,7 +79,7 @@ 
                             ]))
                         ],
                         'type'    => new BooleanType(),
-                        'resolve' => function ($object, $args) {
+                        'resolve' => function($object, $args) {
                             return true;
                         }
                     ]
@@ -100,7 +100,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () { }
+                        'resolve' => function() { }
                     ],
                 ]
             ]),
@@ -122,7 +122,7 @@ 
                                 ]
                             ])
                         ],
-                        'resolve' => function () { return 'success message'; }
+                        'resolve' => function() { return 'success message'; }
                     ]
                 ]
             ])

src/Type/ListType/AbstractListType.php

Braces +3 added lines, -1 removed lines

@@ -37,7 +37,9 @@
         if ($isValid && $itemType->isInputType()) {
             foreach($value as $item) {
                 $isValid = $itemType->isValidValue($item);
-                if (!$isValid) return false;
+                if (!$isValid) {
+                    return false;
+                }
             }
         }
         return $isValid;

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
         $isValid = is_null($value) || is_array($value) || $this->isIterableObject($value);
         $itemType = $this->config->get('itemType');
         if ($isValid && $itemType->isInputType()) {
-            foreach($value as $item) {
+            foreach ($value as $item) {
                 $isValid = $itemType->isValidValue($item);
                 if (!$isValid) return false;
             }
@@ -45,7 +45,7 @@ 
 
     private function isIterableObject($value)
     {
-        if(is_object($value)) {
+        if (is_object($value)) {
             $implements = class_implements($value);
             return isset($implements['Iterator']) || isset($implements['IteratorAggregate']);
         }

src/Introspection/QueryType.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         if ($value && $value->getKind() == TypeMap::KIND_ENUM) {
             $data = [];
             foreach ($value->getValues() as $enumValue) {
-                if(!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
+                if (!$args['includeDeprecated'] && (isset($enumValue['isDeprecated']) && $enumValue['isDeprecated'])) {
                     continue;
                 }
 
@@ -91,7 +91,7 @@ 
         }
 
         /** @var AbstractObjectType $value */
-        return array_filter($value->getConfig()->getFields(), function ($field) use ($args) {
+        return array_filter($value->getConfig()->getFields(), function($field) use ($args) {
             /** @var $field Field */
             if (in_array($field->getName(), ['__type', '__schema']) || (!$args['includeDeprecated'] && $field->isDeprecated())) {
                 return false;

Tests/Schema/IntrospectionTest.php

Spacing +7 added lines, -7 removed lines

@@ -136,7 +136,7 @@ 
             'description'       => 'latest description',
             'deprecationReason' => 'for test',
             'isDeprecated'      => true,
-            'resolve'           => function () {
+            'resolve'           => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -201,9 +201,9 @@ 
                                 ['name' => 'String', 'fields' => null],
                                 ['name' => '__Schema', 'fields' => [['name' => 'queryType', 'args' => []], ['name' => 'mutationType', 'args' => []], ['name' => 'subscriptionType', 'args' => []], ['name' => 'types', 'args' => []], ['name' => 'directives', 'args' => []]]],
                                 ['name' => '__Type', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'kind', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'ofType', 'args' => []], ['name' => 'inputFields', 'args' => []], ['name' => 'enumValues', 'args' => [['defaultValue' => 'false']]], ['name' => 'fields', 'args' => [['defaultValue' => 'false']]], ['name' => 'interfaces', 'args' => []], ['name' => 'possibleTypes', 'args' => []]]],
-                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []],]],
+                                ['name' => '__InputValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'defaultValue', 'args' => []], ]],
                                 ['name' => 'Boolean', 'fields' => null],
-                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []],]],
+                                ['name' => '__EnumValue', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ]],
                                 ['name' => '__Field', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'isDeprecated', 'args' => []], ['name' => 'deprecationReason', 'args' => []], ['name' => 'type', 'args' => []], ['name' => 'args', 'args' => []]]],
                                 ['name' => '__Subscription', 'fields' => [['name' => 'name', 'args' => []]]],
                                 ['name' => '__Directive', 'fields' => [['name' => 'name', 'args' => []], ['name' => 'description', 'args' => []], ['name' => 'args', 'args' => []], ['name' => 'onOperation', 'args' => []], ['name' => 'onFragment', 'args' => []], ['name' => 'onField', 'args' => []]]],
@@ -291,7 +291,7 @@ 
                 'id'   => ['type' => new IntType()],
                 'name' => ['type' => new IntType()],
             ],
-            'resolveType' => function ($type) {
+            'resolveType' => function($type) {
 
             }
         ]);
@@ -319,7 +319,7 @@ 
         $unionType = new UnionType([
             'name'        => 'UnionType',
             'types'       => [$object1, $object2],
-            'resolveType' => function () {
+            'resolveType' => function() {
 
             }
         ]);
@@ -330,7 +330,7 @@ 
             'args'    => [
                 'id' => ['type' => TypeMap::TYPE_INT]
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return [
                     'id'   => 1,
                     'name' => 'Alex'
@@ -356,7 +356,7 @@ 
                     ]
                 ])
             ],
-            'resolve' => function () {
+            'resolve' => function() {
                 return null;
             }
         ]));

src/Type/Object/AbstractObjectType.php

Doc Comments +3 added lines

@@ -87,6 +87,9 @@
         return $this->getConfigValue('interfaces', []);
     }
 
+    /**
+     * @param ObjectType|null $value
+     */
     public function isValidValue($value)
     {
         return is_array($value) || is_null($value) || is_object($value);

src/Field/AbstractField.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $config['type'] = $this->getType();
             $config['name'] = $this->getName();
             if (empty($config['name'])) {
-                $config['name'] =$this->getAutoName();
+                $config['name'] = $this->getAutoName();
             }
         }
 

src/Config/AbstractConfig.php

Spacing +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
         $validator = ConfigValidator::getInstance();
 
         if (!$validator->validate($this->data, $this->getContextRules(), $this->extraFieldsAllowed)) {
-            throw new ConfigurationException('Config is not valid for ' . ($this->contextObject ? get_class($this->contextObject) : null) . "\n" . implode("\n", $validator->getErrorsArray(false)));
+            throw new ConfigurationException('Config is not valid for '.($this->contextObject ? get_class($this->contextObject) : null)."\n".implode("\n", $validator->getErrorsArray(false)));
         }
     }
 
@@ -151,7 +151,7 @@ 
         } elseif (substr($method, 0, 2) == 'is') {
             $propertyName = lcfirst(substr($method, 2));
         } else {
-            throw new \Exception('Call to undefined method ' . $method);
+            throw new \Exception('Call to undefined method '.$method);
         }
 
         return $this->get($propertyName);

Tests/Library/Config/InterfaceTypeConfigTest.php

Spacing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
     public function testConfigNoFields()
     {
         ConfigValidator::getInstance()->assertValidateConfig(
-            new InterfaceTypeConfig(['name' => 'Test', 'resolveType' => function () { }], null, true)
+            new InterfaceTypeConfig(['name' => 'Test', 'resolveType' => function() { }], null, true)
         );
     }
 
@@ -59,11 +59,11 @@ 
         $interfaceConfig = new InterfaceTypeConfig([
             'name'        => 'Test',
             'fields'      => ['id' => new IntType()],
-            'resolveType' => function ($object) {
+            'resolveType' => function($object) {
                 return $object->getType();
             }
         ], null, true);
-        $object          = new ObjectType(['name' => 'User', 'fields' => ['name' => new StringType()]]);
+        $object = new ObjectType(['name' => 'User', 'fields' => ['name' => new StringType()]]);
 
         $this->assertEquals($interfaceConfig->getName(), 'Test');
         $this->assertEquals($interfaceConfig->resolveType($object), $object->getType());

Tests/Library/Config/ConfigTest.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
             ]
         ]);
 
-        $finalConfig = new TestConfig(['name' => $name . 'final', 'resolve' => function () { return []; }], $object, true);
+        $finalConfig = new TestConfig(['name' => $name.'final', 'resolve' => function() { return []; }], $object, true);
         $this->assertEquals($finalConfig->getType(), null);
 
         $rules['resolve']['required'] = true;
@@ -98,7 +98,7 @@ 
      */
     public function testFinalRule()
     {
-        ConfigValidator::getInstance()->assertValidateConfig(new TestConfig(['name' => 'Test' . 'final'], null, true));
+        ConfigValidator::getInstance()->assertValidateConfig(new TestConfig(['name' => 'Test'.'final'], null, true));
     }
 
     /**