ResolveValidatorTest::testArgumentsValidation() - Code Metrics - Inspection of "versions" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d52ee7...e7842c )

by Alexandr

created 2016-05-21 01:15 UTC

ResolveValidatorTest::testArgumentsValidation() B

↳ Parent: ResolveValidatorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	76
Code Lines	51

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	76
rs	8.9667
cc	1
eloc	51
nc	1
nop	0

How to fix Long Method

<?php
/*
* This file is a part of GraphQL project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 5/15/16 5:09 PM
*/

namespace Youshido\Tests\Library\Validator;


use Youshido\GraphQL\Execution\Context\ExecutionContext;
use Youshido\GraphQL\Field\Field;
use Youshido\GraphQL\Parser\Ast\Argument;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
use Youshido\GraphQL\Parser\Ast\Field as AstField;
use Youshido\GraphQL\Parser\Ast\Fragment;
use Youshido\GraphQL\Parser\Ast\FragmentReference;
use Youshido\GraphQL\Parser\Ast\Query;
use Youshido\GraphQL\Execution\Request;
use Youshido\GraphQL\Type\NonNullType;
use Youshido\GraphQL\Type\Object\ObjectType;
use Youshido\GraphQL\Type\Scalar\BooleanType;
use Youshido\GraphQL\Type\Scalar\IntType;
use Youshido\GraphQL\Type\Scalar\StringType;
use Youshido\GraphQL\Type\Union\UnionType;
use Youshido\GraphQL\Validator\ResolveValidator\ResolveValidator;
use Youshido\Tests\DataProvider\TestEnumType;
use Youshido\Tests\DataProvider\TestInterfaceType;
use Youshido\Tests\DataProvider\TestObjectType;

class ResolveValidatorTest extends \PHPUnit_Framework_TestCase
{

    public function testValidMethods()
    {
        $validator = new ResolveValidator(new ExecutionContext());
        $this->assertEmpty($validator->getExecutionContext()->getErrors());

        $object       = new TestObjectType();
        $fieldName    = new AstField('name');
        $fieldSummary = new AstField('summary');
        $this->assertTrue($validator->objectHasField($object, $fieldName));
        $this->assertEmpty($validator->getExecutionContext()->getErrors());

        $this->assertFalse($validator->objectHasField($object, $fieldSummary));
        $this->assertNotEmpty($validator->getExecutionContext()->getErrors());

        $userType = new ObjectType([
            'name'       => 'User',
            'fields'     => [
                'name' => new StringType(),
            ],
            'interfaces' => [new TestInterfaceType()]
        ]);

        $validator->assertTypeImplementsInterface($userType, new TestInterfaceType());

        $fragment          = new Fragment('name', 'User', []);
        $fragmentReference = new FragmentReference('name');
        $validator->assertValidFragmentForField($fragment, $fragmentReference, $userType);
    }

    /**
     * @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
     */
    public function testInvalidFragmentType()
    {
        $userType          = new ObjectType([
            'name'   => 'User',
            'fields' => [
                'name' => new StringType(),
            ],
        ]);
        $fragmentReference = new FragmentReference('user');
        $fragment          = new Fragment('name', 'Product', []);

        $validator = new ResolveValidator(new ExecutionContext());
        $validator->assertValidFragmentForField($fragment, $fragmentReference, $userType);
    }

    /**
     * @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
     */
    public function testInvalidInterfaceTypeResolve()
    {
        $userType = new ObjectType([
            'name'   => 'User',
            'fields' => [
                'name' => new StringType(),
            ],
        ]);

        $validator = new ResolveValidator(new ExecutionContext());
        $validator->assertTypeImplementsInterface($userType, new TestInterfaceType());
    }

    /**
     * @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
     */
    public function testInvalidUnionTypeResolve()
    {
        $union = new UnionType([
            'name'        => 'TestUnion',
            'types'       => [new TestObjectType()],
            'resolveType' => function () {
                return new BooleanType();
            }
        ]);

        $validator = new ResolveValidator(new ExecutionContext());
        $validator->assertTypeInUnionTypes($union->resolveType(new \stdClass()), $union);
    }

    public function testValidUnionTypeResolve()
    {
        $union = new UnionType([
            'name'        => 'TestUnion',
            'types'       => [new TestObjectType()],
            'resolveType' => function () {
                return new TestObjectType();
            }
        ]);

        $validator = new ResolveValidator(new ExecutionContext());
        try {
            $validator->assertTypeInUnionTypes($union->resolveType(new \stdClass()), $union);
            $this->assertTrue(true);
        } catch (\Exception $e) {
            $this->assertTrue(false);
        }
    }

    public function testArgumentsValidation()
    {
        $variable          = new Variable('year', 'Int');
        $variableWrongType = new Variable('year', 'String');
        $variable->setValue(2016);


        $field     = new Field([
            'name' => 'hero',
            'type' => new ObjectType([
                'name'   => 'User',
                'fields' => [
                    'name' => new StringType()
                ]
            ]),
            'args' => [
                'planet' => new StringType(),
                'year'   => new IntType(),
            ]
        ]);
        $validator = new ResolveValidator(new ExecutionContext());
        $request   = new Request([]);


        $validQuery                    = new Query('hero', null, [
            new Argument('planet', new Literal('earth'))
        ]);
        $invalidArgumentQuery          = new Query('hero', null, [
            new Argument('planets', new Literal('earth'))
        ]);
        $invalidArgumentTypeQuery      = new Query('hero', null, [
            new Argument('year', new Literal('invalid type'))
        ]);
        $argumentWithVariable          = new Query('hero', null, [
            new Argument('year', $variable)
        ]);
        $argumentWithVariableWrongType = new Query('hero', null, [
            new Argument('year', $variableWrongType)
        ]);


        $this->assertFalse($validator->getExecutionContext()->hasErrors());

        $validator->validateArguments($field, $validQuery, $request);
        $this->assertFalse($validator->getExecutionContext()->hasErrors());

        $validator->validateArguments($field, $invalidArgumentQuery, $request);
        $this->assertEquals([
            ['message' => 'Unknown argument "planets" on field "hero"']
        ], $validator->getExecutionContext()->getErrorsArray());
        $validator->getExecutionContext()->clearErrors();

        $validator->validateArguments($field, $invalidArgumentTypeQuery, $request);
        $this->assertEquals([
            ['message' => 'Not valid type for argument "year" in query "hero"']
        ], $validator->getExecutionContext()->getErrorsArray());
        $validator->getExecutionContext()->clearErrors();

        $validator->validateArguments($field, $argumentWithVariable, $request);
        $this->assertEquals([
            ['message' => 'Variable "year" does not exist for query "hero"']
        ], $validator->getExecutionContext()->getErrorsArray());
        $validator->getExecutionContext()->clearErrors();

        $request->setVariables(['year' => '2016']);
        $validator->validateArguments($field, $argumentWithVariable, $request);
        $this->assertFalse($validator->getExecutionContext()->hasErrors());

        $validator->validateArguments($field, $argumentWithVariableWrongType, $request);
        $this->assertEquals([
            ['message' => 'Invalid variable "year" type, allowed type is "Int"']
        ], $validator->getExecutionContext()->getErrorsArray());
        $validator->getExecutionContext()->clearErrors();


    }
}


1			<?php
2			/*
3			* This file is a part of GraphQL project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 5/15/16 5:09 PM
7			*/
8
9			namespace Youshido\Tests\Library\Validator;
10
11
12			use Youshido\GraphQL\Execution\Context\ExecutionContext;
13			use Youshido\GraphQL\Field\Field;
14			use Youshido\GraphQL\Parser\Ast\Argument;
15			use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
16			use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
17			use Youshido\GraphQL\Parser\Ast\Field as AstField;
18			use Youshido\GraphQL\Parser\Ast\Fragment;
19			use Youshido\GraphQL\Parser\Ast\FragmentReference;
20			use Youshido\GraphQL\Parser\Ast\Query;
21			use Youshido\GraphQL\Execution\Request;
22			use Youshido\GraphQL\Type\NonNullType;
23			use Youshido\GraphQL\Type\Object\ObjectType;
24			use Youshido\GraphQL\Type\Scalar\BooleanType;
25			use Youshido\GraphQL\Type\Scalar\IntType;
26			use Youshido\GraphQL\Type\Scalar\StringType;
27			use Youshido\GraphQL\Type\Union\UnionType;
28			use Youshido\GraphQL\Validator\ResolveValidator\ResolveValidator;
29			use Youshido\Tests\DataProvider\TestEnumType;
30			use Youshido\Tests\DataProvider\TestInterfaceType;
31			use Youshido\Tests\DataProvider\TestObjectType;
32
33			class ResolveValidatorTest extends \PHPUnit_Framework_TestCase
34			{
35
36			public function testValidMethods()
37			{
38			$validator = new ResolveValidator(new ExecutionContext());
39			$this->assertEmpty($validator->getExecutionContext()->getErrors());
40
41			$object = new TestObjectType();
42			$fieldName = new AstField('name');
43			$fieldSummary = new AstField('summary');
44			$this->assertTrue($validator->objectHasField($object, $fieldName));
45			$this->assertEmpty($validator->getExecutionContext()->getErrors());
46
47			$this->assertFalse($validator->objectHasField($object, $fieldSummary));
48			$this->assertNotEmpty($validator->getExecutionContext()->getErrors());
49
50			$userType = new ObjectType([
51			'name' => 'User',
52			'fields' => [
53			'name' => new StringType(),
54			],
55			'interfaces' => [new TestInterfaceType()]
56			]);
57
58			$validator->assertTypeImplementsInterface($userType, new TestInterfaceType());
59
60			$fragment = new Fragment('name', 'User', []);
61			$fragmentReference = new FragmentReference('name');
62			$validator->assertValidFragmentForField($fragment, $fragmentReference, $userType);
63			}
64
65			/**
66			* @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
67			*/
68			public function testInvalidFragmentType()
69			{
70			$userType = new ObjectType([
71			'name' => 'User',
72			'fields' => [
73			'name' => new StringType(),
74			],
75			]);
76			$fragmentReference = new FragmentReference('user');
77			$fragment = new Fragment('name', 'Product', []);
78
79			$validator = new ResolveValidator(new ExecutionContext());
80			$validator->assertValidFragmentForField($fragment, $fragmentReference, $userType);
81			}
82
83			/**
84			* @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
85			*/
86			public function testInvalidInterfaceTypeResolve()
87			{
88			$userType = new ObjectType([
89			'name' => 'User',
90			'fields' => [
91			'name' => new StringType(),
92			],
93			]);
94
95			$validator = new ResolveValidator(new ExecutionContext());
96			$validator->assertTypeImplementsInterface($userType, new TestInterfaceType());
97			}
98
99			/**
100			* @expectedException \Youshido\GraphQL\Validator\Exception\ResolveException
101			*/
102			public function testInvalidUnionTypeResolve()
103			{
104			$union = new UnionType([
105			'name' => 'TestUnion',
106			'types' => [new TestObjectType()],
107			'resolveType' => function () {
108			return new BooleanType();
109			}
110			]);
111
112			$validator = new ResolveValidator(new ExecutionContext());
113			$validator->assertTypeInUnionTypes($union->resolveType(new \stdClass()), $union);
114			}
115
116			public function testValidUnionTypeResolve()
117			{
118			$union = new UnionType([
119			'name' => 'TestUnion',
120			'types' => [new TestObjectType()],
121			'resolveType' => function () {
122			return new TestObjectType();
123			}
124			]);
125
126			$validator = new ResolveValidator(new ExecutionContext());
127			try {
128			$validator->assertTypeInUnionTypes($union->resolveType(new \stdClass()), $union);
129			$this->assertTrue(true);
130			} catch (\Exception $e) {
131			$this->assertTrue(false);
132			}
133			}
134
135			public function testArgumentsValidation()
136			{
137			$variable = new Variable('year', 'Int');
138			$variableWrongType = new Variable('year', 'String');
139			$variable->setValue(2016);
140
141
142			$field = new Field([
143			'name' => 'hero',
144			'type' => new ObjectType([
145			'name' => 'User',
146			'fields' => [
147			'name' => new StringType()
148			]
149			]),
150			'args' => [
151			'planet' => new StringType(),
152			'year' => new IntType(),
153			]
154			]);
155			$validator = new ResolveValidator(new ExecutionContext());
156			$request = new Request([]);
157
158
159			$validQuery = new Query('hero', null, [
160			new Argument('planet', new Literal('earth'))
161			]);
162			$invalidArgumentQuery = new Query('hero', null, [
163			new Argument('planets', new Literal('earth'))
164			]);
165			$invalidArgumentTypeQuery = new Query('hero', null, [
166			new Argument('year', new Literal('invalid type'))
167			]);
168			$argumentWithVariable = new Query('hero', null, [
169			new Argument('year', $variable)
170			]);
171			$argumentWithVariableWrongType = new Query('hero', null, [
172			new Argument('year', $variableWrongType)
173			]);
174
175
176			$this->assertFalse($validator->getExecutionContext()->hasErrors());
177
178			$validator->validateArguments($field, $validQuery, $request);
179			$this->assertFalse($validator->getExecutionContext()->hasErrors());
180
181			$validator->validateArguments($field, $invalidArgumentQuery, $request);
182			$this->assertEquals([
183			['message' => 'Unknown argument "planets" on field "hero"']
184			], $validator->getExecutionContext()->getErrorsArray());
185			$validator->getExecutionContext()->clearErrors();
186
187			$validator->validateArguments($field, $invalidArgumentTypeQuery, $request);
188			$this->assertEquals([
189			['message' => 'Not valid type for argument "year" in query "hero"']
190			], $validator->getExecutionContext()->getErrorsArray());
191			$validator->getExecutionContext()->clearErrors();
192
193			$validator->validateArguments($field, $argumentWithVariable, $request);
194			$this->assertEquals([
195			['message' => 'Variable "year" does not exist for query "hero"']
196			], $validator->getExecutionContext()->getErrorsArray());
197			$validator->getExecutionContext()->clearErrors();
198
199			$request->setVariables(['year' => '2016']);
200			$validator->validateArguments($field, $argumentWithVariable, $request);
201			$this->assertFalse($validator->getExecutionContext()->hasErrors());
202
203			$validator->validateArguments($field, $argumentWithVariableWrongType, $request);
204			$this->assertEquals([
205			['message' => 'Invalid variable "year" type, allowed type is "Int"']
206			], $validator->getExecutionContext()->getErrorsArray());
207			$validator->getExecutionContext()->clearErrors();
208
209
210			}
211			}
212

Youshido / GraphQL

Push — master ( d52ee7...e7842c )

ResolveValidatorTest::testArgumentsValidation() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like