StarWarsRelaySchema::build() - Code Metrics - Inspection of "versions" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d52ee7...e7842c )

by Alexandr

created 2016-05-21 01:15 UTC

StarWarsRelaySchema::build() B

↳ Parent: StarWarsRelaySchema

Complexity

Conditions	5
Paths	1

Size

Total Lines	88
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes	14
Bugs	3	Features	3

Metric	Value
c	14
b	3
f	3
dl	0
loc	88
rs	8.2972
cc	5
eloc	52
nc	1
nop	1

How to fix Long Method

<?php

namespace Examples\StarWars;

use Youshido\GraphQL\Config\Schema\SchemaConfig;
use Youshido\GraphQL\Field\InputField;
use Youshido\GraphQl\Relay\Connection\ArrayConnection;
use Youshido\GraphQL\Relay\Connection\Connection;
use Youshido\GraphQL\Relay\Fetcher\CallableFetcher;
use Youshido\GraphQL\Relay\Field\NodeField;
use Youshido\GraphQL\Relay\RelayMutation;
use Youshido\GraphQL\Schema\AbstractSchema;
use Youshido\GraphQL\Type\ListType\ListType;
use Youshido\GraphQL\Type\NonNullType;
use Youshido\GraphQL\Type\Scalar\StringType;

class StarWarsRelaySchema extends AbstractSchema
{
    public function build(SchemaConfig $config)
    {
        $fetcher = new CallableFetcher(
            function ($type, $id) {
                switch ($type) {
                    case FactionType::TYPE_KEY:
                        return TestDataProvider::getFaction($id);

                    case
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    ShipType::TYPE_KEY:
                        return TestDataProvider::getShip($id);
                }

                return null;
            },
            function ($object) {
                return $object && array_key_exists('ships', $object) ? new FactionType() : new ShipType();
            }
        );

        $config->getQuery()
               ->addField(new NodeField($fetcher))
               ->addField('rebels', [
                   'type'    => new FactionType(),
                   'resolve' => function () {
                       return TestDataProvider::getFaction('rebels');
                   }
               ])
               ->addField('empire', [
                   'type'    => new FactionType(),
                   'resolve' => function () {
                       return TestDataProvider::getFaction('empire');
                   }
               ])
               ->addField('factions', [
                   'type'    => new ListType(new FactionType()),
                   'args'    => [
                       'names' => [
                           'type' => new ListType(new StringType())
                       ]
                   ],
                   'resolve' => function ($value = null, $args, $info) {

                       return TestDataProvider::getByNames($args['names']);
                   }
               ]);


        $config->getMutation()
               ->addField(
                   RelayMutation::buildMutation(
                       'introduceShip',
                       [
                           new InputField(['name' => 'shipName', 'type' => new NonNullType(new StringType())]),
                           new InputField(['name' => 'factionId', 'type' => new NonNullType(new StringType())])
                       ],
                       [
                           'newShipEdge'    => [
                               'type'    => Connection::edgeDefinition(new ShipType(), 'newShip'),
                               'resolve' => function ($value) {
                                   $allShips = TestDataProvider::getShips();
                                   $newShip  = TestDataProvider::getShip($value['shipId']);

                                   return [
                                       'cursor' => ArrayConnection::cursorForObjectInConnection($allShips, $newShip),
                                       'node' => $newShip
                                   ];
                               }
                           ],
                           'faction' => [
                               'type'    => new FactionType(),
                               'resolve' => function ($value) {
                                   return TestDataProvider::getFaction($value['factionId']);
                               }
                           ]
                       ],
                       function ($value, $args, $info) {

                           $newShip = TestDataProvider::createShip($args['shipName'], $args['factionId']);

                           return [
                               'shipId'    => $newShip['id'],
                               'factionId' => $args['factionId']
                           ];
                       }
                   )
               );

        /** https://github.com/graphql/graphql-relay-js/blob/master/src/__tests__/starWarsSchema.js */
    }

}


1			<?php
2
3			namespace Examples\StarWars;
4
5			use Youshido\GraphQL\Config\Schema\SchemaConfig;
6			use Youshido\GraphQL\Field\InputField;
7			use Youshido\GraphQl\Relay\Connection\ArrayConnection;
8			use Youshido\GraphQL\Relay\Connection\Connection;
9			use Youshido\GraphQL\Relay\Fetcher\CallableFetcher;
10			use Youshido\GraphQL\Relay\Field\NodeField;
11			use Youshido\GraphQL\Relay\RelayMutation;
12			use Youshido\GraphQL\Schema\AbstractSchema;
13			use Youshido\GraphQL\Type\ListType\ListType;
14			use Youshido\GraphQL\Type\NonNullType;
15			use Youshido\GraphQL\Type\Scalar\StringType;
16
17			class StarWarsRelaySchema extends AbstractSchema
18			{
19			public function build(SchemaConfig $config)
20			{
21			$fetcher = new CallableFetcher(
22			function ($type, $id) {
23			switch ($type) {
24			case FactionType::TYPE_KEY:
25			return TestDataProvider::getFaction($id);
26
27			case
			0 ignored issues – show Coding Style introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
28			ShipType::TYPE_KEY:
29			return TestDataProvider::getShip($id);
30			}
31
32			return null;
33			},
34			function ($object) {
35			return $object && array_key_exists('ships', $object) ? new FactionType() : new ShipType();
36			}
37			);
38
39			$config->getQuery()
40			->addField(new NodeField($fetcher))
41			->addField('rebels', [
42			'type' => new FactionType(),
43			'resolve' => function () {
44			return TestDataProvider::getFaction('rebels');
45			}
46			])
47			->addField('empire', [
48			'type' => new FactionType(),
49			'resolve' => function () {
50			return TestDataProvider::getFaction('empire');
51			}
52			])
53			->addField('factions', [
54			'type' => new ListType(new FactionType()),
55			'args' => [
56			'names' => [
57			'type' => new ListType(new StringType())
58			]
59			],
60			'resolve' => function ($value = null, $args, $info) {
			0 ignored issues – show Unused Code introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The parameter `$info` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
61			return TestDataProvider::getByNames($args['names']);
62			}
63			]);
64
65
66			$config->getMutation()
67			->addField(
68			RelayMutation::buildMutation(
69			'introduceShip',
70			[
71			new InputField(['name' => 'shipName', 'type' => new NonNullType(new StringType())]),
72			new InputField(['name' => 'factionId', 'type' => new NonNullType(new StringType())])
73			],
74			[
75			'newShipEdge' => [
76			'type' => Connection::edgeDefinition(new ShipType(), 'newShip'),
77			'resolve' => function ($value) {
78			$allShips = TestDataProvider::getShips();
79			$newShip = TestDataProvider::getShip($value['shipId']);
80
81			return [
82			'cursor' => ArrayConnection::cursorForObjectInConnection($allShips, $newShip),
83			'node' => $newShip
84			];
85			}
86			],
87			'faction' => [
88			'type' => new FactionType(),
89			'resolve' => function ($value) {
90			return TestDataProvider::getFaction($value['factionId']);
91			}
92			]
93			],
94			function ($value, $args, $info) {
			0 ignored issues – show Unused Code introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The parameter `$info` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
95			$newShip = TestDataProvider::createShip($args['shipName'], $args['factionId']);
96
97			return [
98			'shipId' => $newShip['id'],
99			'factionId' => $args['factionId']
100			];
101			}
102			)
103			);
104
105			/** https://github.com/graphql/graphql-relay-js/blob/master/src/__tests__/starWarsSchema.js */
106			}
107
108			}
109

Youshido / GraphQL

Push — master ( d52ee7...e7842c )

StarWarsRelaySchema::build() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like