FieldsAwareConfigTrait - Code Metrics - Inspection of "ADDED:" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d17f3...e891dc )

by Alexandr

created 2016-08-14 17:23 UTC

FieldsAwareConfigTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	114
Duplicated Lines	11.4 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	7
Bugs	1	Features	2

Metric	Value
wmc	18
c	7
b	1
f	2
lcom	1
cbo	4
dl	13
loc	114
ccs	44
cts	44
cp	1
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	buildFields()	0	6	2
A	applyInterface()	0	6	1
A	addFields()	0	14	3
A	addField()	0	10	2
A	buildFieldConfig()	13	13	3
A	getField()	0	4	2
A	hasField()	0	4	1
A	hasFields()	0	4	1
A	getFields()	0	4	1
A	removeField()	0	8	2

How to fix Duplicated Code

<?php
/*
* This file is a part of graphql-youshido project.
*
* @author Alexandr Viniychuk <[email protected]>
* created: 12/1/15 11:05 PM
*/

namespace Youshido\GraphQL\Config\Traits;


use Youshido\GraphQL\Field\AbstractField;
use Youshido\GraphQL\Field\Field;
use Youshido\GraphQL\Field\FieldInterface;
use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;

/**
 * Class FieldsAwareTrait
 * @package Youshido\GraphQL\Config\Traits
 */
trait FieldsAwareConfigTrait
{
    protected $fields = [];

    public function buildFields()
    {
        if (!empty($this->data['fields'])) {
            $this->addFields($this->data['fields']);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }

    /**
     * Add fields from passed interface
     * @param AbstractInterfaceType $interfaceType
     * @return $this
     */
    public function applyInterface(AbstractInterfaceType $interfaceType)
    {
        $this->addFields($interfaceType->getFields());

        return $this;
    }

    /**
     * @param array $fieldsList
     * @return $this
     */
    public function addFields($fieldsList)
    {
        foreach ($fieldsList as $fieldName => $fieldConfig) {

            if ($fieldConfig instanceof FieldInterface) {
                $this->fields[$fieldConfig->getName()] = $fieldConfig;
                continue;
            } else {
                $this->addField($fieldName, $this->buildFieldConfig($fieldName, $fieldConfig));
            }
        }

        return $this;
    }

    /**
     * @param AbstractField|string $field     Field name or Field Object
     * @param mixed                $fieldInfo Field Type or Field Config array
     * @return $this
     */
    public function addField($field, $fieldInfo = null)
    {
        if (!($field instanceof FieldInterface)) {
            $field = new Field($this->buildFieldConfig($field, $fieldInfo));
        }

        $this->fields[$field->getName()] = $field;

        return $this;
    }

    protected function buildFieldConfig($name, $info = null)

    {
        if (!is_array($info)) {
            $info = [
                'type' => $info,
                'name' => $name,
            ];
        } elseif (empty($info['name'])) {
            $info['name'] = $name;
        }

        return $info;
    }

    /**
     * @param $name
     *
     * @return Field
     */
    public function getField($name)
    {
        return $this->hasField($name) ? $this->fields[$name] : null;
    }

    /**
     * @param $name
     *
     * @return bool
     */
    public function hasField($name)
    {
        return array_key_exists($name, $this->fields);
    }

    public function hasFields()
    {
        return !empty($this->fields);
    }

    /**
     * @return Field[]
     */
    public function getFields()
    {
        return $this->fields;
    }

    public function removeField($name)
    {
        if ($this->hasField($name)) {
            unset($this->fields[$name]);
        }

        return $this;
    }
}


1			<?php
2			/*
3			* This file is a part of graphql-youshido project.
4			*
5			* @author Alexandr Viniychuk <[email protected]>
6			* created: 12/1/15 11:05 PM
7			*/
8
9			namespace Youshido\GraphQL\Config\Traits;
10
11
12			use Youshido\GraphQL\Field\AbstractField;
13			use Youshido\GraphQL\Field\Field;
14			use Youshido\GraphQL\Field\FieldInterface;
15			use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
16
17			/**
18			* Class FieldsAwareTrait
19			* @package Youshido\GraphQL\Config\Traits
20			*/
21			trait FieldsAwareConfigTrait
22			{
23			protected $fields = [];
24
25	71		public function buildFields()
26			{
27	71		if (!empty($this->data['fields'])) {
28	41		$this->addFields($this->data['fields']);
			0 ignored issues – show Bug introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29	41		}
30	71		}
31
32			/**
33			* Add fields from passed interface
34			* @param AbstractInterfaceType $interfaceType
35			* @return $this
36			*/
37	1		public function applyInterface(AbstractInterfaceType $interfaceType)
38			{
39	1		$this->addFields($interfaceType->getFields());
40
41	1		return $this;
42			}
43
44			/**
45			* @param array $fieldsList
46			* @return $this
47			*/
48	43		public function addFields($fieldsList)
49			{
50	43		foreach ($fieldsList as $fieldName => $fieldConfig) {
51
52	43		if ($fieldConfig instanceof FieldInterface) {
53	3		$this->fields[$fieldConfig->getName()] = $fieldConfig;
54	3		continue;
55			} else {
56	42		$this->addField($fieldName, $this->buildFieldConfig($fieldName, $fieldConfig));
57			}
58	43		}
59
60	43		return $this;
61			}
62
63			/**
64			* @param AbstractField\|string $field Field name or Field Object
65			* @param mixed $fieldInfo Field Type or Field Config array
66			* @return $this
67			*/
68	51		public function addField($field, $fieldInfo = null)
69			{
70	51		if (!($field instanceof FieldInterface)) {
71	51		$field = new Field($this->buildFieldConfig($field, $fieldInfo));
72	51		}
73
74	51		$this->fields[$field->getName()] = $field;
75
76	51		return $this;
77			}
78
79	51	View Code Duplication	protected function buildFieldConfig($name, $info = null)
			0 ignored issues – show Duplication introduced 2016-05-21 01:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80			{
81	51		if (!is_array($info)) {
82			$info = [
83	40		'type' => $info,
84	40		'name' => $name,
85	40		];
86	51		} elseif (empty($info['name'])) {
87	32		$info['name'] = $name;
88	32		}
89
90	51		return $info;
91			}
92
93			/**
94			* @param $name
95			*
96			* @return Field
97			*/
98	28		public function getField($name)
99			{
100	28		return $this->hasField($name) ? $this->fields[$name] : null;
101			}
102
103			/**
104			* @param $name
105			*
106			* @return bool
107			*/
108	33		public function hasField($name)
109			{
110	33		return array_key_exists($name, $this->fields);
111			}
112
113	33		public function hasFields()
114			{
115	33		return !empty($this->fields);
116			}
117
118			/**
119			* @return Field[]
120			*/
121	33		public function getFields()
122			{
123	33		return $this->fields;
124			}
125
126	1		public function removeField($name)
127			{
128	1		if ($this->hasField($name)) {
129	1		unset($this->fields[$name]);
130	1		}
131
132	1		return $this;
133			}
134			}
135

Youshido / GraphQL

Push — master ( 5d17f3...e891dc )

FieldsAwareConfigTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like