Youshido / GraphQL

src/Validator/ResolveValidator/ResolveValidator.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 
     public function assertValidArguments(FieldInterface $field, AstFieldInterface $query, Request $request)
     {
-        $requiredArguments = array_filter($field->getArguments(), function (InputField $argument) {
+        $requiredArguments = array_filter($field->getArguments(), function(InputField $argument) {
             return $argument->getType()->getKind() === TypeMap::KIND_NON_NULL;
         });
 

Tests/Issues/Issue99/Issue99Test.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 
         self::assertTrue(isset($res['data']['items']));
 
-        foreach($res['data']['items'] as $item) {
+        foreach ($res['data']['items'] as $item) {
             self::assertTrue(isset($item['custom']['value']));
             self::assertEquals(self::BUG_NOT_EXISTS_VALUE, $item['custom']['value']);
         }

Tests/Issues/Issue99/Issue99Schema.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
                         'args'    => [
                             'example' => new StringType()
                         ],
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 ['id' => 1],
                                 ['id' => 2],

src/Execution/Request.php

Doc Comments +4 added lines, -1 removed lines

@@ -223,6 +223,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $name
+     */
     public function getVariable($name)
     {
         return $this->hasVariable($name) ? $this->variables[$name] : null;
@@ -266,7 +269,7 @@ 
     }
 
     /**
-     * @return array|VariableReference[]
+     * @return VariableReference[]
      */
     public function getVariableReferences()
     {

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 namespace Youshido\GraphQL\Execution;
 
 
-use Youshido\GraphQL\Parser\Ast\ArgumentValue\Literal;
 use Youshido\GraphQL\Parser\Ast\ArgumentValue\Variable;
 use Youshido\GraphQL\Parser\Ast\ArgumentValue\VariableReference;
 use Youshido\GraphQL\Parser\Ast\Fragment;

Spacing +1 added lines, -1 removed lines

@@ -208,7 +208,7 @@
         }
 
         $this->variables = $variables;
-        foreach($this->variableReferences as $reference) {
+        foreach ($this->variableReferences as $reference) {
             /** invalid request with no variable */
             if (!$reference->getVariable()) continue;
             $variableName = $reference->getVariable()->getName();

Braces +6 added lines, -2 removed lines

@@ -210,11 +210,15 @@
         $this->variables = $variables;
         foreach($this->variableReferences as $reference) {
             /** invalid request with no variable */
-            if (!$reference->getVariable()) continue;
+            if (!$reference->getVariable()) {
+                continue;
+            }
             $variableName = $reference->getVariable()->getName();
 
             /** no variable was set at the time */
-            if (!array_key_exists($variableName, $variables)) continue;
+            if (!array_key_exists($variableName, $variables)) {
+                continue;
+            }
 
             $reference->getVariable()->setValue($variables[$variableName]);
             $reference->setValue($variables[$variableName]);

Tests/Issues/Issue109/Issue109Schema.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
                                 ]
                             ]
                         ]),
-                        'resolve' => function ($source, array $args, ResolveInfo $info) {
+                        'resolve' => function($source, array $args, ResolveInfo $info) {
                             $internalArgs = [
                                 'comment_id' => 200
                             ];

Tests/Performance/NPlusOneTest.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
             ['id' => 2, 'name' => 'Alex'],
             ['id' => 3, 'name' => 'Mike'],
         ];
-        $posts   = [];
+        $posts = [];
         for ($i = 0; $i < 10; $i++) {
             $posts[] = [
                 'id'     => $i + 1,
@@ -67,7 +67,7 @@ 
                 'fields' => [
                     'posts' => [
                         'type'    => new ListType($postType),
-                        'resolve' => function ($source, $args, $info) {
+                        'resolve' => function($source, $args, $info) {
                             return $this->getDataForPosts();
                         }
                     ]

src/Relay/Connection/ArrayConnection.php

Doc Comments +10 added lines, -2 removed lines

@@ -38,9 +38,9 @@ 
     }
 
     /**
-     * @param $cursor string
+     * @param string|null $cursor string
      *
-     * @return int|null
+     * @return string|null
      * @deprecated Use cursorToKey instead.
      */
     public static function cursorToOffset($cursor)
@@ -94,6 +94,10 @@ 
         return self::connectionFromArraySlice($data, $args, 0, count($data));
     }
 
+    /**
+     * @param integer $sliceStart
+     * @param integer $arrayLength
+     */
     public static function connectionFromArraySlice(array $data, array $args, $sliceStart, $arrayLength)
     {
         $after  = isset($args['after']) ? $args['after'] : null;
@@ -139,6 +143,10 @@ 
         ];
     }
 
+    /**
+     * @param string $object
+     * @param integer $index
+     */
     public static function edgeForObjectWithIndex($object, $index)
     {
         return [

Indentation +24 added lines, -24 removed lines

@@ -29,12 +29,12 @@ 
      */
     public static function offsetToCursor($offset)
     {
-      return self::keyToCursor($offset);
+        return self::keyToCursor($offset);
     }
 
     public static function keyToCursor($key)
     {
-      return base64_encode(self::PREFIX . $key);
+        return base64_encode(self::PREFIX . $key);
     }
 
     /**
@@ -48,30 +48,30 @@ 
         return self::cursorToKey($cursor);
     }
 
-  /**
-   * Converts a cursor to its array key.
-   *
-   * @param $cursor
-   * @return null|string
-   */
+    /**
+     * Converts a cursor to its array key.
+     *
+     * @param $cursor
+     * @return null|string
+     */
     public static function cursorToKey($cursor) {
-      if ($decoded = base64_decode($cursor)) {
+        if ($decoded = base64_decode($cursor)) {
         return substr($decoded, strlen(self::PREFIX));
-      }
-      return null;
+        }
+        return null;
     }
 
-  /**
-   * Converts a cursor to an array offset.
-   *
-   * @param $cursor
-   *   The cursor string.
-   * @param $default
-   *   The default value, in case the cursor is not given.
-   * @param array $array
-   *   The array to use in counting the offset. If empty, assumed to be an indexed array.
-   * @return int|null
-   */
+    /**
+     * Converts a cursor to an array offset.
+     *
+     * @param $cursor
+     *   The cursor string.
+     * @param $default
+     *   The default value, in case the cursor is not given.
+     * @param array $array
+     *   The array to use in counting the offset. If empty, assumed to be an indexed array.
+     * @return int|null
+     */
     public static function cursorToOffsetWithDefault($cursor, $default, $array = [])
     {
         if (!is_string($cursor)) {
@@ -80,10 +80,10 @@ 
 
         $key = self::cursorToKey($cursor);
         if (empty($array)) {
-          $offset = $key;
+            $offset = $key;
         }
         else {
-          $offset = array_search($key, array_keys($array));
+            $offset = array_search($key, array_keys($array));
         }
 
         return is_null($offset) ? $default : (int) $offset;

Spacing +3 added lines, -3 removed lines

@@ -18,7 +18,7 @@ 
         if (!is_array($data)) return null;
 
         $index = array_search($object, $data);
-        return $index === false ? null : (string) self::keyToCursor($index);
+        return $index === false ? null : (string)self::keyToCursor($index);
     }
 
     /**
@@ -34,7 +34,7 @@ 
 
     public static function keyToCursor($key)
     {
-      return base64_encode(self::PREFIX . $key);
+      return base64_encode(self::PREFIX.$key);
     }
 
     /**
@@ -86,7 +86,7 @@ 
           $offset = array_search($key, array_keys($array));
         }
 
-        return is_null($offset) ? $default : (int) $offset;
+        return is_null($offset) ? $default : (int)$offset;
     }
 
     public static function connectionFromArray(array $data, array $args = [])

Braces +4 added lines, -3 removed lines

@@ -15,7 +15,9 @@ 
 
     public static function cursorForObjectInConnection($data, $object)
     {
-        if (!is_array($data)) return null;
+        if (!is_array($data)) {
+            return null;
+        }
 
         $index = array_search($object, $data);
         return $index === false ? null : (string) self::keyToCursor($index);
@@ -81,8 +83,7 @@ 
         $key = self::cursorToKey($cursor);
         if (empty($array)) {
           $offset = $key;
-        }
-        else {
+        } else {
           $offset = array_search($key, array_keys($array));
         }
 

src/Introspection/SchemaType.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 use Youshido\GraphQL\Schema\AbstractSchema;
 use Youshido\GraphQL\Type\ListType\ListType;
 use Youshido\GraphQL\Type\Object\AbstractObjectType;
-use Youshido\GraphQL\Type\Object\ObjectType;
-use Youshido\GraphQL\Type\TypeMap;
 
 class SchemaType extends AbstractObjectType
 {

Tests/Library/Type/InputObjectTypeTest.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 
 use Youshido\GraphQL\Execution\Processor;
-use Youshido\GraphQL\Parser\Ast\ArgumentValue\InputObject;
 use Youshido\GraphQL\Schema\Schema;
 use Youshido\GraphQL\Type\InputObject\InputObjectType;
 use Youshido\GraphQL\Type\ListType\ListType;

Spacing +10 added lines, -10 removed lines

@@ -55,7 +55,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
@@ -74,7 +74,7 @@ 
                             ]))
                         ],
                         'type'    => new BooleanType(),
-                        'resolve' => function ($object, $args) {
+                        'resolve' => function($object, $args) {
                             return true;
                         }
                     ]
@@ -108,7 +108,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
@@ -127,7 +127,7 @@ 
                             ])
                         ],
                         'type'    => new BooleanType(),
-                        'resolve' => function ($object, $args) {
+                        'resolve' => function($object, $args) {
                             return true;
                         }
                     ]
@@ -151,7 +151,7 @@ 
                 'fields' => [
                     'empty' => [
                         'type'    => new StringType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                         }
                     ],
                 ]
@@ -174,7 +174,7 @@ 
                                 ]
                             ])
                         ],
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'success message';
                         }
                     ]
@@ -223,10 +223,10 @@ 
                                 ],
                             ],
                         ],
-                        'resolve' => function ($source, $args) {
+                        'resolve' => function($source, $args) {
                             return [
-                                'limit is ' . $args['paging']['limit'],
-                                'offset is ' . $args['paging']['offset'],
+                                'limit is '.$args['paging']['limit'],
+                                'offset is '.$args['paging']['offset'],
                             ];
                         }
                     ],
@@ -270,7 +270,7 @@ 
                                 ]
                             ]),
                         ],
-                        'resolve' => function ($source, $args) {
+                        'resolve' => function($source, $args) {
                             return sprintf('%s by %s', $args['title'], $args['userId']);
                         }
                     ],