Youshido /
GraphQL
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like ResolveValidator often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResolveValidator, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class ResolveValidator implements ResolveValidatorInterface |
||
| 34 | { |
||
| 35 | |||
| 36 | /** @var ExecutionContextInterface */ |
||
| 37 | protected $executionContext; |
||
| 38 | |||
| 39 | 34 | public function __construct(ExecutionContextInterface $executionContext) |
|
| 40 | { |
||
| 41 | 34 | $this->executionContext = $executionContext; |
|
| 42 | 34 | } |
|
| 43 | |||
| 44 | /** |
||
| 45 | * @param AbstractObjectType $objectType |
||
| 46 | * @param Mutation|Query|AstField $field |
||
| 47 | * @return null |
||
| 48 | */ |
||
| 49 | 27 | public function objectHasField($objectType, $field) |
|
| 50 | { |
||
| 51 | 27 | if (!(($objectType instanceof AbstractObjectType || $objectType instanceof AbstractInputObjectType)) || !$objectType->hasField($field->getName())) { |
|
| 52 | 2 | $this->executionContext->addError(new ResolveException(sprintf('Field "%s" not found in type "%s"', $field->getName(), $objectType->getNamedType()->getName()))); |
|
| 53 | |||
| 54 | 2 | return false; |
|
| 55 | } |
||
| 56 | |||
| 57 | 27 | return true; |
|
| 58 | } |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @inheritdoc |
||
| 62 | */ |
||
| 63 | 27 | public function validateArguments(AbstractField $field, $query, Request $request) |
|
| 64 | { |
||
| 65 | $requiredArguments = array_filter($field->getArguments(), function (InputField $argument) { |
||
| 66 | 21 | return $argument->getType()->getKind() == TypeMap::KIND_NON_NULL; |
|
| 67 | 27 | }); |
|
| 68 | |||
| 69 | 27 | $withDefaultArguments = array_filter($field->getArguments(), function (InputField $argument) { |
|
| 70 | 21 | return $argument->getConfig()->get('default') !== null; |
|
| 71 | 27 | }); |
|
| 72 | |||
| 73 | 27 | foreach ($query->getArguments() as $argument) { |
|
| 74 | 17 | View Code Duplication | if (!$field->hasArgument($argument->getName())) { |
|
|
|||
| 75 | 2 | $this->executionContext->addError(new ResolveException(sprintf('Unknown argument "%s" on field "%s"', $argument->getName(), $field->getName()))); |
|
| 76 | |||
| 77 | 2 | return false; |
|
| 78 | } |
||
| 79 | |||
| 80 | /** @var AbstractType $argumentType */ |
||
| 81 | 17 | $originalArgumentType = $field->getArgument($argument->getName())->getType(); |
|
| 82 | 17 | $argumentType = $originalArgumentType->getNullableType()->getNamedType(); |
|
| 83 | 17 | if ($argument->getValue() instanceof Variable) { |
|
| 84 | /** @var Variable $variable */ |
||
| 85 | 4 | $variable = $argument->getValue(); |
|
| 86 | |||
| 87 | //todo: here validate argument |
||
| 88 | |||
| 89 | 4 | if ($variable->getTypeName() !== $argumentType->getName()) { |
|
| 90 | 2 | $this->executionContext->addError(new ResolveException(sprintf('Invalid variable "%s" type, allowed type is "%s"', $variable->getName(), $argumentType->getName()))); |
|
| 91 | |||
| 92 | 2 | return false; |
|
| 93 | } |
||
| 94 | |||
| 95 | /** @var Variable $requestVariable */ |
||
| 96 | 3 | $requestVariable = $request->getVariable($variable->getName()); |
|
| 97 | 3 | View Code Duplication | if (!$requestVariable) { |
| 98 | 1 | $this->executionContext->addError(new ResolveException(sprintf('Variable "%s" does not exist for query "%s"', $argument->getName(), $field->getName()))); |
|
| 99 | |||
| 100 | 1 | return false; |
|
| 101 | } |
||
| 102 | 3 | $variable->setValue($requestVariable); |
|
| 103 | |||
| 104 | 3 | } |
|
| 105 | |||
| 106 | 16 | $values = $argument->getValue()->getValue(); |
|
| 107 | 16 | if (!$originalArgumentType instanceof AbstractListType) { |
|
| 108 | 15 | $values = [$values]; |
|
| 109 | 15 | } |
|
| 110 | 16 | foreach ($values as $value) { |
|
| 111 | 16 | if (!$argumentType->isValidValue($argumentType->parseValue($value))) { |
|
| 112 | 3 | $this->executionContext->addError(new ResolveException(sprintf('Not valid type for argument "%s" in query "%s"', $argument->getName(), $field->getName()))); |
|
| 113 | |||
| 114 | 3 | return false; |
|
| 115 | } |
||
| 116 | 16 | } |
|
| 117 | |||
| 118 | 15 | if (array_key_exists($argument->getName(), $requiredArguments)) { |
|
| 119 | 3 | unset($requiredArguments[$argument->getName()]); |
|
| 120 | 3 | } |
|
| 121 | 15 | if (array_key_exists($argument->getName(), $withDefaultArguments)) { |
|
| 122 | 6 | unset($withDefaultArguments[$argument->getName()]); |
|
| 123 | 6 | } |
|
| 124 | 25 | } |
|
| 125 | |||
| 126 | 25 | if (count($requiredArguments)) { |
|
| 127 | 1 | $this->executionContext->addError(new ResolveException(sprintf('Require "%s" arguments to query "%s"', implode(', ', array_keys($requiredArguments)), $query->getName()))); |
|
| 128 | |||
| 129 | 1 | return false; |
|
| 130 | } |
||
| 131 | |||
| 132 | 24 | if (count($withDefaultArguments)) { |
|
| 133 | 4 | foreach ($withDefaultArguments as $name => $argument) { |
|
| 134 | 4 | $query->addArgument(new Argument($name, new Literal($argument->getConfig()->get('default')))); |
|
| 135 | 4 | } |
|
| 136 | 4 | } |
|
| 137 | |||
| 138 | 24 | return true; |
|
| 139 | } |
||
| 140 | |||
| 141 | 7 | public function assertTypeImplementsInterface(AbstractType $type, AbstractInterfaceType $interface) |
|
| 142 | { |
||
| 143 | 7 | if (!$interface->isValidValue($type)) { |
|
| 144 | 1 | throw new ResolveException('Type ' . $type->getName() . ' does not implement ' . $interface->getName()); |
|
| 145 | } |
||
| 146 | 6 | } |
|
| 147 | |||
| 148 | 3 | public function assertTypeInUnionTypes(AbstractType $type, AbstractUnionType $unionType) |
|
| 166 | |||
| 167 | /** |
||
| 168 | * @param Fragment $fragment |
||
| 169 | * @param FragmentReference $fragmentReference |
||
| 170 | * @param AbstractType $queryType |
||
| 171 | * |
||
| 172 | * @throws \Exception |
||
| 173 | */ |
||
| 174 | 5 | public function assertValidFragmentForField(Fragment $fragment, FragmentReference $fragmentReference, AbstractType $queryType) |
|
| 185 | |||
| 186 | 9 | public function hasArrayAccess($data) |
|
| 190 | |||
| 191 | 23 | public function isValidValueForField(AbstractField $field, $value) |
|
| 210 | |||
| 211 | 23 | public function resolveTypeIfAbstract(AbstractType $type, $resolvedValue) |
|
| 215 | |||
| 216 | /** |
||
| 217 | * @param AbstractType $type |
||
| 218 | * @param $resolvedValue |
||
| 219 | * @return AbstractObjectType |
||
| 220 | * @throws ResolveException |
||
| 221 | */ |
||
| 222 | 6 | public function resolveAbstractType(AbstractType $type, $resolvedValue) |
|
| 241 | |||
| 242 | /** |
||
| 243 | * @return ExecutionContextInterface |
||
| 244 | */ |
||
| 245 | 2 | public function getExecutionContext() |
|
| 249 | |||
| 250 | /** |
||
| 251 | * @param ExecutionContextInterface $executionContext |
||
| 252 | */ |
||
| 253 | public function setExecutionContext($executionContext) |
||
| 257 | |||
| 258 | } |
||
| 259 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.